From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 442D9FEA838 for ; Wed, 25 Mar 2026 08:56:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4951F6B0089; Wed, 25 Mar 2026 04:56:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 353DD6B008A; Wed, 25 Mar 2026 04:56:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A99D6B008C; Wed, 25 Mar 2026 04:56:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 06D4D6B0089 for ; Wed, 25 Mar 2026 04:56:09 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C80A1140801 for ; Wed, 25 Mar 2026 08:56:08 +0000 (UTC) X-FDA: 84583978416.17.AC90D01 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf25.hostedemail.com (Postfix) with ESMTP id 14ABFA0008 for ; Wed, 25 Mar 2026 08:56:06 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jwCjOxlK; spf=pass (imf25.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1774428967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aW++o4+jjdS4Pj2+y2xdIc0pib9QWGl6Y8o0iGR7Vws=; b=GF10fsesmmxIsR28R+ndwOOxNmq5FsgnxBlUkuFAd1ADehTUdLSoVQUHkGCAf8yV2EH0Vc S6qDz8876kOn10nYmw886+psp78QwwEUI+gY1d2VcbiQ7Ce/+S6lCuA5QVKyoMHFYKEG7t ERBEDiar5Dkbr/WFtftxfhOPa49v5yQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1774428967; a=rsa-sha256; cv=none; b=ZDxMUHRoEOwG68U34oFcgS7uZ+mJdNuowp1DAxyhO+k4jwKOqn9uY+/zSEMpiX0/63B5fw yQt/8HcZr4z8gyssFuyig+gagRZFCngOo2zSOX+DIJ2r/Sl+uB4+KNmIN4mH4eWYRMCQfW Zag7uHJ8FmZk7/k7M5INVDP4odm5QII= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jwCjOxlK; spf=pass (imf25.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 68609600AC; Wed, 25 Mar 2026 08:56:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE684C4CEF7; Wed, 25 Mar 2026 08:55:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774428966; bh=tTB7VgoGtVpHZnvihVybYX/BDQRt1nfjM2gXZEcVM0E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jwCjOxlK5w+qtI6HGD0P93Z2rHixiQFCP7o/siPfSKcD8BSC1/4d8Mu3VxIXiq5Dg Xb6M1ysIFJvyWtEModesHBoQ8UpwzeqxTZGGJql1neZr7pmMVG7RcUkt5pQYxg/MYV u2lYPPWSlNCyfE0zfwa6nqYVtUtZmkurwZXSxZar1DLJZOSn79UFQi9YMzC/WBeQdq 0YaVdXab5ssHjtTgdecM5n12+vOGx7LZxguDTJNHu1ZPxiKgLYRrnrMEVK19pOZAtB q+JwIoWoMUUxPsJWZBrxBum1OaDiEmvFggftHTJuJOYNV9tVaGsV23RAHyReoTB+Bs I8x/jbsJ3votQ== Message-ID: <7fc10c85-0bab-4004-9a9c-3bac4777d3b3@kernel.org> Date: Wed, 25 Mar 2026 09:55:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] mm: rename VMA flag helpers to be more readable To: "Lorenzo Stoakes (Oracle)" , Andrew Morton Cc: Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , Muchun Song , Oscar Salvador , Konstantin Komarov , Tony Luck , Reinette Chatre , Dave Martin , James Morse , Babu Moger , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Matthew Wilcox , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Hugh Dickins , Baolin Wang , Jann Horn , Pedro Falcato , Jason Gunthorpe , linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-mm@kvack.org, ntfs3@lists.linux.dev, linux-fsdevel@vger.kernel.org References: <0f9cb3c511c478344fac0b3b3b0300bb95be95e9.1772704455.git.ljs@kernel.org> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <0f9cb3c511c478344fac0b3b3b0300bb95be95e9.1772704455.git.ljs@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Stat-Signature: ktopg8sw6qqbt3kmsp313gemb1zzjwcq X-Rspamd-Queue-Id: 14ABFA0008 X-Rspam-User: X-HE-Tag: 1774428966-751036 X-HE-Meta: U2FsdGVkX1/DDv+HDpnUl2FGS5QK5Js1VDE6m/ZffRAv6GX/YQiZv5ZzgadvAO6AfyIPl2tx13NLaQ6Q3/kEzalJlPBBBsnzAhi42CKZmqZRSG8elXnS0L/T9xRPjF5A5nlSZBuVfTmIS6+2IpIsvVqxLn7igzwFh5OYixblknCDodOtCWeqCbisXQgM0F4bMBOYQRnY+ZEYkttTrCaV3v9W/lOIsA0dmNk0sDkEwXEVjkmFw4TkunE6UHPiSMzoNAZ/doAvW+nNb78UfiRw6husPM1ppNPgIJ7pkAZIpjm+hWS8njQ1gXIE7lk6/UpSMvwBTI/bUDhtgpuXh3Ec3L5VX40MEc/sjYsm9rL5LGBZ7WI+A4QsrdwwybMiP7nfmXs9wHBDMHDCOIO4ZznlFbF/KTIA6eT3H7gSY2P4dQuECBYXKjkDp/U4iYZ8kdxTQAf9sNWhMIeZe2kqcJp9VRF3lxfBeevK9mGXzyDdOLGc0LOsg3rZTeYJ2Mg8km7JHyquq3dSM5zcXsahEARfB0QlQmR1csMbGCkQ9w4GlLGXaB7K+58POxAzwqSSIcNYKUFIN16H4T/F2IsWTWshjE2Sc54PAptQ+B42zZftfsGUAEB9uVguoVRXVUitJ1icTbP4nEDTD4zMJNyZjtQEJgK5xm7nDUzh4dnxlbKaSesXl473AeTsj8wRHaZw+Ws1hiOd/Mt+Wkos9sPl9xYLDYLxZizWEe/udnsjAEbLV2TIWiwp0TkmkAWn4t8rVSx1t3/tId4lQdxHrCpzUuUCSqQf/UiSdoieUBSkWAOJXqt2ve6qVjqyx9z6w50nNkT/7lCUeCoXBgeOhteJ1W2xDyS2QmJC763QXofUYSg1y/OZGOOwFEu+NPEoo+og3HyVrbeoQvTctUu5B2W7tuWIfr1ux2OBeEGh6jNz9rsd1vqZTe7+m+lY/I1MMgPOvZLX7PPd54/3kyWRD08r0JI sMnuLY5A Jk+29KMU0U4CnsLCJ0ZjBVw7u9iDCcZis0IA9vMqC/+pdivEQ/j/MzqmBSmJh3fNuC2shsWJzKpH6yuF8w1YGQq1fTFHwJNcsE0P8ZU7p6fIjxYGYi/R3dbimQfk9TDenw/EpRPKBZDf3ZXT1z0o1P8v8PgEL1ifZn0fX5loQfiYgctIRb4VTrLKn2bS8J5gS2R7Ajn5MmQYHk5rXPLT+46z8m7o6VGzW1ISB5wScAg/uJHleVj695aB8qah4XS7tfZf00N9jr/o/FuBqnMqAieuuNw== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/5/26 11:50, Lorenzo Stoakes (Oracle) wrote: > On reflection, it's confusing to have vma_flags_test() and > vma_desc_test_flags() test whether any comma-separated VMA flag bit is set, > while also having vma_flags_test_all() and vma_test_all_flags() separately > test whether all flags are set. > > Firstly, rename vma_flags_test() to vma_flags_test_any() to eliminate this > confusion. > > Secondly, since the VMA descriptor flag functions are becoming rather > cumbersome, prefer vma_desc_test*() to vma_desc_test_flags*(), and also > rename vma_desc_test_flags() to vma_desc_test_any(). > > Finally, rename vma_test_all_flags() to vma_test_all() to keep the > VMA-specific helper consistent with the VMA descriptor naming convention > and to help avoid confusion vs. vma_flags_test_all(). > > While we're here, also update whitespace to be consistent in helper > functions. > > Suggested-by: Pedro Falcato > Signed-off-by: Lorenzo Stoakes (Oracle) > --- Acked-by: David Hildenbrand (Arm) -- Cheers, David