From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A866BC4167B for ; Mon, 2 Jan 2023 08:32:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E272F8E0002; Mon, 2 Jan 2023 03:32:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD5508E0001; Mon, 2 Jan 2023 03:32:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9CCB8E0002; Mon, 2 Jan 2023 03:32:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B87148E0001 for ; Mon, 2 Jan 2023 03:32:20 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7EA32A07FC for ; Mon, 2 Jan 2023 08:32:20 +0000 (UTC) X-FDA: 80309192040.08.6E4403F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf05.hostedemail.com (Postfix) with ESMTP id 9D13710000A for ; Mon, 2 Jan 2023 08:32:17 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MJPFsj0L; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TTQVax9a; spf=pass (imf05.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672648337; a=rsa-sha256; cv=none; b=pIsKhsOVTYLxLkzQufPYfYTdN2kXuhJ+rshiJNZe2FCwEKCWO/b+TiOPwCMe4v2mfNHl82 g/UP8p9CE/9/PgAJ8iA8ZxSzWBvm5peHxvPpD9pGGVcNeLImeN51FZEzoPLUHUq2kreT+I 1UcBdWjl1Ai1GL4/a9GZeDuhViL3QSI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MJPFsj0L; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TTQVax9a; spf=pass (imf05.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672648337; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H75DFi9ruBZtmFkVkdPw0eEU2taX9Gg8XsLbPaQHEe4=; b=ieJEZNZWPyuH6LQZYkl6Lgp+vBjQueS2NnQ3R2/6pvi0Ule2dHuptX+LNazuHRwSFvxF2r 9r99vg3U+0p7aeFc/Cmd7r0jU+L4TRWk2zYSMkWaxPi4l+BmGCOFx5oqGHksdEvGt1XO76 zgNaqMiumkJg5U7JlY0/5lbZ3t+py7g= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0F5AC20897; Mon, 2 Jan 2023 08:32:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1672648336; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H75DFi9ruBZtmFkVkdPw0eEU2taX9Gg8XsLbPaQHEe4=; b=MJPFsj0LM8oWnteJyW53u4CUKbsexOFgRTQV04ifwTmDySriYHMPDcHzvliisBgcGLUAws SEnnKOo1R4BpiYbwI4kA9M2U7bNT5jvoSXF5OEBZ0CabhUxNWZyRqfBlHP7k5t8n0tbl5c omMLmC4YweurOobMfALepySs0VpDzOs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1672648336; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H75DFi9ruBZtmFkVkdPw0eEU2taX9Gg8XsLbPaQHEe4=; b=TTQVax9agQi/0O0uIYCs4wv2f1250O6kked2hT2h/6j9UVQjlkSPohT5egknrZSKUmbTSe kU26ydWBmJrQjTAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D75FC139C8; Mon, 2 Jan 2023 08:32:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /JJuM4+WsmMPJQAAMHmgww (envelope-from ); Mon, 02 Jan 2023 08:32:15 +0000 Message-ID: <7fb9b7cc-5c07-4b30-fa5e-6146b402f73f@suse.cz> Date: Mon, 2 Jan 2023 09:32:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [patch] mm, slab: periodically resched in drain_freelist() To: David Rientjes , Andrew Morton , Christoph Lameter , Pekka Enberg , Joonsoo Kim Cc: Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: Content-Language: en-US From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 9D13710000A X-Rspamd-Server: rspam01 X-Stat-Signature: 874x6uwduuwkhf3uq4xnicabaq1io6xk X-HE-Tag: 1672648337-564342 X-HE-Meta: U2FsdGVkX1+WNekxtvIStMAA4YhvPTDDGb18fr23Je6C6RbqOjVcjIehVvoYE7K7Dbx6LaIUgrVFbFrWHHj/o0nvZReo3skf8qlR9CBvVhaSJaDkpuln/Y7KDbLJ2HAMkKBOhZjdCwbf1/QGNctPumTAp/sy+bNyPnOA3L0v+DKeDYBCa9vqHyBeII5DlPBrjrpjru/iZ8O2w7CgnscY8XDb1Jd031OGqCXMbTlTKNgmscUYcfHl+hlO1F7SVG/LeWsTxYuN4H43wzlyVeZETWUzvvSufnpUYkkNOcnJqowYhGpY3B9Qej79nOayHOonP4q6tuV2CKws87fWm8HdNsiWR0F4rqa7naGUZdio2gpLPl3fZjoNwIrkRCBCfGcf9cOjb608shLYAiUy2KXbqaCjwlk3cifb7XYVAcTfJxDg41S1WddqqinZ7AiPPOEbiR1Sw6y9K7pmNF+Ya8/hSgHNXXWrhBNAW1DAuMYHihymOaDgfyZeY+mDqrJxB1cvAZrtJKz7yRNNesyW04+puPa5WMKt6fi2S54fzpQ/03Mnanlct6PQsNI6hJ3tx5x2OpasKSgfOvww/1Y1vJV54Za7xwCOlhP7WFxJH+8h4OB8ZzRhovRp7Gxdbb9LcVA4FQStQYIetEnePQxvfv6Zoqw6DKpeWFol+GEChO6gBBZhJ0pnN/xllCgD9KRK4+O7Oof+T3RDqe61TifkYjJAgw/DPj6bb8iuX6zMce7z6wsReSzR9NI0vw5SNOaD186xc9sbnxkSiLUl+lhUMmkkEmZzhPEaTjzE8AIPXmhNyq0Qw8CBvVLjPrSuHcmsV5QhL6Yedt2zgKBygGu9Frn2icJjIfznM3dYr77R5BbiU9kDRNWyJjTks3Rj25/UYABEl1LLOjxGc/4GPBvyNwZHNdD1PuPAlKufYD/UvhO/GKt106zldXBcA/pzZmiEDs43jqTHRx6G6m3dYffly3R KBWjsl7t VqUKGOdngaUQOAF5boWx0fJ5zYoGxjMyzpmtsBvkKrXPSoWrtBWedc9/3Cw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/28/22 07:05, David Rientjes wrote: > drain_freelist() can be called with a very large number of slabs to free, > such as for kmem_cache_shrink(), or depending on various settings of the > slab cache when doing periodic reaping. > > If there is a potentially long list of slabs to drain, periodically > schedule to ensure we aren't saturating the cpu for too long. > > Signed-off-by: David Rientjes Thanks, added to slab/for-6.2-rc3/fixes > --- > mm/slab.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/slab.c b/mm/slab.c > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -2211,6 +2211,8 @@ static int drain_freelist(struct kmem_cache *cache, > raw_spin_unlock_irq(&n->list_lock); > slab_destroy(cache, slab); > nr_freed++; > + > + cond_resched(); > } > out: > return nr_freed;