From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 538BDC6FD18 for ; Tue, 18 Apr 2023 15:55:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4EF08E0002; Tue, 18 Apr 2023 11:55:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFE8F8E0001; Tue, 18 Apr 2023 11:55:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC6B28E0002; Tue, 18 Apr 2023 11:55:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AE9D58E0001 for ; Tue, 18 Apr 2023 11:55:56 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5CB451603C2 for ; Tue, 18 Apr 2023 15:55:56 +0000 (UTC) X-FDA: 80694962712.06.8AFC709 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 9CEA314000A for ; Tue, 18 Apr 2023 15:55:53 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JTuPOcXQ; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681833354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bu2WXyCBFn70BrFOAHD2w7CCSZ5K+Kah1HWaszqXR7M=; b=XMDigdoGbebVaanFDdlJHSW9TjU8CwLrCsG1r8pjnHk7x1PmV+sea4mha64vH53CIvpBty iMGsFpJfU1816ai/l63EDcZJ1KqhBbpIh5ucWyH4KLeqR3PnJERNvZlhEiJyoDlm3s/Apo VCt9ahjTLkAHLbjMOiNg5Z4ipqxDyJQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JTuPOcXQ; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681833354; a=rsa-sha256; cv=none; b=Pn9tRItgUmOyiuBKKBNhY0/Ya04isg+mguADiAsHPuW729K/7GD9GHxK+v4Jw4e56ITRWI O3WxJxtTj/+o9hXkxamZqvgxzx19TQj3TnPbCEYBZyPR3WCtQKAfQXUfh8msBmbsgrjo3l 8aoAc0E3pUyFfTbQlgdr8RsZb+1jHS4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681833352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bu2WXyCBFn70BrFOAHD2w7CCSZ5K+Kah1HWaszqXR7M=; b=JTuPOcXQh518fSbRLym8JHR86xWfD2zXJlJsIMd/IYhWlazoIJRop4xrrg/G/BXPCgNBUo 3Z4gqBxFo1Ngruih+WUulkY5I/29ktSSp5iYq0enbiVq+Yt9M8wOcGUI63KdoAg91K4NpN gPhVbY0spu8+Gpm6VVReLASh1Cbl9pI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-209-b4lHP5DmNfO_iv9q9O0eDA-1; Tue, 18 Apr 2023 11:55:51 -0400 X-MC-Unique: b4lHP5DmNfO_iv9q9O0eDA-1 Received: by mail-wm1-f72.google.com with SMTP id l32-20020a05600c1d2000b003f17b89ddfcso430419wms.1 for ; Tue, 18 Apr 2023 08:55:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681833350; x=1684425350; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bu2WXyCBFn70BrFOAHD2w7CCSZ5K+Kah1HWaszqXR7M=; b=J/g2CfsuZELjr//jE15hhFdcHeZ2bFbL4skGTh/qPpVujKFyI/0QxO97H5FH0WALxM F36nZHgt3woOJJTa5FRRUMJVlMcHQimuFCCMjxZlm3MsHsK5F9+Eu/NhfoKGsS9867H6 T35W02iJbxdA9TDrpk35MkEcusohVxbAFObnWuA14g4mxzGxbI2DiIYPZv39elQYQuO9 BwxcHH6KPbcFPO0ZpCyM+8eec9yqkaDcZMwmArdDrSdVsvYUj6D5k25PWQ2OZnSxhnHx TYOb3H3z6QS5zAFihZjeDtJbAZSB1gglaq2o1I7BZmZCgEhmY3sW1iL/fGqeEC7S9q4I e7Qg== X-Gm-Message-State: AAQBX9c2H/8jUGAqzYXsW7ytr/Hd+bgKFBHAiMkfEjMiJ1mQgcwDBUD4 4IzCv5IOA9jRA1jDuV+TEg3RErpyTftAn4szpNYtctUTrXplWxMiHBvQuPSSq+b0SgpET/Gawqg /3CoMzdVvbJE= X-Received: by 2002:a7b:c7cb:0:b0:3f1:72e2:5d13 with SMTP id z11-20020a7bc7cb000000b003f172e25d13mr5852123wmk.16.1681833350226; Tue, 18 Apr 2023 08:55:50 -0700 (PDT) X-Google-Smtp-Source: AKy350Z1j/eqSrGsLGiAtdPfeIYhyQjZeuM76uEuc4151AByxVjGqnHN1YQGTPrOF+yr1m2bfY1Bnw== X-Received: by 2002:a7b:c7cb:0:b0:3f1:72e2:5d13 with SMTP id z11-20020a7bc7cb000000b003f172e25d13mr5852102wmk.16.1681833349870; Tue, 18 Apr 2023 08:55:49 -0700 (PDT) Received: from ?IPV6:2003:cb:c715:3f00:7545:deb6:f2f4:27ef? (p200300cbc7153f007545deb6f2f427ef.dip0.t-ipconnect.de. [2003:cb:c715:3f00:7545:deb6:f2f4:27ef]) by smtp.gmail.com with ESMTPSA id q9-20020a1ce909000000b003ee20b4b2dasm15205166wmc.46.2023.04.18.08.55.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 08:55:49 -0700 (PDT) Message-ID: <7fabe6ee-ba8f-6c48-c9f7-90982e2e258c@redhat.com> Date: Tue, 18 Apr 2023 17:55:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 4/6] io_uring: rsrc: avoid use of vmas parameter in pin_user_pages() To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: Matthew Wilcox , Jens Axboe , Pavel Begunkov , io-uring@vger.kernel.org References: <956f4fc2204f23e4c00e9602ded80cb4e7b5df9b.1681831798.git.lstoakes@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <956f4fc2204f23e4c00e9602ded80cb4e7b5df9b.1681831798.git.lstoakes@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: mtkainhqdh89wgjt99qunqgpoqirq4o7 X-Rspam-User: X-Rspamd-Queue-Id: 9CEA314000A X-Rspamd-Server: rspam06 X-HE-Tag: 1681833353-106320 X-HE-Meta: U2FsdGVkX1/LPmFaIqPPVsydvDL+UD4/jNOVpdqApreJ1wUDUn9EAIamYygGzmJXzLNN9RARH5r4MU7msRajtxbhTurGPIsQxSoCK/SxiaZRoXltkkFuQDiM/6ayvCYPIVl08yM1Hx9vHo2vR2lYN67W+4rWJOzDE0pJJMB8BqwQxKmD7sDus7iaQ2u5qVBi2/jmRS3FkF0rTMm8uBhn8ZyHspFrZvsv8Tj218Nq1BktFOaLnb7owk7yBBAV9/zoWcKFiqloO0n6nTiXgTbJStGIP/4DulMkmqOouEpmcEOb+y9RsPfMCBHpwKscH2mxXuYxzR8uheGl8qpVu2nSoVofQtrseL0xe27XXyDPh8NfrCMcexVnRRT0Ha+XQp2dDRDm/thOgQqLQfG9lLYfwir7su9ovIkXVfwWOdzw6tKawOZzLMrL3qDnS6fOUplER6C5ZHAmnfVPHWybB2BXP22yuin9nJ/le5JcWr/+K8Rbrp+s0vQcr+UXa+KSMdrGJhXhQU9x5VmUiRqxGsW4kBYGdkVaKnGUi0kQ2QZZkJ4zQ4RCFZNiGA8k3VDpzwV62+TEoXau+fKP5TEgB2g9QNBWbO47houq4hOrNIOJo/fMaQ4E/woG4CaYS7w1P43Csx9hAdIyWTC0p+vuoHe9d7FMdZIX6gImprlyAlO7XUaLxsxFhyzs2ugu+dvXk7mBi/N7lSz7J9yAVSvedx36ooofq41TP5Bl20pP5Y5kzI09EGQu8GHs+twmlN4vI0XsDDqI52LYVqfYihDsKyeyxAn0R3Xozfbglm/xsaYrLUO18w/of4BYnio1MnSg/4tdO9fKbiWW2qkdMWKW9slfoGsy6aykuOeh3Qb8VDtQJHa4Fgw04uIhQaJAGpJUvhfmBzB8gBjlVS/RuwtKegGGa0a9nZqSiQeMbII7nz+CsiRm43KlsmopFDHxIiYZjnvoFk04Jg9SBlNbLPOUOW9 jD8XSXxI 3RSCSsfBHhsDUInPOw9PHrQOKDtiRLLvgeqmT4UPFVGEVTbxP8D3j1bEoucpfXaSqB8LinFduRGBVuR+7+f9dOzk1qcmC7eAJHqk5XvZYVgKupv5K+m8siSp6hxUHVT/QtsB5+tiSOlwBnNrSfqGSWQy47RWDenHTnA6NrfvSMIzPO89Ooz98ArFMEF1sqt4fqiplLmdBybzfQlFnCxheyqCquge4PUicMpU6+tXYBMmZOzCes7IdSlOXB8eH6ynNV8Bgn+gIx8mkDMUxot1Y1OBoavnWh7xyiTnDiReBrkpvbue8/KqfoMqZTrJ2BHwVhHIoJYZ6T8T/YZrpT/IOGZJtmFGttW4H/AIwnc4vD9jogLqAD5X3B7Hpwm9FSssSoDuLQ67odloShDGzkqqaVG/jrAdm9Q0I/kmjxhuZRA9QFrGbssqfCmHr+itj0bXxgLDhktSl+suw9Q8LLJ44NndRjfPQy8JDZxxSHXJJal6bEk2GR9xtSnD95JgnSjbxMDq9xatJQfSrjnx9m3bqLCjpuGClfp+jkWNhpK/c93J7WAQiQh1+aUmTcQQ5FWHL9a71guI8QYQBoCcBtIb2u2rnjunqVkmO03r1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.04.23 17:49, Lorenzo Stoakes wrote: > We are shortly to remove pin_user_pages(), and instead perform the required > VMA checks ourselves. In most cases there will be a single VMA so this > should caues no undue impact on an already slow path. > > Doing this eliminates the one instance of vmas being used by > pin_user_pages(). > > Suggested-by: Matthew Wilcox (Oracle) > Signed-off-by: Lorenzo Stoakes > --- > io_uring/rsrc.c | 55 ++++++++++++++++++++++++++++--------------------- > 1 file changed, 31 insertions(+), 24 deletions(-) > > diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c > index 7a43aed8e395..3a927df9d913 100644 > --- a/io_uring/rsrc.c > +++ b/io_uring/rsrc.c > @@ -1138,12 +1138,37 @@ static int io_buffer_account_pin(struct io_ring_ctx *ctx, struct page **pages, > return ret; > } > > +static int check_vmas_locked(unsigned long addr, unsigned long len) TBH, the whole "_locked" suffix is a bit confusing. I was wondering why you'd want to check whether the VMAs are locked ... > +{ > + struct file *file; > + VMA_ITERATOR(vmi, current->mm, addr); > + struct vm_area_struct *vma = vma_next(&vmi); > + unsigned long end = addr + len; > + > + if (WARN_ON_ONCE(!vma)) > + return -EINVAL; > + > + file = vma->vm_file; > + if (file && !is_file_hugepages(file)) > + return -EOPNOTSUPP; You'd now be rejecting vma_is_shmem() here, no? -- Thanks, David / dhildenb