From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96888C47DD9 for ; Wed, 27 Mar 2024 15:47:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A1616B009D; Wed, 27 Mar 2024 11:47:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 151F56B00A3; Wed, 27 Mar 2024 11:47:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F35666B00A8; Wed, 27 Mar 2024 11:47:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D50F96B009D for ; Wed, 27 Mar 2024 11:47:44 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6FFABC0DA6 for ; Wed, 27 Mar 2024 15:47:44 +0000 (UTC) X-FDA: 81943249248.25.5E473DC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 17A6C180018 for ; Wed, 27 Mar 2024 15:47:41 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SBY91gqt; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711554462; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nx2RBcEO1zlkXSO8aDJi6Uao1EiV9BqGUI/e60nrr6c=; b=eH1Cp/vbQNPr2Hwg7corskCAIhOPJH1lwGMrzgjERQ6C2FK12AultpKG57kCL3jj660K5G owLEndsOhc7928ioM1pMJ0Ad4qC5xZxXOH3BS4l+QR+PO0jmj/Alrw3noRtqU8zNabhk7G eL2AaLXIlcZOCNSCKVWserszDXNyIKc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SBY91gqt; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711554462; a=rsa-sha256; cv=none; b=EsRn1xDRiFTK6xEtQWP9xEcabH2E86Y5JzA/K5zdne8VW0+OB0qnerPGBqmLY00mrqBKuh gY2A1wjaxJSlHAaVmhH1/MC8Y1z1qBPySwm3H2MOdg2an07xZ9nsc2M8jf5uwegngFT264 B6DxXZcOfNCuvjR8YcKBKptiind7p2s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711554461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nx2RBcEO1zlkXSO8aDJi6Uao1EiV9BqGUI/e60nrr6c=; b=SBY91gqtVcFUzzi4TSoCzeGe9vmp0v24ukKZfzJt7wOw1zr/PfIBXYy9RUizIS09ggbs3a MkVQfC6QTbV3ZUYN7NYQrK+73TU/RXejokfPRtFk0Rk9arlFsQlHfJfFpXTf02LeGM96FV u1a2BhFKKDJrTeLC1ny8ABALMy3802w= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-BWMY9HsdOrqjidMXLhAULQ-1; Wed, 27 Mar 2024 11:47:39 -0400 X-MC-Unique: BWMY9HsdOrqjidMXLhAULQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40e435a606aso37278925e9.3 for ; Wed, 27 Mar 2024 08:47:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711554458; x=1712159258; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nx2RBcEO1zlkXSO8aDJi6Uao1EiV9BqGUI/e60nrr6c=; b=two3jsg/u7NoCon58zIKQrrSqps8lXu7T6mkmAZ68HmSkyOKK3IUhAUfOs70qFa0Cs qblxIEY4mIhfeXBDZNPY+dKlm33sSZEI06iC0oO9qrwz8PVM7BgPvv/s0QuDYqN8cBBl Xl/kbu0bXSScXjxhrFhil+PlXGN+JBxk/AAm0yvUKySPWoy0u2SgD+ZG+gVvupd/LDDM Dg7Ojnmx1Ya3FWxyzXarEUfwNBLBug4a2cjct+yJrhXrH1C7tbKFGmzkhDzTi20BpRi2 0XyzKKH1qaB6ZseSl7f16G+OQyWspu8xUB4IK7jhDpyJZtVIqkB9Zs03uzBc3yg6GpVS F4hA== X-Forwarded-Encrypted: i=1; AJvYcCWqgFmFSz7OMz9MozxigJGU1xgj8IRUF+AeNN4cj+3r0APpn/46ZYc2Z8c/kKJvr7ghdsqmZWzdH8xePp7wHNS5aiY= X-Gm-Message-State: AOJu0YyRTchPiWp+vX3u9ezPyeil08UB2ZecLVE/vHZXvDp2kelzaOn0 lYDDbAHQhA7up8pQr8qNDqiheHz2GJqjupqh0D7esuSCUhZ8bZk4wOLx3MLCh4Nv+AIO9d9ZVUI BUhg1G0f5bJp1dBE6yAqOgYta5cRSs6z6sB7xZa6DgW1EHH5q X-Received: by 2002:a05:600c:524d:b0:414:8c04:23d7 with SMTP id fc13-20020a05600c524d00b004148c0423d7mr351318wmb.12.1711554458566; Wed, 27 Mar 2024 08:47:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGMMNr9uPGzoqufs3UzwsuyIJrM6qX29FP7ICBLhhHmRIezXNRoAaLgs2liyRBDuZ/By57oYw== X-Received: by 2002:a05:600c:524d:b0:414:8c04:23d7 with SMTP id fc13-20020a05600c524d00b004148c0423d7mr351286wmb.12.1711554458105; Wed, 27 Mar 2024 08:47:38 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:8a00:362b:7e34:a3bc:9ddf? (p200300cbc7088a00362b7e34a3bc9ddf.dip0.t-ipconnect.de. [2003:cb:c708:8a00:362b:7e34:a3bc:9ddf]) by smtp.gmail.com with ESMTPSA id m31-20020a05600c3b1f00b004146bcdde06sm2534359wms.6.2024.03.27.08.47.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Mar 2024 08:47:37 -0700 (PDT) Message-ID: <7f9fd647-dd0a-4be0-9e3b-3f0fe5f479cc@redhat.com> Date: Wed, 27 Mar 2024 16:47:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 0/3] mm/gup: consistently call it GUP-fast To: Ryan Roberts , Peter Xu Cc: linux-kernel@vger.kernel.org, Andrew Morton , Mike Rapoport , Jason Gunthorpe , John Hubbard , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, x86@kernel.org, Arnd Bergmann References: <20240327130538.680256-1-david@redhat.com> <3922460a-4d01-4ecb-b8c5-7c57fd46f3fd@redhat.com> <8727a618-30c4-4a13-b0e9-eccc3fd67c73@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <8727a618-30c4-4a13-b0e9-eccc3fd67c73@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 17A6C180018 X-Stat-Signature: 3tg8ef57x6wnwks7eqfzkcbuny516yhk X-Rspam-User: X-HE-Tag: 1711554461-298602 X-HE-Meta: U2FsdGVkX18pVt56simBzo+B+uXQMgy1O0s4LHEOoe3l7ih6RZgFRjpcHXuKxTUpBBh9cznjuzD4xImyMqylV0mb5k3zAdS4hFnJrvI/y4bJcu1rNC147P5Vl3eKuhtCWm1/k65alRuS/1zcpSoZ3gDSIxlD8lnMwdq1ElMyHTW9keOMLjRVahFWFEiktnIJIzTtIZsxGKeDaEfXn6FxgF9p8qBlsJ/DlGN4jT6xWirWcWVGeo2MrNFjMm8wT76mbtZZz9TUW8q2m0cTiu2TnQYek72WEPgY+tr0PRKosg9jxCXHVzjjS2ILgcYvns14S/AobBaq+COb1HTuFZ3UqvjwTnmjhwb0irECP0Ms1BbAzEi7MRVZlr32kSlS4KG4uXa4ElRid8Hh7I4JuPPPk9UMOJRyCLNHjM8tkPcqLw3SnCiu84jULlDdMA7vZ4CUERH9HcrtMz0lEgfpHrZfmdw1y5ueRzGrOILPrUAzt7aYLJc+RE+hEBzIIq6qMMnlNWjmkj6ASdSHkcp1ypeocVKGXWLKsVR6JsXgkP4N6Ukvy7WcaEMS5pyZTTas+VQQ6EtPXrb2ywf8TRV/oeZzgCPdQ10uIyMrbWjddTONuOPYHkSevWcYJBwd3qthcHnkPbdUFacpsKvrcdn9wpTKoh9Cp8Z6sNsJHK5UEIzCUh2vHbEczOdX2lDqTmsifWaLUPetyNR2N7xps3y+GH16TPIOHWgNxUPbtysmBlAIyvRroNVJg2ZuyTxhB0PQkyJWmQYchzHwq6SC9NT5PRGAvmfmPpqK01nP9vU0uM8gIV7sXaQv2nwbeZprNKNUx1L0yGqiV+W74wyJXds3f+MXIR+fZlpcmoLasrtwo0KN2LToVruHyQONy0sMIM8VpYVKrjTuDV099RFAP+JAA1hftwSMRLQNKIqTX1qzQA9Mdc8cJ5tp7LwhbYEURiFlG8nn1bM/KjoaOSWMIFqfTPM inBy6c/i WB4UR8zgPKEaMofvM/o5kRzC6iXI9c8iArUz7lXkDJZHtJ33UUfuDacEsIla8CLEP3VusOGKBwo5WfkRfIhlxj6GBbvm18Pd9M+Ysa5KSYLJ3wBS+finbAX9xUPm6CzhWGAzoVe2O5k+XuTHwANQeC8WDdhs4KD1KateGf1Qkv2sUvJuvgluqElUlJMXzUFf/C+TX85cenVykuDANWKjhRg+A/sdY2stluvG0+Qe1bZcxXzCy/pRMnRLUAkPQrHUq03WbHK00Gqm7vdkxRoh9aBodW7C3PWQpqgEK/8iE0aX/JhkR2/oNunFc6rTwY6VDiNGWfdlD41O00bZ6KqicP09WEuau+rk2DM39Prl9tzyj038tbA0T5R/gfV4N5jqxG1s05Q306FLgQEbUs51WajHElp8Lu3JJWYyr2JG+x2udRYgeJ2F2H4Mqe4ocmBCNo1NslDaybWU84LQxdQuoDtbaIXuQhaQ8UrJxIiVMx+Fw2iiRKUYgnmEknY9rsbYm3BFeSmGoodgfPYNG/Z9PqoQpzUl2Fvkh+lyJTMDPGEJ02Hkiljw6BVvDrCMOmd3zhRDko9jVlNHSK+egbmVwXjtQ1qq000K6GkmhsjIwSUsdXJbq14Z2WdTrjZL3MTnJE/328S2vJuEBtLDvRjUBfXIp9k3zctQjQGup X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.03.24 16:46, Ryan Roberts wrote: >> >> Some of them look like mm-unstable issue, For example, arm64 fails with >> >>   CC      arch/arm64/mm/extable.o >> In file included from ./include/linux/hugetlb.h:828, >>                  from security/commoncap.c:19: >> ./arch/arm64/include/asm/hugetlb.h:25:34: error: redefinition of >> 'arch_clear_hugetlb_flags' >>    25 | #define arch_clear_hugetlb_flags arch_clear_hugetlb_flags >>       |                                  ^~~~~~~~~~~~~~~~~~~~~~~~ >> ./include/linux/hugetlb.h:840:20: note: in expansion of macro >> 'arch_clear_hugetlb_flags' >>   840 | static inline void arch_clear_hugetlb_flags(struct folio *folio) { } >>       |                    ^~~~~~~~~~~~~~~~~~~~~~~~ >> ./arch/arm64/include/asm/hugetlb.h:21:20: note: previous definition of >> 'arch_clear_hugetlb_flags' with t >> ype 'void(struct folio *)' >>    21 | static inline void arch_clear_hugetlb_flags(struct folio *folio) >>       |                    ^~~~~~~~~~~~~~~~~~~~~~~~ >> In file included from ./include/linux/hugetlb.h:828, >>                  from mm/filemap.c:37: >> ./arch/arm64/include/asm/hugetlb.h:25:34: error: redefinition of >> 'arch_clear_hugetlb_flags' >>    25 | #define arch_clear_hugetlb_flags arch_clear_hugetlb_flags >>       |                                  ^~~~~~~~~~~~~~~~~~~~~~~~ >> ./include/linux/hugetlb.h:840:20: note: in expansion of macro >> 'arch_clear_hugetlb_flags' >>   840 | static inline void arch_clear_hugetlb_flags(struct folio *folio) { } >>       |                    ^~~~~~~~~~~~~~~~~~~~~~~~ >> ./arch/arm64/include/asm/hugetlb.h:21:20: note: previous definition of >> 'arch_clear_hugetlb_flags' with type 'void(struct folio *)' >>    21 | static inline void arch_clear_hugetlb_flags(struct folio *folio) > > see: https://lore.kernel.org/linux-mm/ZgQvNKGdlDkwhQEX@casper.infradead.org/ > Yes, besides the other failures I see (odd targets), I was expecting that someone else noticed that already :) thanks! -- Cheers, David / dhildenb