From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 218A5C636CC for ; Tue, 31 Jan 2023 15:02:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 654ED6B0071; Tue, 31 Jan 2023 10:02:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 605236B0072; Tue, 31 Jan 2023 10:02:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A6156B0074; Tue, 31 Jan 2023 10:02:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3C8E56B0071 for ; Tue, 31 Jan 2023 10:02:40 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 123731C6231 for ; Tue, 31 Jan 2023 15:02:40 +0000 (UTC) X-FDA: 80415410880.29.79F80C1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id B206C2001E for ; Tue, 31 Jan 2023 15:02:36 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eP8wYmOR; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675177357; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xxh3yGM/ZsG6BoXNyGFfgQ/WFqnddub0mxCa53sHlr0=; b=Y1R32wsDj37kYXtcCYsvjpoQvcIPckyoFINQpg30R4qez2x9bFuufbBEPgOPoA/rQCHfSK gGznlT3rKsDmoUcvyjtW6Ng74/87dJaSAzuOz7CsKtKfIYtMEkbXeEhAp+EuzAXz1csuGi vDLimAfDUl7LVVEwGftaUeZMMzCRbSY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eP8wYmOR; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675177357; a=rsa-sha256; cv=none; b=nj5+7DcS1xLZmPRRcAfSh5bG02/b9W9DpP980tEEPVwM5G0ycBSpz7H6XfFtnujqOTn6jc GDWE3ycicu2HpEDVM91p019pxsNUlLFpRWV1/H1KUzQRorB7RTuOJn5HoLxsdNMziOJfCa a+fdwpEji+9swJNo5hVJr2bYgGa15cg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675177356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xxh3yGM/ZsG6BoXNyGFfgQ/WFqnddub0mxCa53sHlr0=; b=eP8wYmORAn38NPgan8yO5kouNFrvThQq/rL4i1zC9xWQ2299vFD8f5E9bfWuKAXkGMXu8m yi+28KBHC/VEbM3SJ7XrkbWJiRE0objDNsRSJesl2Y0FRJ5sq4gdQGS6aT61TPNVdoDqpe rdoJ3DWrnYy8ClTrcDzp1oXG2tjn9Dw= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-67-F3-lWGPcNlaxxBCfflPn-Q-1; Tue, 31 Jan 2023 10:02:25 -0500 X-MC-Unique: F3-lWGPcNlaxxBCfflPn-Q-1 Received: by mail-wm1-f69.google.com with SMTP id bg25-20020a05600c3c9900b003da1f6a7b2dso11438436wmb.1 for ; Tue, 31 Jan 2023 07:02:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xxh3yGM/ZsG6BoXNyGFfgQ/WFqnddub0mxCa53sHlr0=; b=wE4wfFfbpaXL1BZFPGiHKIrVZEK3b4w50jlypWneWEInAt1RmQ4KHozz+DYB+Kh1wi qDxFz8fKzxFgDSi1bvK4vSzx4p2EMCJdnATIXa1uNpccbaUUcTKhBWnkZ+P9oOs/FPkQ ivblZGlWVuKJMi8p3yGi9ZNM9sRZFwz34fERaH+eb/chkuuVSmmhSxvBrulT6ai8ElVF dp7fF73k29rgkyVSFSKDxdv6bVmHJENrAXHCXsul06VvRlTxVgBRO4DmYr3HnC3EwXdu eZkIxhteYDXcyE+Y4/tntnPvJ7TGdZ/uis8M2u+UhjFkIdsuGOxHey5OKKOdGFnsUsHj 9DJg== X-Gm-Message-State: AO0yUKVibNjFs8rmuferjSnG/3d1y40pb2QaD0SPFq7pm164Z6HIMHP3 XBG8fNlm/l++6DczQp8vw4siDv+suNi1QH0lyicyUa8YyfyYsBmljKraPdZ6eec33LJEdd9jOBW QLzJDlWT/J7s= X-Received: by 2002:a05:600c:12c6:b0:3dc:59a5:afc7 with SMTP id v6-20020a05600c12c600b003dc59a5afc7mr8099365wmd.20.1675177344021; Tue, 31 Jan 2023 07:02:24 -0800 (PST) X-Google-Smtp-Source: AK7set/V4yEZEsQrG/ruc8sFzoH9qJbB6K1Fnya6OXei72kF8T6t0smCD8SwpweMLGlQh0L9cOmCbA== X-Received: by 2002:a05:600c:12c6:b0:3dc:59a5:afc7 with SMTP id v6-20020a05600c12c600b003dc59a5afc7mr8099330wmd.20.1675177343696; Tue, 31 Jan 2023 07:02:23 -0800 (PST) Received: from ?IPV6:2003:d8:2f0a:ca00:f74f:2017:1617:3ec3? (p200300d82f0aca00f74f201716173ec3.dip0.t-ipconnect.de. [2003:d8:2f0a:ca00:f74f:2017:1617:3ec3]) by smtp.gmail.com with ESMTPSA id hg6-20020a05600c538600b003dafbd859a6sm19664293wmb.43.2023.01.31.07.02.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 07:02:23 -0800 (PST) Message-ID: <7f8f2d0f-4bf2-71aa-c356-c78c6b7fd071@redhat.com> Date: Tue, 31 Jan 2023 16:02:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [GIT PULL] iov_iter: Improve page extraction (pin or just list) To: Jens Axboe , David Howells Cc: John Hubbard , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jason Gunthorpe , Logan Gunthorpe , Jeff Layton , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <040ed7a7-3f4d-dab7-5a49-1cd9933c5445@redhat.com> <3351099.1675077249@warthog.procyon.org.uk> <3520518.1675116740@warthog.procyon.org.uk> <3791872.1675172490@warthog.procyon.org.uk> <88d50843-9aa6-7930-433d-9b488857dc14@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: cjxzc7j5zq4wpc1chgu55a9kk4nrqksr X-Rspam-User: X-Rspamd-Queue-Id: B206C2001E X-Rspamd-Server: rspam06 X-HE-Tag: 1675177356-907392 X-HE-Meta: U2FsdGVkX19nuMOnfBoX/wvLeRwcysKAgepKSaharGiFDIhov9Kwpbmjk8a6UwYJ4/7l6OC4HOBMyOnGCkp3Ca5Q4ISKGuhyWPMXBeCkrCR/Lk4u2fNpNXBO1R1e1UPMNGcV0hd9ZExOOwo8b7b85qS3zjc9LQfnX/nGncE73e2bC80vyZl1IEN0XnAR5LI2jB8fkLE5XBclBcG/5AO0UaXVJ0B4y1cnDpnRivFx/ZYVH29aEzYUfViKeTyNkp5wkNXuu7dAvvrunxnn+NqxDbgwlo+gBX0qM7/NMH0DPX60B/gxR3wPiNMDh3p8r29LCee9Z9dq91T4qfrvepc0PRO0TpieR+BfX0IPay3k623/cnLU7Seis9/B7yq+G1EJSHig2JoTW6X1GmITTT5xvBHOUwxyJW6FzQHLXRcMizX4Mqp0QO37ELUEA/rbm7Sb8Ub+z+cIl1JrnOvisso/avYLvQdUxl76Vc+rK4OXMqrHXjNf/8436N0LHujrfFoEwZehe6uVc66+4R9aoo3SwzkkSEeJ3jArU/lVZXnxIQfnDgFuzKE9HnhKzhNBKKfpFzcsowsYvmcKcaAyPhojCfrtlgsohSx8nUDW/0A2OgtjGwsPkZpIdJnLBnBTI2ebIt1fXWP6J5xMePomo26bpttJAep3pCBswEKpQCEs/iTil8xKs40WjKQO2xn2cFjdujUpqrQTJdSsDS20XuIpTNtG9fdYwxEwXIF272S07R2HimnViQzy8IJ4JhfYcWic4A62mZmrz8Dcds21MhHxcNRO0altEWIMrNcBUgKFRr2pBl82RP5F7dIOo3e4GiicI2WFXQuBP/Krn8wF6Q5B7QLLYsSqvUOErs2YAD0gInzsbE9mkr3KagWr+s4dd5BRk6AYQCmoT56yufAfZTFeEo2cjZN90eNjoKSdh0gk+ydk4UksgCRdYxjJI2o1x4faNdtuyMSwEN0FcN/Trbm YaBYXBSa IlQOXkAaDSxMENHHRKmiCwplfOFz4BxFWJPghfMV2O5GYAqw+ecVh9QSAX2FuaX0avzeZSys8Rye4qOtm8islqIBb6XLpV+/ilAg1PBj07QuFdv3l3NedOHY9ragArv5easG2oPpqRt1wR0IAW6awsoBHD6zJ8JNcD6qJhB9Z8hz2JTBnvn5BRwB1GNL/tudXCnj78VHBAL7C6wcVUeb7j5+zFJcPC5cIXwF7L9l8uMyFd/uYxRQf/A/tOa+7JaqmKl0eE8YNQu2OibTD7FeQgvmFVTpfTU+FAIaVCDVN/XfEueUlhUoHQVZit1zceQkJgLLYSV2LxSwzDdCm+Xy9oTODPZrRfn6M3OkrKyuzExiZaAGgdmpV+ipZi6svaW4z6UHEbW11Wwei8EMYtE1sOAevAR/e2b2RVg9LmHH22pH8UBZXfSCzws8tNLU2bJTB165WlxBNopGN0AG67DjNu2mlSOh+QibWOgnN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.01.23 15:50, Jens Axboe wrote: > On 1/31/23 6:48?AM, David Hildenbrand wrote: >> On 31.01.23 14:41, David Howells wrote: >>> David Hildenbrand wrote: >>> >>>>>> percpu counters maybe - add them up at the point of viewing? >>>>> They are percpu, see my last email. But for every 108 changes (on >>>>> my system), they will do two atomic_long_adds(). So not very >>>>> useful for anything but low frequency modifications. >>>>> >>>> >>>> Can we just treat the whole acquired/released accounting as a debug mechanism >>>> to detect missing releases and do it only for debug kernels? >>>> >>>> >>>> The pcpu counter is an s8, so we have to flush on a regular basis and cannot >>>> really defer it any longer ... but I'm curious if it would be of any help to >>>> only have a single PINNED counter that goes into both directions (inc/dec on >>>> pin/release), to reduce the flushing. >>>> >>>> Of course, once we pin/release more than ~108 pages in one go or we switch >>>> CPUs frequently it won't be that much of a help ... >>> >>> What are the stats actually used for? Is it just debugging, or do we actually >>> have users for them (control groups spring to mind)? >> >> As it's really just "how many pinning events" vs. "how many unpinning >> events", I assume it's only for debugging. >> >> For example, if you pin the same page twice it would not get accounted >> as "a single page is pinned". > > How about something like the below then? I can send it out as a real > patch, will run a sanity check on it first but would be surprised if > this doesn't fix it. > > > diff --git a/mm/gup.c b/mm/gup.c > index f45a3a5be53a..41abb16286ec 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -168,7 +168,9 @@ struct folio *try_grab_folio(struct page *page, int refs, unsigned int flags) > */ > smp_mb__after_atomic(); > > +#ifdef CONFIG_DEBUG_VM > node_stat_mod_folio(folio, NR_FOLL_PIN_ACQUIRED, refs); > +#endif > > return folio; > } > @@ -180,7 +182,9 @@ struct folio *try_grab_folio(struct page *page, int refs, unsigned int flags) > static void gup_put_folio(struct folio *folio, int refs, unsigned int flags) > { > if (flags & FOLL_PIN) { > +#ifdef CONFIG_DEBUG_VM > node_stat_mod_folio(folio, NR_FOLL_PIN_RELEASED, refs); > +#endif > if (folio_test_large(folio)) > atomic_sub(refs, folio_pincount_ptr(folio)); > else > @@ -236,8 +240,9 @@ int __must_check try_grab_page(struct page *page, unsigned int flags) > } else { > folio_ref_add(folio, GUP_PIN_COUNTING_BIAS); > } > - > +#ifdef CONFIG_DEBUG_VM > node_stat_mod_folio(folio, NR_FOLL_PIN_ACQUIRED, 1); > +#endif > } > > return 0; > We might want to hide the counters completely by defining them only with CONFIG_DEBUG_VM. -- Thanks, David / dhildenb