From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FAAFC25B75 for ; Fri, 31 May 2024 12:30:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD2F36B009A; Fri, 31 May 2024 08:30:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C83806B009B; Fri, 31 May 2024 08:30:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4B5F6B009C; Fri, 31 May 2024 08:30:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 951796B009A for ; Fri, 31 May 2024 08:30:18 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4C560A309F for ; Fri, 31 May 2024 12:30:18 +0000 (UTC) X-FDA: 82178623716.13.645C9B8 Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) by imf04.hostedemail.com (Postfix) with ESMTP id DD68140005 for ; Fri, 31 May 2024 12:30:14 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=PiQPFE01; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf04.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.161.50 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717158615; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pobb+qKmbEVkLRW5gpiFE+2DxXv9n/WgMfYUIElZ6qQ=; b=4Q5iE3iLob53sXt51lLtadrRGQmka1zukKsh18cFwdcECrLUrwjS6BSxWl5ooUTpMVZHZ0 echeeOCJUtIWT0mAaGR8K9cWh7Wbn3/+zfNwI/B/OF4dD+IFyGO1XlEwYnhgx57L11D5GE 8afB9+CfFLURdGd3jpFw051ZLYs6Uio= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=PiQPFE01; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf04.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.161.50 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717158615; a=rsa-sha256; cv=none; b=qLalcioRS3xmiLxXG+B71NNAqnpyDXUyvRcYNTX4zUaXgte+NKmXq8y1egH7I8cLyzh3aN HIsoiarj3q17VJAZKe8DIUAp1EPIwL2iazgeZnlZ1I66Pl0pSWuXofkNogZVcW/uabwo8K WFPDA4Q5PmCg/o5ZW3+N3r4n0A8Hkdw= Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-5b97b5822d8so929757eaf.3 for ; Fri, 31 May 2024 05:30:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1717158613; x=1717763413; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pobb+qKmbEVkLRW5gpiFE+2DxXv9n/WgMfYUIElZ6qQ=; b=PiQPFE01ee4SYaitO7ssugl86dHnkJQO5E6oo1Qn+TuNUuksLUCweqBzuf5NY/IJdT kyGOU8h0f4qbxHItS6Pehw3BFuG6rBwH1FeqOx5HiYaGk239fnq0FReXpkdHxzOqRtIM uGZT3EkSDMgvr2oB0Wraifem5yTPhG6b5nVE+f5HwCwV6ETSx3CUM4NsXZeJIB8e0Tl/ 8gTsmbHWm09VSo9tugLb/nWIlYcXuF2BqTOy7h5Hmk4DF9cuB8JQ9yqclY4xfkiXPdUD U6Q5hUYnsMZ+aGA2sJ86tvgHfjTp8htW9NBWxLNulCUDoWgGS2GLN62z8BGUikSVvd9E xMJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717158613; x=1717763413; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pobb+qKmbEVkLRW5gpiFE+2DxXv9n/WgMfYUIElZ6qQ=; b=i5VthUQyG578pKyOu5dT6FfmSwsxkjGuGxRGd6lSkHmLRtnplDd0AA7aXt3JEwlcLt Z4yV+2ceHvMkM8ohpJB35cWTq38Z2RQLvRQrbvwiqTAuVW+KW1KyY59MTm6yl+wV8KHx q+QXGahEzAkWhVTap+OcHLd+8ZS7yDiCeCnAlZrpiDvhZtgfTlCE8q1sHEYR4Kr1MgYK BiIhL/s4Fekc/6KuzW0KJnzvVjuhUMxkwjbG40fQIyz+uxEvdjXSKDZjZMgHFtk5pdbT 5d8U4j+WuNU1kTeZeo+NTapUJsLNimR2U0m3CbZFh6fuBTIeSJcxWizxarFXJ+Ueu7wb fc/g== X-Gm-Message-State: AOJu0Yws7Pm7UDciN4/v+hE9Ekk5Mi5bGwTv2EXsi9Nj+cTomDXUsRId a2g7OifrxdPWBHPsK9XOx9XCK6PfBDSSslZDS2/A1VNJD3ObfLa078TyySYgYlQ= X-Google-Smtp-Source: AGHT+IGeo7tqAnMa9JIVWwH4HjMXc/fO4mXZB9xlsqbbsjuQhrqcsOkModTThzMO7MtphiKdpMdQXg== X-Received: by 2002:a05:6358:33a2:b0:199:28f7:c247 with SMTP id e5c5f4694b2df-19b48c28251mr203744155d.9.1717158613508; Fri, 31 May 2024 05:30:13 -0700 (PDT) Received: from [10.4.66.249] ([139.177.225.230]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6c354b945a8sm1181633a12.23.2024.05.31.05.30.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 May 2024 05:30:13 -0700 (PDT) Message-ID: <7f7c3bbe-e250-420d-a7d5-89508d881f0b@bytedance.com> Date: Fri, 31 May 2024 20:30:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [External] Re: [QUESTION] mm: Redundant const parameter? Content-Language: en-US To: Dev Jain Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com References: From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DD68140005 X-Stat-Signature: 7gegf5a8ywygqmm91r9m4qr77i661yr9 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717158614-617722 X-HE-Meta: U2FsdGVkX1/CWy3hL3KLDW9urTlWhzuEvp5fnkuR7h1NWsw8yCUTtDVOze594FRVidYclyA+hiNfYyt9dl17F90aXUWM+LhVOIPFYVpUdCitfirt/idhNvjM0s0WszVHgSIDXHCPDcpoZXNnVxWA4cvcDPz0jSVTXCd0rAFpjNPVU19eHwy538H54A+obI/NxLCl0l7m8JirPteNve53VgEaRzcUMeHDTCp9iMSQYqd4woJjtrUPoL7nW70azqGaz7bBEk544kbOEMqxTscfr3sAHvm2h2+RRRqsbj6MD96YFJdvbwZWK/zZwqS4xDfjKLt2s/XJAx9K0MmiOrmss/Is00bajo1Dw28CTaotg7RuF0t6CH0qYWFcSeNiWSlMX84/Pr5PAe1bbyVGqf1d4cjgepXiopf6pZHlcymoVUSDCqcEDF5xhO9V9BeMimV5Dcib9tYcwqFqhYPXJRP9T8AMbHuXgv9Rh27EsCI3xOwglviVMBn0sziqNXdrbuTohxQwvtL0tJK72l1qmULcR3vBrDRPiu33Oi/yCQ6vY63lpRY31zHbxVPqKSqiTES1bRUiW7XP/ea8D22QMEhK5sEGX2Wm4ehxIfpPUL0vg3pQ6jKMT7ROsynDR5dPAECtNyM+/Sl7YD9xjimMCgETBalg0bYYX8Cblvs54QUq/EzbALTbPQicDPH8mNacCYGfqv2Gi8aXnSRoWF1NnhM2hNlFoV/WO+6hVeHYXm6sZkGnI8t336+IBn+j/S5OlbaFauqb1GC7cemHFHxs0TXnWT5pJcIWoGSMiu32gmFZ7/T2+DcYWoLGzs2UN9F1POvCfA+OgqCT/brHvoDzYk00bcSny7Gj0aj96VtlpJiTg0qGWnGeZeyT2q8psKMAXxxtYAEPld7H+JLXSGNJb9y2puxMPb9qXBDT1AHnm9Xh50cPzNwF67E0U8SJbUckvLyEFLmNc1HdmQrsWAQvogZ OtKXCfke cL+i8RE8M4ztclgHDRLfXqezlTM1G54eE0RvZ3pEaFXXMJNGO4TEzYnh/N4aDNbpQI5FLVjJZs3LLVyfiyB8N3AkadT0Aa9T5TADXCYI7Mf5uMFLzWOnqI3xImV467ux9HgjwEPDumDqSTt1+440TYabh7egbYkiGlanJqcxsIXg3Sj3pDRudIUFNXBCKERDqANQKgiCPHtdMFsyiusbslwR1+DU9fOT6SKj5zVsH4Nt0YlYJDCVTM86x2Cue5D9eez7qT4MuQEqNT/6A5E1LvOnAm50FkbMHDJ76K4Bn300tXqyQAWeu2RxtU7EpgMlpMlw27zy5RpUjg3zQZnvSWwtTvRcRAPd3MKwBiNe9owmimzp/wOgcGUnKwiMDtVrf2wvH03dAwv7lU9RfxD8NxPNDvn6iUXiToyptYsWZswVqhbVNp+sTfUpoMQNfszBe3Ov+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.032314, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/31 19:31, Dev Jain wrote: > I guess it would be better if I send this as a patch and wait for comments. Ah, you're right. I think it should be: return folio_test_workingset(slab_folio(slab)); Right? Don't notice there isn't any build warning about this "const" discard. Thanks. > > On 5/31/24 16:42, Dev Jain wrote: >> Hi Chengming, >> >> In mm/slub.c, you had defined slab_test_node_partial() to take a const parameter. >> >> Is there any point of taking in a const, when you are anyways typecasting it to >> >> a (struct folio *) from (const struct folio *) ? In fact, at the place where you call >> >> slab_test_node_partial(), the struct slab *slab is not const. >> >> Please comment. >> >> >> Thanks >> >> DJ >> >> >> >>