From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B9A6C433F5 for ; Thu, 24 Mar 2022 08:55:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF6106B0072; Thu, 24 Mar 2022 04:54:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA4FE6B0073; Thu, 24 Mar 2022 04:54:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A44DD6B0074; Thu, 24 Mar 2022 04:54:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0165.hostedemail.com [216.40.44.165]) by kanga.kvack.org (Postfix) with ESMTP id 912766B0072 for ; Thu, 24 Mar 2022 04:54:59 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4683CA010C for ; Thu, 24 Mar 2022 08:54:59 +0000 (UTC) X-FDA: 79278669918.29.F6CEF9F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id CA2761A0030 for ; Thu, 24 Mar 2022 08:54:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648112098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qQ7KlexPypooA6FYJm9ptq0BegCdasbya4hs+9/TZnw=; b=WbR7z7rgyCYlW8jghLGwbcpWx/8+QjdPMIRY0OnLKSlZSE/7gAFjKHl/fIMrEXl2bQV8+Q g7qZ7cGS1i2UDG5NSkc7PiYmNO4j1g8tWcplfyTY6DmNabp3edCn0bo3klsvihit9+zIWM jcC6SwPcMcL9ouHVozTxpVOn/TXDxi8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-633-ks84r_egPzqDal2_WPWVJg-1; Thu, 24 Mar 2022 04:54:57 -0400 X-MC-Unique: ks84r_egPzqDal2_WPWVJg-1 Received: by mail-wr1-f69.google.com with SMTP id d17-20020adfc3d1000000b00203e2ff73a6so1438397wrg.8 for ; Thu, 24 Mar 2022 01:54:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=qQ7KlexPypooA6FYJm9ptq0BegCdasbya4hs+9/TZnw=; b=Ob94m+Abow3rwwxl88R0YDQwvbugTRRL0QwsfIStovMwnTa8mRskwPxkfrqm4JFz52 l9Rt0rCqV/fCvH4/GbQ3E0sIxfhQOqv23526rCBT4J1U5gqF5h8qw8njtsROM9p6hZMv V7WsLMwul9uv8elzWNOgkHB8lW/jkQBMqL1j175YqVlKcMi7oR1EHVneVrvwUlFdnjbM +InVjNkmkMaSNvDXTkzrgj3BqcdnCqY+9pBcrEK7DFMdyXBmRaqXP+u7Xbqmp5cDXodF GaMMezHE3CTxRifRLplObXKAz64zx7VGSJ+XS6aJo7nyfoQnZL1TJ5TkCtYztn3NB3e7 NpMg== X-Gm-Message-State: AOAM531ZKTb1Rpwyo9W0KPTk6i6iVh6+1sUVaNiQAfPBakbPK1av+P68 3PGLzkHk3iiwx+nTjVeZJxgKrSvQ/cCpLrd+IuzY4los9tRLsdFmBTk7w4X5OLbMb5vwK86MUxW Bj7zswHJGhkM= X-Received: by 2002:a5d:4688:0:b0:203:f0cc:da10 with SMTP id u8-20020a5d4688000000b00203f0ccda10mr3691953wrq.87.1648112096055; Thu, 24 Mar 2022 01:54:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfRD51IlIU/a0GHZ9SIvipCRxOPeVi0YzksbN1K4luw5OyNTpyxlPpbv0I1KWaXpJOgTdZaA== X-Received: by 2002:a5d:4688:0:b0:203:f0cc:da10 with SMTP id u8-20020a5d4688000000b00203f0ccda10mr3691926wrq.87.1648112095733; Thu, 24 Mar 2022 01:54:55 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:20af:34be:985b:b6c8? ([2a09:80c0:192:0:20af:34be:985b:b6c8]) by smtp.gmail.com with ESMTPSA id e12-20020a5d6d0c000000b001a65e479d20sm2327670wrq.83.2022.03.24.01.54.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Mar 2022 01:54:55 -0700 (PDT) Message-ID: <7f74c6f3-3830-a508-7357-39361ba8111f@redhat.com> Date: Thu, 24 Mar 2022 09:54:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v2] mm/vmstat: add events for ksm cow To: CGEL Cc: akpm@linux-foundation.org, yang.yang29@zte.com.cn, dave.hansen@linux.intel.com, ran.xiaokai@zte.com.cn, yang.shi@linux.alibaba.com, saravanand@fb.com, minchan@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xu xin References: <20220323075714.2345743-1-yang.yang29@zte.com.cn> <614b33de-cdf0-73d2-08e3-196363d816d2@redhat.com> <623bcb0a.1c69fb81.ae484.a006@mx.google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <623bcb0a.1c69fb81.ae484.a006@mx.google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WbR7z7rg; spf=none (imf19.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CA2761A0030 X-Stat-Signature: wn8m4mtg86nbi9tjphy8th6bbrb8gx54 X-HE-Tag: 1648112098-336399 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.03.22 02:36, CGEL wrote: > On Wed, Mar 23, 2022 at 07:43:04PM +0100, David Hildenbrand wrote: >> On 23.03.22 08:57, cgel.zte@gmail.com wrote: >>> From: Yang Yang >>> >>> Users may use ksm by calling madvise(, , MADV_MERGEABLE) when they want >>> to save memory, it's a tradeoff by suffering delay on ksm cow. Users can >>> get to know how much memory ksm saved by reading >>> /sys/kernel/mm/ksm/pages_sharing, but they don't know what's the costs >>> of ksm cow, and this is important of some delay sensitive tasks. >>> >>> So add ksm cow events to help users evaluate whether or how to use ksm. >>> >>> Signed-off-by: Yang Yang >>> Reviewed-by: xu xin >>> Reviewed-by: Ran Xiaokai >>> --- >>> v2: >>> - fix compile error when CONFIG_KSM is not set >>> --- >>> include/linux/vm_event_item.h | 2 ++ >>> mm/memory.c | 20 +++++++++++++++++--- >>> mm/vmstat.c | 2 ++ >>> 3 files changed, 21 insertions(+), 3 deletions(-) >>> >>> diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h >>> index 16a0a4fd000b..6f32be04212f 100644 >>> --- a/include/linux/vm_event_item.h >>> +++ b/include/linux/vm_event_item.h >>> @@ -131,6 +131,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, >>> SWAP_RA_HIT, >>> #ifdef CONFIG_KSM >>> KSM_SWPIN_COPY, >>> + KSM_COW_SUCCESS, >>> + KSM_COW_FAIL, >>> #endif >>> #endif >>> #ifdef CONFIG_X86 >>> diff --git a/mm/memory.c b/mm/memory.c >>> index 4111f97c91a0..c24d5f04fab5 100644 >>> --- a/mm/memory.c >>> +++ b/mm/memory.c >>> @@ -3257,6 +3257,8 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf) >>> __releases(vmf->ptl) >>> { >>> struct vm_area_struct *vma = vmf->vma; >>> + vm_fault_t ret = 0; >>> + bool ksm = 0; >>> >>> if (userfaultfd_pte_wp(vma, *vmf->pte)) { >>> pte_unmap_unlock(vmf->pte, vmf->ptl); >>> @@ -3294,6 +3296,7 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf) >>> */ >>> if (PageAnon(vmf->page)) { >>> struct page *page = vmf->page; >>> + ksm = PageKsm(page); >>> >>> /* >>> * We have to verify under page lock: these early checks are >>> @@ -3302,7 +3305,7 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf) >>> * >>> * PageKsm() doesn't necessarily raise the page refcount. >>> */ >>> - if (PageKsm(page) || page_count(page) > 3) >>> + if (ksm || page_count(page) > 3) >>> goto copy; >>> if (!PageLRU(page)) >>> /* >>> @@ -3316,7 +3319,7 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf) >>> goto copy; >>> if (PageSwapCache(page)) >>> try_to_free_swap(page); >>> - if (PageKsm(page) || page_count(page) != 1) { >>> + if (ksm || page_count(page) != 1) { >> >> I think we really want to recheck here, after locking the page. >> Consequently, just do a PageKsm() check below. >> >>> unlock_page(page); >>> goto copy; >>> } >>> @@ -3339,7 +3342,18 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf) >>> get_page(vmf->page); >>> >>> pte_unmap_unlock(vmf->pte, vmf->ptl); >>> - return wp_page_copy(vmf); >>> + ret = wp_page_copy(vmf); >>> + >>> +#ifdef CONFIG_KSM >>> + if (ksm) { >>> + if (unlikely(ret & VM_FAULT_ERROR)) >>> + count_vm_event(KSM_COW_FAIL); >>> + else >>> + count_vm_event(KSM_COW_SUCCESS); >>> + } >>> +#endif >> >> Do we really care if we failed or not? I mean, the failure case will >> usually make your app crash either way ... due to OOM. >> > I think we need failed count. Because ksm cow oom is a little different > from general OOM. User may wonder I am not allocing new memory, why it > cause OOM? And OOM may have big impact for some kind of tasks, so we > better let user know that, do we? The log will be flooded by messages from the OOM handler, how will one counter regarding KSM help? I really don't think this is of any use. -- Thanks, David / dhildenb