From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE789C4332F for ; Mon, 30 Oct 2023 19:25:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D1546B026B; Mon, 30 Oct 2023 15:25:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 581496B026D; Mon, 30 Oct 2023 15:25:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4495B6B0286; Mon, 30 Oct 2023 15:25:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 325F36B026B for ; Mon, 30 Oct 2023 15:25:23 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0A164B58F7 for ; Mon, 30 Oct 2023 19:25:23 +0000 (UTC) X-FDA: 81403106526.28.25E0423 Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf09.hostedemail.com (Postfix) with ESMTP id 52ADF140021 for ; Mon, 30 Oct 2023 19:25:21 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=linux.com (policy=none); spf=softfail (imf09.hostedemail.com: 62.72.0.81 is neither permitted nor denied by domain of cl@linux.com) smtp.mailfrom=cl@linux.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698693921; a=rsa-sha256; cv=none; b=ZI7I97q8tkzz0W2E2UWuDuxD/t25E/j7FKoJQrdKpRL8N2iZIOFkF/lMW37pTYAZCuisQB TaczfGw7JECzBkvQ9Ips7CVLPWpWfHR6YudOjjWhTBcKySWODvg+PxSfpIvuHgfYXjsO1U tsF/UfK/s45a2IwWB0mkac/gKEcZmic= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=linux.com (policy=none); spf=softfail (imf09.hostedemail.com: 62.72.0.81 is neither permitted nor denied by domain of cl@linux.com) smtp.mailfrom=cl@linux.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698693921; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cLe5dLICMsyUi28EqOyBVnOKkU5zLHxDyAsnK3+Lwi0=; b=hJG3BevlYyYyi4hrwlsWxiRj1dF7n8O9Eh1EBjzt4KHbOz7mzxD+UNm4htdFDrljnmZWwJ eD/vuH3EBKci8twpRjCCC7jDBZiEAqxYdPQOIQqwQEpV0wKrWZ5H+NffM19QXCWbLvtaY0 Z/acFisBkzmk8uXuDbgcQQvuVUrY9uQ= Received: by gentwo.org (Postfix, from userid 1003) id BD90248F2C; Mon, 30 Oct 2023 12:25:19 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id BC0EE48CA2; Mon, 30 Oct 2023 12:25:19 -0700 (PDT) Date: Mon, 30 Oct 2023 12:25:19 -0700 (PDT) From: Christoph Lameter To: Chengming Zhou cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chengming Zhou Subject: Re: [RFC PATCH v3 0/7] slub: Delay freezing of CPU partial slabs In-Reply-To: <1199315b-63ce-4be4-8cde-b8b2fd29f91a@linux.dev> Message-ID: <7f70d130-c05a-3cb7-9509-41c21c3014fb@linux.com> References: <20231024093345.3676493-1-chengming.zhou@linux.dev> <1199315b-63ce-4be4-8cde-b8b2fd29f91a@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 52ADF140021 X-Stat-Signature: 5z95uyso8qbi36bg8f4nziifergtyqxy X-Rspam-User: X-HE-Tag: 1698693921-447392 X-HE-Meta: U2FsdGVkX1+DUDn7feFgniOks7kAdThOjmiW+xGEohMclpsjr3nY36f0lzQwK31qGwcbjYyTK3wWMaRxGe+qAKAvnwUx1A9/umsKbkjdiailorwrzLoDfOmROgS8c4Jjsga/d/7wEcxQml7lwsj6kHu681eYx1Ml0a6NvGzEzX+hPcWB7zh2YBDi0As7heI7PJHBWh7AJz45zlyWrtiQPoFuqS6nUCBcvU//UoDDe80uHf0OCqEMBhOU31hzkf+6nP/hYSN5XMxH9gAqPL8RXt6HlG1IGvMPT012edv7NTv0Q8NCpNap5zVUKCqCMMo970gEaM1rBPGLmIUFFFBhLQ+81bELcG9249/rP/GwscAgHRvYozJaniZQR6XMUs8vADic6R6F1zj85NcEJLZyVyEcyu++5u7esqiHKL1r7l+wGHPDgpVGMI+NFg1D5x5j5WGWv3FQfmN4SaMviqSqP2tB7Mii5Pei5/qSLt4qyXeZ5JFepvIIVHmasFVtz5BqfBNdPaJwZu/lV3uK42/K5mWkiuQp6TIo2iloQe5jmiTIr8Ux2O/RnTcO9v9LhN+JiReHyAXIthGab/pu4lKisyNE2tPNPfMM69cPbuzpPCJTf3Mzf6ugOJdrBbjOTPoffrNEqpvgnftvqSL8i2JTeLnf8ZEZ3n0mQUH9e6qkg06I0yyV5qrTgFYxo1CV++TXp+2Qxu3ke4X445IvE2vri7DUTTT0JjDQiGX7SyFJy8H6SeV7xZrjQMkl6lZ8RZbbb+wsJxa1Ae68p2xmuRpQGViJVEh/nmGWSMLKFMBrv6UfIwdjIqjCWHslMN1ubIi2Xm+RUZhjmDWiawOcxIQ+Tz57rNparZOTiOwC01um7TTaV5HWq9uYZokSLxsk7rxBDpnPF266sRqosRqAHms0p4i8dNHO7mubw1mlLN1DxR9PfiXjLxakQfhUpXhMqbWRaXTcYMYxsqc4LZwWLr3 2js/p9Ij Gp7Dx6qXkgGqI0CqYK7QMCSyyKXAlWW7z90qbHbssMv4wAG+3F/Xjxhr1NyerjhrwXrh+L/V1zDwQvo35bKI7kCHUSY56QJ/mww6tU0IXkFcC4/2qCbYYRljgwz9LLAIznth0Nm16MF5PFPlqwbamKaIJ/f2xL5V2MNFzJQQlqFas17U8qPVYxmEF+iTmzOqgaU9OkYP2lGdoZzc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 28 Oct 2023, Chengming Zhou wrote: > 2. But for full slab (slab->freelist == NULL), PG_workingset is not much useful, we don't > safely know whether it's used as the cpu slab or not just from this flag. So __slab_free() > still rely on the "frozen" bit to know it. > > 3. And the maintaining of "frozen" has no extra cost now, since it's changed together with "freelist" > and other counter using cmpxchg, we already have the cmpxchg when start to use a slab as the cpu slab. > > Maybe I missed something, I don't know how to drop the frozen flag. Maybe frozen is now = PG_Workingset | cmpxchg-frozen?