From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C95A7FA373D for ; Tue, 1 Nov 2022 11:14:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 415146B0072; Tue, 1 Nov 2022 07:14:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C5826B0073; Tue, 1 Nov 2022 07:14:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B5896B0074; Tue, 1 Nov 2022 07:14:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1AE3F6B0072 for ; Tue, 1 Nov 2022 07:14:42 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B72BDA0352 for ; Tue, 1 Nov 2022 11:14:41 +0000 (UTC) X-FDA: 80084615562.19.99EF018 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf22.hostedemail.com (Postfix) with ESMTP id E4FA2C001F for ; Tue, 1 Nov 2022 11:14:39 +0000 (UTC) Received: from canpemm100007.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4N1nNK5cZlzRnsl; Tue, 1 Nov 2022 19:09:37 +0800 (CST) Received: from canpemm500005.china.huawei.com (7.192.104.229) by canpemm100007.china.huawei.com (7.192.105.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 1 Nov 2022 19:14:33 +0800 Received: from canpemm500005.china.huawei.com ([7.192.104.229]) by canpemm500005.china.huawei.com ([7.192.104.229]) with mapi id 15.01.2375.031; Tue, 1 Nov 2022 19:14:33 +0800 From: zhaogongyi To: kernel test robot CC: "oe-lkp@lists.linux.dev" , "lkp@intel.com" , Shuah Khan , David Hildenbrand , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [linus:master] [selftests/memory] 13023c33c9: kernel-selftests.memory-hotplug.mem-on-off-test.sh.fail Thread-Topic: [linus:master] [selftests/memory] 13023c33c9: kernel-selftests.memory-hotplug.mem-on-off-test.sh.fail Thread-Index: Adjt4wESSc/+YfD2QFSTt9INW1YibA== Date: Tue, 1 Nov 2022 11:14:33 +0000 Message-ID: <7f67ed236c3c49c1a29877a3aa221e20@huawei.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.67.110.209] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667301281; a=rsa-sha256; cv=none; b=P1q6gcW4fx4KPkYD/ZC9CjuSl9p+HvJOCt6Np0vp6tjtJS9ksbUcVm18zK822ElpeESXMs o6EOJSjhgOeV4qB7CSGPxnBHyuD1hpL5OeaMSYDDzRpiprT7ub+iIdPr33P43zOiZHHw9/ lyhLScUJsksXSoy/6EU1jLc+XqSevIM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of zhaogongyi@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=zhaogongyi@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667301281; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=yUdme+WEJkl7iYEiWzXjix7rrdSo5tsUCxGaildMmbE=; b=Yq8qCJzr0kEbqqa6XZ9nHT1HaakTtfVg46l4JFRgKDpMCEswEkanKACxGfPD8LEP3kH5Ur +CfJziFcEd+KpPxnYpweUHifkQTRfwb8SzZ8ZDsu4YMA4CrAkQt9CQeAufQcwjat3mtmyG rk/0TdroYRBId8FZGh8gV54NlrPl03c= X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of zhaogongyi@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=zhaogongyi@huawei.com X-Stat-Signature: i8jnpxgpxcjjjkmjfj41hd5bfyqiwetq X-Rspamd-Queue-Id: E4FA2C001F X-Rspamd-Server: rspam06 X-HE-Tag: 1667301279-419913 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi! >=20 > Hi Gongyi, >=20 > We noticed that below commit may change the exit status of > memory-hotplug selftest, please check if the test result is expected. >=20 > We got same test log before this commit but with a good exit, though > there were also some "Invalid argument" and "unexpected success" log. > Please help give some guidance if there are any problems in our test flow= . > Thanks. >=20 >=20 > Greeting, >=20 > FYI, we noticed kernel-selftests.memory-hotplug.mem-on-off-test.sh.fail > due to commit (built with gcc-11): >=20 > commit: 13023c33c962730a38d6b43995910c8805637a9a > ("selftests/memory-hotplug: Add checking after online or offline") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master >=20 > in testcase: kernel-selftests > version: kernel-selftests-x86_64-9313ba54-1_20221017 > with following parameters: >=20 > group: memory-hotplug >=20 > test-description: The kernel contains a set of "self tests" under the > tools/testing/selftests/ directory. These are intended to be small unit t= ests > to exercise individual code paths in the kernel. > test-url: https://www.kernel.org/doc/Documentation/kselftest.txt >=20 >=20 > on test machine: 8 threads Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz > (Skylake) with 28G memory >=20 > caused below changes (please refer to attached dmesg/kmsg for entire > log/backtrace): >=20 >=20 > 2022-10-28 01:04:44 make quicktest=3D1 run_tests -C memory-hotplug > make: Entering directory > '/usr/src/perf_selftests-x86_64-rhel-8.3-kselftests-13023c33c962730a38 > d6b43995910c8805637a9a/tools/testing/selftests/memory-hotplug' > TAP version 13 > 1..1 > # selftests: memory-hotplug: mem-on-off-test.sh # Test scope: 2% hotplug > memory > # online all hot-pluggable memory in offline state: > # SKIPPED - no hot-pluggable memory in offline state > # offline 2% hot-pluggable memory in online state > # trying to offline 5 out of 224 memory block(s): > # online->offline memory0 > # ./mem-on-off-test.sh: line 78: echo: write error: Invalid argument # > offline_memory_expect_success 0: unexpected fail # online->offline > memory1 # online->offline memory10 # online->offline memory100 # > online->offline memory101 # online->offline memory102 > # online all hot-pluggable memory in offline state: > # offline->online memory1 > # offline->online memory10 > # offline->online memory100 > # offline->online memory101 > # offline->online memory102 > # Test with memory notifier error injection > # ./mem-on-off-test.sh: line 267: echo: write error: Invalid argument # I can not reproduce the error according to the file 'reproduce'.=20 Line 267 is not runnable on my system. Is there something wrong here? The code on my system like: 266 # 267 # Offline $ratio percent of hot-pluggable memory 268 # 269 echo 0 > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_OFFLINE/error 270 for memory in `hotpluggable_online_memory`; do 271 if [ $((RANDOM % 100)) -lt $ratio ]; then 272 offline_memory_expect_success $memory &>/dev/null 273 fi 274 done > online_memory_expect_fail 142: unexpected success # > online_memory_expect_fail 190: unexpected success > # ./mem-on-off-test.sh: line 287: echo: write error: Invalid argument # The problem is similar with line 267. > offline_memory_expect_fail 107: unexpected success # It seems the error-inject not work. Regards, Gongyi