From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A208ECAAD3 for ; Tue, 6 Sep 2022 00:54:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A086D8023E; Mon, 5 Sep 2022 20:54:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B68380224; Mon, 5 Sep 2022 20:54:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8801D8023E; Mon, 5 Sep 2022 20:54:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 784A680224 for ; Mon, 5 Sep 2022 20:54:00 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4E8FFA0F2E for ; Tue, 6 Sep 2022 00:54:00 +0000 (UTC) X-FDA: 79879838640.25.24D8198 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by imf09.hostedemail.com (Postfix) with ESMTP id 9238414007C for ; Tue, 6 Sep 2022 00:53:59 +0000 (UTC) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id E03CB840AE; Tue, 6 Sep 2022 02:53:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1662425637; bh=OQRfBNGlI5tgqzGu/+LeerqO+BWTietPlsgYYaJl4R0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WgqgT3O8+hCGyCYyGNVUXk9n2PoiKHWqddClM+Rku5+BgmnxfohLda8xOoltvQqPS elppYUGLy9Aj97HBhViz8aSE3OV6/T6UeT4BfQSTCYwb6zI3TnEwlQ8CZCddYUZuCa nr+weAFjAc7OHBTQ9+2+lO16UP/QxEKQ0gKYNHAOJvEqwxp1zIgupAMEB4N5ccNys1 efY0nO3TCgPM/WxfhxEqe6x5SvOtfuSkhnmbI9Kn1s04RESGmhNZ0qSHCkDftrPeDw izjrdL0v+amFFl2XVW/sTxVk5wiT0qMYJrlZa80ASDkev8fBu3v/SqPg1L/eL7f3cO 3v0pSenB10o3g== Message-ID: <7f661266-757d-3913-851c-96559229e553@denx.de> Date: Tue, 6 Sep 2022 02:53:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [kbuild-all] Re: [linux-next:master 2262/4736] drivers/extcon/extcon-usbc-tusb320.c:19: warning: expecting prototype for drivers/extcon/extcon-tusb320.c(). Prototype was for TUSB320_REG8() instead Content-Language: en-US To: "Chen, Rong A" , kernel test robot Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List , Chanwoo Choi , =?UTF-8?Q?Alvin_=c5=a0ipraga?= References: <202209030755.eB4SkwGE-lkp@intel.com> <92d78ac2-c32a-cd19-891c-7bac77725b84@denx.de> <494af0d7-b07a-3d50-7539-09c300b79dd8@intel.com> From: Marek Vasut In-Reply-To: <494af0d7-b07a-3d50-7539-09c300b79dd8@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662425640; a=rsa-sha256; cv=none; b=L7yOMH6rYPI8+0eAHL5qGLiFYI0Qkya+M98sTyq/wKbdnZmQPmDyE4iFG4/AS9t0dviCks 9pYyy87gOxMc/pFsdIlpXa0kT5zRYPKCJu+TiwLBPVebKybfocYV3M2cRssCaJZw1ZVRPH 6IKu2CO2sZ1bxrue8Hh/Rck632ylkBo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=denx.de header.s=phobos-20191101 header.b=WgqgT3O8; spf=pass (imf09.hostedemail.com: domain of marex@denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=marex@denx.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662425640; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OQRfBNGlI5tgqzGu/+LeerqO+BWTietPlsgYYaJl4R0=; b=HOiG3yHv74qwN1UrSniBLNr3YJ40PGXVyStrVTVdj+3ew1Q2TvDkhI5j0yrqO/0v0Wf6sW k8I154jJdag3GR95/3uDAvrI1gLRysh+IgVCPVOmZx89QuGRliGwtbkiaMSDJr3sM/xWEZ jGIa99W46ybqMXoXxVOyArJNOjkG1yE= Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=denx.de header.s=phobos-20191101 header.b=WgqgT3O8; spf=pass (imf09.hostedemail.com: domain of marex@denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=marex@denx.de; dmarc=none X-Rspamd-Server: rspam01 X-Rspam-User: X-Stat-Signature: c7zn8s38ce6qjb4oum77xcowzihci4ai X-Rspamd-Queue-Id: 9238414007C X-HE-Tag: 1662425639-378439 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/5/22 04:54, Chen, Rong A wrote: > > > On 9/3/2022 10:31 PM, Marek Vasut wrote: >> On 9/3/22 01:21, kernel test robot wrote: >>> tree: >>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >>> master >>> head:   e47eb90a0a9ae20b82635b9b99a8d0979b757ad8 >>> commit: 822a6200734c94ccbfc9ae7acc5da5505b991515 [2262/4736] extcon: >>> usbc-tusb320: Add USB TYPE-C support >>> config: x86_64-randconfig-a003 >>> (https://download.01.org/0day-ci/archive/20220903/202209030755.eB4SkwGE-lkp@intel.com/config) >>> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project >>> f28c006a5895fc0e329fe15fead81e37457cb1d1) >>> reproduce (this is a W=1 build): >>>          wget >>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>>          chmod +x ~/bin/make.cross >>>          # >>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=822a6200734c94ccbfc9ae7acc5da5505b991515 >>>          git remote add linux-next >>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >>>          git fetch --no-tags linux-next master >>>          git checkout 822a6200734c94ccbfc9ae7acc5da5505b991515 >>>          # save the config file >>>          mkdir build_dir && cp config build_dir/.config >>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross >>> W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/extcon/ >>> >>> If you fix the issue, kindly add following tag where applicable >>> Reported-by: kernel test robot >>> >>> All warnings (new ones prefixed by >>): >>> >>>>> drivers/extcon/extcon-usbc-tusb320.c:19: warning: expecting >>>>> prototype for drivers/extcon/extcon-tusb320.c(). Prototype was for >>>>> TUSB320_REG8() instead >>> >>> >>> vim +19 drivers/extcon/extcon-usbc-tusb320.c >>> >>>      18 >>>    > 19    #define TUSB320_REG8                0x8 >>>      20    #define TUSB320_REG8_CURRENT_MODE_ADVERTISE    GENMASK(7, 6) >>>      21    #define TUSB320_REG8_CURRENT_MODE_ADVERTISE_USB    0x0 >>>      22    #define TUSB320_REG8_CURRENT_MODE_ADVERTISE_15A    0x1 >>>      23    #define TUSB320_REG8_CURRENT_MODE_ADVERTISE_30A    0x2 >>>      24    #define TUSB320_REG8_CURRENT_MODE_DETECT    GENMASK(5, 4) >>>      25    #define TUSB320_REG8_CURRENT_MODE_DETECT_DEF    0x0 >>>      26    #define TUSB320_REG8_CURRENT_MODE_DETECT_MED    0x1 >>>      27    #define TUSB320_REG8_CURRENT_MODE_DETECT_ACC    0x2 >>>      28    #define TUSB320_REG8_CURRENT_MODE_DETECT_HI    0x3 >>>      29    #define TUSB320_REG8_ACCESSORY_CONNECTED    GENMASK(3, 2) >>>      30    #define TUSB320_REG8_ACCESSORY_CONNECTED_NONE    0x0 >>>      31    #define TUSB320_REG8_ACCESSORY_CONNECTED_AUDIO    0x4 >>>      32    #define TUSB320_REG8_ACCESSORY_CONNECTED_ACC    0x5 >>>      33    #define TUSB320_REG8_ACCESSORY_CONNECTED_DEBUG    0x6 >>>      34    #define TUSB320_REG8_ACTIVE_CABLE_DETECTION    BIT(0) >>>      35 >> >> I still believe this is a false positive, is it not ? > > Hi Marek, > > Thanks for your reply, the issue is not introduced by this commit, it > should be related to '/**' in the head of this file: > > diff --git a/drivers/extcon/extcon-usbc-tusb320.c > b/drivers/extcon/extcon-usbc-tusb320.c > index edb8c3f997c9..41041ff0fadb 100644 > --- a/drivers/extcon/extcon-usbc-tusb320.c > +++ b/drivers/extcon/extcon-usbc-tusb320.c > @@ -1,5 +1,5 @@ >  // SPDX-License-Identifier: GPL-2.0 > -/** > +/* >   * drivers/extcon/extcon-tusb320.c - TUSB320 extcon driver >   * >   * Copyright (C) 2020 National Instruments Corporation Uh, OK, I wouldn't have thought of that based on the output above. The change above is obviously correct, can you submit a patch ? Thanks !