From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86683C54E5D for ; Mon, 18 Mar 2024 10:54:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2FCC6B0088; Mon, 18 Mar 2024 06:54:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE06D6B0089; Mon, 18 Mar 2024 06:54:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCFDE6B008A; Mon, 18 Mar 2024 06:54:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B8CC26B0088 for ; Mon, 18 Mar 2024 06:54:43 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 81041160E6E for ; Mon, 18 Mar 2024 10:54:43 +0000 (UTC) X-FDA: 81909851646.22.BBCB0E0 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf27.hostedemail.com (Postfix) with ESMTP id 240CE40019 for ; Mon, 18 Mar 2024 10:54:40 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of tujinjiang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=tujinjiang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710759281; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+VQ/cN37QlLt0ZYor7Ku0GzDnUWxx6GE+vnmFrv22rU=; b=yX3p+n9iAAzPPMqv8w8IZLs5qcwZLBi9iwYLm437/tCkFftfPWDP2MqTJUgGTu/IoxNL8n oahaco08ZhagB4E7aQyQsPMcC6SvkRs95TPBu0WFMF5APlkyfU4cVC3QmmZfy2GQvhrHjN rUsE0y6azEba2iRP4sDrHy2/M72XvPg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of tujinjiang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=tujinjiang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710759281; a=rsa-sha256; cv=none; b=5osSI61DSzN48M9ASHlsGl759+sdRWDux9MbTbRrj9GeC+ixVH3tYvfWFG5HiIlEtioKN5 aXUoP1uBITIfrFdfdOhZ/3YY6bbcucsdhMDJCY5xd3KZzJwk0YXQzRItmw2YEzLTgaEQHr psTds8ubQs4ZQCcRaFp+mcYcMdpiv4s= Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4TysCx2XBxzbdDH; Mon, 18 Mar 2024 18:53:49 +0800 (CST) Received: from dggpeml500011.china.huawei.com (unknown [7.185.36.84]) by mail.maildlp.com (Postfix) with ESMTPS id 29D05140259; Mon, 18 Mar 2024 18:54:37 +0800 (CST) Received: from [10.174.179.13] (10.174.179.13) by dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 18 Mar 2024 18:54:36 +0800 Message-ID: <7f5ef5da-b4b2-b49c-fb9f-1abcdd2e95da@huawei.com> Date: Mon, 18 Mar 2024 18:54:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v3] mm/ksm: fix ksm exec support for prctl To: David Hildenbrand , , , , , , , References: <20240318090441.179486-1-tujinjiang@huawei.com> <522cd833-c09e-49d8-a79a-6811cf5f9abd@redhat.com> From: Jinjiang Tu In-Reply-To: <522cd833-c09e-49d8-a79a-6811cf5f9abd@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.13] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500011.china.huawei.com (7.185.36.84) X-Rspamd-Queue-Id: 240CE40019 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: wo7grepsoa4pq8zdqofq1nfipw9jnopw X-HE-Tag: 1710759280-114666 X-HE-Meta: U2FsdGVkX1896Qji/PxQq6WAsx90ONEAJXimITWoXch/0BAwKX0jjOmof0fKL5B5ebue7m5r1JZAIUK4w+C7ALx74iT0wEqsKHOYSpYPGqBsjLDPJtynT17GJga8isC1gfGR32yuY8NVMF+EGD/m/EmOuwFkglAB9G4g5QB5UHyrHpjNVO9fNku/1Vtz7DKxGNv1GJlglWi9JLl3jHxCVI2ejFwtiJ6p33LRo1MS6gL+SA7HHg652n7rET1Ku3C2/BqCeVI4uB0jJxGoQKx7YseaBwuvS33642jN36B/pakxnpaciZQG6m9Qs9Ahhd3P9MGoJhIFL1h0kaJwSSjlMlZlihATAjnsiSGhRc3LwIlG+ydDhVutS4r4Zc5JeUJ4hSBD8XnK4z2K0ak4GbaLX8wIxuG8SrYSKO8xfi9g6PpsyK/19fapK3DBjoEyKszeX4QZog+q7W6366ZGI/pRChiWYMrBDJ92A3dqUdjzj3NemtSiJ/SQyTN29wI6y69bTVr5Bt5IAyxef3eBCqHxD7nQJWoHRE8mtY/uUH0KO0cciSGPPu0WRvGOoa6WofvJaGKH6h61jt7UonOzupp3LRnSIeRe6KJLLSrZfSG1Q2wEE0zwZh0c11jLRXrfqnMaMc8vWtbF7wFThuCT+TiLKkmwvkjPasxzE5IXowrIvqF+SIB6VjiY21x23CRzIAYbi5sdKXqI9McR7VUPy+uCflZblw5moJJVVA1qdU8PHpzvpFUqvhin9cZJ3RULvtMXKRmiNO+bgaKMpzWnYRRsOIFBeAQ7XLkq/VmZQdBpHjxr+QaW5GbxyiidK15uS9LCiLkPBgo63/E3r22KMS1JqbSUCzSfKgO1vArk+QJSAb1LE3XrYq4RWw9341MnZlv3Icvm+NhucFZxyM4C41zmb55z1LgEBLhathd8KTpyD2oVhRfn91ASIW4t/BXTXtLgDQkdtMMgPMryyAnMAmY tMcGEjxd BdbzoC7wHRBSCgXFVCvw9oS/vCL8i7wSQPh93rX8ZzSZkiT5ItUQOddSH0jiREddn7EIXZHYt41gwGXF/niwIhFiVa6JhWqH03deMu6o9uyEm12OAgjmWIrbO905kVqFwiwF95SY624VDXQ3zLBZyGtKHaKLQLYdBloTGNRmDTPeLcaDQ7VcIKgQh3A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/3/18 17:59, David Hildenbrand 写道: > On 18.03.24 10:04, Jinjiang Tu wrote: >> commit 3c6f33b7273a ("mm/ksm: support fork/exec for prctl") inherits >> MMF_VM_MERGE_ANY flag when a task calls execve(). Howerver, it doesn't >> create the mm_slot, so ksmd will not try to scan this task. >> >> To fix it, allocate and add the mm_slot to ksm_mm_head in >> __bprm_mm_init() >> when the mm has MMF_VM_MERGE_ANY flag. >> >> Fixes: 3c6f33b7273a ("mm/ksm: support fork/exec for prctl") >> Signed-off-by: Jinjiang Tu >> --- > > Can we also please extend the KSM selftest? > tools/testing/selftests/mm/ksm_functional_tests.c > > We do have test_prctl_fork_exec(), but in ksm_fork_exec_child() we > only test if the flag is set, not if de-duplication using the ksm > daemon actually works. > OK, I will try to extend the selftest.