From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8637E77188 for ; Fri, 20 Dec 2024 14:28:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 480BC6B008C; Fri, 20 Dec 2024 09:28:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 409446B0092; Fri, 20 Dec 2024 09:28:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D3636B0093; Fri, 20 Dec 2024 09:28:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0EBCB6B008C for ; Fri, 20 Dec 2024 09:28:47 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B9B80160A3A for ; Fri, 20 Dec 2024 14:28:46 +0000 (UTC) X-FDA: 82915567266.27.3DDF9DF Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf12.hostedemail.com (Postfix) with ESMTP id 0D4744000E for ; Fri, 20 Dec 2024 14:28:29 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734704901; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NoZP/C74YL+gAOuTVINVRjr/kSwdZlwelqBG4tRegrQ=; b=1VLIJhQjABl8OvRgJIgxjwZ6SIYjPRxTCTBSyN3VYwta8bXTTpeQ51KRrMJ+MrqpVkMm0A FDbKBsvt2CTxjQDz2mJzyRZWSC7sITsmQjTix3H9Q1ZnGHqz6+ogTMmPn/45eWCCHauQof gfVmi0r8Yv1rejkcKJIFJtThu6INNRs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734704901; a=rsa-sha256; cv=none; b=7+3GXwarVu1uQ4+6FKUAq1QJ5xeOBuzGq0eeg6SWVvZfTeCHwPa2G1pm7LI6xF0GiqlVbH 6Yja/GqDkVX/N5D/Qxtqx2pkR6u9h/oq+Nl+FPryF8Ea7LIIAmWLTEM5nhoKBcjc8tg9Bu PD1iSOMnKFjS4/RzYtXP272cXIzVyFk= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 59F5F1480; Fri, 20 Dec 2024 06:29:12 -0800 (PST) Received: from [10.57.72.191] (unknown [10.57.72.191]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6FAEB3F720; Fri, 20 Dec 2024 06:28:38 -0800 (PST) Message-ID: <7f5e6ac7-01ef-46c8-bc85-7f8399dadb19@arm.com> Date: Fri, 20 Dec 2024 15:28:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/10] mm: Move common parts of pagetable_*_[cd]tor to helpers To: Qi Zheng Cc: Peter Zijlstra , linux-mm@kvack.org, Andrew Morton , Catalin Marinas , Dave Hansen , Linus Walleij , Andy Lutomirski , "Mike Rapoport (IBM)" , Ryan Roberts , Thomas Gleixner , Will Deacon , Matthew Wilcox , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, loongarch@lists.linux.dev, x86@kernel.org, Alexander Gordeev References: <20241219164425.2277022-1-kevin.brodsky@arm.com> <20241219164425.2277022-2-kevin.brodsky@arm.com> <20241219171920.GB26279@noisy.programming.kicks-ass.net> <75cb4ff8-eb0c-4519-a30a-f8be717ba278@arm.com> <0daabd32-cba4-4345-baa8-e8c66bc899ff@bytedance.com> <2f65f93e-9d44-4acc-b63c-8f5a35f59699@arm.com> <33ce9b58-4787-49cd-a7f2-34272cb3ecf7@bytedance.com> Content-Language: en-GB From: Kevin Brodsky In-Reply-To: <33ce9b58-4787-49cd-a7f2-34272cb3ecf7@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Stat-Signature: briztsai94bhfn563yxdjmmwqezigenz X-Rspamd-Queue-Id: 0D4744000E X-Rspam-User: X-HE-Tag: 1734704909-817003 X-HE-Meta: U2FsdGVkX18Djp/wlymz/eO2WoqQAj6Nra9y5unebOcxllTM3+ZjIKQrlkpTBkQact/6VlXhU5GgPGJt4i37o5WlZni7iaWYjs9YZxjWu46UiyZamgxCNuygo+Ly4h0T/gWbV79GNIfFxbKh150eF5McQdI+9niNUJ50UXPwQhdyk5AEY6rBuMiPLoNXmfJcXufZzyTHEXlD7FPwsrfNBcPomDEqqqKNaUYGb10VLE8SjwN/Aj/w1ezWmMKnGmsW9z4c3VZwWFXd7myKUChwMD2zlIns2dNniX8ZOBHmzbkBvcps8KJRXoHS5GKhP6HfBDEvAj5jsPxvqwZHGXVQ1vyCGtmF41J2wscNK0Foas1Ji9HZeF/KemeSx5HRcwBEMUsFFIP3wABZgoRyYMd/Q63WOqZ6QGHfszlHEq5SWad8V2iEsE/tVCOayc1bj9PWUY4alDZ+IUHa9z0k18jcSQWo+Sh3r5hW/0oNBMYSZ58dLs4sSETaNUPaYE/y8ziAOO2jbsAFJKX71d2Hvi14SOHJxImFZlFRty301Cnw7Vkr42REjTvmFWaSXuWWqsn+noM8jNKsJ2Iuz3H8wxW80X2/tqAff+PujJlNlleB4YBXeJDEojXXkOaox63Bxdx6H6Mk8doaEi3TwVbJ5RwhADaC3DHbgw1PBYlD+av7eK1HkjvPiBBw0akzsDMtOCqXuQpxv7ENNpbS4Lw2rL/MMY8p1BqI4IB36oTm2qUfrWlB82qyuIBdhVOJJ5hbl4LrfrGccqNRO4+czQbSv1eLn5l/3l+BblIWIjLSeOgOz2+o1i2++MjOVkJQFwD4JhBKFvkqzNSCFs8rBbIbep4Wv5W93eGN17I9WLB9jWLiCVdAKOCup6jevfZ1WyPqQk8OLz75wmmVNGaHuRVSlo2gvd8ejNTaK3d48CE5lmhGGGFZBCZblTpeu86/vpY2BnUxazz9CMAZH8UZeMHJwj9 EUyLXYGq k/JwORZHfcqQTSQm/aG0FOowMxQdkDoGp/VGpx6a3A90Z4t1cHeIvAQHTILIvkZKBK1RQ0+Q0VagNvSDcZyOEHnNP4CA7P2QKllqzUQw+uy+v27zLvpFtJ2H6EngmYfQZfdjFgZljNV/DYiFgCrbfxGrnMDE8Wyb4ZpZtwMYE3ICSrCbKaBMnCLTiYNVBOvx9/WRdHGFs29XfKc52RjlSK6lykDY2DfzyfW1U+jgkWnCLDAaQ5jiPd+GNelcKqqA4wrf9wQcIPaFhES2Kf9As6rd1CeLwm/Y1YYLikAEDQQed0r/TH17mYICY30MZQadf+6Ac0KoM6Pyh4JIYNTBcR3uqpFXvm5mrbUBWc5fCyUBV7T8UZM3Img8104W3ivcMTw/C X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20/12/2024 15:16, Qi Zheng wrote: >>> >>> Did I miss something? >>> >>> My patch series is not only for cleanup, but also for fixes of >>> UAF issue [1], so is it possible to rebase your patch series onto >>> mine? I can post v3 ASAP. >> >> I see, yours should be merged first then. The issue is that yours would >> depend on some of the patches in mine, not the other way round. >> >> My suggestion would then be for you to take patch 5, 6 and 7 from my >> series, as they match Alexander's suggestions (and patch 5 is I think a >> useful simplification), and replace patch 2 in your series with those. I >> would then rebase my series on top and adapt it accordingly. Does that >> sound reasonable? > > Sounds good. But maybe just patch 5 and 6. Because I actually did > the work of your patch 7 in my patch 2 and 4. Yes that's fair! You'd have to do adapt my patch 7 to make it fit in your series so I agree it makes more sense this way. > > So, is it okay to do something like the following? > > 1. I separate the ctor()/dtor() part from my patch 2, and then replace >    the rest with your patch 6. > 2. take your patch 5 form your series Sounds good to me! IIUC Dave Hansen gave his Acked-by for the x86 part of patch 6 [1], would make sense to add it when you post your v3. > > If it's ok, I will post the v3 next Monday. ;) Perfect. I'm going offline tonight, when I come back in the new year I'll review your v3 series and post a new version of this one. Cheers, - Kevin [1] https://lore.kernel.org/linux-mm/a7398426-56d1-40b4-a1c9-40ae8c8a4b4b@intel.com/