From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE33FCAC599 for ; Wed, 17 Sep 2025 15:19:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EACB88E0036; Wed, 17 Sep 2025 11:19:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E84A48E0003; Wed, 17 Sep 2025 11:19:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D73D48E0036; Wed, 17 Sep 2025 11:19:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C026B8E0003 for ; Wed, 17 Sep 2025 11:19:01 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 71DD0C05B3 for ; Wed, 17 Sep 2025 15:19:01 +0000 (UTC) X-FDA: 83899100082.17.18EA775 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 1916840002 for ; Wed, 17 Sep 2025 15:18:58 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WfX4KE76; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1758122339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Hy7kdzIRoahwzaXq+ZGvnPXEqK5VVBRIst3tKW3Ibxs=; b=4+t5MdQgAg6EeEobEDIW/Ffx0AtEgfqZRymhmeEtLfZajeq7veN6qd4FFhwAhvAQSUqJnl WJUaBgy2FjEiPdTi5EYh/M4ZPm1k3ZtJyBiaSN7QnIFEgyTi+ZNqnAud34/XTsCXhwxlEM jEun7qjDxqeM/W62HCTUUUDnKTG0mFo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WfX4KE76; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1758122339; a=rsa-sha256; cv=none; b=jJKDp9V8dIEDsnJTiz4fXwqXCz0AYf42u4eoKB5aNk98JfD4iOiRgP0s1/SQu3I3e3LsWs ekbi4YT1smVjboUCgPQL5ZWvpOAUkkzqSvhuLw3h8Dj5DElejuhWdjeqLZhzEgreeMxxvK AN9f9xsMj5DrmncfRlvGv/p+thxqPDE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758122338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Hy7kdzIRoahwzaXq+ZGvnPXEqK5VVBRIst3tKW3Ibxs=; b=WfX4KE76zKuM5i2NUQrJiTpMmqfGB0/QRkGZ4jAveYCTh7XhIk+ebvPO3zcPefYIMjbdFs IeP4Ra/1FZQ+7NFOPGJf4/dZYsWK2T478PrT0WUOkU5z5xkKjsGJO4UCEDQ/A8uaj107Fo KauyGMtfNLr9y2s9HyRPl7PtKXqQXIU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-122-OjZ1QRTKPmWiPp54CRkBTA-1; Wed, 17 Sep 2025 11:18:57 -0400 X-MC-Unique: OjZ1QRTKPmWiPp54CRkBTA-1 X-Mimecast-MFC-AGG-ID: OjZ1QRTKPmWiPp54CRkBTA_1758122336 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-45e05ff0b36so5010655e9.0 for ; Wed, 17 Sep 2025 08:18:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758122336; x=1758727136; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Hy7kdzIRoahwzaXq+ZGvnPXEqK5VVBRIst3tKW3Ibxs=; b=F6wlI8q9yS/Gn8ONEJGwy05Qna9OjcBb91Larli7HXTI3uYVcV4Sqt2WzGkh3Gm8so u6FQLVZsNtryq70iLHG36LRSa8NWxPRDZ2/fB+qj8ECmCaI6mIzf9f/IT0apZzoYgist 6iPFNF+6eE+k3x3B6NGDAtmT9Ic2TrSr9c3DyMkIgIO5z9THHuNEH4l2HTuR+/acfrjN J91l8pWSHCH5SwMynVTMFxi0yocgqtiZvM8t/CYub6Gq6KcZOL9pQYN7HbqYr8PY9xGg p/VOjr5AygKFCbKIyGkSh7+LNd7KhKlE0ZzMpZT7vm7yoPc4MfQHMYLK6aphmAw9lgLT fP3g== X-Forwarded-Encrypted: i=1; AJvYcCXeMGwVXjduTwZ9w3noEPpfOis8bi+x4UZYQeow0P4mkZOtMdUtvqTcoqiLGZuHndP9ukOz8zVVKg==@kvack.org X-Gm-Message-State: AOJu0Yy+4+F1N1xcXefy2vecEkaZzhqd3CRQVCsLL94GyLa4UejzFALe K67XN52r+M3LJrK3is0Q3KCT3Nt8Oj5pgG1qYhoeNV8F9O3XX7iPE1S971JbOU4I6A99pakv+Rh M+G8MVcTfAjWre3A8Z/KywqKvZBkPGta2lN6MA578myaDE5H2uG4e X-Gm-Gg: ASbGnctD18yAH5Zfums9TZ8nlCoJpAPLXho8pzPGENOQExW9CEpjc5tY0muJohf7wgK b8OrcvYflJJQNtu5wHXW70Lz/RYt0ANPANybwvZBDa6KHUKXoTzrEOpN0Eh67zY7yjWdQZ72Lp0 0ZbYUpMlWZ0RTUYVqT0KyrqEwnGDGwcpvdfarsIFFRnHhrlJJeVFE46sp2Xt/MU6W5Auc3H1Sx4 eT9CV7LTq1fZMgoIdZMt+oM7ZcpCNM/0fl2GAKIea7s6cP6wAovdmTxkcjLDg8VSfFv9pVqyuo9 glCwm33X9iGxSNNOsbEuvnevmv8TBSv+Vf4qw1sNb8nmH+G7IlXl7XL+JsGDDkPcDE9ly0NI5Qq Tj5lGNZD0RkBSwzCXwUqYorE6Z9J10f4IYiDbHNn1bFNubxWtA5Y5vXyNL7MMP4dU X-Received: by 2002:a05:600c:c0c2:b0:45d:e201:1603 with SMTP id 5b1f17b1804b1-45ffbb87d0fmr44805875e9.15.1758122335840; Wed, 17 Sep 2025 08:18:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGZJXZpzuRjgrByrwR+JkhhVX9lJLsNt0iPyJ6yeH+tCAOWNZvmbwXLVLzskDHw5XXeFtjkaQ== X-Received: by 2002:a05:600c:c0c2:b0:45d:e201:1603 with SMTP id 5b1f17b1804b1-45ffbb87d0fmr44805575e9.15.1758122335350; Wed, 17 Sep 2025 08:18:55 -0700 (PDT) Received: from ?IPV6:2003:d8:2f27:6d00:7b96:afc9:83d0:5bd? (p200300d82f276d007b96afc983d005bd.dip0.t-ipconnect.de. [2003:d8:2f27:6d00:7b96:afc9:83d0:5bd]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45f3211e8c7sm40537455e9.3.2025.09.17.08.18.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Sep 2025 08:18:52 -0700 (PDT) Message-ID: <7f4aa4c6-7b77-422b-9f7a-d01530c54bff@redhat.com> Date: Wed, 17 Sep 2025 17:18:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC][PATCH v3 09/16] genirq/irqdesc: Have nr_irqs as non-static To: Eugen Hristev , Thomas Gleixner , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, andersson@kernel.org, pmladek@suse.com, rdunlap@infradead.org, corbet@lwn.net, mhocko@suse.com Cc: tudor.ambarus@linaro.org, mukesh.ojha@oss.qualcomm.com, linux-arm-kernel@lists.infradead.org, linux-hardening@vger.kernel.org, jonechou@google.com, rostedt@goodmis.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org References: <20250912150855.2901211-1-eugen.hristev@linaro.org> <20250912150855.2901211-10-eugen.hristev@linaro.org> <87cy7q9k8y.ffs@tglx> <87a52u9jyl.ffs@tglx> <8df2cf28-c15e-4692-a127-6a5c966a965e@linaro.org> <2bd45749-e483-45ea-9c55-74c5ba15b012@redhat.com> <87v7lh891c.ffs@tglx> <95ff36c2-284a-46ba-984b-a3286402ebf8@redhat.com> <24d6a51d-f5f8-44d7-94cb-58b71ebf473a@linaro.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <24d6a51d-f5f8-44d7-94cb-58b71ebf473a@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: L1ey1QlUVSw6p-f58OPjNtTN0l6FoAqFLt0avPWsQds_1758122336 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1916840002 X-Stat-Signature: kwo67cpmma1xxwbdb1x9ocwdcpzufdua X-HE-Tag: 1758122338-280305 X-HE-Meta: U2FsdGVkX19Y0ceytguYB9+OfeBVJZs7MbxJlwo0vhyGpU/s3Kj0fAtngWLxcKR+cHt1BsA7LlGLGj/phVNWUILC+8gcD4Cd3AHrVJC0YDRI5/KHeDkO0cNeeMhU1TMafUdYhZIUJ64rGyJJTBARjO8nXO+qt/oVho+n3MVM9noap6HMH6Sh/700yZqE9Ov7Lmpz7Kh1mTsgUmtklZo+UG70nKe4Ffvy+VJDOBUHpnWLBin11nO9lJJeWI7zJB5soVbW5e3RhkijQVy9slHDIykUxrsQHFnJ5Zj0+4uf6TrDaxhSkDq553CCLOfeCbN2cmikZfxSd0dmnO9LdU9VBEpJ+v7M1nd+Jd0jYJajAWH9YGZ+yUJTTffirdc4RY0lqbYF65srjzduPlEIHKCiXrAsv7rT4NqfKKtgcBgUYVBNwhpFe8+htmbdO9jA4wrVAhpfXFQvHRehWq2QGpgLQg9KW7itKdGueJ4rnCf/fzNjA3/dy/H60AxmDUyICXzet6YKn2T+67LpyUCnDveD1Z7yEw0bgO77xJlim2mZWYcRFqyEMhdeyHOmbmt/UOYqWnbXbp40bYJ/Zu9gHYUntLKjjYqU6Bh3BA+uGu8hz4r/rH8/rYm1tX3Onxw40xuTWaADqhmuNSDGgo6C7MC/4h8bFsirbb1pjBHwlvWT8Gc5tVBJ87/N9Xw6A2Ki5gmFez68N4yl4VFMZjM3H1ixVpSJESfOFmOqoUw4MeZi1b55R1tfvSAzNBFrUlF9v7Zo9QE5UOjKC6RoKzWzbjhveW34PDmJ9vW+gRGl3W1F/evDSsadBlGzh4OhP3hhCLeewC6nZSQ80kCoSRi4AbSAuymX3ylZTyA6/MV2F6xN9byfWvqUHcuqoyKsgr0QLep4pBfZaXXWxln9UZjYNfnu79Fm7VtC/NWa+7ytsL8BCYQN+hZOZcfzOr4OW0Hpyu4sPs9zKE08OVQ+blIyER+ CC+6KehZ ZTe8HJsF2tO3DXrBqDmo68QpFPPWsylp4jYXEmNICunJSwP2Bc2HHWvonPF6m/hHeCxzp/td8lwCxbcClT597nbo8ckeb0yGnHB7dNVs9/WBHw/YSNfB4TNVQIZ0EOYbNtwF7vkoNBzeALg7bhR34SGiRPe8e3fx51rBPe2YRlYCzs/MLd6jP4zAavzpO+bE9lbPEdkLQGcDC2DZEiVaJ51dgJZSejyaEc6cO4QqpOt62f6gCMMBqjJWWov6XxOaSzscs9dwJCYBisKHmZDTZg4ATza1quQ+XH9KVhj+ntB3rq8vErCD1TIt+VUF1Te03DcvTUD8VijzW3XJT3YbnOwCKnZtxh574YHksAlbljAkjOEkEfe9be0yNnuJcT6vIu5YT4fm6DMcfc/X8EhszKph4hnyE2mSB+h3VLdQSESI0yNwIBuenq6lDVeaJW9eb8ly8wCQDHFK13mAHWUgH/Q4sOKDj+FytVN0m X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.09.25 17:02, Eugen Hristev wrote: > > > On 9/17/25 17:46, David Hildenbrand wrote: >> On 17.09.25 16:10, Thomas Gleixner wrote: >>> On Wed, Sep 17 2025 at 09:16, David Hildenbrand wrote: >>>> On 17.09.25 07:43, Eugen Hristev wrote: >>>>> On 9/17/25 00:16, Thomas Gleixner wrote: >>>>>> I pointed you to a solution for that and just because David does not >>>>>> like it means that it's acceptable to fiddle in subsystems and expose >>>>>> their carefully localized variables. >>>> >>>> It would have been great if we could have had that discussion in the >>>> previous thread. >>> >>> Sorry. I was busy with other stuff and did not pay attention to that >>> discussion. >> >> I understand, I'm busy with too much stuff such that sometimes it might >> be good to interrupt me earlier: "David, nooo, you're all wrong" >> >>> >>>> Some other subsystem wants to have access to this information. I agree >>>> that exposing these variables as r/w globally is not ideal. >>> >>> It's a nono in this case. We had bugs (long ago) where people fiddled >>> with this stuff (I assume accidentally for my mental sanity sake) and >>> caused really nasty to debug issues. C is a horrible language to >>> encapsulate stuff properly as we all know. >> >> Yeah, there is this ACCESS_PRIVATE stuff but it only works with structs >> and relies on sparse IIRC. >> >>> >>>> I raised the alternative of exposing areas or other information through >>>> simple helper functions that kmemdump can just use to compose whatever >>>> it needs to compose. >>>> >>>> Do we really need that .section thingy? >>> >>> The section thing is simple and straight forward as it just puts the >>> annotated stuff into the section along with size and id and I definitely >>> find that more palatable, than sprinkling random functions all over the >>> place to register stuff. >>> >>> Sure, you can achieve the same thing with an accessor function. In case >>> of nr_irqs there is already one: irq_get_nr_irqs(), but for places which >> >> Right, the challenge really is that we want the memory range covered by >> that address, otherwise it would be easy. >> >>> do not expose the information already for real functional reasons adding >>> such helpers just for this coredump muck is really worse than having a >>> clearly descriptive and obvious annotation which results in the section >>> build. >> >> Yeah, I'm mostly unhappy about the "#include " stuff. >> >> Guess it would all feel less "kmemdump" specific if we would just have a >> generic way to tag/describe certain physical memory areas and kmemdump >> would simply make use of that. > > The idea was to make "kmemdump" exactly this generic way to tag/describe > the memory. That's probably where I got lost, after reading the cover letter assuming that this is primarily to program kmemdump backends, which I understood to just special hw/firmware areas, whereby kinfo acts as a filter. > If we would call it differently , simply dump , would it be better ? > e.g. include linux/dump.h > and then DUMP(var, size) ? > > could we call it maybe MARK ? or TAG ? > TAG_MEM(area, size) I'm wondering whether there could be any other user for this kind of information. Like R/O access in a debug kernel to these areas, exporting the ranges/names + easy read access to content through debugfs or something. Guess that partially falls under the "dump" category. Including that information in a vmcore info would probably allow to quickly extract some information even without the debug symbols around (I run into that every now and then). > > this would go to a separate section called .tagged_memory. > Maybe just "tagged_memory.h" or sth. like that? I'm bad at naming, so I would let others make better suggestions. > Then anyone can walk through the section and collect the data. > > I am just coming up with ideas here. > Could it be even part of mm.h instead of having a new header perhaps ? > Then we won't need to include one more. I don't really have something against a new include, just not one that sounded like a very specific subsystem, not something more generic. -- Cheers David / dhildenb