From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C76CC6FD1F for ; Tue, 14 Mar 2023 16:31:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D9498E0001; Tue, 14 Mar 2023 12:31:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78A5B6B0074; Tue, 14 Mar 2023 12:31:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 650CF8E0002; Tue, 14 Mar 2023 12:31:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 53D5B8E0001 for ; Tue, 14 Mar 2023 12:31:29 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 21D751A1070 for ; Tue, 14 Mar 2023 16:31:29 +0000 (UTC) X-FDA: 80568044298.09.FEBDB2F Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf16.hostedemail.com (Postfix) with ESMTP id 3185C18002A for ; Tue, 14 Mar 2023 16:31:26 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FtmIms2Q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of f.fainelli@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=f.fainelli@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678811487; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DEz24v95b0i34MGAg5Fg9f+XM78CDT3tIsiees5jA8c=; b=GA7PbEoZfnLC4YBrsg2zpTzSvRdbJGIoDIhZCsQwaYNnK5ySv3sOnPuXHhjGZSmM3haqf2 4bfCWk0G2uY4xYa1O8MRCHc1jKKe63enGnf7gpZ792u/PwLgglscoPOWYd+25yxkyXn3nz nAYo3mwcgd28F/zwG3ujC1uPwjCwjmI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FtmIms2Q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of f.fainelli@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=f.fainelli@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678811487; a=rsa-sha256; cv=none; b=2Ka07YIy3CVcg/rdxNeMXVa2tcHxJm8LcKQUXP+c7wZ2VwNHCJCCy4s58b/172GH2G3EjO bwgQ5fszgqB+J2OwkXtHNEHHPr3mRSZTNXLwdXF8YTNuGHtkhUHpRt0bX+wL1B/Gw7jESf qeYRWMnvEmKbRKpevG66dlFIBE/Y2c4= Received: by mail-pj1-f45.google.com with SMTP id j13so212638pjd.1 for ; Tue, 14 Mar 2023 09:31:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678811486; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DEz24v95b0i34MGAg5Fg9f+XM78CDT3tIsiees5jA8c=; b=FtmIms2QxlCvzfuSI9XKKtM0r+aRAAPlD6p8eFrg/abi1XoWcBYo32u1/HXHTQFPly AeXuXleO7ZQCfwTtilrtyquOpAbReyhJgidtmq4VEYmDle4/HUozYgnU+P4MXGAcEeqO ztH9HWI8berKE2iJt3MWXHvK85+I1xC7wRE1IaG5xbmtn+FpLxOHclIF2masPdSUGrdk UAjYwnwUozzgiPVi1piQBp/JEF0d1swB95thc0zYlor3lH1KoTYhBkMdQGCQ9Zef6th1 pTyROFbcqpNmte43uoPx7kJ9Ubm5zDHRBUtQmuYz9A+41XcyADTANA5x9VEvP+Fbl7yN QEiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678811486; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DEz24v95b0i34MGAg5Fg9f+XM78CDT3tIsiees5jA8c=; b=3GxE6VVQw/8cW+wjNjEh/3eoOPhMiPtI7GDV1fKNWKqgxtuY/TLylHKH2BovkOPWN0 GUTXqr7IyogpQrpAlBgHnXI6kCo8aOEDbyOeD5qNPKbry1pm7Ib9q5LhuqBEPdv6ujVp ER05w1wgFKE2XowebAEhGH7BVbDDDdX+lWNTVJP57lvKKiCIcQL3jaDQ8V6jgXnLz2c+ 3rYRvppsGS3+s50Z/OS0YdwCkkUNz62GrnkL317ezVdALCLdhDZD5aXso+4CEkBEKqP1 KY0NMEoThjzMIAJCWhyFx4m9AP6yT6rqioofiJMufDje+2ErBrHP4P3bEtn77wSMJ0Fl mfeg== X-Gm-Message-State: AO0yUKVkpG21qv0REUIYw+PoggPR8CNojRKbuFjvxJMK7eyC1i06O6gz FJYavxcdwgaVSi8lcki2hG8= X-Google-Smtp-Source: AK7set9tKnIoDzlI2PwH4ckA3AVJLIIUOHtwt4iLtNKPBoejQTCa81hLcA/vzkkWYXAYm7adoxZgDA== X-Received: by 2002:a17:90b:4a12:b0:23d:7ae:6467 with SMTP id kk18-20020a17090b4a1200b0023d07ae6467mr7198889pjb.11.1678811485889; Tue, 14 Mar 2023 09:31:25 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id c1-20020a17090a490100b00233ccd04a15sm1922617pjh.24.2023.03.14.09.31.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Mar 2023 09:31:24 -0700 (PDT) Message-ID: <7f39daad-05b0-46f8-bc89-185b336d8fd4@gmail.com> Date: Tue, 14 Mar 2023 09:31:21 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v4 2/4] mips: add including Content-Language: en-US To: Thomas Bogendoerfer , Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, mpe@ellerman.id.au, geert@linux-m68k.org, mcgrof@kernel.org, hch@infradead.org, Helge Deller , Serge Semin , Huacai Chen , Jiaxun Yang , linux-mips@vger.kernel.org References: <20230308130710.368085-1-bhe@redhat.com> <20230308130710.368085-3-bhe@redhat.com> <20230313175521.GA14404@alpha.franken.de> <20230314153421.GA13322@alpha.franken.de> From: Florian Fainelli In-Reply-To: <20230314153421.GA13322@alpha.franken.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 3185C18002A X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: ghu48dci18iybaia1wpn7i71zcedbudy X-HE-Tag: 1678811486-971011 X-HE-Meta: U2FsdGVkX1+bLiYEgDObecD8gPNwJYy9Cn+VcPj8eeHTBLFm+SG1zRz9dVA+dsZ2wfDchTPMOEhhux2xz2MwIRmT9h827avs3xjvpEDK4mB4IAuF+Dp4WLyfBQYBa/2I6IxHxp9gPUUdm7sFOLON9ElnSmAACjqy7d0x6rHrZ+UiKcCw0BPSgKY5vzFYRQ1ASVhknWpGL+XY5hCxrJpY2nEqe+CCV9QAIZTuvnqHCAP991Y5QR022Cxkydibq2l4CxqtXrRspAsJyrTlsnKwKC3O4tCgczndR7Fm3H8Dg/or5W6tK2sIu+Kw1N+DktGeCOmUlAWntqtqihh2okE5Fp5gpnvVTNtpNN9PfQg+PRoqoDKHdd+EbmYGg4B4ELKkM9wmLsi/xnFmUYewjXTfqrKbXEcShOzgQfoLjOIiI2W8w0dGnf9EV+d9FdM2KeGHGN9985Z3hN+8JAxv6FPD3OgPiBdBpAGlAy3lkssa9IhJzQbZRR3j61lvK3Bc+72Me15N8mMhynoHxfKo4mY3kgIZ2NJWupaWpiy5utz8Rz6t2clwsp/c5L/Z6GaExsdvHPy1tpYLQuF0q53R9X+k5RtmK9rMBQOBAGLaH3uuYjvO6Qydl60ffV3Hp5k6nQ1OeI7sq1YFmS+vxF+puZJoj21OQi2I48ciPgcDB7b3jQT8JOl6jAfBz63/3tTuIP1QesIwgin9bcJS7Zm0lyd+S0twrs4U2lsRTGLwuTUU3gEceG8p4pZFlTYkLas40G0GhAnZzy41lZ7rcUTHwiIZoEFjAoxXzRZvROBKzOUujPJWeT0TDbWJzDiknuk4TkaueA9rm+/GY3RyMMp6rpQxNoj2JZsizu/g7Ot+TCDCH8r1iJV0GJPBjlAhiT/vYm5z3IHLEjmZ0bnhN8gMEoWI94Q3SSrw4PG1/0aHToBV/nPAkfBBJLtW7IcBkdXH1SHZA77Vfmxex689NHxVMC2 6Q6VjJ8G WU/HtiWEnxprpuqw5ffB9n5fUp9nCapA7PUt6NGxz8OjKT1TRflYHC6egReQQJD3OC6MKw5/pu+phTq5RdmExX3j4HzMy9ysg6C4KwE3WPmYu3cxXppaNtwkbhGXKJDwcF/Bh0RmifMadxEjAaaQ43TVRN+W/fl6GuLyRxKRMGG43f7D4d3Zq8JClrOpe0MzNaE8nUgIAOReHDv0GpkFnCmzqqo3DhRwBHM6+x2kUv9GF2ari8ujuRyCDzrnyaAs9IQRxNUfGAqmjQo8fQiIkZFoKHBFHrz0bQGkm5BkvlEg8RDBihlxE4ZepIuWqtM5iJhMJmW6EozumgZZlGCDHFGvX4Ap4ks/aEW03r3+qu+OWSMY/AR2Tsr0uEEbVImFqFkRcDMgzOYLZFdHYk891TNUHTPYgAgiT1fONKmOhY0FAqfNBu/Ksk3WXd9lo1mP/RJVRDzAJFSxGVrSq+GCzC46Jwvj9/y9pfYc+5Qenon+95f14jgjNkN8hVXlnjpogm48rctjc+nqprdd8N5VmpuBh9/bBrt460AzL7IljPVz6V+g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/14/23 08:34, Thomas Bogendoerfer wrote: > On Tue, Mar 14, 2023 at 10:56:36AM +0800, Baoquan He wrote: >> On 03/13/23 at 06:55pm, Thomas Bogendoerfer wrote: >> ...... >>> /local/tbogendoerfer/korg/linux/include/linux/spinlock_api_smp.h:111:2: error: implicit declaration of function ‘LOCK_CONTENDED’ [-Werror=implicit-function-declaration] >>> LOCK_CONTENDED(lock, do_raw_spin_trylock, do_raw_spin_lock); >>> ^~~~~~~~~~~~~~ >>> GEN Makefile >>> Checking missing-syscalls for N32 >>> CALL /local/tbogendoerfer/korg/linux/scripts/checksyscalls.sh >>> Checking missing-syscalls for O32 >>> CALL /local/tbogendoerfer/korg/linux/scripts/checksyscalls.sh >>> CALL /local/tbogendoerfer/korg/linux/scripts/checksyscalls.sh >>> CC init/version.o >>> In file included from /local/tbogendoerfer/korg/linux/include/linux/spinlock.h:311:0, >>> from /local/tbogendoerfer/korg/linux/include/linux/vmalloc.h:5, >>> from /local/tbogendoerfer/korg/linux/include/asm-generic/io.h:994, >>> from /local/tbogendoerfer/korg/linux/arch/mips/include/asm/io.h:618, >>> from /local/tbogendoerfer/korg/linux/include/linux/io.h:13, >>> from /local/tbogendoerfer/korg/linux/arch/mips/include/asm/mips-cps.h:11, >>> from /local/tbogendoerfer/korg/linux/arch/mips/include/asm/smp-ops.h:16, >>> from /local/tbogendoerfer/korg/linux/arch/mips/include/asm/smp.h:21, >>> from /local/tbogendoerfer/korg/linux/include/linux/smp.h:113, >>> from /local/tbogendoerfer/korg/linux/include/linux/lockdep.h:14, >>> from /local/tbogendoerfer/korg/linux/include/linux/rcupdate.h:29, >>> from /local/tbogendoerfer/korg/linux/include/linux/rculist.h:11, >>> from /local/tbogendoerfer/korg/linux/include/linux/pid.h:5, >>> from /local/tbogendoerfer/korg/linux/include/linux/sched.h:14, >>> from /local/tbogendoerfer/korg/linux/include/linux/utsname.h:6, >>> from /local/tbogendoerfer/korg/linux/init/version.c:17: >>> /local/tbogendoerfer/korg/linux/include/linux/spinlock_api_smp.h: In function ‘__raw_spin_trylock’: >>> /local/tbogendoerfer/korg/linux/include/linux/spinlock_api_smp.h:90:3: error: implicit declaration of function ‘spin_acquire’ [-Werror=implicit-function-declaration] >>> spin_acquire(&lock->dep_map, 0, 1, _RET_IP_); >>> ^~~~~~~~~~~~ >>> /local/tbogendoerfer/korg/linux/include/linux/spinlock_api_smp.h:90:21: error: ‘raw_spinlock_t {aka struct raw_spinlock}’ has no member named ‘dep_map’ >>> spin_acquire(&lock->dep_map, 0, 1, _RET_IP_); >>> ^~ >>> /local/tbogendoerfer/korg/linux/include/linux/spinlock_api_smp.h: In function ‘__raw_spin_lock_irqsave’: >>> /local/tbogendoerfer/korg/linux/include/linux/spinlock_api_smp.h:110:20: error: ‘raw_spinlock_t {aka struct raw_spinlock}’ has no member named ‘dep_map’ >>> spin_acquire(&lock->dep_map, 0, 0, _RET_IP_); >>> ^~ >>> /local/tbogendoerfer/korg/linux/include/linux/spinlock_api_smp.h:111:2: error: implicit declaration of function ‘LOCK_CONTENDED’ [-Werror=implicit-function-declaration] >>> LOCK_CONTENDED(lock, do_raw_spin_trylock, do_raw_spin_lock); >>> ^~~~~~~~~~~~~~ >>> [...] >>> >>> I've cut the compiler output. Removing the asm-generic doesn't show this >>> problem, but so far I fail to see the reason... >> >> Thanks for trying this. >> >> Do you have the kernel config file, I can try to reproduce on my local >> machine. And by the way, it could be fixed with below patch, not very >> sure. Earlier, Arnd suggested this to fix a similar case. > > already tried it, but it doesn't fix the issue. I've attached the > config. I had attempted a similar approach before as Baoquan did, but met the same build issue as Thomas that was not immediately clear to me why it popped up. I would be curious to see how this can be resolved. -- Florian