From: Mark Brown <broonie@kernel.org>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
Cc: "debug@rivosinc.com" <debug@rivosinc.com>,
"Liam.Howlett@oracle.com" <Liam.Howlett@oracle.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"bp@alien8.de" <bp@alien8.de>,
"lorenzo.stoakes@oracle.com" <lorenzo.stoakes@oracle.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"x86@kernel.org" <x86@kernel.org>,
"vbabka@suse.cz" <vbabka@suse.cz>,
"arnd@arndb.de" <arnd@arndb.de>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Subject: Re: [PATCH RFC/RFT v2 2/2] kernel: converge common shadow stack flow agnostic to arch
Date: Fri, 1 Nov 2024 22:39:15 +0000 [thread overview]
Message-ID: <7f392b4e-9970-42d4-8204-2aa967a5375d@sirena.org.uk> (raw)
In-Reply-To: <7109dfcc6df5a610dcfe35a77bb7a84f8932485b.camel@intel.com>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On Fri, Nov 01, 2024 at 09:50:27PM +0000, Edgecombe, Rick P wrote:
> On Wed, 2024-10-16 at 14:57 -0700, Deepak Gupta wrote:
> > - * The maximum distance INCSSP can move the SSP is 2040 bytes, before
> > - * it would read the memory. Therefore a single page gap will be enough
> > - * to prevent any operation from shifting the SSP to an adjacent stack,
> > - * since it would have to land in the gap at least once, causing a
> > - * fault.
> I want to take a deeper look at this series once I can apply and test it, but
> can we maybe make this comment more generic and keep it? I think it is similar
> reasoning for arm (?), is there anything situation like this for risc-v? Or
> rather, why does risc-v have the guard gaps?
Yes, for arm64 you can only move the pointer in single frames so a
single page is enough.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-11-01 22:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 21:57 [PATCH RFC/RFT v2 0/2] Converge common flows for cpu assisted shadow stack Deepak Gupta
2024-10-16 21:57 ` [PATCH RFC/RFT v2 1/2] mm: helper `is_shadow_stack_vma` to check shadow stack vma Deepak Gupta
2024-10-17 11:22 ` Mark Brown
2024-10-19 1:24 ` Deepak Gupta
2024-11-01 21:47 ` Edgecombe, Rick P
2024-11-14 23:20 ` Deepak Gupta
2024-10-16 21:57 ` [PATCH RFC/RFT v2 2/2] kernel: converge common shadow stack flow agnostic to arch Deepak Gupta
2024-11-01 21:50 ` Edgecombe, Rick P
2024-11-01 22:39 ` Mark Brown [this message]
2024-11-14 23:30 ` Deepak Gupta
2024-11-14 23:33 ` Edgecombe, Rick P
2024-11-01 21:47 ` [PATCH RFC/RFT v2 0/2] Converge common flows for cpu assisted shadow stack Edgecombe, Rick P
2024-11-14 23:15 ` Deepak Gupta
2024-11-15 14:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f392b4e-9970-42d4-8204-2aa967a5375d@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=debug@rivosinc.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mingo@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox