From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A563E81DE8 for ; Fri, 6 Oct 2023 11:53:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 816A56B02CB; Fri, 6 Oct 2023 07:53:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C6B96B02CC; Fri, 6 Oct 2023 07:53:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 668D16B02CD; Fri, 6 Oct 2023 07:53:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5205A6B02CB for ; Fri, 6 Oct 2023 07:53:12 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1A8AA405F1 for ; Fri, 6 Oct 2023 11:53:12 +0000 (UTC) X-FDA: 81314875824.24.86A0225 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id B7B3F100017 for ; Fri, 6 Oct 2023 11:53:09 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aNq+JB6M; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696593189; a=rsa-sha256; cv=none; b=1y0+O3xLtAwduRqPebWsAk/mkCzpPz1Gx8QQyYJJDDFAgviHGOCu2ilIqXx9x06mKvllcX fhpmpGeFYYjQ/gOQCTs5FiAXTopFZk+TwxaHIIP2WbPCtHIO6FNkxBGPge1YE0pOMKJMEN ndjJSb6WNYNPoGHSOI6Tv2Gbaan6Ylo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aNq+JB6M; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696593189; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZJUb1jOQsr/hINDFS7eegUyJD3IHqJh4zbpcFmt1tEI=; b=Abtu22L/UlKZxvzQSZWT+TNAh7l9Z+9jWyesf1NjET5aBCmIzWKGAnAV0hoplZO/6uukba /FZX39RtgeRV9ENx863ZZAK7+7B6lBCTzxkF7pM9PlDPUFbtt+sdOB4NFJnS2aViSQoV3v jiVfCK3GcRifO46MJ6ajTivrpVbvZXQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696593189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZJUb1jOQsr/hINDFS7eegUyJD3IHqJh4zbpcFmt1tEI=; b=aNq+JB6MS7DuVzlJ3RPpFR4DA3xKfzPx0MmtM3VVXhwykkrjnkXa+acDG36Eh1Q+iQuNbd QRWzlcrs5JQqDxvHoQh5Ea6qeB+v0KVzw9o8JCqRgdvuBBvQmRSjrd7VtFCSNccJk4YRZp SBglSOLcG3NLOx33IERbey1/x7MArJY= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-480-8ue4a2wtNW2u7DyYwncxPg-1; Fri, 06 Oct 2023 07:53:05 -0400 X-MC-Unique: 8ue4a2wtNW2u7DyYwncxPg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-32686c75f8fso1486328f8f.0 for ; Fri, 06 Oct 2023 04:53:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696593184; x=1697197984; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZJUb1jOQsr/hINDFS7eegUyJD3IHqJh4zbpcFmt1tEI=; b=qRejUsGLMthRtfi/vspPUttg5NYewZ77nR4mTo6SUYDhttNUdabNSg0Kal5om5BY1d vRwV/5YHOmdJ5JxKzTb3XBzZKy1gGFZ6W++tfGik9lwhwugrFprrMR6YcJwhInia/8Wp RisBIbQD8dqA1a9PmBhY2XTQGGLjl98LCiSYQdUM+Tg6ZA6/jEvYWY13Mb8hSju7As8X CroQOYTMI2Ld3j7NrFYQSv+TgGKrjq/TH4JyeIjJ5YiHBCI3Q5Du8DrXXQfSSdMon+hw nXp+UKW3+1UC8KMgiemyIFZo9QxsPIWytSrfAY5fY3UNsZyLmQj0vRFyIIzVItcVLxXn lmGQ== X-Gm-Message-State: AOJu0YxJPUdG9quuswUqW43prMMtTJ2gLdNxVBskVy4whvnFDV8Rh9Bl 53QePyVrOKSNDngjjvDseTkM/twT56edI83KFabocfrgZ36jody5eI8S4vBNT/dq/oeCZ8CNMuA eryQTJ8U9sJ8= X-Received: by 2002:adf:ec03:0:b0:319:7b66:7803 with SMTP id x3-20020adfec03000000b003197b667803mr6839924wrn.55.1696593184639; Fri, 06 Oct 2023 04:53:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFBiEjrYbq2iONQGgBZNfcoQQ9VdY6vKWnGAOgxLKT36B8nHaPsIILF4X3HoRj2DnQs6QziQA== X-Received: by 2002:adf:ec03:0:b0:319:7b66:7803 with SMTP id x3-20020adfec03000000b003197b667803mr6839898wrn.55.1696593184142; Fri, 06 Oct 2023 04:53:04 -0700 (PDT) Received: from ?IPV6:2003:cb:c715:ee00:4e24:cf8e:3de0:8819? (p200300cbc715ee004e24cf8e3de08819.dip0.t-ipconnect.de. [2003:cb:c715:ee00:4e24:cf8e:3de0:8819]) by smtp.gmail.com with ESMTPSA id e2-20020adfe382000000b00327de0173f6sm1473098wrm.115.2023.10.06.04.53.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Oct 2023 04:53:03 -0700 (PDT) Message-ID: <7f356263-cb83-f4fb-59c6-406a8d3ed275@redhat.com> Date: Fri, 6 Oct 2023 13:53:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 To: Ryan Roberts , John Hubbard , Matthew Wilcox , Yang Shi , "Yin, Fengwei" , Yu Zhao , Zi Yan , David Rientjes , Andrew Morton , Vlastimil Babka , "Kirill A. Shutemov" , Hugh Dickins Cc: Linux-MM References: <4966f496-9f71-460c-b2ab-8661384ce626@arm.com> <4830fb3e-4a35-4842-98f4-9e7baa0e692a@arm.com> <7301771f-d654-4e5a-a197-3a3d8750440c@nvidia.com> <92937776-1e16-47e5-bef9-4c1a04bc98c0@arm.com> <5fa4aa95-6982-7879-e067-69fdb8b76d01@redhat.com> <1b03f4d6-634d-4786-81a0-5a104799b125@arm.com> <9d13a144-a36c-45d1-b7db-a08f84fa54ca@arm.com> <10061842-139b-4b65-8595-a09c55c000d3@arm.com> From: David Hildenbrand Organization: Red Hat Subject: Re: ANON_LARGE_FOLIOS meeting follow-up & refined proposal In-Reply-To: <10061842-139b-4b65-8595-a09c55c000d3@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B7B3F100017 X-Stat-Signature: fu9idjdd81orhzywg6bu1ds1obidzfg6 X-Rspam-User: X-HE-Tag: 1696593189-618633 X-HE-Meta: U2FsdGVkX1+Q9+l/Fuul1qRYxOSYcgW+h4cGeVgq/n6/BedvMvZ/1XKZvEYUyK0YHZZI7cCSKo5Bkt1OHKEy/hX6JVimtBAtMN9uvXboGgcszyL0/XXxdksoSSw8/TXbQpGpFMObpUWuYe0nRR0sP9HRkkxILT/86OFuYlfXm2yknO/dqTFcJSJxDDUDvGsdxBtFWsPtQlZI6f8YB9hltmALpxjmy11Ob7W7M3M8XFVnfjg9GsvO2ZkTjXGrpzcUaKTpsS1DiX+BDKQgJnocOIK3AQXN9tDok0zMyhQWjkXQBUnXl8L0NKKl4bipt+XaBoUdun+1/4Hp8PxT24UosXfYu5D3iWekL39Zhm38Y48b7LRxUuTnOQI1S7V1qQzdQoPmu7a4L7vys6bET2X/9WtfzanxwdlDKqKg3yPFkZNsT8R5fJmqfhxtgl02HGSb197fkj4pvBdKJ1HazagO4pUseXE0F3PLaJmzKwssA9CaNW8/wmEW0bTq4Tpr4j6JknKFd2T0o8T/Nr3M+WcFKhFk94rilta/GybvpnXfNZjNVpHjmzFB39tbzq5+HLBhrIKaZxMJVVbblKyUqTQpKkxfBHarxKMwAUyHmXfBfSx2bpm0OlEcq2Lj3W6NM1X7XWMvoVu1geRFa7h5IareBsMAewf7WQuOQBpK10RU2FRMykj/hMUf60wxHNRhsrMP0lq6kyBn7BRNNbxNQlq7yxEDTOY24/hjuZbjq4bSSJDv3CbdL5TgYp5ZY7J+TR99lrNdXsslF5g5KoI/hqlw28oyTT0l/Jk34Ja/XxPaPhsAqEjs7qtrODMnURIheqdNC9fHxPT4pYphQ8DBopumeMvSAng7soh+qU50H4JSnPG97/kNKX4FkBlOvsxKVmuD4H2yTTjzF2SL/baKQNjF5YJQewfQwJlXODODZC4EKUnwZLAiJAMF8O+44IhPHrIcdnxlJa2zwX3t3K8JeYn 003AEqrK h4V1v6zhu8BoYLBVubP+7ndx5aSHYZsn8XFJg86embgSRHniSzGU/1srB+ns5PdOybPT9lI1Ra5pi3bmERKlMd2Y9zJYen2Dj588CD3ip3428kYtzDeFHk9tyyqsFjxyYA/lg3aFSuHbD9zEAPwwdJnjS2UQWQfeOJpkDw2oSo/UW4UVhNzuwzqqtRKhSYK5M4N/Q40m8BWXVThDiqmR7Hp4aqRTy0bAYFHv9Xfqge2ihcKpcz4xVMa5GVYpKMPfYMUCb8IxrFU8j2qX8oQmz/hmBQ+5FOeUSwSK3r4rBObISI8UB6dlUwesToBr8bj/1hBJksDkeeCOdS93jAho3twZ17Lf9mWm9ixhzJJEhh2duYHvxcNtYvVNhM8tm4Kk4zzaPZR9Jd7aeBEeSnNZLVm4cUTQqikKH9gKmHzRTkvrxLGeRbfvtf9oSRA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05.10.23 11:46, Ryan Roberts wrote: > On 05/10/2023 09:15, David Hildenbrand wrote: >> On 05.10.23 09:37, Ryan Roberts wrote: >>> On 02/10/2023 13:58, David Hildenbrand wrote: >>>>> [...] >>>>> >>>>> My concern is that the "fresh start" is not as simple as it appears. I've come >>>>> to the conclusion that if we have a new interface, then it should really be a >>>>> strict superset of THP to make it extensible in future. But that opens >>>>> questions >>>> >>>> ^ +1 >>>> >>>>> about how you configure PMD-sized allocations when both interfaces disagree. >>>>> For >>>>> "enabled" its fairly straightforward; you can do a logical OR. But its less >>>>> clear how to handle disagreement over defrag. And then you have huge_zero_page >>>>> and khugepaged etc, which might just stay with THP. But eventually we will >>>> >>>> Probably we want everything that THP had (khugepaged, zeropage, ...) also on >>>> some (selected?) smaller orders. >>>> >>>>> probably want to do async collapse for smaller order folios too, and at that >>>>> point you have to duplicate all those controls... So I concluded that actually >>>>> it is cleaner to just bolt on a small-order extension to THP. I've updated all >>>>> the docs, and that was pretty simple to do, which usually suggests that the >>>>> extension is purely additive and shouldn't be confusing. >>>> >>>> Fine with me. I don't quite like bitmaps exposed to user space, though. Just >>>> having a user-readable list or a "directory" with various options as files might >>>> be cleaner ... >>>> >>>>> >>>>> Take a look at the patches, then make a judgement ;-) >>>>> >>>> >>>> ... but we'll discuss it there :) >>>> >>> >>> David, FYI, the patches are posted at [1] (you're cc'ed) and have been in >>> mm-unstable for nearly a week - so I guess they will go to mm-stable soon by >>> default. So if you want to object to any of it, now's the time ;-). >> >> I just did :P >> >> Note that I'm distracted by a tiny human being. I should be back at work tomorrow. > > Ahh - congratulations! Thanks man! > >> >> Hopefully other people that participated in the discussions can review and ack >> in the meantime. > > That would certainly be nice (hint to everyone else on the thread ;-) Indeed, I'll do my best to provide feedback soon, but I shouldn't be the only one doing so :) [my backlog is crazy large after some sick days, public holidays and tiny human beings] > >> >> IMHO there really is no need to rush at this point. > > I have a couple of selfish reasons; I was hoping to get it into v6.7 since I was > thinking that would be the next LTS, but I've just done the maths again, and it > looks like it will be v6.6, so I guess I've missed it anyway. The other is that Yes, that ship has sailed; also, it's not that much of value if merged but cannot be reasonably enabled yet due to other TODOs (IOW, no distribution would enable it). > I would like to move focus to other changes that build on this, and that's > difficult while this is still not merged. IMHO, this is one of the big important features comparable to ordinary THP back then. We better take our time to get it right (well, rather as little wrong as possible :) ). You can start sending out other work that depends on this, even if not merged yet. ... there tends to be a review bottleneck, so don't expect fast feedback; but it might be reasonable to let people know what's coming up next. -- Cheers, David / dhildenb