From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32C34C3ABBC for ; Fri, 9 May 2025 18:33:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 065926B00A2; Fri, 9 May 2025 14:33:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F30286B00A4; Fri, 9 May 2025 14:33:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD0146B00A5; Fri, 9 May 2025 14:33:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B4D426B00A2 for ; Fri, 9 May 2025 14:33:52 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AD8881A03F1 for ; Fri, 9 May 2025 18:33:53 +0000 (UTC) X-FDA: 83424218346.06.9FA30FD Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by imf01.hostedemail.com (Postfix) with ESMTP id CF4EE4000E for ; Fri, 9 May 2025 18:33:50 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=XgzyAxq0; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf01.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 192.198.163.10) smtp.mailfrom=tim.c.chen@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746815631; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XUbb0MCw68Ncja+L5E8S5VnR9u7SFKyhr1CWF51OEEM=; b=zFAv8gSOnTIULFutCLjwnx9q0E6YIGPrFUdS17GmdrLGobxLFQd+5IBLYOzbhQZQk0FCup bAohO9vKxUgUqrg9pdDEJOe0nB7WpPS8aNApQ5d/y7hJP/oxnYnW5YadZoWd0naMQ3rdAZ TyO8ykdFuFTdcOxLP2AWMCjyQ1J5E80= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746815631; a=rsa-sha256; cv=none; b=vg2Srblnk5kiQrP0GNDblVl0EImAAbQFA4dWwoOJ77/akFk9CN32TeNcclNy6LKGgXiFw8 UqzR/yv7QB+UHFjYbTrSkZ9ACXAamr7F8+rXQR/c3VDb0cHEeGvzPC1kd4MZ0qBNbChU3Y zsLh5WO+/TKnltibXIpe5EiYpgYZz9k= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=XgzyAxq0; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf01.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 192.198.163.10) smtp.mailfrom=tim.c.chen@linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746815631; x=1778351631; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=NExlrnswyHIJcXXajxp1nvUpQkfg++fyr8mjuwKWgeM=; b=XgzyAxq0iroW5KplPyKSNaTw6U3NWd1jNDkJDAzfLdbn8du+koX+JTge eo1juovumFrHpqNlntYYDGiajfwfeJEag2NdsizaM9riBrnO/lxbPplB2 OmqPaHyFIqVQzZAw3Y2QqYgrlPSeg/hHrqql7D7aCew18VGLUgbp6I7Vv /73o9V1pdl8k9JTs/RpSRiAZF0C2ugsc0cnXzgMCapUdXdeH/6IE9Glom HjMZfLwYzeNnsDCCyN1gl/YlwPh7mkh3c1qZEsEIIWvEI3vbAhw12v6FG +4SZheTNBwd56qfWLxSKLJFRtq+vHfBiynnG8UNDk/5BRgH6nwE2naexA w==; X-CSE-ConnectionGUID: 78WC7ApCRrSHtRU4pWKxKA== X-CSE-MsgGUID: fq1GQZbQRXqO23NkJ+pcDw== X-IronPort-AV: E=McAfee;i="6700,10204,11427"; a="60001978" X-IronPort-AV: E=Sophos;i="6.15,275,1739865600"; d="scan'208";a="60001978" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2025 11:33:49 -0700 X-CSE-ConnectionGUID: KWdvAj8bRbOTx2+TsBcW5w== X-CSE-MsgGUID: heKlrp96To6gdwYJHwX/YA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,275,1739865600"; d="scan'208";a="140762395" Received: from inaky-mobl1.amr.corp.intel.com (HELO [10.125.108.203]) ([10.125.108.203]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2025 11:33:49 -0700 Message-ID: <7f237574d9f08a9fa8dcaa60d2edf8d8e91441d4.camel@linux.intel.com> Subject: Re: [PATCH v2 2/2] alloc_tag: keep codetag iterator active between read() calls From: Tim Chen To: David Wang <00107082@163.com>, surenb@google.com, kent.overstreet@linux.dev, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Date: Fri, 09 May 2025 11:33:48 -0700 In-Reply-To: <20250509173929.42508-1-00107082@163.com> References: <20250507175500.204569-1-00107082@163.com> <20250509173929.42508-1-00107082@163.com> Autocrypt: addr=tim.c.chen@linux.intel.com; prefer-encrypt=mutual; keydata=mQENBE6N6zwBCADFoM9QBP6fLqfYine5oPRtaUK2xQavcYT34CBnjTlhbvEVMTPlNNzE5v04Kagcvg5wYcGwr3gO8PcEKieftO+XrzAmR1t3PKxlMT1bsQdTOhKeziZxh23N+kmA7sO/jnu/X2AnfSBBw89VGLN5fw9DpjvU4681lTCjcMgY9KuqaC/6sMbAp8uzdlue7KEl3/D3mzsSl85S9Mk8KTLMLb01ILVisM6z4Ns/X0BajqdD0IEQ8vLdHODHuDMwV3veAfnK5G7zPYbQUsK4+te32ruooQFWd/iqRf815j6/sFXNVP/GY4EWT08UB129Kzcxgj2TEixe675Nr/hKTUVKM/NrABEBAAGJAS4EIAECABgFAk6ONYoRHQFLZXkgaXMgcmVwbGFjZWQACgkQHH3vaoxLv2UmbAgAsqa+EKk2yrDc1dEXbZBBGeCiVPXkP7iajI/FiMVZHFQpme4vpntWhg0BIKnF0OSyv0wgn3wzBWx0Zh3cve/PICIj268QvXkb0ykVcIoRnWwBeavO4dd304Mzhz5fBzJwjYx06oabgUmeGawVCEq7UfXy+PsdQdoTabsuD1jq0MbOL/4sB6CZc4V2mQbW4+Js670/sAZSMj0SQzK9CQyQdg6Wivz8GgTBjWwWsfMt4g2u0s6rtBo8NUZG/yw6fNdaoDaT/OCHuBopGmsmFXInigwOXsjyp15Yqs/de3S2Nu5NdjJUwmN1Qd1bXEc/ItvnrFB0RgoNt2gzf25aPifLabQlVGltIENoZW4gPHRpbS5jLmNoZW5AbGludXguaW50ZWwuY29tPokBOAQTAQIAIgUCTo3rPAIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQHH3vaoxLv2XYdAf8DgRO4eIAtWZy4zLv0EZHWiJ35GYAQ5fPFWBoNURE0+vICrvLyfCKTlUTFxFxTiAWHUO7JM+uBHQSJVsE+ ERmTPsiU O1m7SxZakGy9U2WOEiWMZMRp7HZE8vPUY5AM1OD0b38WBeUD3FPx5WRlQ0z6izF9aIHxoQhci0/WtmGLOPw3HUlCy1c4DDl6cInpy/JqUPcYlvsp+bWbdm7R5b33WW2CNVVr1eLj+1UP0Iow4jlLzNLW+jOpivLDs3G/bNC1Uu/SAzTvbaDBRRO9ToX5rlg3Zi8PmOUXWzEfO6N+L1gFCAdYEB4oSOghSbk2xCC4DRlUTlYoTJCRsjusXEy4bkBDQROjes8AQgAzuAQ5rF4/ZYaklzSXjXERiX0y1zBYmcYd2xVOKf50gh8IYv8allShkQ8mAalwIwyxTY+1k72GNCZIRVILSsuQY6fLmPUciuCk/X1y4oLNsF/Np8M9xxwYwqUibUwRdWwpSG2V0bcqjtUH1akaoY758wLONUmXrlfVonCfENd0aiP+ZLxYE1d1CRPv4KbAZ6z6seQCEQrappE4YXIC9yJUqT076DD1RhPmwNbNTTAauuwG+vX+jWsc5hUaHbKsAf/Rsw13+RA3dzWekbeIxO9qvQoQ26oqKEA31mxWhwNDnkTeo07+e2EGC2BV6s+sU1/m/lup5Bj34JLP7qYtd6EswARAQABiQEeBBgBAgAJBQJOjes8AhsMAAoJEBx972qMS79lYmQH+I4qdFm8wlkh/ZVWNJMSpfUfupuLPZ0g0hxNr3l2ZltEskVl5w+wJV+hBZ7zMmSxMYvMjJ+5aBDSZOfzhnK6+ETl4e/heDYiBLPYCtvU88cMRFb3jKcVxSfSzbBawEr7OFfCny3UtmYQ0PJmHFT6p+wlEHSyKxtyDDlLS/uPPR/llK94fOhvQlX8dir9b8r7JGuFTjtG2YbsTuapi3sFDmBhFZwYcNMt80FSIXGQjJzrsl1ZVSIwmqlF2191+F/Gr0Ld92dz1oEOjwKH1oRb/0MTsNU7udZv7L8iGKWCjHnA0dIoXKilf8EJyXGQ0wjQE3WBAdMecb vSKDRA7k 9a75kCDQROjjboARAAtXPJWkNkK3s22BXrcK8w9L/Kzqmp4+V9Y5MkkK94Zv66lXAybnXH3UjL9ATQgo7dnaHxcVX0S9BvHkEeKqEoMwxg86Bb2tzY0yf9+E5SvTDKLi2O1+cd7F3Wba1eM4Shr90bdqLHwEXR90A6E1B7o4UMZXD5O3MI013uKN2hyBW3CAVJsYaj2s9wDH3Qqm4Xe7lnvTAGV+zPb5Oj26MjuD4GUQLOZVkaA+GX0TrUlYl+PShJDuwQwpWnFbDgyE6YmlrWVQ8ZGFF/w/TsRgJMZqqwsWccWRw0KLNUp0tPGig9ECE5vy1kLcMdctD+BhjF0ZSAEBOKyuvQQ780miweOaaTsADu5MPGkd3rv7FvKdNencd+G1BRU8GyCyRb2s6b0SJnY5mRnE3L0XfEIJoTVeSDchsLXwPLJy+Fdd2mTWQPXlnforgfKmX6BYsgHhzVsy1/zKIvIQey8RbhBp728WAckUvN47MYx9gXePW04lzrAGP2Mho+oJfCpI0myjpI9CEctvJy4rBXRgb4HkK72i2gNOlXsabZqy46dULcnrMOsyCXj6B1CJiZbYz4xb8n5LiD31SAfO5LpKQe/G4UkQOZgt+uS7C0Zfp61+0mrhKPG+zF9Km1vaYNH8LIsggitIqE05uCFi9sIgwez3oiUrFYgTkTSqMQNPdweNgVhSUAEQEAAbQ0VGltIENoZW4gKHdvcmsgcmVsYXRlZCkgPHRpbS5jLmNoZW5AbGludXguaW50ZWwuY29tPokCVQQTAQgAPwIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQTRofI2lb24ozcpAhyiZ7WKota4SQUCYjOVvwUJF2fF1wAKCRCiZ7WKota4SeetD/4hztE+L/Z6oqIYlJJGgS9gjV7c08YH/jOsiX99yEmZC/BApyEpqCIs+RUYl12hwVUJc++sOm/p3d31iXvgddXGYxim00+ DIhIu6sJ aDzohXRm8vuB/+M/Hulv+hTjSTLreAZ9w9eYyqffre5AlEk/hczLIsAsYRsqyYZgjfXLk5JN0L7ixsoDRQ5syZaY11zvo3LZJX9lTw0VPWlGeCxbjpoQK91CRXe9dx/xH/F/9F203ww3Ggt4VlV6ZNdl14YWGfhsiJU2rbeJ930sUDbMPJqV60aitI93LickNG8TOLG5QbN9FzrOkMyWcWW7FoXwTzxRYNcMqNVQbWjRMqUnN6PXCIvutFLjLF6FBe1jpk7ITlkS1FvA2rcDroRTU/FZRnM1k0K4GYYYPj11Zt3ZBcPoI0J3Jz6P5h6fJioqlhvZiaNhYneMmfvZAWJ0yv+2c5tp2aBmKsjmnWecqvHL5r/bXeziKRdcWyXqrEEj6OaJr3S4C0MIgGLteARvbMH+3tNTDIqFuyqdzHLKwEHuvKxHzYFyV7I5ZEQ2HGH5ZRZ2lRpVjSIlnD4L1PS6Bes+ALDrWqksbEuuk+ixFKKFyIsntIM+qsjkXseuMSIG5ADYfTla9Pc5fVpWBKX/j0MXxdQsxT6tiwE7P+osbOMwQ6Ja5Qi57hj8jBRF1znDjDZkBDQRcCwpgAQgAl12VXmQ1X9VBCMC+eTaB0EYZlzDFrW0GVmi1ii4UWLzPo0LqIMYksB23v5EHjPvLvW/su4HRqgSXgJmNwJbD4bm1olBeecIxXp6/S6VhD7jOfi4HACih6lnswXXwatzl13OrmK6i82bufaXFFIPmd7x7oz5Fuf9OQlLOnhbKXB/bBSHXRrMCzKUJKRia7XQx4gGe+AT6JxEj6YSvRT6Ik/RHpS/QpuOXcziNHhcRPD/ZfHqJSEa851yA1J3Qvx1KQK6t5I4hgp7zi3IRE0eiObycHJgT7nf/lrdAEs7wrSOqIx5/mZ5eoKlcaFXiKJ3E0Wox6bwiBQXrAQ/2yxBxVwARAQABtCVUaW0gQ2hlbiA8dGltLmMuY2hlbkBsaW51eC5pbnRl bC5jb20+ iQFUBBMBCAA+FiEEEsKdz9s94XWwiuG96lQbuGeTCYsFAlwLCmACGwMFCQHhM4AFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQ6lQbuGeTCYuQiQf9G2lkrkRdLjXehwCl+k5zBkn8MfUPi2ItU2QDcBit/YyaZpNlSuh8h30gihp5Dlb9BnqBVKxooeIVKSKC1HFeG0AE28TvgCgEK8qP/LXaSzGvnudek2zxWtcsomqUftUWKvoDRi1AAWrPQmviNGZ4caMd4itKWf1sxzuH1qF5+me6eFaqhbIg4k+6C5fk3oDBhg0zr0gLm5GRxK/lJtTNGpwsSwIJLtTI3zEdmNjW8bb/XKszf1ufy19maGXB3h6tA9TTHOFnktmDoWJCq9/OgQS0s2D7W7f/Pw3sKQghazRy9NqeMbRfHrLq27+Eb3Nt5PyiQuTE8JeAima7w98quQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) MIME-Version: 1.0 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CF4EE4000E X-Rspam-User: X-Stat-Signature: ha57mfwrju8ybb7n3ajrt7dnsf3fw4qj X-HE-Tag: 1746815630-672002 X-HE-Meta: U2FsdGVkX18gpLLbUN/T1OVBqx8llvUIb11IuSL4eapxbR5oUHfwcSl92tMrPfOQ0sEcbhX58OMIwvDSnGAF4DyghzQEmIwowosX047gaUbWYTbBZEyu0yPgugQFhP7MTCQqSRo0jLP6gsh63jISP/4TRz7TYZWwK/nhfNEzCdLkXdIvKidhhIP47iIvPgQRvRXCuStOM0a+UAfh/hslnmFCaRsFv3GjDHt97rCmW2fXBV1HUimSvWYhlIsAZ0RWAppMlWavzlfozpIygAORKZcoBEpy87iC3nuqX3bz0KKYxAGTNYy1AqzEhaAT8HS7872k/MOKIEkdas/1ALW6s5qRv7/R5Gow3zdpxk2n0EgXOOnRGE213IlAA8LeOBd70+inP+4dIBWobeqRFeXZ61RiyycEULgdYSTatQcal9Je1KT8ggsEgSU57ovNhb5GP1AUWgF/hFsgfoynBiDR4FfZqcNXM4ubsf4nY3ImlKWIv8oG4juBC/p3fayAWHI2tUzHVDJS8QXjGVVXTe11fqNO8tYwquCWzDIxFtd4VnfHFJeAMivtB6naZq1S4E334LUYwwu5mBX07rZh9ibmvwvNzRSvn9fmhhTDbQXNatmwd2Pxfdk08Opt0SMx3JMDB5T3JRy+B6LiUaa4+0vgE2bUsCUdb0T9pZmhC4EXx+zX+v3y9FSiTs7IXDC/o4Qgq+JUpiuqPQaimfKJzlyk/ZS9oMP15SqYM9WelDvdAQvm6xbo5JAXCdtGEeFjK8Np43xbEDv1FJsiJJdPl4+EWpbKUesVebRMpWMzndip8FFhbjuMQRUulRmhtMUxCXKMxUZ/babuUJaAr08Cajrp4ElirOtcEs0HpGOnwlptwJ1u2gRxrb+Kz6/BKFHKNulj3ccZxJryM0vKN+0PRb/BAwvDf9f3m66oknQT/ssmRKPzce+sPU/MQ8oJ4IwusHicjk9AZlM24o7nmDDVu7C kywJRF+3 qbizJdLLa7t5qfw9YLBcRvt7dWJywmI/NjcEqYoOIG9QvBlO9Uj2xXSZAVR9/97ZkhClN9hsl83w3Xg6FFW+jHgvsvbeh475T1JXE/4rkcYXSPpn/zwP9gZ1eXGN4hNMbGgX7J8SlA2nGRuG49QVNivxZmatjf78tn3k1xcY8aTL30TnB7A5JES6hYCBn4N7YpmCLWG/GH5REYWYwtCnQPI5RxMXzYzI3xLMu/T848bjJxAVtu7HPNvAHikOZfY9cfoUBJ3jTpL7mTIAg7IBzE9dOvreycDXj7arj81KBSJyw+IM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 2025-05-10 at 01:39 +0800, David Wang wrote: >=20 >=20 > Signed-off-by: David Wang <00107082@163.com> > --- > lib/alloc_tag.c | 29 ++++++++++------------------- > 1 file changed, 10 insertions(+), 19 deletions(-) >=20 > diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c > index 25ecc1334b67..fdd5887769a6 100644 > --- a/lib/alloc_tag.c > +++ b/lib/alloc_tag.c > @@ -45,21 +45,16 @@ struct allocinfo_private { > static void *allocinfo_start(struct seq_file *m, loff_t *pos) > { > struct allocinfo_private *priv; > - struct codetag *ct; > loff_t node =3D *pos; > =20 > - priv =3D kzalloc(sizeof(*priv), GFP_KERNEL); > - m->private =3D priv; > - if (!priv) > - return NULL; > - > - priv->print_header =3D (node =3D=3D 0); > + priv =3D (struct allocinfo_private *)m->private; > codetag_lock_module_list(alloc_tag_cttype, true); > - priv->iter =3D codetag_get_ct_iter(alloc_tag_cttype); > - while ((ct =3D codetag_next_ct(&priv->iter)) !=3D NULL && node) > - node--; > - > - return ct ? priv : NULL; > + if (node =3D=3D 0) { > + priv->print_header =3D true; > + priv->iter =3D codetag_get_ct_iter(alloc_tag_cttype); > + codetag_next_ct(&priv->iter); > + } Do you need to skip print header when *pos !=3D 0? i.e add } else { priv->print_header =3D false; } Tim > + return priv->iter.ct ? priv : NULL; > } > =20