From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC7E2ECAAD8 for ; Tue, 20 Sep 2022 13:22:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34588940008; Tue, 20 Sep 2022 09:22:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F46E940007; Tue, 20 Sep 2022 09:22:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1954D940008; Tue, 20 Sep 2022 09:22:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 07F5E940007 for ; Tue, 20 Sep 2022 09:22:44 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C1F86A0B95 for ; Tue, 20 Sep 2022 13:22:43 +0000 (UTC) X-FDA: 79932528606.21.E97E7F7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 65BBB200AC for ; Tue, 20 Sep 2022 13:22:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663680162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HAagr+5D/SDR0OvGsWzOAQR3yF3tO/raRhnWXj9RfQU=; b=iYTQiWu/E4sCMHxAiVx6ueskKvC6WJsenmAjDs3V8WmrxRrCn61n173xGKHpEvHnAT7/HZ em0bx0lqF1C0s9sdGCA2lAHoW3XtDC4/i8HJRGsM/3MzGdgO8sEgtesY0BBbjwfdYCPvfz VIwcxMmPXoHOICI/gDk8Sdx3fx8gTgI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-441-3sny9Jr2NWCoIi0xOR7XAg-1; Tue, 20 Sep 2022 09:22:41 -0400 X-MC-Unique: 3sny9Jr2NWCoIi0xOR7XAg-1 Received: by mail-wm1-f71.google.com with SMTP id 14-20020a05600c228e00b003b4d065282dso660037wmf.8 for ; Tue, 20 Sep 2022 06:22:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=HAagr+5D/SDR0OvGsWzOAQR3yF3tO/raRhnWXj9RfQU=; b=JKnUtCtZKtj6jFo/blePlXqZOu6RK2wwuoJi74vvK3nNxk4CWmOOpW14ZhUDivY7uo lFm7gkOoqiT7YrOL7iPwAqdYhhfcHfTd3FCLDoz1p1uBwaQJEYcRSj7dAtAtPz84+AUZ 40+MdqRMZXhxULE3v9xNjL9n/f1YBonwCUUnWIvFwx8cb7DGpbGNLh84j9lvjGhM1ztX DdqdYxIA2/DMQr5Z/rl0Tyz3exQ72ICm5oAGze2GTgLOyBm/K/S/jX59gch6FtuJFba4 aXRqzJ7wigTsu77S0roaOQgvhRnhU+mwuv2wQeFo1ZRyPCZwQoUELq+Zk+HToPE9sEd7 X7IQ== X-Gm-Message-State: ACrzQf3PSFbSZur0Y9ybMIX6u1+NZXOejnntKea0x7aPRt+N1ssdwp5G ab6ENYjPvJem9I8Ix9iNYC3ZlCZqDr9wCqgk1aK2/ysIU6WwkncMBRTBcA8PkKHcWd1ye9q8AXO DOX9Rlo6gtMU= X-Received: by 2002:a05:600c:4f56:b0:3b4:b6b0:42d4 with SMTP id m22-20020a05600c4f5600b003b4b6b042d4mr2395180wmq.143.1663680160832; Tue, 20 Sep 2022 06:22:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4uNmTszB+WUAb11KH7RULfuLObx/dVn5U7CXVqKDMewoWn5osuTwcZ84XnG0Qq7JUZG3l1Dw== X-Received: by 2002:a05:600c:4f56:b0:3b4:b6b0:42d4 with SMTP id m22-20020a05600c4f5600b003b4b6b042d4mr2395155wmq.143.1663680160558; Tue, 20 Sep 2022 06:22:40 -0700 (PDT) Received: from ?IPV6:2003:cb:c712:2300:e82d:5a58:4fd8:c1e6? (p200300cbc7122300e82d5a584fd8c1e6.dip0.t-ipconnect.de. [2003:cb:c712:2300:e82d:5a58:4fd8:c1e6]) by smtp.gmail.com with ESMTPSA id o17-20020a5d4a91000000b00228dff8d975sm1606351wrq.109.2022.09.20.06.22.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 06:22:39 -0700 (PDT) Message-ID: <7f1cfee4-c6de-ea59-0aa9-9bd55054fb22@redhat.com> Date: Tue, 20 Sep 2022 15:22:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] mm/secretmem: remove reduntant return value To: xiujianfeng , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Binyi Han References: <20220920012205.246217-1-xiujianfeng@huawei.com> <3196b824-bcee-0c44-bfd3-f6cd8a1e6719@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663680163; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HAagr+5D/SDR0OvGsWzOAQR3yF3tO/raRhnWXj9RfQU=; b=tPTNuNL02uUIcYLckrvUKDQyXJUB9Mtc4isFM2ItoPCX5zBIWAz6am3hlSpJdFnchZ+bGf efN55tXtDMjSEK7WPzj+cpgaPgfw5B/WmE4Jf+RVmSR6D/Cdd1qT27y4q+4aqgIxMxhYpH rJ+mxgQwuuow2jCmmpstW6T/5gbwijg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="iYTQiWu/"; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663680163; a=rsa-sha256; cv=none; b=r6+uPp4rSq2xRjbR1OJ/A4V4cnI3RPIq+hiFwV3gyLzMlyuCS+BOcupguPH9dPau8P+fYf bsWVnHcY/b0LRswwbd/ERvRlA80hL5AEMHHaWKk44Z3d6RqUCo13ChninFNIGiC58OpFAG mwsDfbMozGZpEYzOBS7EXrfIMugTYA4= X-Stat-Signature: i1ewo3u5butputct7w1cdkocu3jdc67c X-Rspam-User: X-Rspamd-Queue-Id: 65BBB200AC X-Rspamd-Server: rspam02 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="iYTQiWu/"; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1663680163-786112 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20.09.22 14:35, xiujianfeng wrote: > Hi, > > 在 2022/9/20 20:10, David Hildenbrand 写道: >> On 20.09.22 03:22, Xiu Jianfeng wrote: >>> The return value @ret is always 0, so remove it and return 0 directly. >>> >>> Signed-off-by: Xiu Jianfeng >>> --- >>>   mm/secretmem.c | 6 ++---- >>>   1 file changed, 2 insertions(+), 4 deletions(-) >>> >>> diff --git a/mm/secretmem.c b/mm/secretmem.c >>> index 6a44efb673b2..04c3ac9448a1 100644 >>> --- a/mm/secretmem.c >>> +++ b/mm/secretmem.c >>> @@ -278,10 +278,8 @@ static struct file_system_type secretmem_fs = { >>>   static int __init secretmem_init(void) >>>   { >>> -    int ret = 0; >>> - >>>       if (!secretmem_enable) >>> -        return ret; >>> +        return 0; >>>       secretmem_mnt = kern_mount(&secretmem_fs); >>>       if (IS_ERR(secretmem_mnt)) >> >> On top of which tree is that? >> >> 6.0-rc6 has here: >> >> if (IS_ERR(secretmem_mnt)) >>     ret = PTR_ERR(secretmem_mnt); >> > Sorry, it's on linux-next tree, I should have used [PATCH -next]:) > Maybe this change should be squashed into the patch from Binyi directly: commit 4eb5bbde3ccb710d3b85bfb13466612e56393369 (mm/mm-hotfixes-stable) Author: Binyi Han Date: Sun Sep 4 00:46:47 2022 -0700 mm: fix dereferencing possible ERR_PTR Smatch checker complains that 'secretmem_mnt' dereferencing possible ERR_PTR(). Let the function return if 'secretmem_mnt' is ERR_PTR, to avoid deferencing it. Link: https://lkml.kernel.org/r/20220904074647.GA64291@cloud-MacBookPro Fixes: 1507f51255c9f ("mm: introduce memfd_secret system call to create "secret" memory areas") Signed-off-by: Binyi Han Reviewed-by: Andrew Morton Cc: Mike Rapoport Cc: Ammar Faizi Cc: Hagen Paul Pfeifer Cc: James Bottomley Cc: Signed-off-by: Andrew Morton -- Thanks, David / dhildenb