From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 229D6CF6D2C for ; Wed, 2 Oct 2024 14:44:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7A484401B1; Wed, 2 Oct 2024 10:44:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A02994401AF; Wed, 2 Oct 2024 10:44:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82E1D4401B1; Wed, 2 Oct 2024 10:44:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4EEC14401AF for ; Wed, 2 Oct 2024 10:44:52 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D783CC0826 for ; Wed, 2 Oct 2024 14:44:51 +0000 (UTC) X-FDA: 82628933982.14.9CB55B0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf18.hostedemail.com (Postfix) with ESMTP id EC2981C0010 for ; Wed, 2 Oct 2024 14:44:47 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=12Zr4U0Q; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=P4KgZGbb; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Zc1cPzkM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=12RJnV0w; dmarc=none; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727880266; a=rsa-sha256; cv=none; b=kLAyspqtFOHtslko8khBwgqybhkliReezQ7+lgc0GWRU4pcoB33kew6GnHB4KjCkwBz/6Z 0jZBTtBjP2Ik6HcYhC6xmCLOc9N08HgdcRGA4GtyB1+Q5CfdJWMq/cC1abq6xqbeHi/KoQ sXGPkidsw6bfUIxRjFOvs0G6b9vrnJ4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=12Zr4U0Q; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=P4KgZGbb; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Zc1cPzkM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=12RJnV0w; dmarc=none; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727880266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Belre76DL6h+0gD4JiFxLhRUZh4NO1hWWD43NEdumV4=; b=PQSOLJek6ALwtphksiFElw6SBScMwbbtwYqTRWbT5VSGUk+Q4tZJXln0NPCOFnbv1KgooX B2aCH6NvojIVAOX9q8POtOk3fDvlFoyX1F1m/BHoz0MrhmNgeQWhwEoMf3ydg1QGdX4amy KP/xpF+lRKy2VgvfRIr16QIbJ7ZZiIg= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E6475219EE; Wed, 2 Oct 2024 14:44:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727880286; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Belre76DL6h+0gD4JiFxLhRUZh4NO1hWWD43NEdumV4=; b=12Zr4U0Q7vibjRo0oZ9RaWG1aO5DJoaUW+ryILL8JL5958QC7tIDvRfyHu2axT/jN6pzUe oegWOM2YWeyUOJ8mPBj46Ujxrfl23VjiGOBdEwdtvX6HikIhSHtJ/th7gSwW0frKzAtccL tlFgXLPKkTn/jrOOgU3YUu/oxwGM8kI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727880286; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Belre76DL6h+0gD4JiFxLhRUZh4NO1hWWD43NEdumV4=; b=P4KgZGbbiC8yYmw5t6DljUj6bq2eV4H/K+x/wQtn5DY0jaB18QLR1vFsJ9fdJQO+n2bGx6 wyBXZINzLL46JKDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727880285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Belre76DL6h+0gD4JiFxLhRUZh4NO1hWWD43NEdumV4=; b=Zc1cPzkMWSQBnSQN0xZUR/ZMkuow81+byG5pv/cATuO4h1NmOTRhgZc9OBTQzNa74Uh7Rb mgYDaDQLUL6uFNrgsc6No49rp3q+HZohKp56hnr+/Xb552Us7OsSFegHE2Kg/FV7b8DpPy HU+evWluNzba/WJ1HqjCqhM3H5bWNpI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727880285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Belre76DL6h+0gD4JiFxLhRUZh4NO1hWWD43NEdumV4=; b=12RJnV0wVUR5bFbvcRnM6w3GrBLoKKIljoSl1DzuC780vlBrUaYFS4mduMJDA0oiA9C2v9 StK2Uu+tBCkcmMBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BC31A13A6E; Wed, 2 Oct 2024 14:44:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id d7tiLV1c/WYyNwAAD6G6ig (envelope-from ); Wed, 02 Oct 2024 14:44:45 +0000 Message-ID: <7f18cd71-4a4a-4d29-beb4-33f6d9fe3c12@suse.cz> Date: Wed, 2 Oct 2024 16:44:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH slab hotfixes v2 2/2] slub/kunit: skip test_kfree_rcu when the slub kunit test is built-in Content-Language: en-US To: Guenter Roeck , Christoph Lameter , David Rientjes Cc: Roman Gushchin , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Paul E. McKenney" , Boqun Feng , Uladzislau Rezki , rcu@vger.kernel.org, David Gow , Rae Moar , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Brendan Higgins References: <20241001-b4-slub-kunit-fix-v2-0-2d995d3ecb49@suse.cz> <20241001-b4-slub-kunit-fix-v2-2-2d995d3ecb49@suse.cz> <80d0cd70-c00a-475c-a028-e842fb86403b@suse.cz> <87f2fe09-ba6a-4405-b716-5325bb6a223b@roeck-us.net> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <87f2fe09-ba6a-4405-b716-5325bb6a223b@roeck-us.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: kgrhqizdw5egras91zmxqyd4dkx61oir X-Rspamd-Queue-Id: EC2981C0010 X-Rspamd-Server: rspam02 X-HE-Tag: 1727880287-379084 X-HE-Meta: U2FsdGVkX19Tlv0WPXFXe7j4iCe0XC/iVEa5Z1LJRc/Eyg9MbBWgSXDfy/8T1Wy2Bn6mhZTV0FYdR1gsyFjqyxZAMvud7CLkmlt/av+tjQl69g4AtFIeSDPv91Yju5YHODI3W8fHs1QU6/vJ1EoFsAQlEautqV4blyL1z2zZ9dr6C34Z6Tu6+cTuFnndEfGjZbG0I10iSf7hHz+vPcpxK8BJ9ZLGcpzTTC76rMeIh7J9LcA60htOBUtnWQ/J+rg42IW/ZfpMAK66u6ZhbDx0ujuMnyVXjzXGFR6Yv0MMWhL5uWSW/BxlF8jTxNLAsxOncbY74o7n5tWXmNA6EbtMQDQzfQIgGozq5JNm9KM86MGO2TPw92WPkx0+25Hw6qvoZWbZ0Y85WC/yCpiLZ8Pcf6LcCJjlWm3YWi2GixpmhILX8eYIWnw6di2FiqKrm1Ve3Sb6k3Oo3oawXGkvcV4WvJTF9YITs+UweWbKERI47jRLtSBgM18SkwCPh54C2GbI42oXuf+w+9/lEFRd5wB0rxQSZzmfPfrLBfcuTquZ9VstdIAROk+Aud2r3c6hkb7CvlSF3jqwWsgyDbi2fT1s7P3h6/TeJDq2nF6j/Vjmj1fzFZX74YSYES/uwJFo8v/u+RYcoy0SZ0QoD/kbq06dVRtDTa3oLUwJEcUP5kWwSgmZmdSp+dQKgO7mPqtgvnQxyFjyROSmivMSIigAZZae113xAXccA0qY6ihEvdbDcCwM72BIUh7tpGrIBm/9mPvsflCeQ8c+lSfUmSRCoDNRBkdEsAdittFKDagwFR/vTHKmbvASIOVUrKBQt1zq3F2I56Zlpyub8aNdqPyUpWG1sz/sYoYAhlY5QQFd8Vwfppr2APJ0EnNJ3FpPPvaFhnBIF3KYrJy1QjWUQe1+8LJixFknrcRCGXEw1OmC7gDbp7kss4302F7FwiSEIY3x/3Jy2Tfe7uGxnlGPiZVeys4 ZYiGw5iZ uIckW+X4bzcIULEfKpvuJHipNORALW6t6ZK6KaRcft0tT8Ar+n+NGjPur1z7spKoXRaqAnhplYf/6ewcCoUWyT0or3458N+wUhHn/K0bW8G7OMSQMujXD9A7xyttZYY0zPqJxQyhax78NbNcmAXCD9kdGwCgfPAE34sVeZOR9CUI8AZkksm5NFl0n6ay/Up4LmCaJMSjWArrMgxI7jtktZdl40zdrijxCsP2VLUZ39u9EX9vwryhTZbT6YSfVxGaTflwnwvu35UPbh+CFIHem9LGQx2K2ke2THy9pHMVyBxTFp/kuN13rz8Cl1PVmUayC2X9Ln/DB4PLZ6/uU1VfSEtuLMLYCM3HJn8wWiOHzKqGTt24diberkPK20vQlVTR+cqZytNBGikbeRco+y6vl79PPsarzoiIe4ZzJbQejrtinAaVDyhDOWbqQjsDRLL7yFZ7ws1XBOt0mxlLJ8WQyxHrQLQNxuMwQevo8CqunxPMcAyk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/2/24 15:52, Guenter Roeck wrote: > On 10/2/24 03:26, Vlastimil Babka wrote: >> On 10/1/24 18:20, Vlastimil Babka wrote: >>> Guenter Roeck reports that the new slub kunit tests added by commit >>> 4e1c44b3db79 ("kunit, slub: add test_kfree_rcu() and >>> test_leak_destroy()") cause a lockup on boot on several architectures >>> when the kunit tests are configured to be built-in and not modules. >>> >>> The test_kfree_rcu test invokes kfree_rcu() and boot sequence inspection >>> showed the runner for built-in kunit tests kunit_run_all_tests() is >>> called before setting system_state to SYSTEM_RUNNING and calling >>> rcu_end_inkernel_boot(), so this seems like a likely cause. So while I >>> was unable to reproduce the problem myself, skipping the test when the >>> slub_kunit module is built-in should avoid the issue. >>> >>> An alternative fix that was moving the call to kunit_run_all_tests() a >>> bit later in the boot was tried, but has broken tests with functions >>> marked as __init due to free_initmem() already being done. >>> >>> Fixes: 4e1c44b3db79 ("kunit, slub: add test_kfree_rcu() and test_leak_destroy()") >>> Reported-by: Guenter Roeck >>> Closes: https://lore.kernel.org/all/6fcb1252-7990-4f0d-8027-5e83f0fb9409@roeck-us.net/ >> >> I hope you can confirm it helps, because the commit added two tests and I've >> only skipped one of them, as it's the one using kfree_rcu(), which is >> suspected. But the other is responsible for the (now suppressed) >> kmem_cache_destroy() warning, and maybe I'm missing something and it was >> actually that one causing the lockups. >> > > Everything works with your patches applied, so we are good. Thanks for testing! Queued for -next now and will send to Linus later if all's good. >> Since you mentioned the boot lockups happened on some x86_64 too, do you >> have a .config of the lockup case? I've tried tweaking some rcu options but >> still nothing. >> > > I have a bunch of debug options enabled. Configuration (generated using > "make savedefconfig") for x86_64 is attached. Hmm, didn't see the hang with that (using virtme-ng) on v6.12-rc1. Guess there's something more to it. Oh well. > Thanks, > Guenter