From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01D36C54FB9 for ; Tue, 21 Nov 2023 07:22:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7172E6B045C; Tue, 21 Nov 2023 02:22:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 69FF36B045F; Tue, 21 Nov 2023 02:22:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51A406B0460; Tue, 21 Nov 2023 02:22:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3C53A6B045C for ; Tue, 21 Nov 2023 02:22:59 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1AE77B5B49 for ; Tue, 21 Nov 2023 07:22:59 +0000 (UTC) X-FDA: 81481119678.16.ED4D05C Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf17.hostedemail.com (Postfix) with ESMTP id D3E994000B for ; Tue, 21 Nov 2023 07:22:56 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mMNLUTLR; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of arnd@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=arnd@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700551377; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kR6RvNYBq7ncv1XC8Md/QRQP6Vi7+ciyP1tD9dczobk=; b=JeoouxhcJ9Bij7hTDOJg7ifT9WoKjoTIQmBl+9sBpwtphPBp5po/Q/MLB7I3vJ80qL4QzS 0xsGUksGbjsfoxTVT4CiKW1vtQkHLaycTGhx7RnE8IeTd4JETVvG3Jx1D1Eyh+Hu/HstCn tlvshm7MMXmxRa/Y17Qt/W9gaOkwuuA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mMNLUTLR; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of arnd@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=arnd@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700551377; a=rsa-sha256; cv=none; b=IsH2WyrJKvPIMmb2lAdRYgyVSJjSHHiloqCBlUv93XR8DNaDcH653U1MXr17WKl+n7u/kN dbTmku00AVLD3mh6pZ61f0gLdGKSKcmJWmtN5TKIrPEOyhsdQncHH/dOQRrBOVLyYgNATa s0WsgkwSNrpZe/ORStXiferdnisX8R0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 40552B81055; Tue, 21 Nov 2023 07:22:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07515C433C8; Tue, 21 Nov 2023 07:22:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700551374; bh=rTUDuCw0+yacO1VkcLXeIh3RHyma9O/gexWOtY1atkE=; h=In-Reply-To:References:Date:From:To:Cc:Subject:From; b=mMNLUTLRp90G0p8qEBvndw7PFpfeyjlIgQ4HzPyhnjy1/62WeS+GNT4Iyn2aMsOrk JPFDHLAkbNzPeK9d41gITvmH8sUo7y62gvpS81jfH7NVZJSGe5h/mRQU6XW7xaxmCS TwhO/fvRchxY0+okPLx+/yvEJyKL5U7Wogicmj6zoMKlisrhLDHZh8gGWm8zb5LMdm X2aPuSgPYuSYlJn9pBg6AgvOmi+8fMeXAcD5XnMvkoOiXaHDQp1tnxuIof+cpWqDNB kSa/xPOwxKA5i4MBAXUQWz+ACx9BTCDdmCMgcVVTqKXfqI+2TuG6R76+OogI3OWeA5 iDJDo+ZlEz+5Q== Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailauth.nyi.internal (Postfix) with ESMTP id DF16A27C0054; Tue, 21 Nov 2023 02:22:52 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Tue, 21 Nov 2023 02:22:52 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudegkedguddthecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugeskhgvrhhnvghlrdhorhhgqeenucggtf frrghtthgvrhhnpeelvefgudeiheefledttedthfffgfekudegkeelffdtiedvgfevieet teekheffveenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhguodhmvghsmhhtphgruhht hhhpvghrshhonhgrlhhithihqdduvdekhedujedtvdegqddvkeejtddtvdeigedqrghrnh gupeepkhgvrhhnvghlrdhorhhgsegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i36794607:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 6A5E6B60089; Tue, 21 Nov 2023 02:22:50 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1178-geeaf0069a7-fm-20231114.001-geeaf0069 MIME-Version: 1.0 Message-Id: <7f16795c-ec35-4fe5-86e7-6fb36b05cfc5@app.fastmail.com> In-Reply-To: <202311211441.4LgOiu32-lkp@intel.com> References: <20231120215945.52027-3-pstanner@redhat.com> <202311211441.4LgOiu32-lkp@intel.com> Date: Tue, 21 Nov 2023 08:22:29 +0100 From: "Arnd Bergmann" To: "kernel test robot" , "Philipp Stanner" , "Bjorn Helgaas" , "Andrew Morton" , "Randy Dunlap" , "Jason Gunthorpe" , "Eric Auger" , "Kent Overstreet" , "Niklas Schnelle" , "Neil Brown" , "John Sanpe" , "Dave Jiang" , "Yury Norov" , "Kees Cook" , "Masami Hiramatsu" , "David Gow" , "Herbert Xu" , "Thomas Gleixner" , "wuqiang.matt" , "Jason Baron" , "Ben Dooks" , "Danilo Krummrich" Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, "Linux Memory Management List" , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 1/4] lib: move pci_iomap.c to drivers/pci/ Content-Type: text/plain X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D3E994000B X-Stat-Signature: 5ouiupb5ui9t1ipzuqwom7tgjrxmeeob X-Rspam-User: X-HE-Tag: 1700551376-185371 X-HE-Meta: U2FsdGVkX19V+OsaDLQTsiG1xkCnaGD+QeNKyz+K3Aw7QDgFb240VrJFbVlQ2GWCnUZoSNBLozXmZgMi/YfzsLbJjU3Iy6ZThNO9zHcaUxf04p90JprJMZgOOU3OInJHw2sJO8vfk7BUvBCLHyp2nbWXMBFjurRTUZII2/QNs8M9iR4BXZ1ysLhTrFQOv0EgCevn5o/SPBD7t80PdiIkhOQzq4JiAd4rqQ1lutVvK0ky41FgOr2X4O2RPn73tIq0M+xFWLLM61II3e7PnffYTZUf3RTK0uNH9wkB/KGMQUNE9wwYUWAAdRzSMUGKbVF/usmtfeqrydsmlOCdn1GUcB1KPpjYwWTslHPWdDQgtkb6rQORfrmueRjqtC2b+u8lm10orGNZgQv+V+0tEe2E9+wLWoXCGyL0zz+jR8jScQ4m3UI/0DdAmVTqR42tImIAbnhDiNj47Or5VhTUGxTVQdOqcnqYa/6u0VMUbk9D14bKg6Z4lkvX2FJo/VZ8+hqv6odypcSD/LdSGzIAgS5XN49cFFYMaDh8bdJv2HR351+gkz1AS4J2DFt7x6B2nG6oySOznTr7go6UV3XWqZ2L516WD3ZsaUyDSfPsg4caB4F9FZc0HGiJc4w+qlec7Pal3zTgLDQgc4ArU26pA7w33cOP0wWOpTt3hUmaOZnaUTmb2Teiac/mGZsH0qSo7lW6EiSQOXll5ZKxooHHkyyONVVulaFt758V+1Zojao8L7v4+2ko0zyLnYl5osk8Kt7n/4YvHTz0r/vOST3Q8VD9ATaGZMinGEOcdTALX/OfDztfarSbSG9ZcoN2O1vQi+uabczRVB/cmo3U6Ci+RcLzeZF8nVTT6uuoYXBHfOOKST31oysLouXLaceoRLtwnvFSvF2w3Rc2Vh1QDdmHN76EkFI/Rw4B+HjtLJ10rGeVohUXKPaLDtWK9f1iv1S7+zDjY/S0aaDEor4MmXa86Pg ozc3USbs K1I7ViVNQ+eS0JGyH+STkharY+HZMXo02j6PcEvlCzdr+M84Otal1w0pkokxpZjDBKywV+Kf3/us8hpyOqcUFaZXeEnzeu04d6cEeWAiAQYG3POKYgBfJT6GwNwZwMilZYUa74rM3QYlYONmxwnWMTdPBRlEmJCLzaTRFQ58hcM5fUYGpGALPgjqDZyrQIdhYf2JW2p+XJQVF3+oy7d/9TgzHP/Iag4op3fRRi9ZIyFFCZa71ILa4XM4mn+Du8VtBMqdaMBeV0Ud+DNbb46iAsr9m9CXzufAb/1QRg1yuEVWU6Gd87V6I8uxpqUg2vt+XUCGxvdY4J6vpQxGun9MYLDWS1GOuXWvXJ31nNoc9Zv5WcgI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 21, 2023, at 07:48, kernel test robot wrote: > > If you fix the issue in a separate patch/commit (i.e. not just a new > version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: > https://lore.kernel.org/oe-kbuild-all/202311211441.4LgOiu32-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > drivers/pci/iomap.c:27:15: error: redefinition of 'pci_iomap_range' > void __iomem *pci_iomap_range(struct pci_dev *dev, > ^ > include/asm-generic/pci_iomap.h:44:29: note: previous definition is here > static inline void __iomem *pci_iomap_range(struct pci_dev *dev, int bar, > ^ >>> drivers/pci/iomap.c:43:10: error: call to undeclared function '__pci_ioport_map'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > return __pci_ioport_map(dev, start, len); >From what I can tell looking at the header, I think we can just remove the "#elif defined(CONFIG_GENERIC_PCI_IOMAP)" bit entirely, as it no longer serves the purpose it originally had. It also looks like s390 is the only architecture that actually uses a custom implementation of pci_iomap*(), and this already has #define pci_iomap pci_iomap #define pci_iomap_range pci_iomap_range #define pci_iounmap pci_iounmap #define pci_iomap_wc pci_iomap_wc #define pci_iomap_wc_range pci_iomap_wc_range so the entire CONFIG_GENERIC_PCI_IOMAP symbol can probably be replaced with individual checks here, using CONFIG_PCI as the conditional in the Makefile. Arnd