From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEDF1C369AB for ; Tue, 15 Apr 2025 10:00:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B05AC2800C2; Tue, 15 Apr 2025 06:00:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB4022800BE; Tue, 15 Apr 2025 06:00:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DFD92800C2; Tue, 15 Apr 2025 06:00:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6C6352800BE for ; Tue, 15 Apr 2025 06:00:42 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5F9541CC86A for ; Tue, 15 Apr 2025 10:00:42 +0000 (UTC) X-FDA: 83335833924.02.A61C0FA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id DD7F420015 for ; Tue, 15 Apr 2025 10:00:39 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=THRww4Nj; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744711240; a=rsa-sha256; cv=none; b=AH9jRs+fNJ3z+02lZuopq1wqC+pKn79dD5L9k6P9jkEeNYcl/0/V5GHoENELKcrUZAiXw5 +lGPnWq9qMUnZD9OrByIefD0r1YeVk+ep/GTEpaH22tTZ3MSmXvsZMe0l4cJhDOLO5zcc8 ssq72AGhNU73i/08Iibpc7m7kl3OZWE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=THRww4Nj; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744711240; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7mAeOW/b2ubB4qNjTwwEbjGSRwZqSyZVqpozBB+ugwA=; b=uz+d/sxr+pWRS+mgfw2iGfMMfhyqRPMbH2rGHRNnMQ7kN8euXM8eOrmJb9EvmrX2SjBR2H AhN6BNyUc481XyscUaIit6c43TOwSPxbATLu++HKjkgXeFi+H34q+/70rw7/aJiZKAl29a ExIK02aAl+QulTOp5/VTuBQhPgNciz8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744711239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7mAeOW/b2ubB4qNjTwwEbjGSRwZqSyZVqpozBB+ugwA=; b=THRww4Nj4tv0fnOkPkVT0g0YWbeWYSOxCh/1Bp8ZWozycSAKYeyBg6jE/1PaSMqepgI1Z8 XW0PL/ffbaMyVQh4jUHr+C2dMEhHPO1h6ZxPpFQux8UCFqe3tHOEjeYBqAdpiyF49ILRxw XGgrPb4UxAdUqHo3yJtPK/djKMJHSsU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-167-7UOzrEL7PHCuhpFxE38ElA-1; Tue, 15 Apr 2025 06:00:37 -0400 X-MC-Unique: 7UOzrEL7PHCuhpFxE38ElA-1 X-Mimecast-MFC-AGG-ID: 7UOzrEL7PHCuhpFxE38ElA_1744711237 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43d51bd9b41so42192315e9.3 for ; Tue, 15 Apr 2025 03:00:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744711237; x=1745316037; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7mAeOW/b2ubB4qNjTwwEbjGSRwZqSyZVqpozBB+ugwA=; b=ABdYA0hEX1XfQyO1p/RCqDCozE4mKzyceWvrT/D1Y4K0AE706RkWmZAjHZ8XK+fmHm T7N5pzBBnp0CEWiuS/YSiMaSNrqwugQvtnZ4H0xR31KWqpnDRXaHrSfLqYTDGXl4nwzI WAgS9H9FEXITYVcfYm69B0prAbGckL6tSkvVBwZz8UtLjwi/V+UXdC/h+xKTjMckdUlB WdDStAfNab6qBwXuegmNHX9qMt5WF/s3aLwm0/kptnmZNnS6qBaCg8M5GCUdu3aQe+Q5 D3EPrJAl1nY4cVkT+1NT6UxWcQB5+bFrtnJlxujRi/N/Xm+IOJjWfYQarKqme3bh2LRT Nh0A== X-Forwarded-Encrypted: i=1; AJvYcCWFTb88NeQns6PTojrDanXIdNNgQEVCS62bpjpspZSl6r7ORvqSOyNGHGXf5qQjRlMik7li21Jsrw==@kvack.org X-Gm-Message-State: AOJu0YwJti852u04WLtOB9iMqAnYiYibe3kJct5dTSQkt4Xg+xJ9jvPZ ktjwGQUijDLbgB1b4NKsPDIAi5QgCTiCg6FEPgb8nF4l8pizARUksnYfO5zUyx+9xr0IXbboi1D PgU1SLsyxKtbEQFbZ4SfCom5HbXyXziflqjm8lqOZIpr1/UzG X-Gm-Gg: ASbGnctsyniDQarulOO+TmUMR2Y842XefscSU7dc5P8NA7T90Tj4bCMrCMmka95mbZS gJpqm7M0+VQq9nw2ZaPPUnIm1hgxyGFZCq8qCMsFVGhhmMhiPXqiHMGLafm5Q2TkxuWMEau31cQ EtUJQ/ta3Z/z/gxd68Xa47b/aM8k9xP5mNOgIbPT6B1ANIUKJHvhKqd7FIPBMac/o5kUB7YISjR mGrJ3clv/jkH2JzON9jFVv+TM1h+tHfwXdvlV/K21xhYrjVlTA1UU33d1XFRCbKfVInzoFrn+53 3WkB5p3CFJZTqwO/ebxqkVyClrOm+epddOVFOkhSM9onOPqz9jLcbJZQjGcPBVbQCk2Qs643CYw rjF1In8D3eHe13FieOKYbUEQ2L7O4I5A1nH7MvQ== X-Received: by 2002:a05:600c:3113:b0:43c:fe5e:f03b with SMTP id 5b1f17b1804b1-43f3a9b5acdmr143132915e9.30.1744711236759; Tue, 15 Apr 2025 03:00:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFua0RrMbLY9ixZJsGuyoUtI/FvxeaQUjCr3cFk2q+7C5IW0Bap/mKr+ZFuPq527qax9dAqAg== X-Received: by 2002:a05:600c:3113:b0:43c:fe5e:f03b with SMTP id 5b1f17b1804b1-43f3a9b5acdmr143132505e9.30.1744711236329; Tue, 15 Apr 2025 03:00:36 -0700 (PDT) Received: from ?IPV6:2003:d8:2f02:2900:f54f:bad7:c5f4:9404? (p200300d82f022900f54fbad7c5f49404.dip0.t-ipconnect.de. [2003:d8:2f02:2900:f54f:bad7:c5f4:9404]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f2075fc78sm207798535e9.27.2025.04.15.03.00.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Apr 2025 03:00:35 -0700 (PDT) Message-ID: <7ef1f10e-b835-4cd6-be82-0c92412e2ecf@redhat.com> Date: Tue, 15 Apr 2025 12:00:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 1/2] mm: skip folio reclaim in legacy memcg contexts for deadlockable mappings To: Joanne Koong , miklos@szeredi.hu, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Cc: jefflexu@linux.alibaba.com, shakeel.butt@linux.dev, bernd.schubert@fastmail.fm, ziy@nvidia.com, jlayton@kernel.org, kernel-team@meta.com, Miklos Szeredi References: <20250414222210.3995795-1-joannelkoong@gmail.com> <20250414222210.3995795-2-joannelkoong@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250414222210.3995795-2-joannelkoong@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jx59Q0o1V5j37IsPYK46ZNYlrjANS0Y7gs902Tht0v0_1744711237 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DD7F420015 X-Stat-Signature: 7775r9zmwdtu6qj47mi9ye4ekfima45t X-HE-Tag: 1744711239-452399 X-HE-Meta: U2FsdGVkX18VKWPEvKaVbAQMdj4u3hCF88JFj2bGr/WRU2IFq+3kgENTC8PKVFJRaTga2tjUgyAQYOlOe9UMge3O9PuaF51xbvR+F/uz2EbS2HHYW1ZYBkOdz43Hrq6u1hK0x7BiRZuV6mrgoSnmts/s8yMoZrQXQZ2RptyCog3jocaIEih1Vrpgpqx+YiMcDQ830G6hNBfn6aO8zwdDaIn/NAITa1dG2iIP+3YMhNjoa4v0Q4NikC0HGIQPLcwCk8YVy4gNiubt5g8e48DkkOuX2cvDblQwRkYHdd23KO96LmQDPQuOm+w8l3wYIND9P61qz/r35sQ9mIsZLrlA1GWJ7uN0hFucfSeP2ZLQjOfDOrle6VKnY8lJke4/uvKPBD+aIyU+pkJUJTzbjzOcCcNVkOb0IdUPGN9GyXK2Xb/WmAqBHXzp5s3AHWRssm/WBws3+VN+oDyXwz5Ac60KmqJzD26VDHvzRVr1FYww/qwyPGo47+tzbAz96E1/neGFJ0aCUkxPV7Dva3vNat3bJwNohLdgE+hCSfJXtQJxFyUbw5qU5Gccflu8ZPdaU901KN+6bTEohuclEWh5M+ZgBbZrr2pMAypcXjFge+Kkuxd8cGFCfJf6yQkgCCcdmgRRmlJdz1mNcjxeltithWMzWm2ZtQ0IdTv0ChjcKWZtFsK7ykoazS8iOHp+4Gb3dn7YW798jyrwotoZCWFa7mot1q48E6kNJ1b1ttfW3RYNVvbsZLq3MCWRPam9dzCJXuiaadcpZkpT/63TPZnd0rHFrh6UQdBWs1alPE0lgoy/OA8tcUo77MNLnRH/8woDNsq7c/Jz0bSTIazhm40hujSo0ZaJLSiTArRIH5fP6Rx/uN+Grd2ChqTCMLkHQ0d1bqNt2lWMwWcJ5G3EXsB3YhYmGBG/knF+f3rMA7Hrn/BUvgiJBTW7/27UabgHmcK/wU6w8bJjeBMt+ZBMC+L3ET5 5hazVPyb QzM5X48EAIzo4wP+fUg0fKIwG6lCH5mcVQCLWa58fSBONPGk3pdKbOTdW0L9+vNO3Qf6E6gishG7tEyo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > /* Case 1 above */ > if (current_is_kswapd() && > folio_test_reclaim(folio) && > @@ -1201,7 +1205,9 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, > /* Case 2 above */ > } else if (writeback_throttling_sane(sc) || > !folio_test_reclaim(folio) || > - !may_enter_fs(folio, sc->gfp_mask)) { > + !may_enter_fs(folio, sc->gfp_mask) || > + (mapping && > + mapping_writeback_may_deadlock_on_reclaim(mapping))) { Nit: Would have put that into a single line (we can exceed 80c where reasonable) Thanks! Acked-by: David Hildenbrand -- Cheers, David / dhildenb