From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: zhong jiang <zhongjiang@huawei.com>, Michal Hocko <mhocko@suse.cz>
Cc: akpm@linux-foundation.org, vbabka@suse.cz, rientjes@google.com,
linux-mm@kvack.org, Xishi Qiu <qiuxishi@huawei.com>,
Hanjun Guo <guohanjun@huawei.com>,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH] mm: fix oom work when memory is under pressure
Date: Wed, 14 Sep 2016 20:29:56 +0900 [thread overview]
Message-ID: <7edef3e0-b7cd-426a-5ed7-b1dad822733a@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <57D91771.9050108@huawei.com>
On 2016/09/14 18:25, zhong jiang wrote:
> On 2016/9/14 16:52, Michal Hocko wrote:
>> On Wed 14-09-16 10:42:19, Michal Hocko wrote:
>>> [Let's CC Hugh]
>> now for real...
>>
>>> On Wed 14-09-16 15:13:50, zhong jiang wrote:
>>> [...]
>>>> hi, Michal
>>>>
>>>> Recently, I hit the same issue when run a OOM case of the LTP and ksm enable.
>>>>
>>>> [ 601.937145] Call trace:
>>>> [ 601.939600] [<ffffffc000086a88>] __switch_to+0x74/0x8c
>>>> [ 601.944760] [<ffffffc000a1bae0>] __schedule+0x23c/0x7bc
>>>> [ 601.950007] [<ffffffc000a1c09c>] schedule+0x3c/0x94
>>>> [ 601.954907] [<ffffffc000a1eb84>] rwsem_down_write_failed+0x214/0x350
>>>> [ 601.961289] [<ffffffc000a1e32c>] down_write+0x64/0x80
>>>> [ 601.966363] [<ffffffc00021f794>] __ksm_exit+0x90/0x19c
>>>> [ 601.971523] [<ffffffc0000be650>] mmput+0x118/0x11c
>>>> [ 601.976335] [<ffffffc0000c3ec4>] do_exit+0x2dc/0xa74
>>>> [ 601.981321] [<ffffffc0000c46f8>] do_group_exit+0x4c/0xe4
>>>> [ 601.986656] [<ffffffc0000d0f34>] get_signal+0x444/0x5e0
>>>> [ 601.991904] [<ffffffc000089fcc>] do_signal+0x1d8/0x450
>>>> [ 601.997065] [<ffffffc00008a35c>] do_notify_resume+0x70/0x78
Please be sure to include exact kernel version (e.g. "uname -r",
"cat /proc/version") when reporting.
You are reporting a bug in 4.1-stable kernel, which was prone to
OOM livelock because the OOM reaper is not available.
( http://lkml.kernel.org/r/57D8012F.7080508@huawei.com )
I think we no longer can reproduce this bug using 4.8-rc6 (or linux-next),
but it will be a nice thing to backport __GFP_NORETRY patch to stable
kernels which do not have the OOM reaper.
> Adding the __GFP_NORETRY, the issue also can fixed.
> Therefore, we can assure that the case of LTP will leads to the endless looping.
>
> index d45a0a1..03fb67b 100644
> --- a/mm/ksm.c
> +++ b/mm/ksm.c
> @@ -283,7 +283,7 @@ static inline struct rmap_item *alloc_rmap_item(void)
> {
> struct rmap_item *rmap_item;
>
> - rmap_item = kmem_cache_zalloc(rmap_item_cache, GFP_KERNEL);
> + rmap_item = kmem_cache_zalloc(rmap_item_cache, GFP_KERNEL | __GFP_NORETRY);
> if (rmap_item)
> ksm_rmap_items++;
> return rmap_item;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-09-14 11:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 14:47 zhongjiang
2016-09-09 11:44 ` Michal Hocko
2016-09-12 9:51 ` zhong jiang
2016-09-12 11:13 ` Michal Hocko
2016-09-12 13:42 ` zhong jiang
2016-09-12 17:44 ` Michal Hocko
2016-09-13 13:13 ` zhong jiang
2016-09-13 13:28 ` Michal Hocko
2016-09-13 14:01 ` zhong jiang
2016-09-14 7:13 ` zhong jiang
2016-09-14 8:42 ` Michal Hocko
2016-09-14 8:50 ` zhong jiang
2016-09-14 9:05 ` Michal Hocko
2016-09-14 8:52 ` Michal Hocko
2016-09-14 9:25 ` zhong jiang
2016-09-14 11:29 ` Tetsuo Handa [this message]
2016-09-14 13:52 ` zhong jiang
2016-09-18 6:00 ` Tetsuo Handa
2016-09-18 6:13 ` Tetsuo Handa
2016-09-19 4:44 ` zhong jiang
2016-09-19 7:15 ` zhong jiang
2016-09-16 22:13 ` Hugh Dickins
2016-09-17 15:56 ` Michal Hocko
2016-09-18 4:04 ` zhong jiang
2016-09-18 14:42 ` Michal Hocko
2016-09-19 17:27 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7edef3e0-b7cd-426a-5ed7-b1dad822733a@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=akpm@linux-foundation.org \
--cc=guohanjun@huawei.com \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=qiuxishi@huawei.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox