From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE82DECAAD1 for ; Wed, 31 Aug 2022 16:16:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56DC78D0001; Wed, 31 Aug 2022 12:16:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51D866B0072; Wed, 31 Aug 2022 12:16:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E47A8D0001; Wed, 31 Aug 2022 12:16:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 306426B0071 for ; Wed, 31 Aug 2022 12:16:22 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 00FC4160489 for ; Wed, 31 Aug 2022 16:16:21 +0000 (UTC) X-FDA: 79860390162.06.2C82220 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf11.hostedemail.com (Postfix) with ESMTP id C63CD40027 for ; Wed, 31 Aug 2022 16:16:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4836A1F8B5; Wed, 31 Aug 2022 16:16:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1661962578; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o6HPf2L5K/Lf19WA17JOPqDvb/Xtjl8d0vphRCxEgqI=; b=zBDQYaA+l+/TSuNHSYDCGhMJeYAFsYzeqxQ7P4uK9gALDZVcjidqlp5NjAS4qezgONMpkb PkV5Im0Jxa/iiLo+EIeFTyxZSFBupNAP2wPRf/gPObtELbuYLipZWPacfgPBMdpMHvMOIf Qdr0vrxXRoMrBby/EK4eG2n9qnkWTUc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1661962578; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o6HPf2L5K/Lf19WA17JOPqDvb/Xtjl8d0vphRCxEgqI=; b=SuTDp3IjI5FO8HxfMs/7Unxrl96d2zzzFOerZDDbxtcgDG3/6AgGOHZGiuW7+iimP8GWWC tdElo8fMERSsnPCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 191041332D; Wed, 31 Aug 2022 16:16:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id J35VBVKJD2O8AQAAMHmgww (envelope-from ); Wed, 31 Aug 2022 16:16:18 +0000 Message-ID: <7edc9d38-da50-21c8-ea79-f003f386c29b@suse.cz> Date: Wed, 31 Aug 2022 18:16:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH -next] mm: kence: add __kmem_cache_free to function skip list To: Marco Elver , Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Feng Tang , Andrew Morton , Alexander Potapenko , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-mm@kvack.org References: <20220831073051.3032-1-feng.tang@intel.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zBDQYaA+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=SuTDp3Ij; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661962580; a=rsa-sha256; cv=none; b=G8N881O2rRtklambUypMvJ2qS7cAq7eHC/lU1ZpEv6gP+ssDKW+Iwo/MhQCiYKEjmi5BFq UFVe0ABsc5wGBIXQntqRD+2DbexKcyZADuBfRMAZ3alc8Z99MT7ZHARO1hYak9j0HKHhCW A3by5x4Wy0Fx6I7CHh7FXCNDkB2kEEc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661962580; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o6HPf2L5K/Lf19WA17JOPqDvb/Xtjl8d0vphRCxEgqI=; b=kAcy15foRw+PUrrcLT3GR3z1S4unjCoVjsEPsMjK1nuZ8zziKQz7LV4rvNKfiH46unUhuI pUOPnQQjQgYknHlm7Pbc6O0W/ywGzEc1C/IqB9CzfTX4oQKqJVaNf4bhqbPr6K5IiHhBb8 2G2C1VDxTIRVXzr/ePRv8Rq2CU0zbRw= X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zBDQYaA+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=SuTDp3Ij; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C63CD40027 X-Stat-Signature: chtumyyo8ny5ohjn3c751r654n5pjz45 X-HE-Tag: 1661962579-20168 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/31/22 16:21, Marco Elver wrote: > On Wed, 31 Aug 2022 at 16:04, Hyeonggon Yoo <42.hyeyoo@gmail.com> wrote: > >> Maybe you can include those functions too? >> >> - __kmem_cache_alloc_node >> - kmalloc_[node_]trace, kmalloc_large[_node] > > This is only required if they are allocator "root" functions when > entering allocator code (or may be tail called by a allocator "root" > function). Because get_stack_skipnr() looks for one of the listed > function prefixes in the whole stack trace. > > The reason __kmem_cache_free() is now required is because it is tail > called by kfree() which disappears from the stack trace if the > compiler does tail-call-optimization. I checked and I have this jmp tail call, yet all test pass here. But I assume the right commit to amend is 05a1c2e50809 ("mm/sl[au]b: generalize kmalloc subsystem") Could you Feng maybe verify that that commit is the first that fails the tests, and parent commit of that is OK? Thanks.