From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F949C3DA59 for ; Tue, 16 Jul 2024 01:19:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2A426B0085; Mon, 15 Jul 2024 21:19:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD9246B0088; Mon, 15 Jul 2024 21:19:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA0F56B0089; Mon, 15 Jul 2024 21:19:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A9FB96B0085 for ; Mon, 15 Jul 2024 21:19:40 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 251F712162D for ; Tue, 16 Jul 2024 01:19:40 +0000 (UTC) X-FDA: 82343858520.22.6EA7268 Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) by imf24.hostedemail.com (Postfix) with ESMTP id EC65218000F for ; Tue, 16 Jul 2024 01:19:36 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=cr0h4GhR; spf=pass (imf24.hostedemail.com: domain of joseph.qi@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=joseph.qi@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721092739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xec8Q/X1EdPBny7ED667Auisr/10A9HW03C61vOQHzQ=; b=hxizEge+ks907RLRl6b2+DvlWw2rkAnmz9gFuh/QmbqB4bmFozYJslOmfF6VS8wk7uECg9 JxHimC8xhFQVxwYkz9E0ax3VaMlLnS/M1nbuS8GsEEiHGblGKy5QApnV8Mst9zKNk4IeC8 klAtVYsCVzwJaZ7LveiY9/z/xBAN6pQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721092739; a=rsa-sha256; cv=none; b=M9cU+zjdV3nfVEQux1bHNyo0cggoVx3oU6KqhH5dayW4jAawsED5OLi8xkjbeB9jX5pjx3 VtrVLjD2oPmnk7o2DlXHGYS5bPiyf2CpzzboyNCGFjjeQJNCHYjFiqlX+QDDEAuCh8ctGd ruaUgYZHp2S0WSuHL80W1OagF8Z2mL4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=cr0h4GhR; spf=pass (imf24.hostedemail.com: domain of joseph.qi@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=joseph.qi@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1721092773; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=Xec8Q/X1EdPBny7ED667Auisr/10A9HW03C61vOQHzQ=; b=cr0h4GhRkjOKvTBKDtLKs5wQoVKOFiH+rwpvtWGaSjz3s8K8esEI+IFxvxA5ycSy/WPxBSwBIK1MEO4FeqhXm1OvN55vR/UcJJxk7Q0CUrovKsT9qBuBlPhD3MBYZkgXnLRFtOJhntGy8fc7WqIFxv9R7x0vt5LP/zodNIFFGAs= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R721e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067112;MF=joseph.qi@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0WAfQXmk_1721092771; Received: from 30.221.128.129(mailfrom:joseph.qi@linux.alibaba.com fp:SMTPD_---0WAfQXmk_1721092771) by smtp.aliyun-inc.com; Tue, 16 Jul 2024 09:19:32 +0800 Message-ID: <7ed24ac3-73ad-4cd0-ba27-c4e8098c5830@linux.alibaba.com> Date: Tue, 16 Jul 2024 09:19:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] quota: remove unneeded return value of register_quota_format To: Kemeng Shi , jack@suse.com Cc: mark@fasheh.com, jlbec@evilplan.org, hughd@google.com, akpm@linux-foundation.org, ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240715130534.2112678-1-shikemeng@huaweicloud.com> <20240715130534.2112678-3-shikemeng@huaweicloud.com> Content-Language: en-US From: Joseph Qi In-Reply-To: <20240715130534.2112678-3-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: rrom6dkr3fz754jws8wd615mwrehqxy5 X-Rspamd-Queue-Id: EC65218000F X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721092776-12417 X-HE-Meta: U2FsdGVkX19NMKzIbDdNEXFD9vb/bScosL3gzNEjCwm+uyxk5xTDOg5hfugo0rGZ/Bi3HWwJ878JStdm4pEQpihMISsL+o90T0Jv8pr4auH1w1YvP0pKG+n1cQwFL6jQ1PWIXHrean+nHo5T6FQeo4O4Gz/mDF8W9jIav57750Lupr+6YHV0/z49llj94CiBhzRJB81kwT/+1ZqdH/+jlDJI5WxPCK/eCiY7LKEoDMwoMDi0xML64oiKDG/xoFeJSkxDV5txnDcJ8C9sI2LdkBvLZftpja9rwETP7dDv3j89jklzhQAWazRirBGeaSdU1Q3i+pTRWUTRL1sPr5eXaOzA6NDBoAlKnDSGjcKd36ry0twb2M+IfY7dxTAaxrb31fHMd0FiPinrioLmgFguURLDRi1ICztJaNkdLREnnPscv4kbqS0gY/vRo2qyFH/DqdY2hTAp+u9bkdQTooK5hpgO9bpk/3sr49sT7dIeT/+hyUoVIkE/LW4f99d1VDjChsGsScKuq2+OJ8FcvAS0hxeYZ0MR0wJW9JRcl5mAcmxA0++aecLCZHjyjmfUNsYODTLoJYX2iNbcZ3T+rBAHNyITLIB63TvSAC5+RDyAJzlK8GimyDz6K5vdD+iuPof4v9CgI9LyO7G76DJNedv6hxsRmKs7dBaI08HcD3Z21F7+dSOu7D/b+jmJ6h90ZOVZ/GmMWZJcYg/5NYE7arUF2MgwRr8gGoSpH8uX/iLqFRxZcNtBAdr/ZMdUFqkVdvYp/PwZakAjpEQD05inu1m36jHweUzlUAlPzdHvdu+0cGk+X+FkI84sGHUgqjoFd9sQPFNl+ZMaSvH8cAASjPhCGbwIi6HsAomTrWfTdwIwNfDKAAwV+r8B3OzDWqq7p72nW+4ONw95yvQmpzJMTkqJS2hL9STV2z8IAb6sPzOTB8aKxeeVl6zgcDjqTmJWCHxuS7Y8mkImNoJr4XQ9TbZ lMeBGph4 Qt4LTDp32MibezMis6wmMFmWJyXyzaAsErpnbMyBI6luKRY2a6EV+/DgkugQ9ijTB51L6SF+cP6+icFi/il9/f0nKTTc0xW/q4fyiyxb+0ApmqC9Q2VqxTHMfo4qUOKV8rkPMtpn4CQcZCIJAix35Pyz2Vwrps9S1PpaX0Q915mTrfyP/tMOPEXCfVwigmf0iIRYgOfvwk9vxe8/D/s0B4xk6eNkBf3edLJrT/VAVG67NmQDiPtmlTInA20Vx5r08jTxto1nAZ5vEsLFeUczr4lzOPEExr9EfmntAbxAgp+l2x8dapvTzVDz1xQJ/sP57/WWz5lVu1B8Zeo6dDZaVVKxlZoUyt7BiopQX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Looks good. Reviewed-by: Joseph Qi On 7/15/24 9:05 PM, Kemeng Shi wrote: > The register_quota_format always returns 0, simply remove unneeded return > value. > > Signed-off-by: Kemeng Shi > --- > fs/ocfs2/super.c | 6 ++---- > fs/quota/dquot.c | 3 +-- > fs/quota/quota_v1.c | 3 ++- > fs/quota/quota_v2.c | 9 +++------ > include/linux/quota.h | 2 +- > mm/shmem.c | 7 +------ > 6 files changed, 10 insertions(+), 20 deletions(-) > > diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c > index afee70125ae3..73caa8914ebe 100644 > --- a/fs/ocfs2/super.c > +++ b/fs/ocfs2/super.c > @@ -1571,15 +1571,13 @@ static int __init ocfs2_init(void) > > ocfs2_set_locking_protocol(); > > - status = register_quota_format(&ocfs2_quota_format); > - if (status < 0) > - goto out3; > + register_quota_format(&ocfs2_quota_format); > + > status = register_filesystem(&ocfs2_fs_type); > if (!status) > return 0; > > unregister_quota_format(&ocfs2_quota_format); > -out3: > debugfs_remove(ocfs2_debugfs_root); > ocfs2_free_mem_caches(); > out2: > diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c > index 23fcf9e9d6c5..a08a71890cd8 100644 > --- a/fs/quota/dquot.c > +++ b/fs/quota/dquot.c > @@ -163,13 +163,12 @@ static struct quota_module_name module_names[] = INIT_QUOTA_MODULE_NAMES; > /* SLAB cache for dquot structures */ > static struct kmem_cache *dquot_cachep; > > -int register_quota_format(struct quota_format_type *fmt) > +void register_quota_format(struct quota_format_type *fmt) > { > spin_lock(&dq_list_lock); > fmt->qf_next = quota_formats; > quota_formats = fmt; > spin_unlock(&dq_list_lock); > - return 0; > } > EXPORT_SYMBOL(register_quota_format); > > diff --git a/fs/quota/quota_v1.c b/fs/quota/quota_v1.c > index 3f3e8acc05db..6f7f0b4afba9 100644 > --- a/fs/quota/quota_v1.c > +++ b/fs/quota/quota_v1.c > @@ -235,7 +235,8 @@ static struct quota_format_type v1_quota_format = { > > static int __init init_v1_quota_format(void) > { > - return register_quota_format(&v1_quota_format); > + register_quota_format(&v1_quota_format); > + return 0; > } > > static void __exit exit_v1_quota_format(void) > diff --git a/fs/quota/quota_v2.c b/fs/quota/quota_v2.c > index c48c233f3bef..1fda93dcbc1b 100644 > --- a/fs/quota/quota_v2.c > +++ b/fs/quota/quota_v2.c > @@ -440,12 +440,9 @@ static struct quota_format_type v2r1_quota_format = { > > static int __init init_v2_quota_format(void) > { > - int ret; > - > - ret = register_quota_format(&v2r0_quota_format); > - if (ret) > - return ret; > - return register_quota_format(&v2r1_quota_format); > + register_quota_format(&v2r0_quota_format); > + register_quota_format(&v2r1_quota_format); > + return 0; > } > > static void __exit exit_v2_quota_format(void) > diff --git a/include/linux/quota.h b/include/linux/quota.h > index 07071e64abf3..89a0d83ddad0 100644 > --- a/include/linux/quota.h > +++ b/include/linux/quota.h > @@ -526,7 +526,7 @@ struct quota_info { > const struct quota_format_ops *ops[MAXQUOTAS]; /* Operations for each type */ > }; > > -int register_quota_format(struct quota_format_type *fmt); > +void register_quota_format(struct quota_format_type *fmt); > void unregister_quota_format(struct quota_format_type *fmt); > > struct quota_module_name { > diff --git a/mm/shmem.c b/mm/shmem.c > index a8b181a63402..d27104e1af9b 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -4660,11 +4660,7 @@ void __init shmem_init(void) > shmem_init_inodecache(); > > #ifdef CONFIG_TMPFS_QUOTA > - error = register_quota_format(&shmem_quota_format); > - if (error < 0) { > - pr_err("Could not register quota format\n"); > - goto out3; > - } > + register_quota_format(&shmem_quota_format); > #endif > > error = register_filesystem(&shmem_fs_type); > @@ -4693,7 +4689,6 @@ void __init shmem_init(void) > out2: > #ifdef CONFIG_TMPFS_QUOTA > unregister_quota_format(&shmem_quota_format); > -out3: > #endif > shmem_destroy_inodecache(); > shm_mnt = ERR_PTR(error);