From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70AC3C43334 for ; Mon, 13 Jun 2022 03:27:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D72648D0148; Sun, 12 Jun 2022 23:27:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFAD98D0142; Sun, 12 Jun 2022 23:27:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B73B18D0148; Sun, 12 Jun 2022 23:27:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A24128D0142 for ; Sun, 12 Jun 2022 23:27:07 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7BD0934440 for ; Mon, 13 Jun 2022 03:27:07 +0000 (UTC) X-FDA: 79571776494.24.D928312 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf13.hostedemail.com (Postfix) with ESMTP id 617752007C for ; Mon, 13 Jun 2022 03:27:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655090825; x=1686626825; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=yQsTX5D9o+QT4TiAmxzoHdqWMATpMDAE+jjECvuubgs=; b=HI9be+zKCXcHKWfRiySfuRm9HH8ePU7iczDkT3Qci3y4SXSKe8+1F076 eJsx4fL5GE0EeN+8/AsWtADcaVQftGhI2WUOnC87nUu6opFXKM/vhPuj8 IW4ai0dqWQ4tJelQmL3xDm2MaJa4iXFcshngpxIph1Nbnkv2ao5nRD3Af ojURHcbDEDOM7xQarN2u3/XF+b8P5Wsb697J2zi+RioKz8NQ8LaDKgGcv anApErdm6TwUWp3vXh2KzUwZYl18mMa6LUyVuiwWQYuLhNXqgd6gH1azk uGXdm03ygH9y99J/O1squGiGqxGk7YpxIt0o+y3FEdtBkhcxU2fivi8uq A==; X-IronPort-AV: E=McAfee;i="6400,9594,10376"; a="279199318" X-IronPort-AV: E=Sophos;i="5.91,296,1647327600"; d="scan'208";a="279199318" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2022 20:27:03 -0700 X-IronPort-AV: E=Sophos;i="5.91,296,1647327600"; d="scan'208";a="611571882" Received: from xinyangc-mobl.ccr.corp.intel.com ([10.254.214.65]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2022 20:26:58 -0700 Message-ID: <7ed1f9f544937b5c82ab380a4977e5ae22a98c43.camel@intel.com> Subject: Re: [PATCH v6 03/13] mm/demotion: Return error on write to numa_demotion sysfs From: Ying Huang To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org Cc: Wei Xu , Greg Thelen , Yang Shi , Davidlohr Bueso , Tim C Chen , Brice Goglin , Michal Hocko , Linux Kernel Mailing List , Hesham Almatary , Dave Hansen , Jonathan Cameron , Alistair Popple , Dan Williams , Feng Tang , Jagdish Gediya , Baolin Wang , David Rientjes Date: Mon, 13 Jun 2022 11:26:55 +0800 In-Reply-To: <20220610135229.182859-4-aneesh.kumar@linux.ibm.com> References: <20220610135229.182859-1-aneesh.kumar@linux.ibm.com> <20220610135229.182859-4-aneesh.kumar@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655090825; a=rsa-sha256; cv=none; b=mNAWAabAHbz0nvLsBEekmbKuCfSoV+9oGScv1kS2fgYa0PK3tq75k+HTCfqXIcwc0IvRgI XCVXBfWG483S7kviIqU8tCxZOGUjkEtoBfmJh8uYQLftHj7CoSY8OMyXubIz4JrQmzlxNY b8fg8SLIMgX7pcdgk+oEo0yEzQc3+NA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HI9be+zK; spf=none (imf13.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655090825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SlIL1Fzm+TodKeVPga7nRSXc+hx28aMZihbrsDRXCs4=; b=nZwxWxRuMV00WN8TGFLYrvgbrU/ET1e3JBBptWe4XhoySsJtK9fYQk8l2exd+EcswMKg8f qtIQcAR9gcu3epuoQ9uNMzurS1Fq3t3rXb5QPcdsm9csZsMy03xtaAb3Qbg/VVZAwh7DQz DNwazGxVFugwDdB6gYCrCAkO95nD9VM= X-Rspamd-Queue-Id: 617752007C Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HI9be+zK; spf=none (imf13.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: bg1nhi8573i4qn6qtdpep9b3eqiz8f6y X-HE-Tag: 1655090825-56388 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2022-06-10 at 19:22 +0530, Aneesh Kumar K.V wrote: > With CONFIG_MIGRATION disabled return EINVAL on write. > > Signed-off-by: Aneesh Kumar K.V > --- >  mm/memory-tiers.c | 3 +++ >  1 file changed, 3 insertions(+) > > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index 9c6b40d7e0bf..c3123a457d90 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -105,6 +105,9 @@ static ssize_t numa_demotion_enabled_store(struct kobject *kobj, >  { >   ssize_t ret; >   > > + if (!IS_ENABLED(CONFIG_MIGRATION)) > + return -EINVAL; > + How about enclose numa_demotion_enabled_xxx related code with CONFIG_MIGRATION? >   ret = kstrtobool(buf, &numa_demotion_enabled); >   if (ret) >   return ret; Best Regards, Huang, Ying