From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65E16C46CD3 for ; Wed, 20 Dec 2023 09:43:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E85E66B0081; Wed, 20 Dec 2023 04:43:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E36336B0082; Wed, 20 Dec 2023 04:43:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D24F66B0083; Wed, 20 Dec 2023 04:43:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C2F946B0081 for ; Wed, 20 Dec 2023 04:43:03 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 95D8B809CC for ; Wed, 20 Dec 2023 09:43:03 +0000 (UTC) X-FDA: 81586707846.23.7746C97 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf25.hostedemail.com (Postfix) with ESMTP id 2C168A0014 for ; Wed, 20 Dec 2023 09:42:59 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703065381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QCCFmN/TrnXksC8NDo6RdczkIJnuvoOy3ov6xvWc8xw=; b=p+Ml5W5DibXsBZn17q7nfKKMLHyWnWc0Xya/y1i+3BXy40llDY4OK9+nD+UreXeo2o8qel 1g5Y8zQ1I6qcpw+ABCZ0TmP4QS7eq3FPa46GJRFLw3rHlQAEGRhp4ApqTbdLfLoIQeUi28 prAzswVvnWgvsW69RYsz0smXF0P/aZo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703065381; a=rsa-sha256; cv=none; b=dUPO0I7WqGTtf8EElxNSnqRJNK3Hg0sJVMKqQJQvdC1hFWAQozUAyw43J8v/PnIlm4vcTz FdHQ5Ggmk/XN3bJuNSErpU+g8C0bwF0UA6DBikEFGIc6AQTOwmurhirWqbxXrMMqoPbYvk RhYmXCxHV53KckzVaXYYvCpy9wcK3DQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0VyttMeo_1703065374; Received: from 30.97.48.56(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VyttMeo_1703065374) by smtp.aliyun-inc.com; Wed, 20 Dec 2023 17:42:55 +0800 Message-ID: <7ec7bbfd-41db-4a62-b58a-315ad244c0aa@linux.alibaba.com> Date: Wed, 20 Dec 2023 17:43:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: page_alloc: remove duplication of free_one_page() To: Kuan-Ying Lee , Andrew Morton , Matthias Brugger , AngeloGioacchino Del Regno Cc: casper.li@mediatek.com, chinwen.chang@mediatek.com, qun-wei.lin@mediatek.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20231220074757.3656-1-Kuan-Ying.Lee@mediatek.com> From: Baolin Wang In-Reply-To: <20231220074757.3656-1-Kuan-Ying.Lee@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2C168A0014 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ckx7x6ufsp43dw5cofmmf4utxx5y1cy9 X-HE-Tag: 1703065379-758626 X-HE-Meta: U2FsdGVkX1+ebXK8mzgmiDaQ0cVkqiJ8cjGtiFJdte0YD0L/SNHd21HHquh24Y7KISTPmDiA6sOMWgV39cAdu3oFryvxyftrn/b0cZBpJihNa0CBAuR+q/Gw+BE3PBzaXJGYMah7tTdKVtXsDD/dAM9HZMr0LsKrv3fhH2gGErFBybFPqjf9Vx4n2ykHDHGj0hQq0gKMtDAoPW/3zYusfuw7UwFt71O15LhTQzggThOeiLXw4sRcq+BApExKfz9xgHsmJNCkp8Wd78kZwwvCXb7lLCQB0cfsrwuhvIFQ0aBRgNlsihbDVLjxawBSbsJVkccQFBSpb0VjYe4EW2X4wFILzOVTUgb3QYeeAMynMAOCN37PP2zE7i8y/Z8T1i9FgfQeBK5m1cUeJY7vjHAGtBKmZGG89VKJBUp9pQdZosXAns1E/5F7XW8i6uCM2pQxtXmL8t6kBzY6JPNQUvx2VYKOJVlIr1V/m1RRPd7daLja4PU8JEmp1uvGUz6R0a+lzMM65Q/xrd7ay1Owd+sMOxmIm6d9mP3yHgHMDS7830NIXuodk4M9sCl63oIuqJ4DYdk2N6x/DFec8hjWsKuBANBCeG3t7Qal4yyvhPlKAcYKRML4iMRHdlIy5exG5NnZchkh22iK4O+kwshyU3pEvQ+Uj5ZECQro4f/YIWvMSWYZe/r2LiyTfKTJxosOtn9niRuVDJCboRJQ7qPoAx4Nzik9Au+FECQa3jmoEtHP2PzhC8XZPVOpIkNv6NcgiQcUMZirNPI9maqH80MEhiyLyE4eMHfH/DpPCxxkc8xsu+k0kPKVAiwS/9JvLfgC88rVfkUdLwJKIFZoj122wgcfAeD+ep9qm+6Te+wPfK4nITTCQGHu2Brn18gKQfHQb4PeD2t7D4GyE3L/reNU/ryDCgKCzbYt5FZdLjcPClS0y/bX2Wv1zrEHceyzgTooYKAap6Uyz7nn4m2WCQDeB6i rETPONu7 apuSsXQPRmzZXaC8mKUhp8IrMCO48SSygsKef7zNelW/r3nv/KcjiPT3puze6eTTe83SgU4e4A0OEKeqEaeCeniaBUnomvgsImPt1iPfe+2vFNCQQznCrPEL/noPMaHgf2mGZU54JbUu3kurUGAAbcbdiTiU1YFDOfSFYvbTRHrBoqU55n5KQYkLQ5UEw4HLsyeqV2ElusZRYddH/Qu8/3rkrfkLDS2mBpOAZWcQ8i2Q5LV7vJVRBkFtv/eMaasxfXiNvKHJmBodPeNntv2z0Sd96/h0HaIeNfFEeLSR2twYb1vIeCMNlpGSN25UaC4qmWLrLuSfNeqNVUtM5ydT6dMiqnreYoU30tKO6T9y7c9wGYbRDyYromuiGR4UOtOHrzEYuMHVpfQ1X4ZrJ1MWbAZv6DXm3KGy5NuXs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On 12/20/2023 3:47 PM, Kuan-Ying Lee wrote: > Remove duplication of free_one_page(). > > Cc: Casper Li > Signed-off-by: Kuan-Ying Lee Just FYI: There is already a same patch submitted, see: https://lore.kernel.org/all/20231216030503.2126130-1-yajun.deng@linux.dev/T/#u > --- > mm/page_alloc.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 2f646773a934..f46af8616cac 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1262,7 +1262,6 @@ static void free_one_page(struct zone *zone, > static void __free_pages_ok(struct page *page, unsigned int order, > fpi_t fpi_flags) > { > - unsigned long flags; > int migratetype; > unsigned long pfn = page_to_pfn(page); > struct zone *zone = page_zone(page); > @@ -1277,13 +1276,7 @@ static void __free_pages_ok(struct page *page, unsigned int order, > */ > migratetype = get_pfnblock_migratetype(page, pfn); > > - spin_lock_irqsave(&zone->lock, flags); > - if (unlikely(has_isolate_pageblock(zone) || > - is_migrate_isolate(migratetype))) { > - migratetype = get_pfnblock_migratetype(page, pfn); > - } > - __free_one_page(page, pfn, zone, order, migratetype, fpi_flags); > - spin_unlock_irqrestore(&zone->lock, flags); > + free_one_page(zone, page, pfn, order, migratetype, fpi_flags); > > __count_vm_events(PGFREE, 1 << order); > }