From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A397CC61DA4 for ; Thu, 2 Feb 2023 08:39:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FCA16B0071; Thu, 2 Feb 2023 03:39:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AD176B0072; Thu, 2 Feb 2023 03:39:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8F7E6B0073; Thu, 2 Feb 2023 03:39:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D92BC6B0071 for ; Thu, 2 Feb 2023 03:39:29 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AC0801C64E7 for ; Thu, 2 Feb 2023 08:39:29 +0000 (UTC) X-FDA: 80421702858.03.16AC9C0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 1926C40007 for ; Thu, 2 Feb 2023 08:39:26 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OGJrYQRj; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675327167; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cEmUWkILhjHwy32wJlP5ahEThJlPzKxbPpXUXtBpjW8=; b=TohfjFpP/WevepecIeimhwOhYz43r3AHFQfi/6kz2TgnWdCGen1J2ajrDHa6CBwr/4ZXai 2F36tO3+V76ZH/OlzxuDhXIA9+0cTzsq7CrxlCbF86SCucgsk9u+o/eyqls4LHKObz/GDe 4lQu8xbjTL08SaFTmtBTWlIUDq2AFFo= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OGJrYQRj; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675327167; a=rsa-sha256; cv=none; b=hcimYsYu7xZNjLiHi7wA6hJ4hMVhPIoMR9ps2pXn76gVNjFzBhcbQeQC2Qn+ENeT22x2q6 PntNWrFGZjKz57byxiM32TqT5xAgdjVbu5iiTY99MBkjBJuu+YR7vSmDu9PZSzkTWcBcGq dBdF3P6VXoTWHRuboqKnmE6c4xeq5xg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675327166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cEmUWkILhjHwy32wJlP5ahEThJlPzKxbPpXUXtBpjW8=; b=OGJrYQRjiPzR82ZOYbSRh86N0VkoguV3O8JR6weOUq27HfvLx+KqBs0DmX/cI5vK/vsfrH P05HrCFSbRjSb4yqU+WmlOSkow2HF8Pruvl6EFptir7cWaKNrTVt2tA8CcYVCV47p49HWn IZ1Tl26fxkdVTPZet7KPcfArXRub58s= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-247-HzrbjyZvNNWY9sVAKzBNFw-1; Thu, 02 Feb 2023 03:39:24 -0500 X-MC-Unique: HzrbjyZvNNWY9sVAKzBNFw-1 Received: by mail-wm1-f70.google.com with SMTP id j24-20020a05600c1c1800b003dc4480f7bdso2451665wms.5 for ; Thu, 02 Feb 2023 00:39:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cEmUWkILhjHwy32wJlP5ahEThJlPzKxbPpXUXtBpjW8=; b=DsDU2eFgXDg64goH3V4we+HLAd0PyKZIcDZABA6pQJEBzRnxjWKfyVkV3juVfuWxyE koGhd0E+4erGzYW1RF1baUd/zyLRfNo4G0osh3ts0IBe6yEwtdw71++TU/s7Dc5oWAJ7 XviTXkIJHVL7P2NrQnFvBOwph5zBsCWWJEO7ahFax3LZSeWglCv+/ATQF3kiY8GS+rFl 38ABWrPNtuGpAm43HLGvDpQzxbK2tpGptUOurwY2//04AKSygex48Ht4nfgFRF7jhrkL W/W2d5rcTKupUpuj/lNn3A2R4TOC8sg42kfZh/wS3cvbdY1qbC5IVOOwloBJSsWivxMO FeFA== X-Gm-Message-State: AO0yUKXL0AmEoSxkd/655cojWkjf4ymrkmAvFt1H6SiIYn2Md/ZHJope GaKzqs1Jp/u7pJJNmnGt76PZXYJ5nc7k3w4OV+k7ue5ZyFEegGPxrbM9U2HK11IYl2S4ymo8j4H Q5sUMqSR39N4= X-Received: by 2002:adf:e192:0:b0:2bd:fa1d:5291 with SMTP id az18-20020adfe192000000b002bdfa1d5291mr5604505wrb.67.1675327163209; Thu, 02 Feb 2023 00:39:23 -0800 (PST) X-Google-Smtp-Source: AK7set98llXB/OWQBWRDSwiILjhUm2SHG2oN+98oEMUauH+IM4rxQpqpkQvaA7kT1rOvZPHO/7OhmQ== X-Received: by 2002:adf:e192:0:b0:2bd:fa1d:5291 with SMTP id az18-20020adfe192000000b002bdfa1d5291mr5604494wrb.67.1675327162961; Thu, 02 Feb 2023 00:39:22 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id a13-20020adfeecd000000b002bbedd60a9asm19075117wrp.77.2023.02.02.00.39.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Feb 2023 00:39:22 -0800 (PST) Message-ID: <7eb43c35-5245-df9b-9e81-ae59d176839c@redhat.com> Date: Thu, 2 Feb 2023 09:39:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] mm/gup: Add folio to list when folio_isolate_lru() succeed To: Kuan-Ying Lee , Andrew Morton , Matthias Brugger , Alistair Popple , John Hubbard Cc: chinwen.chang@mediatek.com, andrew.yang@mediatek.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230131063206.28820-1-Kuan-Ying.Lee@mediatek.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230131063206.28820-1-Kuan-Ying.Lee@mediatek.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 3e6jy1hq3dyyjanncztabt9kq69earqp X-Rspamd-Queue-Id: 1926C40007 X-HE-Tag: 1675327166-862082 X-HE-Meta: U2FsdGVkX18QOptJC4zrlxzh+zk/5w52rJkPEbfeNQFss+/rDa8sSuFcoKetKnbUfOhAH8hKAYw4Jd/WX523vrEvNY5FlVSg5AmZLtqo/rs0fCfbLKFsS4H6jsjz67shGhkT5bP4+nzlwoSsBoBNpy/h1eyJMbWQ8HeLjdyrhf3DTfmwPEV8XCElu6/U/TKHMzULHa8zNOyJofR1efPJZgTAX4zhMBqUeFx8bMOYjM3DzuaH/x/o112BkoJS3fr+EkCvrvELPMO0yrZB0LijAFBQbWQtGXDdOQkYly5S1tuw2yARm6kBdwWu/D7EB+WSuq1bghMNyg61Hpw59JbuXR4vPMb1r6l2VyUjvIdXi7UMePuJveq1VQvAJzcxhMZ7dXfkslGVBMFWNbLGBTOZR/x7AEVEpLH4qIFjj1rGIjWujsdzyzVPsZ0/HAcYj0CehU47O0Atg7p5eRaDjwjsOpxfh3dNW60lsXil+6pvhFOiAj7DwRN7KVTwjVgY43wxukmdDM/Zyijc23gk9+sm0rh04csuG3DGx3UbKH66OQ/++/1qG4NVGggRX5yNxFS+pOKXHZAAgnxNFr8n2ywSfQMKnR+kFmCNpoU9Lm3TiOurPze9LXnYk9spEaU3lPaByeDv7APmFTLKItLxlyKFJmMufYzjh5qqYDCDxgGFgVFOjCKzRv/92kC1qbsG8QW/08xjA0+aevnSll9K1bvxUrqOxUWOeRwPfctX7hMhEZn1zbowRs78MEkHab/JyM7+8zcK/0Mc8L78J+obw9kK//findzQsLiDJYBLubtlLFQrGN9KU2FDxHZ7dsJBJXhqhp0G/Bkg1AHnxmCUiKt9XifRl9YViTNVwL+Ch8NMfZAd6Jd9jszSh1g1ohj2XrD071KE+3IKnhYRVtVZlJE92bEO5BsQeTKft2fSreSo6JQQDn1UY92BxrMKGCFIFBMWIaOz3WuF95aANRXWckG BtXPDiCM 4EYVJDNG32RMKZtbmkv08hKL8khlmakCnObu5j3tu3ZL5CmMS3r4fZtRLSMawnuPK1gLLHTcSTFSsdfp4aMu2pHAB9MEC5EEeNLD80Zn9rMg5bGp9hpT4154UdGoKtkrugXCWj0490IuavAub4brdXGCpef4fxZ7XDZkkee6QIyfCxbmr8eZCfJ/Q1kAHQfVAxc+v1K+4IlhxSSz6OBt8LpV5p/vtESQ5uOMH4IEXoMyyafL9BECVJDoa4w2A+vcM5g1ae1O2AKr5Jh/VqxR0KwYg3sui25rpnbSaiNmpavNtjWdKi9Q7ol+k3AKxNV3c8Un5wm1PqmzLrZKVvnoP9p2I+YqZs14JWKXYUHBG4RGrGks3+N6ccIOMd7hTA6i6ldpYWdwOZNZGcaoTz47pkGYlspaiFFIq3X4rwXdL7XyFlfr89b4eGnY3MTypcF2wfp1/dIhGiMtEMubb8sU2OvuKxJlRZhcts/BIvQSzRbVpA8BKP5fs9STGNQbBhOG6wsoY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.01.23 07:32, Kuan-Ying Lee wrote: > If we call folio_isolate_lru() successfully, we will get > return value 0. We need to add this folio to the > movable_pages_list. > > Fixes: 67e139b02d99 ("mm/gup.c: refactor check_and_migrate_movable_pages()") > Signed-off-by: Kuan-Ying Lee > --- > mm/gup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/gup.c b/mm/gup.c > index f3d2cccb89f8..918c364d01ac 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -1914,7 +1914,7 @@ static unsigned long collect_longterm_unpinnable_pages( > drain_allow = false; > } > > - if (!folio_isolate_lru(folio)) > + if (folio_isolate_lru(folio)) > continue; > > list_add_tail(&folio->lru, movable_page_list); Agreed that this deserves cc:stable Acked-by: David Hildenbrand -- Thanks, David / dhildenb