Re: [Patch v2 1/3] mm/khugepaged: remove redundant clearing of struct collapse_control

[Dev Jain <dev.jain@arm.com>]

On 14/11/25 8:30 am, Wei Yang wrote:
> The structure struct collapse_control is being unnecessarily cleared
> twice during the huge page collapse process.
>
> Both hpage_collapse_scan_file() and hpage_collapse_scan_pmd() currently
> perform a clear operation on this structure.
>
> Remove the redundant clear operation.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> ---
>   mm/khugepaged.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index 7e8cb181d5bd..1fc8986a28b3 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -2803,8 +2803,6 @@ int madvise_collapse(struct vm_area_struct *vma, unsigned long start,
>   			hend = min(hend, vma->vm_end & HPAGE_PMD_MASK);
>   		}
>   		mmap_assert_locked(mm);
> -		memset(cc->node_load, 0, sizeof(cc->node_load));
> -		nodes_clear(cc->alloc_nmask);
>   		if (!vma_is_anonymous(vma)) {
>   			struct file *file = get_file(vma->vm_file);
>   			pgoff_t pgoff = linear_page_index(vma, addr);

Reviewed-by: Dev Jain <dev.jain@arm.com>