From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A39FC2BA18 for ; Mon, 17 Jun 2024 09:51:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 099736B015F; Mon, 17 Jun 2024 05:51:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 022276B0161; Mon, 17 Jun 2024 05:51:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D69556B0164; Mon, 17 Jun 2024 05:51:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B25026B015F for ; Mon, 17 Jun 2024 05:51:16 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 33D56A19E9 for ; Mon, 17 Jun 2024 09:51:16 +0000 (UTC) X-FDA: 82239912552.12.CD2C840 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf12.hostedemail.com (Postfix) with ESMTP id D117C40004 for ; Mon, 17 Jun 2024 09:51:13 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1ESoFfPK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3vejC7C4; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1ESoFfPK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3vejC7C4; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718617871; a=rsa-sha256; cv=none; b=MmovkqVYoiM1KvutEBypbY3ZxcRJOIb7HWvC2BFOosVCCprR2u7ZPCPXsB6pLi9FyQqU4i 6dJt5puy5XbGqBmtaNibS7R+5YxbSlr+P63QiOV3nf1kdmDYqVbfVSS9XlR2Aef7eILURF 1y/8fapqHa11FwFEZjW5GlUK6vi6Lcc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1ESoFfPK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3vejC7C4; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1ESoFfPK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3vejC7C4; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718617871; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fuIeDQYjpzcVAvYyapi1f6nI5RxpTFpdwPDiKAdC4rg=; b=Z+jKyVFeiIyDS/DaIfCT9enFweOvscLrknYelHKXriSg8o2/znyUpkuigQck3OAnBgYASQ BZuBTMyqPMSkFqkdfUwByNm3V75rH/eVMNFRsAanYoPsWFwRa2spJkqCjh3VeUs90XjlmR 4Tg1minr2I4dLNs8D4isqmGmjNA7ny0= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 170B437FA8; Mon, 17 Jun 2024 09:51:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1718617872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fuIeDQYjpzcVAvYyapi1f6nI5RxpTFpdwPDiKAdC4rg=; b=1ESoFfPKDBQeHgZoK6C6BOQ5WTYbF9bcscwveSB3jOqz1FdUVLi6hZH+MZF5jFr+o1wpV4 VgU9Jm8nwEJ1uqU9Cbt4iBa8Ucvlg90mjRw8rlKG68v4iQ9EU8ZROsBPnKX+UOdO8729cb xqzzgJlS3BzKHUEfPF4r0dT6cERE5uY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1718617872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fuIeDQYjpzcVAvYyapi1f6nI5RxpTFpdwPDiKAdC4rg=; b=3vejC7C4zmUV0GQPnlOnZ+xQQW9mqcdWXWH1gDqbDFIjLs0yhAD5AhWBB6bdKNQwO4PaG6 qT5lx+gCXI8XILBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1718617872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fuIeDQYjpzcVAvYyapi1f6nI5RxpTFpdwPDiKAdC4rg=; b=1ESoFfPKDBQeHgZoK6C6BOQ5WTYbF9bcscwveSB3jOqz1FdUVLi6hZH+MZF5jFr+o1wpV4 VgU9Jm8nwEJ1uqU9Cbt4iBa8Ucvlg90mjRw8rlKG68v4iQ9EU8ZROsBPnKX+UOdO8729cb xqzzgJlS3BzKHUEfPF4r0dT6cERE5uY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1718617872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fuIeDQYjpzcVAvYyapi1f6nI5RxpTFpdwPDiKAdC4rg=; b=3vejC7C4zmUV0GQPnlOnZ+xQQW9mqcdWXWH1gDqbDFIjLs0yhAD5AhWBB6bdKNQwO4PaG6 qT5lx+gCXI8XILBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id ED68D139AB; Mon, 17 Jun 2024 09:51:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4WyIOQ8HcGYzfAAAD6G6ig (envelope-from ); Mon, 17 Jun 2024 09:51:11 +0000 Message-ID: <7eaee8ce-ad5b-41ea-9eb5-83195f83fd24@suse.cz> Date: Mon, 17 Jun 2024 11:51:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] slab: make check_object() more consistent Content-Language: en-US To: Chengming Zhou , "Christoph Lameter (Ampere)" Cc: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Feng Tang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com, Kees Cook References: <20240607-b4-slab-debug-v3-0-bb2a326c4ceb@linux.dev> <20240607-b4-slab-debug-v3-1-bb2a326c4ceb@linux.dev> <63da08b7-7aa3-3fad-55e6-9fc3928a49de@gentwo.org> <8b844d71-01f1-472b-a63a-4c9cdb26e9ef@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 19niiccmxa95pa6izhz4wiy6zw3uojsp X-Rspamd-Queue-Id: D117C40004 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1718617873-106004 X-HE-Meta: U2FsdGVkX18n22UptdRjUygRi0szg95JopR019yR37G/WlWQ6i+RvKMbftejxFVUH8twq2ogLeLkH93panPI4zoaemm/fXUUcdTYuJ5OgcxOG4C6O1XXexCgyeq3XsA+IibLweLFQybEjl/UWB2Rd9gbSjARi3X8JUoMsIDzqZc4VnXosA5OyJJL2M2Hzr1l18iibB9FieAUsaSwXnw2RU7n8ksJo0JtIgXv0ykX6qd4SJJTeaQuVLp9I9j0zuyX9vdeYxdpfzS9IOWCMIWQI1qhfLXXRtjvSYr8Yp9t5T8ow29op9wqiFpGbtXi5VOZ+fLQEsfMfncVFzyPDxyYT4Za4xclv6NEwpWxt7/36usfETCOpGF3Mq1UYF8rJOdYMdJul1I5zZWJN6if7n2aLH5fvRLhXnAcy6Aq8PL41koIuiZi9lBLWNexNv0UIFjafL/fYbX10yfkxGMemO0ka+YtupDWb40QGTwDIJrkMstwENB6cks0a9fQbQiK43yj7qAy3KIGWVgw3tEY4funY+WCqtZTlwYwf+U5UeTxEBZ6+RsjqeDfi4sfSP42YP87KOorLn7S6PZ0k8kgFF9PjuVzfUfOJnDa67jmeiR6g5/TEHSH6Wdi4SHQKSAwB0iKKE5lTSGxCeUkocsxH8whxQ/J2WnOwTrp41be7lGVnalOC/J2vOFuTMEqIsiP9DjaIdb9XrAFID+ych88l9iMvIRbJnL+K2k0vt15VzoPljDglIF691tJn4glyVo6bQeDPHw5ZVayoxoAZdcz3h+JnFbVvNv1ErsyYmGFeGJMAtYQ40pXxvk9XbQ4JRc7ubbD+v2ImmBQBOanpgFjlNCAG9Qi9Sk/6XBzvT4EMSYfW6reU1O2axwfpj9eLkKC2PecBD0oHEjUwUXqPZVCOn3VoxWANqVFEqkaxjw1NlRwsDw4H5mvlTwATer9ZCVxCqzQEODo3IbTtPGOQRTz7Hg uniISvph MfFlb2iswEopaz95E2xoRCdt7i7kGRcSkPgFLGOMAY99A+fc4PHMOkUKq3CVmyvZfWwcyJrqcnCBYNWf0rXCl1fTLa7bKSnGXGUmtOqLS61FIvz5+P0LBQkUOROk3czntB6Gr48pfxWn8zmKb4clkvS7wuhu+2oOif010cTE6zD/P8CpJZRHaF2PAy0T5U6QNXgGL6A+WROedwAb7dTAK4i1yxvNdZyxmACktSJ5b65svxJUCt4zIZgqT9y6ZvsisSvm+Q4oe2CXcZAQ1v7eh0FKc4QiapWS2uxe2DZUmIRhf4WiFEcza7exP0n2pcWlKdQIeBMp+PfLmDCFRfbkrVib2xp/1feVtg5MxDhT09VJuxAcXeWR1a6gCyyIyev6+94Nh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/14/24 4:40 AM, Chengming Zhou wrote: > On 2024/6/12 06:52, Christoph Lameter (Ampere) wrote: >> On Mon, 10 Jun 2024, Vlastimil Babka wrote: >> >>> Even if some security people enable parts of slub debugging for security >>> people it is my impression they would rather panic/reboot or have memory >>> leaked than trying to salvage the slab page? (CC Kees) >> >> In the past these resilience features have been used to allow the continued operation of a broken kernel. >> >> So first the Kernel crashed with some obscure oops in the allocator due to metadata corruption. >> >> One can then put a slub_debug option on the kernel command line which will result in detailed error reports on what caused the corruption. It will also activate resilience measures that will often allow the continued operation until a fix becomes available. > > This reminds me that we can't toggle slub_debug options for kmem_cache in runtime, > I'm wondering is it useful to be able to enable/disable debug options in runtime? > We can implement this feature by using per-slab debug options, so per-slab has > independent execution path, in which some slabs with debug options enabled go > the slow path, while others can still go fast path. Many of the debug options change the layout of objects in slabs (i.e. affect calculate_sizes()) so it would be very complicated to change things in runtime. Also the cache might be merged with other ones if it boots without debug... I don't think it would be feasible at all. > No sure if it's useful in some cases? Maybe KFENCE is enough? Just my random thoughts. > > Thanks.