From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 880A2C5AD49 for ; Tue, 3 Jun 2025 13:05:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24FEB6B043E; Tue, 3 Jun 2025 09:05:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2275A6B0440; Tue, 3 Jun 2025 09:05:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13DFA6B0441; Tue, 3 Jun 2025 09:05:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E7F126B043E for ; Tue, 3 Jun 2025 09:05:31 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8B2EB80902 for ; Tue, 3 Jun 2025 13:05:31 +0000 (UTC) X-FDA: 83514110862.27.E41DA90 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf27.hostedemail.com (Postfix) with ESMTP id B057A4000E for ; Tue, 3 Jun 2025 13:05:29 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Svw4zhmS; spf=pass (imf27.hostedemail.com: domain of broonie@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748955929; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Puhz2Ko0qjcOzLQv9UIZNqgwnTz3J75G+T/ZG/ScIQA=; b=2uetV5oqXHJKfurs5VeIecjz+N77tsSqwbOqIdlpe2H9Rfrn/Jf/yz7bmAy5KpRtr1cfxR SoR1UwNecUH+3jYpVWvwAJIr4g/pBwFERcA4WnubLNragE8cURH6Cg17kQwgLYKZkKqawo QGr1x6L5aKecsENmFHZYOUGHeac/ycI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Svw4zhmS; spf=pass (imf27.hostedemail.com: domain of broonie@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748955929; a=rsa-sha256; cv=none; b=0pzc6nOC9HsCVtAFf2B6V9kH9i7DrZG6EhbHFrjKdTA8A9Th6h23VflERRy9ST2DdXGw6V 58amYAYbr6OWbAvBRaQi3eZKJiRai4AeMAY/0VscF7AyJwk7SR14MSTTZbJoc0iwAAscjh tIis215eprI1aBeWKF9NEjZf4Mx6/xo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 858E749C55; Tue, 3 Jun 2025 13:05:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2651C4CEED; Tue, 3 Jun 2025 13:05:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748955928; bh=CQR2F4P/WFuLDUfY7mMG0WsFnPiqWfcgBuMnmRlV4Rw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Svw4zhmSwk5wlMEpy885E553vr9FZiwmTa06hHqVug9C3ZC+qBt57F1ya33rflZNo t4HpISxklHGjZsVBP4Ad6v89xohy/Tbmk6r++MnwbcWUCy1HcTl7NBaYqbUXlD0+TD SrFHr579GfoAFLB8dWZggToNmHpiQyMc8YUOEA5+bWn6mPhphgAcUp8dLXx25xs1fR 6z+AP6mf9+dMOZmNJLky/KQn+h1qtaY3ifxvW0GmRJoWylZgPKN6L33N5x260EC8te vaBARCbkxOJlVldTLq/q86RSe8DvhVF78QYivga0I3HDIDlTHWFNNFymgMpsGcyLz9 rnbm7gmSHn+Zw== Date: Tue, 3 Jun 2025 14:05:24 +0100 From: Mark Brown To: David Hildenbrand Cc: Andrew Morton , Shuah Khan , Lorenzo Stoakes , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm Message-ID: <7ea6e0bf-da88-41a4-b6a0-1b1ee15c8dd0@sirena.org.uk> References: <20250527-selftests-mm-cow-dedupe-v2-0-ff198df8e38e@kernel.org> <20250527-selftests-mm-cow-dedupe-v2-4-ff198df8e38e@kernel.org> <7ca09fbb-8b10-4dea-9456-dce21ade2099@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/mJ9tvidvqv+qSmO" Content-Disposition: inline In-Reply-To: <7ca09fbb-8b10-4dea-9456-dce21ade2099@redhat.com> X-Cookie: Avec! X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B057A4000E X-Stat-Signature: 5d13bnq73snqp11z8qdx4qu7ftekzn4q X-Rspam-User: X-HE-Tag: 1748955929-489386 X-HE-Meta: U2FsdGVkX19RnM9cPgTVcM67+yJ0UJsVXtnnu3fYlqyX8P/f1d0WeVg6HqIxVF8pxMjaJknpDCQ4niOt9UnyYO++ct7VIgVhwHQC+cxlBaxaNW6rAmRxpUB0SnckpXz9+1LDRtNR7u01jYmYcYC2NjP4Q4GCDMIQB6j9sHNNPwjXkMN5rTKFxl84I7lUgBIb6tnlh46lH36kZA/TVzQtKgIbYL1SOuwmqilmaxWROdWx6QfsgxVwgjrLqSnVg/unYT+8fjADpYJyb68J0QPoihvEF96rF6qUtjeVwAYS5TDwcknwf0mtxhSqn0Ho16boIGYtn7+KP62ap8hLH7I9DHK7qIMQUSn3Lmcx2xa7ywp0S6QPat/8/S9SYFyAnRdSMpWCBx2ykBcz0esm3R44VqHdiClD5oPc/zHGcdjPgZsmJUznjsiImI6Nkn5z1N043DzgwEDYvDqx5LkIYRrp3CDcfGeuxXh01wcI/qar/oCi3jtDwdcxeM36DLsNk8Qa3biWDZdgvXdGZZqg9p6LQMhIox9chkks1bbW9pbgGmeTXsQkcu8rYs9mhaHW+7QWYWiv9NV9B2HG/bvace1Ox4wT3JsJpekUmpF4OPCF5OU1v2ceXv4gfHJfhNrcIsx4W+pmZHhvlLtlvIsyspNG80SBqx1s92ccNmQefSc67Y6pIP28VeNWBLD/b1Imzcdzxj4ztZTJeQiUraWIVnnSyEQLOx/p0zo6BahH0oo13RdFwohHMKI0pE+w/kDjkwufT2/HLdWPObKzzbaRYDeQ6SnLiAXtKe5JC58sL18YL1HbLGlq0HBG9rpGlqPilsmMAduAB34uLt5Od03p6+sReZnawrqrtPnallV0uDBX5r+W2TN4Z3jhKj5hXP1BDtPsnneSQJAwEKUgqcWsjZ1zfJZO64cym6sE5YOHLqjeBgdcZI2CJbJnMtUNWq4lYnV5Ee/i6zTvdAXwXPr5f/v 9A7cB+j9 sCepGPhhPHydGfM/TdgOqrK8JxQSbOULFaKbeYDzOZEqUMaSA/XDUm5MDJmMIcWmgLjUw7bpekId6pZYsjKNN00P6f7FOp/bNh4LMzIraOdvpFoo7nsp3RTTVE3CAl0G1tyNfG8ErrgfU53w++T5WeWHtkIT5PgrU34FrPRsnHnpiJMqFxwyEq/oh/+6zyGp5sv8r5Q/swqi4PWtG8dbEi7BYpHnmolJNcgo4kwVGcdolnajpcv4z2oWXAVmNJ7sWq6YOVavKG0xpjBAPVFXlxLmYohgLoMoYin279tjWEPNfm0eCFjfCfMlLDEQXRbKHVb2gDaaKf/muPW424/E1UFALtVDrdU8GT1IM5edB8F0DzyY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --/mJ9tvidvqv+qSmO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 03, 2025 at 02:36:07PM +0200, David Hildenbrand wrote: > On 27.05.25 18:04, Mark Brown wrote: > > + int result = KSFT_PASS; > > int ret; > > + if (fd < 0) { > > + result = KSFT_FAIL; > > + goto report; > > + } > Not a fan of that, especially as it suddenly converts > ksft_test_result_skip() -- e.g., on the memfd path -- to KSFT_FAIL. It looks like the memfd path was an outlier here, the others all failed if they couldn't allocate the FD. > Can we just do the log_test_result(KSFT_FAIL/KSFT_SKIP) in the caller? Nothing stopping that, or doing it for the cases where we want to skip. IIRC this simplified some of the other callers a little. --/mJ9tvidvqv+qSmO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmg+8xMACgkQJNaLcl1U h9A1/Qf/Xl85W859yQaAXxzS9ufb4fK7OtXZ7yGVpwtzQmY5v8GLTRLRLJjgw3Jx HnhtZCEwnrs2uqx7Z8nIGgOCZOhv1+TEiZurBY8BJgc9OY79InqKqvQuE5vIkkNl BTpHyZlUxWXUCOetEE36of+aGWHi20qY1Qh8VaALARABdaqTc1I5i/VN6hOdOIG4 WKsHJIKi41FvrQzMsJoQSiA57OdcnOIpKOWYDdkVEtF4e0+H7ARBOEzmphxyri2l sDfGkYmmwymn0JZSpVMWzSZnS47uzE0+EPLYWjpsPN/gNY/LV/vNnZYPIL+gTeAy o/jX+FEiqUnwozeW8Vc99YtdDjG8PA== =/ARE -----END PGP SIGNATURE----- --/mJ9tvidvqv+qSmO--