From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B8C6CFA45C for ; Wed, 23 Oct 2024 18:21:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B19626B008A; Wed, 23 Oct 2024 14:20:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC8F06B008C; Wed, 23 Oct 2024 14:20:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F5176B0092; Wed, 23 Oct 2024 14:20:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 69C946B008A for ; Wed, 23 Oct 2024 14:20:59 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B61D6140C15 for ; Wed, 23 Oct 2024 18:20:39 +0000 (UTC) X-FDA: 82705682850.26.5217709 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf22.hostedemail.com (Postfix) with ESMTP id 71EF8C0003 for ; Wed, 23 Oct 2024 18:20:33 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=MzcfHVpw; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Scxe0iMw; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf22.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729707487; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WtOBPs0Pfp8UjWv7LbpRbyaJgPfCHk5AqclGBHWVnK0=; b=jcW7hnv2HnhvPRWMJMnQsXoBo+TAeCK1E6ANg5H9skjqXDRuSYiB0zEBgNuu3NRgKR+9VT k4xJY4ZJobZKIRzSr33oBNvL1yjc3y7VLpUOYLnvU++xX/UZ34FN6MV4jClxERcKgV/nM+ U1jSNQFVr+0aymhb8ziBmt31Rb+A+Pg= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729707487; a=rsa-sha256; cv=pass; b=UFZjUXZB6aMIg6GGgvQPaSm/4tSQscLJj4GMyB8xXVUfEpsB8HCkWuDJvMIam9wuKbQbrF 1+NC4tCrX2l0VGQjXE96LBiiHS1iIP+v3drVaz7ZnRHBFj8kVxkxRHrA89Jd3pvknYEBU2 S+ub4etB7Dx6q9WGS7kkb/uOS2I/kcw= ARC-Authentication-Results: i=2; imf22.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=MzcfHVpw; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Scxe0iMw; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf22.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49NFfe30025373; Wed, 23 Oct 2024 18:20:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=WtOBPs0Pfp8UjWv7Lb pRbyaJgPfCHk5AqclGBHWVnK0=; b=MzcfHVpwfwTHbeODc329x4EdE5acN5Jz3+ 9P/1HbzaI3PC+H6pnaKz2kqAoR17tIkQMPVoJziQzhp0fian9k6+IconiuPAcSld cXygFtu8ZpuEv6+2aXu9TuZzJEBVTXVcFjXINTvExBNnHY099Nr4zUVqdSo9Waab hJMXUB/+sy9SHCEcndARMv3s4Ls7GA17Y4xGS7Fo42BSoF09bgJ7c8gMa6ny8D9z fJrx0k5qiIr8zOl7703FEJn1h3u4XPQQH+LtjbAPRUfzgZWf4G+9jSgaQDAZHMNG Ihd8JxbwnFlOmhBxLDAKhRbgYXF5JxQbkkgGNGH3SEm7yFSXKkCg== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42c5asgtvj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Oct 2024 18:20:51 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49NHsktR027391; Wed, 23 Oct 2024 18:20:50 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2172.outbound.protection.outlook.com [104.47.55.172]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 42emh36nbn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Oct 2024 18:20:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ID6WCVK2gYBSqtcqmpDQZP4oJoxxXKvMVdbK3ynN6wukhV+KnIE1GQr8PoGbpHIHsJufSU3Emznxjq2kD0mMFIr/4YS146Jc4WDn9woE6Eb3cSCwrEr1qrtc0AsxBZhyd7XqSMpbOBLRqH4IAmieONKWr0P0OP4D1tjbxZPJUL7nyzP6ClEOm/NQo9uETEZHEv2om3rjPWdT9pLGZ1bBM10XCiwIHap08I5HMv2EToVhZlUErXvqQTmVUsTQhcqqqxDqOGIC5H9ZQhoxVsrH09yq0ZbfQfOr8gcbXpr7QeLQz1d9eA3EF77DZr1XvlLDTUdLPfAdmzn9B8vyfEOiFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WtOBPs0Pfp8UjWv7LbpRbyaJgPfCHk5AqclGBHWVnK0=; b=ByUAeBgJ4megqgJ7TaCqUod7zUwuQ+x1nJRB6cZxOIqsPlnSgvj2kDu/h76+AnISTiQigpuPfQMLkstYtP2KwqhN5M60S/0At5ygJJTsU9bNJXc8Z2q+1ZE0CxBrfC/eLKJcF1HOFozogZ0sUDHwnpieRH23fV9rwl/OS4Od7GL98FQnnKqy/vfxJLIf+Vvn6a5PFy1lIfpTm7BzuiTm7ifx43oICGYiRFLKosFyW9DZEl2zAi9K4FlRQ3uCNrHCfFvFuVSsjo9VygaOrl67H+ALY+KfDiyCE57l/iwa6QS3mmwgdKEYw2M6Oh0aLR67YemKWJCQrhNZetnJyQ6mFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WtOBPs0Pfp8UjWv7LbpRbyaJgPfCHk5AqclGBHWVnK0=; b=Scxe0iMwd+qDnD8HScuhi1juZmLYhmZf/+000yOiu7jEuUecypM0/kFpcs3SEBrAtz7PzhxClFyfuPfgDZIEphIbrcaHW4ynisyHxotx21sZl2I+Q9HBcS0gGDqoHn1IFSPyrM1uDz9EneHFtG/ljh4nQwm69CEEj6tFrh4c0EM= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by PH7PR10MB7850.namprd10.prod.outlook.com (2603:10b6:510:30c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.18; Wed, 23 Oct 2024 18:20:48 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%6]) with mapi id 15.20.8069.024; Wed, 23 Oct 2024 18:20:48 +0000 Date: Wed, 23 Oct 2024 19:20:44 +0100 From: Lorenzo Stoakes To: "Liam R. Howlett" , Vlastimil Babka , Andrew Morton , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Peter Xu Subject: Re: [PATCH hotfix 6.12 8/8] mm: do not attempt second merge for file-backed VMAs Message-ID: <7ea1f225-0fd3-4d8e-8618-a275e0797345@lucifer.local> References: <7b6bf6165080505feb5e00b313d2c84c25015e45.1729628198.git.lorenzo.stoakes@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0566.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::16) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|PH7PR10MB7850:EE_ X-MS-Office365-Filtering-Correlation-Id: 6685c0e7-ee8e-48e5-dce1-08dcf38f6ad8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?86WvF0mwJtw0P4o7g4vm0XnJYfkcw2YaLeJBwMVBRpj14QKNBw5dTtooiU1J?= =?us-ascii?Q?z0IDyCDJWyv/6ywBGGRaqbp8iC58A0FafTplM3XKGQ5f6Weeh/CZbDW9JhwM?= =?us-ascii?Q?bTah3j5yG2DWNto/d2EfX/rLF1e1u4wKDAJeQYOxM8aVFsF8VSwJQI7SkKbj?= =?us-ascii?Q?8WA+hI3bE4GMjhLjT+TerDLZZNfdAO7WZH0PB2wOqb4lwmsX/77Xcd+AjkbP?= =?us-ascii?Q?mPdqF0j1BhlzP8Vm6tvP4cIcZ3QMr5TaGjEEUgR60LcyHtjuWqYN296hrt75?= =?us-ascii?Q?DQA5iODwApy/X1K66pQLoy5DmG0ijEYOfFen4a/jMJ3R6CY/pGT8yTX/vWIb?= =?us-ascii?Q?bZuUcxaJlKiiCwUbe9kf9w12Gt/6ux4GsWO1jbr3bOPGJrwW226MMaaKrtSF?= =?us-ascii?Q?D9CVRlMTnc2NC/3amUF44z/eVWEi/81i/fSSERjQG3ePT8TOdxXCq4RIeCLY?= =?us-ascii?Q?y1nJhEubg/D1N9Z0EmS9ByHr0F4N0P3LYzcfbBASJbMUWZjS8Sz2yO3nUZaV?= =?us-ascii?Q?oWiL5QV/otVSADIsbHmHcVRYh1SF4Vq+K6XNuXmzcaQmyJrc3dxtNqUFfeMp?= =?us-ascii?Q?uxoDFovAGgk2nh6809618FZC5/qXibg1l++fUqT3N7TYWXZqG2un62IRKcRY?= =?us-ascii?Q?3j4SUMtjz2Xc4LKvIDo+7ylR8/tPMuzI2UCje+FY7gn6gR9SxyBaUZNjTi/+?= =?us-ascii?Q?EqktpfIYKB22651OdAncxNfUNIfHYsbkcqi8UROkN3mTjztIWj3TN6doJ8hv?= =?us-ascii?Q?9iM4Ku2YdUdBtg7cgaqaooQCT8GR5OmYrE46ItydJgltykst3VO1F/zaBSim?= =?us-ascii?Q?XKzp0RZY/IzBm+i5uLBZwqHxkqd+iuikBEUnPwTX+2k0SSh18U/9ilx1Supi?= =?us-ascii?Q?oAe08/9eh/YH4nqGK9WvURtSQzF9FKGXNfgqlYD4PHK875S5NB0PL/y13mu+?= =?us-ascii?Q?eGyPgH9r59Cblh6J6bYq6xt30cH6A4qzFlgWrPAnGETpXXO2A3ZwxEeUMqo+?= =?us-ascii?Q?UnLped60CWIW9jUWvLC7iMHaJv4rSwLBwE2e7DbiNWky8Tmp9tohs8+hiv0n?= =?us-ascii?Q?fpuFrSdWReCq4+cDu9xYViIFtwIDRJN1AJ7ciQqADLgCP3VKA8NGxR2mQ7Eu?= =?us-ascii?Q?UERlnan/DBxfFMNtVyl0dIeG9jUe/FAnZXXGQb0ZB7bCOoG5qFMs9T4FoKfp?= =?us-ascii?Q?TTQ54vrVK/S2RoRz4BBzhuXZcp5XQIDRqgy7fHcu99GYBhDlxoRkc+RyV5O1?= =?us-ascii?Q?cxIjih1kBcjgVwa+rC/6IPoNk7yOJAetfa4uvVaSUNloBPTOr+rGiCP1/kgi?= =?us-ascii?Q?sYAg7G/b6VbI65fhcO8w+8vF?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+HB8rnsFbpVFZSnDvKqYIZgwTg1I0aohW1SLw1u1T2EkM0MX39YCt9eLWzPf?= =?us-ascii?Q?UzioxiVpYEpAItMTnj4fOks2XxELDbVr0q22imnAtLw/LM16QhuTmQjJxbo6?= =?us-ascii?Q?aMKxVvuZufSzwcydFgdI621olrSqn6h/gZ9IdZkMTLNxvciAhUx+En1HIWS7?= =?us-ascii?Q?gw3rwsHm6pRWP5jLPGPvN7GavhtRvZ98bn4KirK8nsfkNxPjzSsO/ZzPG8si?= =?us-ascii?Q?BPyRsJAfNPKGlzZLQtMDDpp3guhK4gV0/Hq2ov//WABk2rh/3osnZfKQ1BWO?= =?us-ascii?Q?uzsixzjMD3sx1euOGWZ95Wj4KuBlf+6TBpy3QhxoEzaT/V29nuLAqYBniFHQ?= =?us-ascii?Q?pJWoiH/VOI9pqhQTs2HILajJNlEFx5AbtmHGNRmtS8KXY7+8bF3LdjrFIsGh?= =?us-ascii?Q?Ov7jebn1P1P48AuTFn5AtxUUGRu4jTtCsS4bp408ciNY95oW81jFJIDkjyCb?= =?us-ascii?Q?sCf1zQqcp+xBXv7vto+dd1wixVOdPdhzD9fX00CNXHepz5/0FkgVWRUms2GK?= =?us-ascii?Q?TgPBgTkLLqxcje4Wiz25STw4RxzIUephpNw/VR64RFP0c06wDbv4+0mNndTA?= =?us-ascii?Q?1fW8nTBYF3tOSEPltQjYJgi/fYRcdMEo2F0Ob/binTJJChS6qNhsaiPLgcPW?= =?us-ascii?Q?aEcOa91IGzLfY/9KXdc19IztaO1qC0mJOUWR5TmQ2UVMQE8WeM7s6rpGccPI?= =?us-ascii?Q?lWzOz5vpsSSlAe9cEpKRhbHjO3zpJmcndPJvHgTJqNnNb1Q3lHOuiSXqlbq0?= =?us-ascii?Q?xa8ZnykXbyDGLgsfuRAltj/AkYDLWniKpNJ31a9nOrURVCTKkUpFlzPFRcnk?= =?us-ascii?Q?OIDhCdYXwYnxo9jaoJA+kR1yn60E+5mEEhrnLjuWlSKgAMuCtACEGkmxri1e?= =?us-ascii?Q?7iPAduNITEWY9h8HLNtgXQ596LMiII/UZR9hlEO8YlJ/s2pUbzkxBNLWhaQF?= =?us-ascii?Q?r5+MwwHUpd8DSG9k95NnoN34a43PmHPcY5ROBR0wAnGUdzK6MGtLWTWVScbj?= =?us-ascii?Q?abA53KFXUphWvHRA2A8sSIsyDIUwZ+52bJybD1wOYn0LAeqvDxoleMEU+N8x?= =?us-ascii?Q?P32/ZLN/GJmlzqZbELaWNGX3ViopiOzG/UHV4fCNPsANfnqH3bl4U+OzjuHo?= =?us-ascii?Q?pfd5dbNl+DVUuIuf2zP4rxFbsTqMOvO8usveuetrQQNmwYA+2FjfCLkRr6SL?= =?us-ascii?Q?BHKfId7gHUHRWNCb+yGdOJkF+Tw/DAYTzYWSzg9N++jA+ceikNVI5uWya2YJ?= =?us-ascii?Q?AbSYXGpU27+SmxraN35yyOC1Hfd8QSrKnBhMVIQZSerFaghR25WhOLKA2ViJ?= =?us-ascii?Q?Q0HMOXqTEE64WBp8YwEfbhngyZtnBliF7mw+CvAzrEYk0IbrQEQsEPKn3/VW?= =?us-ascii?Q?LVwLDwQKQjOe0NOGvawOBA0xu0bdlkyrhnmzy+OMK/YnT6CKjGUqclJwJvtc?= =?us-ascii?Q?oEbxBwbD4bN0qMHwyTMguCdnryOEIIQ8ibVfIGD/GUFD1bWL2jQrqCyRD7As?= =?us-ascii?Q?VnDuRYXmCuE5vnTOQprhOt0nQqKP1U7ahkdHL72svITpz6Ps2hLouvlKFSto?= =?us-ascii?Q?8BV9dOmYznAuKwQMkanHR8KD6tx+/qk2o/oFuNpRj4QD1Ni1l6jUL6mRq5m1?= =?us-ascii?Q?+Q=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: oHGb1uIdFCRT5f3OuTcWP+hJnHqryxjTfgMOwl8wsovACW11Sn3ZaGOXVHSJDuxqXJegfSctazICWu/iVDyhs2gXeR89YyOTu6HCsRl9BsPg/mWwDkM+wljpuH/Yrrvht8HYp12CRrL2HG8HbLy9/gDEcFvq09RJxAKyBKVRIylVQJp0KUlSx8FMJ5aAgtrbxYvHSyXzu4v3gmcJklRPwXpZZKoETdz8q58zy53Pv19NNLZuaP8rbM0C0J8Sm4MSSDuPvF8SZOf/QzylUbqS60pdBW9ApF73LSeiTXZajiRU3aI/ihf1oSjZbVUXjpgxhFvWIXW5U7LaMGG1TKs8nRacNjjRawmyaBPcb4dsxD7Ck4f1rTBi1JkRSDrEPp0ur9cwcvz99dyA03tGrlP3AaDBvFYElMwoPJdMCNFlGGlGCODqQppfam4tBMvYPaNyHUUtiR6Md876s/wOz05JmAZeEcTqxLFKiWE87wXv8kMWTOXhre6vqgl0aBXnU1fa5znjzNm89ZpCgVfvj6ZveTW74DIzs7u7jWyw0LyeCR7A1MQ5uUEDWlcE//kbWqgS0ww6on6qxRaaaQqT/jH3Y61kSvlMmaz6vaXOJGwPsw4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6685c0e7-ee8e-48e5-dce1-08dcf38f6ad8 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2024 18:20:48.0826 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fr/Lr6ppS4I66Vh2exYquHRJiuX94X+yDvNs3tOJhjszF/n9USgVDVW7o+tZTGArlqsCyDPS6f7f0LP2wY1ZHDc2tdLStxpThGVHZAcLi+I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB7850 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-23_15,2024-10-23_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 malwarescore=0 adultscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410230116 X-Proofpoint-GUID: 6oeHmAPZNyWz7-D6KFwVnlv_5dUeQPUS X-Proofpoint-ORIG-GUID: 6oeHmAPZNyWz7-D6KFwVnlv_5dUeQPUS X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 71EF8C0003 X-Stat-Signature: a6rbuou6jbz4zz5sza3nmctpnxb7tb3y X-Rspam-User: X-HE-Tag: 1729707633-192866 X-HE-Meta: U2FsdGVkX19bWigu8M5qzc/CKZMbCpOgI2SCF1T5TTrcD3fRkHe8lCTj/OG2VmleV5L9ybdCh4BZYSFkefeBVJZ4/9WGNiauH3acl1YCbecR31OKYQUGebQMOQZFCTxQ+EHcQs8qSskipS5sYLPPB79uBFpFg8/nAKVv0IqoZV//GmIB21IZLF9PyUHvTKo+5bpn34XY24zGvcAvQj9bdUZP6vfVhxsA/8tX7op4zSgWjnUokTN03tg/3Dxnr7U8+BxELtsWri889SDLQGTR2jpB3NeggED27voVTkkDdZWV5fwIbQpu+nL/7x02rewvH08cWALdLM2V1tb3Aan/dp0wKRChbI3eGJN7eXqvg3r0/FORMhp9F/R9smi86oIp8IvfXNc5Dre4nLCUA+hPjpbR9a3S+/5RNBdHn6JCi/82NT6lRXxw11hENwjZixNf2nBTdrUm26IucOzlrZJm/PTX/rzcIQTjU6EpYCdG6bQ9H8gPvegYK6y1GMb2NEPfPDKaVrECmPZ+YBZrotFyj0gXz2QskKnCdREOdmrUpwKUq5rZ0Xm2W4AaYlgbiyJdQfA0Ym9GXWZRoEx86RDTEK465mXsy3cqNnfeLEbHhveXrjg3Z8Kutms6HLoHdL/whb0Wu7Oeooa675eLGPNVmhRRPrAlcY/BASBf2jI2B11gio7YyBIEjL4OZ5LTYgSz2NnyTFlUaWt/dMuRgY+0wzMU1P5y70R0tpOKfPRon5f1stjq6yvnlS68v7mU1MDclprPC7YiunyVOrtS0kpOEtgMlak6Xfva7bRVs0Gv6TNfhSpJXwcr/5IyO4fvse227/HL3B9gvztu4N/UHDE5Xg2iOn3XSXChmhUHecnpsNMofDZZAVnPDd+6Mb1l28gMFDpnGd/LkmqsvnwjawlxJ7dcBR9CUt8oyRRqCxCs2kVaP2D20N++BRxTXEdY+M7uL8BZasiQzxptPUFcBkS BRW0/IZB lbx0LcJ0grF+QsJIhGs2KZNKv/AZrs661YTmA9N2Ukyffz3BXqDzOUjUZp7ZHWkxKcKDi+Ffv+38p3z7X3IFa09zMnv9l+93l8eiVaaIhjDfGmI8Kd3z5TjPEqOIeuxi8JGgJRz+sA/XVb/5obibQPlZ9yZwiutLWLmH+rnn0/gHLjmBCnq3v7WnrFGdYPqnr5fJMwUgAMqevpc9uxLRdxU9KjFft6o8ksnVs252Sn1b/WRW/xIU6hAXmo4Nk+ElpQHwAThaxdX6TTDPMTbz/DKxIGf/ovPrHkZ8FZ50FzkSOX0Fo/EHe0pBP2bc1LoFlCUMKqcFBj95me+uj5n5fi/QMwOpZh9VxCMMzzWd1KZkrFYV5OZxiUV1couFM1foZCyCqXYe4oDd9QZ1gjtOVPNnF+7afu2WXknCX0rLJJUNRji95Wvc6ROdOYEOYnHwW5955EbQT2ZcaoUpPHy95zsXrgzbs9UoSspRt7uiaAclAdZqLf2CeIf6B8FP0sUjkMju9PyjUDWUTymHkhIxG2Z+pAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 23, 2024 at 02:16:19PM -0400, Liam R. Howlett wrote: > * Lorenzo Stoakes [241023 11:16]: > > On Wed, Oct 23, 2024 at 05:01:29PM +0200, Vlastimil Babka wrote: > > > On 10/22/24 22:40, Lorenzo Stoakes wrote: > > > > Previously, we'd always try to merge a file-backed VMA if its flags were > > > > changed by the driver. > > > > > > > > This however is rarely meaningful as typically the flags would be changed > > > > to VM_PFNMAP or other VM_SPECIAL flags which are inherently unmergable. > > > > > > > > In cases where it is meaningful (for instance DAX) it is doubtful that this > > > > > > Hm if that's true, I'm imagining many piecemeal mmap()s of DAX that used to > > > merge but now will create tons of VMA's, which doesn't sound great. Then it > > > has also potentially breaking effects on mremap() which doesn't work accross > > > multiple VMA's. > > > > I said this repeatedly to you and Liam but you both still seemed to want > > this :)) > > > > Anyway, yes. I mean you're pretty crazy if you are mapping a bunch of > > adjacent DAX ranges that are all otherwise mergeable next to one another, > > then on that basis assuming that you can mremap() the whole thing. > > Today, this will only work if there is a previous vma, otherwise we skip > the attempt to merge. It's probably a safe bet that there is a previous > vma, but it still means relying on this merging is broken today. True, but I also have a cunning plan, based on what Vlasta was getting at with another idea that was possibly not quite as cunning that means we might be able to still do this but in a much less terrible way... > > > > > > > > > > optimisation is worth the effort and maintenance risk of having to unwind > > > > state and perform a merge. > > > > > > What if we simply created a new vma but only then checked if the flags > > > changed and we can merge it with neighbours (i.e. like the mprotect() > > > merging case). Less efficient, but less tricky and with the same result > > > hopefully? > > > > I'd probably rather just drop this idea rather than wade into something > > entirely new, but let me look at whether we can leverage > > vma_modify_flags(). > > > > I have a feeling we can't because we already explicitly reset state in the > > merge new VMA case, and we'd be introducing a new way in which state could > > get mangled. > > > > But I'll take a look and see, otherwise we can just drop this for now and > > potentially come back to it later, the key bit of the non-backport patches > > are 5-7 anyway. > > > > > > > > > Since we've observed bugs and resource leaks due to complexity in this > > > > area, it is simply not acceptable to have a 'nice to have' optimisation > > > > like this complicating an already very complicated code path, so let's > > > > simply eliminate it. > > > > > > > > Signed-off-by: Lorenzo Stoakes > > > > --- > > > > mm/vma.c | 39 ++------------------------------------- > > > > 1 file changed, 2 insertions(+), 37 deletions(-) > > > > > > > > diff --git a/mm/vma.c b/mm/vma.c > > > > index a271e2b406ab..fe1fe5099e78 100644 > > > > --- a/mm/vma.c > > > > +++ b/mm/vma.c > > > > @@ -2260,8 +2260,7 @@ static int __mmap_prepare(struct mmap_state *map) > > > > return 0; > > > > } > > > > > > > > -static int __mmap_new_file_vma(struct mmap_state *map, struct vm_area_struct *vma, > > > > - struct vm_area_struct **mergep) > > > > +static int __mmap_new_file_vma(struct mmap_state *map, struct vm_area_struct *vma) > > > > { > > > > struct vma_iterator *vmi = map->vmi; > > > > struct vma_merge_struct *vmg = map->vmg; > > > > @@ -2291,34 +2290,6 @@ static int __mmap_new_file_vma(struct mmap_state *map, struct vm_area_struct *vm > > > > (vma->vm_flags & VM_MAYWRITE)); > > > > > > > > vma_iter_config(vmi, vmg->start, vmg->end); > > > > - /* > > > > - * If flags changed after mmap_file(), we should try merge > > > > - * vma again as we may succeed this time. > > > > - */ > > > > - if (unlikely(map->flags != vma->vm_flags && vmg->prev)) { > > > > - struct vm_area_struct *merge; > > > > - > > > > - vmg->flags = vma->vm_flags; > > > > - /* If this fails, state is reset ready for a reattempt. */ > > > > - merge = vma_merge_new_range(vmg); > > > > - > > > > - if (merge) { > > > > - /* > > > > - * ->mmap() can change vma->vm_file and fput > > > > - * the original file. So fput the vma->vm_file > > > > - * here or we would add an extra fput for file > > > > - * and cause general protection fault > > > > - * ultimately. > > > > - */ > > > > - fput(vma->vm_file); > > > > - vm_area_free(vma); > > > > - vma_iter_free(vmi); > > > > - *mergep = merge; > > > > - } else { > > > > - vma_iter_config(vmi, vmg->start, vmg->end); > > > > - } > > > > - } > > > > - > > > > map->flags = vma->vm_flags; > > > > return 0; > > > > } > > > > @@ -2341,7 +2312,6 @@ static int __mmap_new_vma(struct mmap_state *map, struct vm_area_struct **vmap) > > > > { > > > > struct vma_iterator *vmi = map->vmi; > > > > struct vma_merge_struct *vmg = map->vmg; > > > > - struct vm_area_struct *merge = NULL; > > > > int error = 0; > > > > struct vm_area_struct *vma; > > > > > > > > @@ -2365,7 +2335,7 @@ static int __mmap_new_vma(struct mmap_state *map, struct vm_area_struct **vmap) > > > > } > > > > > > > > if (vmg->file) > > > > - error = __mmap_new_file_vma(map, vma, &merge); > > > > + error = __mmap_new_file_vma(map, vma); > > > > else if (map->flags & VM_SHARED) > > > > error = shmem_zero_setup(vma); > > > > else > > > > @@ -2374,9 +2344,6 @@ static int __mmap_new_vma(struct mmap_state *map, struct vm_area_struct **vmap) > > > > if (error) > > > > goto free_iter_vma; > > > > > > > > - if (merge) > > > > - goto file_expanded; > > > > - > > > > #ifdef CONFIG_SPARC64 > > > > /* TODO: Fix SPARC ADI! */ > > > > WARN_ON_ONCE(!arch_validate_flags(map->flags)); > > > > @@ -2393,8 +2360,6 @@ static int __mmap_new_vma(struct mmap_state *map, struct vm_area_struct **vmap) > > > > * call covers the non-merge case. > > > > */ > > > > khugepaged_enter_vma(vma, map->flags); > > > > - > > > > -file_expanded: > > > > ksm_add_vma(vma); > > > > > > > > *vmap = vma; > > > > -- > > > > 2.47.0 > > >