From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B855AC77B7A for ; Tue, 16 May 2023 14:36:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CE64900009; Tue, 16 May 2023 10:36:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 357B2900002; Tue, 16 May 2023 10:36:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D13B900009; Tue, 16 May 2023 10:36:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0A747900002 for ; Tue, 16 May 2023 10:36:07 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5DEBA1A0309 for ; Tue, 16 May 2023 14:36:06 +0000 (UTC) X-FDA: 80796367932.14.A2955E8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id AEFE6160022 for ; Tue, 16 May 2023 14:36:03 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GwNU2jVX; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684247763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HDtlWQaTJft8O2op6owZ91p6/RHXC3pnklg9iA3D7Gs=; b=JVoIrXyS/w3sIDokYXKyhOBmd18r345yjuQu1SL4u8bv/jeRA0vBQJsbLCdVYxf1L/+A1d 7U+05pQJnm7cmGi9vOdXIpeb0ItE21qyV8PsS9deMHoivxtGzKhp+6k6XBPt5N/LsY6eok NTuichABp2ohNp4FbGsrXu0f4677gnE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684247763; a=rsa-sha256; cv=none; b=MSCLeAI7U4guq1hcqGol+Vmugj4q7brjRwS9i7EcLV2vUCm3QFTmU+hbEKnRTDt9ee/Z0J xK1wL5FQMVgexS6z7Mhut0UP6e6qd9uSCeFPHdbBFVWuhoQHBFtGm+rk7T9E/tNeXEzcvr 14AR1Lqc4E1xRP7tf97szqMEXuHvlVo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GwNU2jVX; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684247762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HDtlWQaTJft8O2op6owZ91p6/RHXC3pnklg9iA3D7Gs=; b=GwNU2jVXuUSEPvp/FzFFnijUdMuy5Nr9BffD0SVYeWB1Fcvgr1DVLV858MA0o/9O6AEEs5 6sAnJ9jANU5q8X2wsGbFJhvghTrEmUsAeply9jCxoNilAAvAaDvJjzrqpg4tlaY9p8Yfxk v9Rb+eNgY3rEmOjgy4VZoVaCOBLOZ9M= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-176-HAnh68JIObuBGF4lRLXNiA-1; Tue, 16 May 2023 10:36:01 -0400 X-MC-Unique: HAnh68JIObuBGF4lRLXNiA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f423d47945so37449045e9.0 for ; Tue, 16 May 2023 07:36:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684247760; x=1686839760; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HDtlWQaTJft8O2op6owZ91p6/RHXC3pnklg9iA3D7Gs=; b=j3X9vOjwzBsTcjj96yJfwaV0rJHKPu5fCGxUp/dkD+EwuUkpp6ArmTEgC6LzJF6oyX YYHIkEzrbjJyATA1mlN8w6EPZFmZ8HB7ZyWGpxpqi+p0w8MuJMiM6SgWRdfk+TZZOiTL oyRx44TRZAmfjF9wsmwLb4KbhUF2i4MvUCIKxiTxQEg8nZ7hWe4VRwKn9STNnwULbZH4 g5CvSITU2XC+zfdeB2O6LIixzf20MyXpPx+IZrTFApCw7IgvVHjDyUueGuOvMJB0eYSQ F91MnuPNKMrHrLL/96GpeWzDevAkhMyLv/vluBTybXA1TbRAVWE0nezUb17RrmDdC8yM q/Mg== X-Gm-Message-State: AC+VfDyVFOlNxZMHOughgfstXx2xYNrDE+7/40AuBbGnd1gAfNl6J2WW ktHMelgLBQbYmsPVVzGP5UnqnoSCffnQEeeRk2aqSONpclU+RenWuhM+YBFzwR/fMiR32LbpWMF vQHeU6MA6Ofs= X-Received: by 2002:adf:f58f:0:b0:306:b3f9:e2c9 with SMTP id f15-20020adff58f000000b00306b3f9e2c9mr28308368wro.6.1684247760145; Tue, 16 May 2023 07:36:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ43W1M/r+a9sBvXVLNjQ1rWzK4b+y6axsJM1bg4sF6/pP33gd7tOg3iz5gfyS0T7ZUiF6igvw== X-Received: by 2002:adf:f58f:0:b0:306:b3f9:e2c9 with SMTP id f15-20020adff58f000000b00306b3f9e2c9mr28308347wro.6.1684247759798; Tue, 16 May 2023 07:35:59 -0700 (PDT) Received: from ?IPV6:2003:cb:c74f:2500:1e3a:9ee0:5180:cc13? (p200300cbc74f25001e3a9ee05180cc13.dip0.t-ipconnect.de. [2003:cb:c74f:2500:1e3a:9ee0:5180:cc13]) by smtp.gmail.com with ESMTPSA id x2-20020a05600c21c200b003f508777e33sm2586081wmj.3.2023.05.16.07.35.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 May 2023 07:35:59 -0700 (PDT) Message-ID: <7e9651d6-382a-287c-cd08-03762ccce1f7@redhat.com> Date: Tue, 16 May 2023 16:35:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v5 1/6] mm/gup: remove unused vmas parameter from get_user_pages() To: Sean Christopherson Cc: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Matthew Wilcox , x86@kernel.org, linux-sgx@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kvm@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Jarkko Sakkinen , "H . Peter Anvin" , Xinhui Pan , David Airlie , Daniel Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , Paolo Bonzini , Jens Axboe , Pavel Begunkov , Jason Gunthorpe , John Hubbard , Christian Konig , Jason Gunthorpe References: From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: a8tohxb3unsqfsmqwh6ansktxgjdep1f X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: AEFE6160022 X-HE-Tag: 1684247763-460929 X-HE-Meta: U2FsdGVkX1+AHeirqF8leZ3B0ftDaxt2imXMqfJ3VDdxsm5yCnsbV3xcYehVcdVoZMUiOqJeK1ItIuH760YzXLGWLOYsagSCQLfV9Q+DHVPTdlt/Dl71Cj4W6X8JcZ6AmmWQjYTaPkEQ2S15X1w5RnjQSGJIixXn2mra+9RUktiADVH+okgTRVBwuIC68DsPaStJ6cvrgpnnGRINTjCZOCrYBLJhk4gUld3O11N2UkkN8b/ZMR2Z6smGuHxpaJsbhQlVt+xn2GtC3e5sxdocwTLXq7oqDZRSoH8CL3ldkXoCOAtGPCa2e94K0JO/98fLhaBK3OFRH9MnoVoeJScZBOTPJr3p/cgiyRiePejr5H+ZUc13peO6nSuM3kjZNrfjWvglYjV3uPE2+aGElNaoupxlFnS0zP2Ya6h/2p/dTw1z2d8qKtluwcbXr/jR0JeYNB0YqnkqfMSHyWLfZRIGClWDaG5z4H9FxpYtbIRzn8C9gberF7B5XG3KOGh5lOqhMwZoTVTptUv/V62nVsFza4HePEyf4GLPjyiGbSHRfhN84sREChkmuwV569YMu+RiTeqx9WzXS8SRXxsSNDXIwCbvvL8NB8nMJDQp/JvA8UBDVEWo78wjcWOdk3uAaVH5rugbSoRPpHVXnK1vx5Cd3HxNa9Xnu1ruqIgMZbGmDqMDEr/g058cRS7xRTRLXZjrHZkMcu/xvDU0ljNP7YIYomLd5qaueIhXO57vkF0wlqAWKeIxPtiXlTaoB/qehPyg8Os5MnrAFoEBKjMOI2sC7/BptsP+lZ5BkVi2Vv3Tz6cgvAJRXwOc94Me9zDSgTZZk6Cyi41pPn0rBebtd5GjgXDHjZbMhwzd8UmUlNn4iBJDYXRzeR8dIudvcCIeQYu3voku8lpk8jxbcYXqOWvYNlxqQZ8hU3UW+H1zWGrZdTrhwPzfvLaQ/UQtpJkECheHNpWSBy9mIUnA8eP7M88 bKa/6lRH 7RHHMWeEL4FsF/d4IUQr6exHkYcEAkywDbVoe+ng0HZTzngAf1Dw+f3XjL1rvJpdeUUWUcJWps1Qu+nNEnY6yYs24DBwCk5SOOl845Fml9HPO1LsU5zhictUWST+t9Mu/7G5JrGy6Zn7955uWX5dEjCnsTYTWs7IPudTQ2zO29880h8gGXT+HEVUuBNXV2p3W/kvDCQH8RAQOCyFSuxqzsl5oUsHT+jIS8fmDGASuQOUrkF7+R15VGmXOPDJ1g/4ukr3LBXysKumVPCfjFQAig+a2FOfAQzdS/RlR0h1qb2xkR31bnJfiQ2M78OefL+fXOXZoQID9jhNUizkdHGY3RNLdjemr2ulzhrwixZ4J2hDeeZbBjOrNUZVNVKqScSR6bUW7/RH8r4YuaAVj+criFZlCLGqG6yuPKWIGC4jwiv8WHUxLK6ldkW4qyJ6BcnZdMebJtSvmQAcZ9N1b9KnFLlBZw0yTqHVCsj0Xvx4wJ0zBCqOFDXBmcqG/Ew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.05.23 16:30, Sean Christopherson wrote: > On Tue, May 16, 2023, David Hildenbrand wrote: >> On 15.05.23 21:07, Sean Christopherson wrote: >>> On Sun, May 14, 2023, Lorenzo Stoakes wrote: >>>> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c >>>> index cb5c13eee193..eaa5bb8dbadc 100644 >>>> --- a/virt/kvm/kvm_main.c >>>> +++ b/virt/kvm/kvm_main.c >>>> @@ -2477,7 +2477,7 @@ static inline int check_user_page_hwpoison(unsigned long addr) >>>> { >>>> int rc, flags = FOLL_HWPOISON | FOLL_WRITE; >>>> - rc = get_user_pages(addr, 1, flags, NULL, NULL); >>>> + rc = get_user_pages(addr, 1, flags, NULL); >>>> return rc == -EHWPOISON; >>> >>> Unrelated to this patch, I think there's a pre-existing bug here. If gup() returns >>> a valid page, KVM will leak the refcount and unintentionally pin the page. That's >> >> When passing NULL as "pages" to get_user_pages(), __get_user_pages_locked() >> won't set FOLL_GET. As FOLL_PIN is also not set, we won't be messing with >> the mapcount of the page. For completeness: s/mapcount/refcount/ :) > > Ah, that's what I'm missing. -- Thanks, David / dhildenb