From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] mm: make mmap_region() internal
Date: Thu, 12 Dec 2024 16:48:56 +0000 [thread overview]
Message-ID: <7e94dbb3-e69d-47aa-bae2-741a94fbe23c@lucifer.local> (raw)
In-Reply-To: <Z1sFDCx8m4-TPjqG@casper.infradead.org>
On Thu, Dec 12, 2024 at 03:45:16PM +0000, Matthew Wilcox wrote:
> On Thu, Dec 12, 2024 at 03:36:47PM +0000, Lorenzo Stoakes wrote:
> > +++ b/mm/vma.h
> > @@ -242,9 +242,9 @@ bool vma_wants_writenotify(struct vm_area_struct *vma, pgprot_t vm_page_prot);
> > int mm_take_all_locks(struct mm_struct *mm);
> > void mm_drop_all_locks(struct mm_struct *mm);
> >
> > -unsigned long __mmap_region(struct file *file, unsigned long addr,
> > - unsigned long len, vm_flags_t vm_flags, unsigned long pgoff,
> > - struct list_head *uf);
> > +unsigned long mmap_region(struct file *file, unsigned long addr,
> > + unsigned long len, vm_flags_t vm_flags, unsigned long pgoff,
> > + struct list_head *uf);
>
> Please don't line up the arguments with the paren. Just leave it as two
> tabs.
>
Ack, emacs likes to do this, will tweak on respin assuming mips guys
confirm that idea works!
next prev parent reply other threads:[~2024-12-12 16:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 15:36 [RFC PATCH 0/2] mm: update mips to use do_mmap(), " Lorenzo Stoakes
2024-12-12 15:36 ` [RFC PATCH 1/2] mips: vdso: prefer do_mmap() to mmap_region() Lorenzo Stoakes
2024-12-12 15:36 ` [RFC PATCH 2/2] mm: make mmap_region() internal Lorenzo Stoakes
2024-12-12 15:45 ` Matthew Wilcox
2024-12-12 16:48 ` Lorenzo Stoakes [this message]
2024-12-17 8:23 ` [RFC PATCH 0/2] mm: update mips to use do_mmap(), " Thomas Bogendoerfer
2024-12-17 14:11 ` Liam R. Howlett
2025-01-02 11:46 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e94dbb3-e69d-47aa-bae2-741a94fbe23c@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tsbogend@alpha.franken.de \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox