From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1FE5C021B2 for ; Tue, 25 Feb 2025 12:25:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D164E6B007B; Tue, 25 Feb 2025 07:25:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CC5B46B0082; Tue, 25 Feb 2025 07:25:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8D256B0085; Tue, 25 Feb 2025 07:25:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9C0EA6B007B for ; Tue, 25 Feb 2025 07:25:31 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0CC21A2B93 for ; Tue, 25 Feb 2025 12:25:31 +0000 (UTC) X-FDA: 83158387662.10.1E201E1 Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) by imf23.hostedemail.com (Postfix) with ESMTP id 0C091140007 for ; Tue, 25 Feb 2025 12:25:28 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=sipsolutions.net header.s=mail header.b=GquY8h6k; spf=pass (imf23.hostedemail.com: domain of benjamin@sipsolutions.net designates 168.119.38.16 as permitted sender) smtp.mailfrom=benjamin@sipsolutions.net; dmarc=pass (policy=none) header.from=sipsolutions.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740486329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RW9/j1aXxH33eV1Xb7A0zQmmh3OO9ZTRX9XziHJWwh4=; b=quyW67Qxib1uAUPrEvZMAlpFjA9ip7t3sAlyJgGAkillTMQ+EjxKY/tNoKsx2ozynpSS6X HONNHCq25GL0MIuQssks/LjayU97snMyGd/8TY8CGEqICq1aXgHO5LB5DtRl4gqxDVGLRI o7L71LWSfyTSaCZBOAC0xYMMmM4EzaM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=sipsolutions.net header.s=mail header.b=GquY8h6k; spf=pass (imf23.hostedemail.com: domain of benjamin@sipsolutions.net designates 168.119.38.16 as permitted sender) smtp.mailfrom=benjamin@sipsolutions.net; dmarc=pass (policy=none) header.from=sipsolutions.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740486329; a=rsa-sha256; cv=none; b=XYu83FKafU2vC1QHvm5dD2hNMGlCPCjyg1dLVJduqi7yz0315fgs1JrNjHfTOuqOhDhjZT ltbfFVRU3JosYsw4M81OIKuSY9J48u1PaxWVS4mc+yl8PGB8yZRWYjs9IaExJcBXEbrOaT Faa7WHWlByxgBOG7dz34V87p4jmV4xg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=RW9/j1aXxH33eV1Xb7A0zQmmh3OO9ZTRX9XziHJWwh4=; t=1740486329; x=1741695929; b=GquY8h6kHzuLT7W00cfrZzO5mW2sz77rJFYANTOQHo8n1UK OUJVEf8p9zqtVGFXUUyoFUnSCVhNgLZGjdZ4x5IyKdzeyt9dLlz4LTjBok3StsPxx+qk3Y83aaQAl MOWds8c3S+Busx/HPtXfm5xrYDLTHDdxV/pEWtCoTBYRirn2URWH3vjhfAmaSFHVeHa/chIfLyEh8 Hr1O5vonVQph5MRAWyGUTCQJ4uPxbTYUwFOhTssuK324vbslxIscR0PZf/LrwT7jKm2abnOEN1pRJ MVJLjX44uBWN8wJ/hGgoHWyrmIM5ie/MLTbNLnHSFKtNm0cfQa4QFCIJ2Gk0Ym9A==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98) (envelope-from ) id 1tmtzX-00000009sLI-41WK; Tue, 25 Feb 2025 13:24:52 +0100 Message-ID: <7e91bea34552472757a8eec425d1d10643ca584b.camel@sipsolutions.net> Subject: Re: [PATCH v7 5/7] mseal, system mappings: enable uml architecture From: Benjamin Berg To: Lorenzo Stoakes Cc: "jeffxu@chromium.org" , "Jason@zx2c4.com" , "adobriyan@gmail.com" , "deller@gmx.de" , "gerg@kernel.org" , "anna-maria@linutronix.de" , "davem@davemloft.net" , "avagin@gmail.com" , "mhocko@suse.com" , "enh@google.com" , "thomas.weissschuh@linutronix.de" , "hch@lst.de" , "hca@linux.ibm.com" , "peterz@infradead.org" , "adhemerval.zanella@linaro.org" , "linux-kernel@vger.kernel.org" , "ojeda@kernel.org" , "jannh@google.com" , "f.fainelli@gmail.com" , "sroettger@google.com" , "ardb@google.com" , "jorgelo@chromium.org" , "rdunlap@infradead.org" , "mark.rutland@arm.com" , "Liam.Howlett@oracle.com" , "vbabka@suse.cz" , "mpe@ellerman.id.au" , "oleg@redhat.com" , "willy@infradead.org" , "keescook@chromium.org" , "peterx@redhat.com" , "mike.rapoport@gmail.com" , "mingo@kernel.org" , "rientjes@google.com" , "groeck@chromium.org" , "linus.walleij@linaro.org" , "pedro.falcato@gmail.com" , "ardb@kernel.org" , "42.hyeyoo@gmail.com" <42.hyeyoo@gmail.com>, "linux-mm@kvack.org" , "johannes@sipsolutions.net" , "linux-hardening@vger.kernel.org" , "torvalds@linux-foundation.org" , "akpm@linux-foundation.org" , "dave.hansen@linux.intel.com" , "aleksandr.mikhalitsyn@canonical.com" Date: Tue, 25 Feb 2025 13:24:49 +0100 In-Reply-To: References: <20250224225246.3712295-1-jeffxu@google.com> <20250224225246.3712295-6-jeffxu@google.com> <96ebddf3fe31353c89f6a4680eaeb2793c25cd09.camel@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0C091140007 X-Stat-Signature: i7my49w5xm877fssmay1kxyogrgqnz8e X-HE-Tag: 1740486328-733724 X-HE-Meta: U2FsdGVkX1+8m5qd2jQvqMuJ6XehUhLLnVKIVcteISIAfr63dzYlePIjS4LB358jxULv0ljFO47kdrKS+K9sJtqp1KtJ1ELmmEVtxWS5LVybQyBdaeeUa9AlpoZ1mhImMw0oUgdrnZJIbDGcNEQ8KBXlx/1UuC1dlPgZL3MHyD6yGpdL97fekV3tdggnXydCDg0/e9Nyna5UnOl2E0WFi8bOGEDxtZCenBmdtzuKiQ7x1qil3JJLjCU2yuvfiJntxEa/Lu9ZIysiUVVDYHjT04KtMjK0TFeWAvfTp62pUSpUGkmsw/wuobNC43XQGvz80MLlvIjydEODPaDeDThx+RyWDdXleBbfCYaae9TD7WAWFCy/cI6FOSV8uXsuEypWCltPDrL4ONHQCo3KdhTYR1m98A9nf0f2ZE2o+oxOzEci7y3COT39rDG7vpuOfvYNJoRz8Kzyh8ehwXenlHtDJsZpYY3kKAmS2ez/kA9qERKZqDij+j17X/JoFS+ThKtz0bqUNSjurGPrCfykuovwVamQ2TCpZBTZJfwTy+9qjhum2Esx0Wppyjxa/EpXjPQ6I6PEfu1tQgMG0ZHMaqjZuH7jcz12Ll9jFdpuG9GorwLtiHfFtDymBaN+INpCAe4MxIJIVDiS7g0E2vS8z7m9h168l3jEaemrYiuv3rvFToa2+1j2P4pMMpxMDq6J+DYM9Je0jTnhqL0tljrJsQZAy+T+cRe/52Jqly8EsYZ7IGWrEkqZFOvp71zZZ5yq9mqAoRQJcs7lOL3Ilbzi1hnWuL04sQuIm+csIl6UicgHu9B2lNDABvaZtj/4EXvNkJr9NhcWoFjo4qY/cpG7wxZFrvMLts/dYq4p8hoaEmYaDNtA8N77N2YMWSoaGeIDWTwdhu49bYubolna7DI36stHRoycLwLaNzZV1v/i+t89yRAmXGCgec9sNU6rSh0eIb/C0CTfs6nFBRMsblqiJUd ScwREXJx 6kwOtQ51HhtGq1EO2oiPB9EVNAueEDKHFMdw1s+/dzTHO6legHRiv4PXOf6z9xX6WGXQmWups8+vwX1j/eUomeMTGZbIL4eKjJLS2YLepf66JekbHtp/XaXxTyi/L6uA8ejNPikcwMBKg4O+GzipmzgMa3LGnYlw+ZP0qji8cEiqkhPt2b9uO1KLvGD8p8ItlFPQNoyzXhY+KO3CCULJPJJDmQjSU/KaLkBtcM+cg25CR4FuKf9rY3cBU5ulGniUgEVY3aASp/UX0cs6sc195OaYvd2fuZWZq/L1+1SMdDIWy8yXYAqC9pdxvZInZbrn48CWdl4x5iAoUH+IRxHBzX4UFCP55Kb+kOVx6vcMw25F4LmXLPOYMYxnZw/smBW96fAmxrRgRx73O0PWVnFCC8CznV9di1g9g9IuaHVKqmX2fOeR/Q4mqmk/yaQ2RzxliHawzctmIn7OqDUKyWS4MfUGnOx0DzV0YsnJJDjKYinBDAzI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Tue, 2025-02-25 at 10:37 +0000, Lorenzo Stoakes wrote: > On Tue, Feb 25, 2025 at 08:45:21AM +0000, Berg, Benjamin wrote: > > Hi, > >=20 > > On Tue, 2025-02-25 at 06:22 +0000, Lorenzo Stoakes wrote: > > > On Mon, Feb 24, 2025 at 10:52:44PM +0000, jeffxu@chromium.org=C2=A0wr= ote: > > > > From: Jeff Xu > > > >=20 > > > > Provide support for CONFIG_MSEAL_SYSTEM_MAPPINGS on UML, covering > > > > the vdso. > > > >=20 > > > > Testing passes on UML. > > >=20 > > > Maybe expand on this by stating that it has been confirmed by Benjami= n (I > > > _believe_) that UML has no need for problematic relocation so this is= known to > > > be good. > >=20 > > I may well be misreading this message, but this sounds to me that this > > is a misinterpretation. So, just to clarify in case that is needed. > >=20 > > CONFIG_MSEAL_SYSTEM_MAPPINGS does work fine for the UML kernel. > > However, the UML kernel is a normal userspace application itself and > > for this application to run, the host kernel must have the feature > > disabled. > >=20 > > So, UML supports the feature. But it still *cannot* run on a host > > machine that has the feature enabled. >=20 > Sigh ok. Apologies if I misunderstood. >=20 > Is there any point having this for the 'guest' system? I mean security wi= se are > we concerned about sealing of system mappings? >=20 > I feel like having this here might just add confusion and churn if it's n= ot > useful. >=20 > If this is useless for UML guest, let's just drop this patch. I figured it is not a lot of churn and there isn't really any cost to enabling the feature. That said, the only possible real-life use case I can see is doing MM subsystem testing using UML. We certainly do not need the feature to run our UML based wireless stack and driver tests. Benjamin >=20 > >=20 > > Benjamin > >=20 > > >=20 > > > >=20 > > > > Signed-off-by: Jeff Xu > > > > Tested-by: Benjamin Berg > > >=20 > > > Anyway I know UML has at any rate been confirmed to be good to go + > > > patch looks > > > fine, so: > > >=20 > > > Reviewed-by: Lorenzo Stoakes >=20 > OK guess drop this tag please until we can figure this out, sorry Jeff. >=20 > > >=20 > > > > --- > > > > =C2=A0arch/um/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 1= + > > > > =C2=A0arch/x86/um/vdso/vma.c | 6 ++++-- > > > > =C2=A02 files changed, 5 insertions(+), 2 deletions(-) > > > >=20 > > > > diff --git a/arch/um/Kconfig b/arch/um/Kconfig > > > > index 18051b1cfce0..eb2d439a5334 100644 > > > > --- a/arch/um/Kconfig > > > > +++ b/arch/um/Kconfig > > > > @@ -10,6 +10,7 @@ config UML > > > > =C2=A0 select ARCH_HAS_FORTIFY_SOURCE > > > > =C2=A0 select ARCH_HAS_GCOV_PROFILE_ALL > > > > =C2=A0 select ARCH_HAS_KCOV > > > > + select ARCH_HAS_MSEAL_SYSTEM_MAPPINGS > > > > =C2=A0 select ARCH_HAS_STRNCPY_FROM_USER > > > > =C2=A0 select ARCH_HAS_STRNLEN_USER > > > > =C2=A0 select HAVE_ARCH_AUDITSYSCALL > > > > diff --git a/arch/x86/um/vdso/vma.c b/arch/x86/um/vdso/vma.c > > > > index f238f7b33cdd..fdfba858ffc9 100644 > > > > --- a/arch/x86/um/vdso/vma.c > > > > +++ b/arch/x86/um/vdso/vma.c > > > > @@ -54,6 +54,7 @@ int arch_setup_additional_pages(struct > > > > linux_binprm *bprm, int uses_interp) > > > > =C2=A0{ > > > > =C2=A0 struct vm_area_struct *vma; > > > > =C2=A0 struct mm_struct *mm =3D current->mm; > > > > + unsigned long vm_flags; > > > > =C2=A0 static struct vm_special_mapping vdso_mapping =3D { > > > > =C2=A0 .name =3D "[vdso]", > > > > =C2=A0 }; > > > > @@ -65,9 +66,10 @@ int arch_setup_additional_pages(struct > > > > linux_binprm *bprm, int uses_interp) > > > > =C2=A0 return -EINTR; > > > >=20 > > > > =C2=A0 vdso_mapping.pages =3D vdsop; > > > > + vm_flags =3D > > > > VM_READ|VM_EXEC|VM_MAYREAD|VM_MAYWRITE|VM_MAYEXEC; > > > > + vm_flags |=3D VM_SEALED_SYSMAP; > > > > =C2=A0 vma =3D _install_special_mapping(mm, um_vdso_addr, > > > > PAGE_SIZE, > > > > - VM_READ|VM_EXEC| > > > > - VM_MAYREAD|VM_MAYWRITE|VM_MAYEXEC, > > > > + vm_flags, > > > > =C2=A0 &vdso_mapping); > > > >=20 > > > > =C2=A0 mmap_write_unlock(mm); > > > > -- > > > > 2.48.1.658.g4767266eb4-goog > > > >=20 > >=20 > > Intel Deutschland GmbH > > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > > Tel: +49 89 99 8853-0, www.intel.de > > Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon S= ilva > > Chairperson of the Supervisory Board: Nicole Lau > > Registered Office: Munich > > Commercial Register: Amtsgericht Muenchen HRB 186928