From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3F03C433EF for ; Thu, 7 Jul 2022 20:24:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56FD16B0072; Thu, 7 Jul 2022 16:24:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 520806B0073; Thu, 7 Jul 2022 16:24:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E64B900002; Thu, 7 Jul 2022 16:24:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2E74E6B0072 for ; Thu, 7 Jul 2022 16:24:37 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0A1A8465 for ; Thu, 7 Jul 2022 20:24:37 +0000 (UTC) X-FDA: 79661431794.21.E3B34C6 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf12.hostedemail.com (Postfix) with ESMTP id 1C28240027 for ; Thu, 7 Jul 2022 20:24:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657225476; x=1688761476; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=9S4U58gUvPeeCjSN3x93j8R91fqGbZ/AvOS5Dl/SKkU=; b=BCJyQvO6Cxw6pQ1h9MyxKDzl79Xgc1ENbeN2paQ30sRm2s/UQL5jEE9H 0KscK5NoqM0enKbOoY+hGWnC3nlgXpnO1kHBcmALu2kqgmbWW2TSzvJKJ gwQFj15hYQoJAxgvV7965tyg++PDvfyOhlHo98cJK7yvBIlKUggHO3Saj 9CEPMHKaE+XYcsvqCfhKhX+LBaSlcXm+VXvYpWrJ2wRfKlUkZAb7iwDwq LB45ycg3qvX2AN31pYE9BZHYvnVxpYIMAHWH+8GiLihcDC7UQ03ENkahT xVkU0z0QS5e5oBFzBvMWCL8Mztt2eNXrMc9myV/ZoOzfdPezGrJivEiQe Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10401"; a="309676309" X-IronPort-AV: E=Sophos;i="5.92,253,1650956400"; d="scan'208";a="309676309" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2022 13:24:34 -0700 X-IronPort-AV: E=Sophos;i="5.92,253,1650956400"; d="scan'208";a="620937628" Received: from nmajidi-mobl.amr.corp.intel.com (HELO [10.251.17.238]) ([10.251.17.238]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2022 13:24:33 -0700 Message-ID: <7e89459c-41de-3d14-a87a-905150d47e3a@intel.com> Date: Thu, 7 Jul 2022 13:24:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [RFC 1/2] x86/mm/cpa: always fail when user address is passed Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Dan Williams , Paolo Bonzini , Jane Chu , "Aneesh Kumar K . V" , Sean Christopherson , Tianyu Lan , Mike Rapoport , Rick Edgecombe , linux-mm@kvack.org, Borislav Petkov , x86@kernel.org References: <20220614063933.13030-1-42.hyeyoo@gmail.com> <20220614063933.13030-2-42.hyeyoo@gmail.com> <660a5c93-e8cb-1c2f-5b27-c5e341de0bcd@intel.com> <1d6cfffd-582b-b3fa-75b2-5bf21519071b@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657225476; a=rsa-sha256; cv=none; b=Rd4TEuUZqWvYwBXd+ua9TOMvhRiI2d+rvskp5s/5YCDd/T0RkGIgXBqbtUGJAmPzgXiTqk jhXJOmA1u7J/4jMKwqsJaLZLW7NKuV4hOfOqfHWaArNMdBs2fGHgmt7JRGEOiHoKDo5EI6 3XvrSVMIbXz7YTPU3u2hslcBBVeMq1U= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=BCJyQvO6; spf=none (imf12.hostedemail.com: domain of dave.hansen@intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657225476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=brxHkpSMAwa/pjk/QDT6uTCz1r5iOaGnawSUdFVCu/0=; b=Vzy3SsCQHLdmEPO2g+uGtHhimhmG8JpRyJNnX48Xhv9FcmAJHu8wM7Ek1tyF31qWpdlj1o o0WhYhz/Z3cvxptYamW3g7FTQ12MBSMgcsvoZEMKICDpVqS0eLaOyYtqW0WLjuYiLuIQf5 dJoP6XAXKc0HmKnIbkSJ1wbRjicr1nE= X-Rspamd-Server: rspam08 X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=BCJyQvO6; spf=none (imf12.hostedemail.com: domain of dave.hansen@intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Stat-Signature: 4yfzpksrfkny1jjkza77d84nftt17m9r X-Rspamd-Queue-Id: 1C28240027 X-HE-Tag: 1657225475-522230 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/20/22 01:08, Hyeonggon Yoo wrote: >> It would, of course, have to be paired with _PAGE_PRESENT checks. This >> works both on the way in and out of the set_memory code. It shouldn't >> clear other bits a PTE with _PAGE_PRESENT|_PAGE_USER and > You mean nothing should not use set_memory code for PTEs with > _PAGE_USER|_PAGE_PRESENT but set_memory can still be used to clear > _PAGE_USER|_PAGE_PRESENT? I don't see a reason why it should be able to clear _PAGE_USER|_PAGE_PRESENT entries either.