From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB5E9C433EF for ; Wed, 13 Apr 2022 06:40:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79B796B0074; Wed, 13 Apr 2022 02:40:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74B746B0075; Wed, 13 Apr 2022 02:40:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6392C6B0078; Wed, 13 Apr 2022 02:40:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 544976B0074 for ; Wed, 13 Apr 2022 02:40:50 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0EB858249980 for ; Wed, 13 Apr 2022 06:40:50 +0000 (UTC) X-FDA: 79350907860.29.F53B366 Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) by imf19.hostedemail.com (Postfix) with ESMTP id D0CCB1A0002 for ; Wed, 13 Apr 2022 06:40:47 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0V9yAqdB_1649832040; Received: from 30.47.203.83(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0V9yAqdB_1649832040) by smtp.aliyun-inc.com(127.0.0.1); Wed, 13 Apr 2022 14:40:41 +0800 Message-ID: <7e7befd8-6558-d4c3-4d00-9b638a52d815@linux.alibaba.com> Date: Wed, 13 Apr 2022 14:41:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v3 4/4] hugetlb: Clean up hugetlb_cma_reserve To: Peng Liu , mike.kravetz@oracle.com, david@redhat.com, akpm@linux-foundation.org, yaozhenguo1@gmail.com, songmuchun@bytedance.com, liuyuntao10@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220413032915.251254-1-liupeng256@huawei.com> <20220413032915.251254-5-liupeng256@huawei.com> From: Baolin Wang In-Reply-To: <20220413032915.251254-5-liupeng256@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 745qgyjf1wpitzbepcg5bwoogpmsqeek Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.54 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D0CCB1A0002 X-HE-Tag: 1649832047-83916 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/13/2022 11:29 AM, Peng Liu wrote: > Use more generic functions to deal with issues related to online > nodes. The changes will make the code simplified. > > Signed-off-by: Peng Liu Looks more consistent. Thanks. Reviewed-by: Baolin Wang > --- > mm/hugetlb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 2e4d8d9fb7c6..4c529774cc08 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -6953,7 +6953,7 @@ void __init hugetlb_cma_reserve(int order) > if (hugetlb_cma_size_in_node[nid] == 0) > continue; > > - if (!node_state(nid, N_ONLINE)) { > + if (!node_online(nid)) { > pr_warn("hugetlb_cma: invalid node %d specified\n", nid); > hugetlb_cma_size -= hugetlb_cma_size_in_node[nid]; > hugetlb_cma_size_in_node[nid] = 0; > @@ -6992,7 +6992,7 @@ void __init hugetlb_cma_reserve(int order) > } > > reserved = 0; > - for_each_node_state(nid, N_ONLINE) { > + for_each_online_node(nid) { > int res; > char name[CMA_MAX_NAME]; >