From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D85AED75E5B for ; Fri, 22 Nov 2024 14:58:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3651C6B00A6; Fri, 22 Nov 2024 09:58:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EEB66B00BE; Fri, 22 Nov 2024 09:58:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 118996B00BF; Fri, 22 Nov 2024 09:58:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E2E546B00A6 for ; Fri, 22 Nov 2024 09:58:07 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 862C3418D6 for ; Fri, 22 Nov 2024 14:58:07 +0000 (UTC) X-FDA: 82814033778.19.64618AF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 8DF98140008 for ; Fri, 22 Nov 2024 14:57:29 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ReQX+4/H"; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732287391; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fybjabzIT5znve07EjSb13H+L13N+BBGf0ILqIbAicM=; b=AfE1dIU9dAxUgtPxeMWk92iTP3U8A55aBTUmQp9k5Yl+UWFaFPFUn3HkpxUjQVonh7Sfso KxcZryMxvLcbV3mBCFj06pk0500bcXslYa36ldxYoS3p1FzHhF7F5d9BzYclafNxL12UlF YvJZjKk9nkiswBe5npKwxXr840w2LsE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732287391; a=rsa-sha256; cv=none; b=fT8Z/Cuuj8GmjpMp7D/Z6kzL+Oq0k59PEiR0sCjI4lBif5xIxnDdphZLR5Y7dkEdFacDgT DcMzNAD1XGyjuFAhnJxgO+UUKVqA2D+I7AO+6xdtk8ruxkavBLBCfRG9uiKJyGSGFg7bhF 5pofVqK3AmWsz1ucJm1wW+rC9EtyIag= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ReQX+4/H"; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732287484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fybjabzIT5znve07EjSb13H+L13N+BBGf0ILqIbAicM=; b=ReQX+4/H9BJxYDGqnEOxlQQQxYoJctGkCJNtv+OXMAxbVHM7BRtW3zInjpQ40g3hE/Jt4i QyEoM/3IkmjNRU8/tzUPy6f6XpPJa+dZMaWilBfTLwWJL9d/XeJw6M5mq6zrdRM7mJ5ih5 e5sAeZdqQSmXT6rix/9eYypoE1lGTQA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-353-4ZWAR4mSN_uqoXH5TJAY6g-1; Fri, 22 Nov 2024 09:58:01 -0500 X-MC-Unique: 4ZWAR4mSN_uqoXH5TJAY6g-1 X-Mimecast-MFC-AGG-ID: 4ZWAR4mSN_uqoXH5TJAY6g Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4315dd8fe7fso19300205e9.3 for ; Fri, 22 Nov 2024 06:58:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732287480; x=1732892280; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fybjabzIT5znve07EjSb13H+L13N+BBGf0ILqIbAicM=; b=hf96BhcWMUakGUU6k57AJFvqaLE04eU8/YtvKhHXa72abJnxbY7oufbxs/lPzEa/8N hRlCY8cweVkcrUVXhvBp9xUidWCt3Sv8OaqEc7oLW98hnDSupWEL3m9esjcaEKIhr3N9 wkBRERE14BpOB8QsclejAQwkiN1P24LjVjmXfPHhJ2E3wWVFApMen3dI0uWgLS6b4WA6 nrhiUzp86bIlOk7SafEDNIbZST5FYQFRqtf7lKeIH3UTPqrEZzpf6uay1+miDQzKOr69 UiTUfi8GKrlBncYlhoKw1Bd9iS6au3UhLwUARmS4hg+E6940/s1dcS6WKrjD8HYiyTm+ dhaQ== X-Forwarded-Encrypted: i=1; AJvYcCV6a5b+uev5fO7A6PVY5PopBgN/U9rmqh8MYQBg5i3S/JJYaaCg6VnEVF/2xFQuu9wu+BLXobDysA==@kvack.org X-Gm-Message-State: AOJu0YwXWkxn8swn4BHrshtpbb0DnGLcw9m8Yio7bSFNVKQnKVIsJm02 W99TsDiKlnP2Iy4jh1bdMA4mKgABYSzJHlQMFCBD5htzKmggD1oOGrU27jxE0RsBJ/RE/ug3cMJ A3qH0wXhokN9Uqau2NfI8W8dYKcOaiNqS+DDqn27gcAmA3d4u X-Gm-Gg: ASbGncvJ+6B1iJV2spYVyOoluQxAMDhB1swTOxr+sD6cbg0Ll43abJVFYKZHlj+c1bc zTlyXLjSkU9+AfUIkyDz9sitpd8pDLo6Ch02kBe4jvBCHrSA1A8vNxHjoA7UMKFQVwByHun9U9o 7ZE+bXWy+x+ZZWpFSCqKU38PdoGzx2caOeq6y3lLDOrq64ps1+1bg2aWleKFu7g3MhABBeKOBs1 KOHivGcDJciMD3pvw8F/jeu34XzfFlo/pYXvhvxOz4rYmphGu12EMpWJ/PgOKxMrU7GpwbHzcX4 ZzfuMtXp6AFEnJSq7yfrIOets9mrvIp3ALBvnX39cDcLErzK+o+Dgr/BXxGFfJo20O+i3RwZR2c = X-Received: by 2002:a05:600c:3b86:b0:430:57e8:3c7e with SMTP id 5b1f17b1804b1-433ce4ab677mr25397445e9.28.1732287480065; Fri, 22 Nov 2024 06:58:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IF8XH1tv/O6C8QyGu25dCaFr3LPIMsxoUYDZtqzOCWi3LAQc9WQ2E2ledRWDkSxdt4HPjW6mg== X-Received: by 2002:a05:600c:3b86:b0:430:57e8:3c7e with SMTP id 5b1f17b1804b1-433ce4ab677mr25397295e9.28.1732287479772; Fri, 22 Nov 2024 06:57:59 -0800 (PST) Received: from ?IPV6:2003:cb:c70b:7a00:9ccd:493:d8e2:9ac8? (p200300cbc70b7a009ccd0493d8e29ac8.dip0.t-ipconnect.de. [2003:cb:c70b:7a00:9ccd:493:d8e2:9ac8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-433b45d4ce6sm92629955e9.25.2024.11.22.06.57.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Nov 2024 06:57:59 -0800 (PST) Message-ID: <7e6c2c57-d633-4052-95a9-31ccc9c66327@redhat.com> Date: Fri, 22 Nov 2024 15:57:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm/mempolicy: fix migrate_to_node() assuming there is at least one VMA in a MM To: "Liam R. Howlett" , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzbot+3511625422f7aa637f0d@syzkaller.appspotmail.com, stable@vger.kernel.org, Christoph Lameter References: <20241120201151.9518-1-david@redhat.com> <20241121221937.c41ee2b5e8534729e94fc104@linux-foundation.org> <608c7f17-037b-401b-9336-c26bd45d3147@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FivPJPQ3v0jwqqFkKZ85cBkRrGtt1CFyI6WZSJl8iAE_1732287480 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Stat-Signature: mopu3gagbgmes9m438uochyng555wbjg X-Rspamd-Queue-Id: 8DF98140008 X-Rspam-User: X-HE-Tag: 1732287449-869184 X-HE-Meta: U2FsdGVkX1/n0T9VOs4wFdp00mSSjbUa4sAjiMKS++DDoIcSzNFj2u4rOSgHyzznkq4Xb8xzwYYMdWvpopHGN9Rb3czKoKlgZncIMIDPeOYyvgCpjMgcV3kzhM6TmUd5YPngpZu393TLRd3nQSt176mzgn5xIMXu8Ij6rzgaca/V3L4YSQuX4jyltUsXF/+3084wBb0ERScM9N2ZxsJODgBOaQIo4FHuyAasBkCBbWVvNvHCijKdjdEAWyFgw6Aj2Wrg9Dv99ccoNsi9k56r9sR8ud4/P7LUBxiBUYEdB8yX46xroEwmo8ZZ178kIlQiCaGihHnrK2bE46Q9Phzbp3RXqU013ti15tFKyLkvHNPqVRN6ab6Ki+YIqa/ykn+IAKNlOt8uxs1/yhjU3euLUcbmRwVjBQpfocn4N51foTnhN6yShSiugAoXn3w13NdvMfPrHxnLUU76elEi1CNZSwkT5ZG/VSB16Lqs5N6ZG89zjF5bhiBAoS9hnja68+9+14FAtWjnVHSiPaAgsL5ok2xdJOrE7pX7pNi5YVImk1ALLEsR5LX21UHuR+vqLYoiPGAyylUnx3SLddF2AZPWtTJ9Ke6PQQM56nko7TUPbwJQ9SsJJc0+0BcBMS340/e7p5EDUJOuFT4KkzsuEb/8/oiEFZrAgBbbJWf/GGt0aWXqk+yU6wSIgdh4N+/QK17WZeVrlI4v6+HjyGAPYcoaV3JF0iw29BshyK+vTuDJrPE3rq/CjoS8ZmLN1sJpkUIU+xlWD/YYgy074h6RqctRdrlY6Pzwl1d0N1db8vm+hZcRgVPWhT0t8cyZtHvkqohDn7IPpXPnD2+727Hkmwct4l+8kM3uyVm5BkQBRS4GgJmcK8HbJ5axx2SJ+Td5ibdvpJNC54NSiHlTgF9ICeWFWyxFtqW8bmuwdBb/10Y8ds/Ls6SchB7g5g+FYtEqx1fAfqrgP8VdbRQTR5WIMrU 8w781TLM G2PbMBpG7+8/uU4bgekZKx90EcUhNuxY3Np3j0yLwm39WJGCUpSjFYHlOtFHIfF/UvISRG07CLAJt12qbQwZQ9yeHj7IaGnMNHMQR0WBXn4LX57s+yHCX+Dibnjr/VFkLFKL3IllkJ/FL5TE21V2wNNfpqzgf0p5fzOgV5fljVb9IGBzPCD/c6T7dTEss2lnEkk3I5ltqh2A9yvvXqqnTiOR75hvP2mTL/PXanXqCZvuc/q82WpgjeMgdZ1VBRq5NZL5QbYK5bGfXwG/vtho15IF3P0DLKs+U3MR5uoTe6Cdo4wkhOnvLtwTU4h24oxpe3NJw+wWyiipliziUl52nIfHQxG8B/dZuTjtevhftMBenkS5kiUDT9KOGYfpwRgsSjaM80XJXe+9AP976dLxVN465ROFOsid4OxATBR2CAckjx2edZFBYpxCVpU+fzuoA4LdErd2R2KyvtLMRebcXvPyo+JM5BzzmA+3h0R1DWo7yjayETLC4F9yRB+vCy6AcC6wntQaFF0HhZXrjpvRTagbyAT5eJaVFWp7hLuV3kY+GQLldk+vHXwPFLp4mmo+uMp/u9y9jX1R9h8NbbytMZ9QPUmoDSsWvtehRuPbEhCqxlSE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.11.24 15:44, Liam R. Howlett wrote: > * David Hildenbrand [241122 04:32]: >> On 22.11.24 07:19, Andrew Morton wrote: >>> On Wed, 20 Nov 2024 15:27:46 -0500 "Liam R. Howlett" wrote: >>> >>>> I hate the extra check because syzbot can cause this as this should >>>> basically never happen in real life, but it seems we have to add it. >>> >>> So.. >>> >>> --- a/mm/mempolicy.c~mm-mempolicy-fix-migrate_to_node-assuming-there-is-at-least-one-vma-in-a-mm-fix >>> +++ a/mm/mempolicy.c >>> @@ -1080,7 +1080,7 @@ static long migrate_to_node(struct mm_st >>> mmap_read_lock(mm); >>> vma = find_vma(mm, 0); >>> - if (!vma) { >>> + if (unlikely(!vma)) { >>> mmap_read_unlock(mm); >>> return 0; >>> } >>> _ >>> >>> ? >> >> Why not, at least for documentation purposes. Because I don't think this is >> any fast-path we really care about, so expect the runtime effects to be >> mostly negligible. Thanks! > > The next email we get about this will be a bot with a micro benchmark > performance drop. I'll be pleasantly surprised if our migration code is that fast such that this here would matter :) -- Cheers, David / dhildenb