From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E629FEED621 for ; Thu, 12 Sep 2024 16:59:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 790366B0088; Thu, 12 Sep 2024 12:59:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 741086B008C; Thu, 12 Sep 2024 12:59:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 607776B0092; Thu, 12 Sep 2024 12:59:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3CE2D6B0088 for ; Thu, 12 Sep 2024 12:59:27 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B139EA01E1 for ; Thu, 12 Sep 2024 16:59:26 +0000 (UTC) X-FDA: 82556697132.09.7D62777 Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by imf07.hostedemail.com (Postfix) with ESMTP id BC13840011 for ; Thu, 12 Sep 2024 16:59:24 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=Ecdn9lCn; dmarc=none; spf=pass (imf07.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.53 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726160287; a=rsa-sha256; cv=none; b=7aO0Frrlj2Q66pIak/2s1Ni5+v2p7NG4kv7I2nY23oHbi1+AJaEY1Zo00iEAKBtAX7NaZY KFmI6JIKO8UT1BJftG3mXA4w/gHXjslw0gMwG0iUe44VOixRmH1Zn8MQ75ijRSCBPeXjeV S2HH32Y8Rljb06UxB0WHwF1v3ma0haM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=Ecdn9lCn; dmarc=none; spf=pass (imf07.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.53 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726160287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ik/dQnu5jeslrWeWVW6FYf9oUqwHtJ5XqerEocsu/Sk=; b=C5QXzM9J16YQo47LH5EzxRTY9TxnDsW2q2AGl9jvHt5fawfMMXBu33kJG0FI0jwMhMXI7U ws+TydjETtsPMLVORz+WvHDvqeEb3M2BH9yGSJdyiE74XINS4E8XAc3AggZrp3IVHG3X9b odX+P7zWIy6TpoZydtAtkSoS/5d2DpQ= Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-82aad6c83ecso51046239f.3 for ; Thu, 12 Sep 2024 09:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1726160363; x=1726765163; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ik/dQnu5jeslrWeWVW6FYf9oUqwHtJ5XqerEocsu/Sk=; b=Ecdn9lCnyR1Acec0/vTMX8qpFVL4butNuFwKgcIZ0oOu4JiXtRBNZS2R7gs7HRkg/9 f4Bus52FLJqWaFZVRgo5JwxJK4GOyEFM4c6luYl9HtUCanXFF2Xw11UHdZG1xfp+jIpg DqwOBOKVdX5RksTApdXESGVAvYnJ3fTYtPBo/gfBmsjDs7MQcA11WYI449VRZTZu/kcF XRcRA+pYgDj8BE/CD7EdY+Hi1OjRbYiirbdSqN3op6ZSbzYOIKfr34IUVUkm7riU026Z IlNb0uFs3j1BGAyKzVv/IveZq5AmW3RNJoveVaerSdWVBFDbmMA06t14trg6IGp1Wu86 W5QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726160363; x=1726765163; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ik/dQnu5jeslrWeWVW6FYf9oUqwHtJ5XqerEocsu/Sk=; b=c0rpilQDv+OT0AaQVtM1FWV+5mXblZzjlIOdRVkqMjvDtRiaTqPW0JnT6t4IUTvGIK Vc1uhX8AI696XiGY1xykBHmQH3C4H3BfUDPPE0zMjfdzWMmJksMind7gQCSVQ64y/exB QcH5BlV0X5MueobC5jLdeOoKXTV5Pp3lkFJgaq3jokPMNa0pwJGwTbTu1G+nW1mf02/d bSXAY5utde9ECENiyDpPHWPsxAAwRyh2/07JXijuDwnwEkuTXJ1bFkbR2BoWloU9ZjZQ UlDz3UD0fIUD78gkx1pvmWvUbFpoZr/T9gGawL+W9Q/G3diWHHfVYrGbMczaz33DZuim QZHA== X-Forwarded-Encrypted: i=1; AJvYcCXri/O4KZgeuThNmtxSOOxqV0D2mBHqER8f9WC3vnaizloAagJXVA9Yq5se2FBuGx3rPZapD8RUsQ==@kvack.org X-Gm-Message-State: AOJu0YxKAwkNRvqeBl7u+3x7Ya5ylzonwgjsp4C1qUP0SVuXd65VWthQ UeeVAJPuyxp6U6eY5ppy8kgJdnLlITbSvHncTdNV48M/j28ROSRe++Cnqi/4zvw= X-Google-Smtp-Source: AGHT+IG0/AkbaBfjjgY5RdNvez4Q8oJijXmJux9z3RJ6adhyGPQMc3fgvUyAsKJD5k8HozTbpJTZnQ== X-Received: by 2002:a05:6e02:1a8b:b0:375:c443:9883 with SMTP id e9e14a558f8ab-3a08494ab32mr34292555ab.21.1726160363430; Thu, 12 Sep 2024 09:59:23 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4d35f433cbcsm693841173.20.2024.09.12.09.59.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2024 09:59:22 -0700 (PDT) Message-ID: <7e6ab59d-2248-4dab-81e4-4de6343b2672@kernel.dk> Date: Thu, 12 Sep 2024 10:59:22 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 6/8] block: implement write zeroes io_uring cmd To: Pavel Begunkov , Christoph Hellwig Cc: io-uring@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, Conrad Meyer References: <8e7975e44504d8371d716167face2bc8e248f7a4.1726072086.git.asml.silence@gmail.com> <707bc959-53f0-45c9-9898-59b0ccbf216a@gmail.com> <38a79cd5-2534-4614-bead-e77a087fefb2@kernel.dk> <6ecd3129-e039-4b86-9e67-03a7a519266e@gmail.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <6ecd3129-e039-4b86-9e67-03a7a519266e@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BC13840011 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: yyjxyrxfw4b7hi7iqiha1xenocomzzmk X-HE-Tag: 1726160364-64937 X-HE-Meta: U2FsdGVkX19Zk52+YJz/vJx4Zyzj8xX/+ohuA6C5TsjJPBn8y74IbbsMQ6HIHsI2X/Qn1PvjVjLG86t96w6YmCink8CkxM352SzTXxUVzEe8VNZ6GUnEYhL53gQn16gKyNE5enKgu6LXNYCrWyni6vikrV9JXeNYZo7R7TVa0+VEEe0IP4lAnTc/VLsV7jaum+l1A2frY79FtAknN1WSIIZwZP/A+sgLSyOaKVnSN70xWKBGF1o8gLWq/tdyDz6MtfnUM8iOHbJsundkSHlcxTB6CU54gwMn/pzkHgttCXeNO6YDKKhWSItfAA7pUymG9McNLHFQvxqioqoYSa6Tj/fABvduhXcWIaCxyD8/ILx3tDVv6OAq8UjSVyCzH5Zh4iTsmsjtm+uYabqoDFlBvgyykA+d4M4IfQkXjljw+Azl9PTDU7PPaNYhwPUpZmi0vdl9gVQPWylOQehkSgKeidQDme2uWQmYaIRUcJOIC36MOhMEFBUllqwhdVFPKffldeLQDiYYD1lKcnGH17HNaK5fdBWHSMHhNlcNGQfWct4lt6pNvyLbYchG8m5Dyadn1cNtTX1TTifuYpd0YFu/OnRsK0sbI5SevJXoisIp3f0jM77fZn1xkoFa6Ld99aTmVvKuXjBfe43oAv4iDhq24yJ4e0hoeKCfQIX0MRCO5b1V4LGqeThZ6NBhZBJuJaX5Q9JleqBrgOs2mDC+VlolbcIM3AEFCQiFHk7aNX3uJ2wWadiYY5ZOkzlmK4qgvBHDJWbqXLNCO3A6AhQ8L265AfOd29R1jaatlny4XIfV2eSpke+ZbmTTr4uvm21v2+uyWGd2DdYlcpZUaDVHW223TuX5/1ZjH8bsk2irD8cK32MC8IYpywvM1bn/b7RGvC5i0oQtAWEjzuNANwDdAmocWye8Oe1NnK6m941uKbEp5KsVeQlVJKFr9Di9uIDgd+l6u+c/mI5dvcPeRvCa9sK JkAPbJMf U0ZNAI/5+neH/p3bWl3BJtZdCCaW4Atl+e9D+rs08jMU4vBUn3iIThftWVUCmS5qOpFbm7WERNfLX0qAQE9nh6IHTyrmDbfWaaFIDxns1PtZ8cUSY7FI/Fa9JfM3YElc/BGcQJw2aDNz742eWYrzfwKx5SDioXOfHX4y5YGZQUIrTQKaY6uUDs9PPFA7hDmbrBUajYfgglz5aTIWh+UoPDrC292jXCwojitvPVME1FxN2F8TVb1nsIpygAWdHEMjo4jHFedbKU1OzNCjk72pm/q3dkaTxvKQaO2zrk8jit0SqMcrgV91P1mB5zRQf/ids5yar2XKQ1HYpxF1IxUjbYu1LQCH+FxnC85ZVxE97Y02rE8MGkQIGIS3giOPmojfBBewKUkLsWeoZgL/Yy1pT8Kl2LIeFiQdZEYuTsTD5A7OoUPHCql5ZJN4lGfRUKSk/WQPR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/12/24 10:53 AM, Pavel Begunkov wrote: > On 9/12/24 17:32, Jens Axboe wrote: >> On 9/12/24 10:25 AM, Pavel Begunkov wrote: >>>> an entirely different command leading to applications breaking when >>>> just using the command and the hardware doesn't support it. >>>> >>>> Nacked-by: Christoph Hellwig >>>> >>>> to this incomplete API that will just create incompatbilities. >>> >>> That's fine, I'd rather take your nack than humouring the idea >>> of having a worse api than it could be. >> >> How about we just drop 6-8 for now, and just focus on getting the actual >> main discard operation in? That's (by far) the most important anyway, >> and we can always add the write-zeroes bit later. > > That's surely an option, and it's naturally up to you. Just trying to make forward progress - and since the actual discard is the most interesting bit (imho), seems silly to gate it on the latter bits. > But to be clear, unless there are some new good arguments, I don't > buy those requested changes for 6-8 and refuse to go with it, that's > just creating a mess of flags cancelling each other down the line. That's something to hash out, might be easier to do in person at LPC next week. For now I'll just drop 6-8. -- Jens Axboe