From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F506C47074 for ; Thu, 4 Jan 2024 12:05:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F7616B02E7; Thu, 4 Jan 2024 07:05:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A9A76B02F1; Thu, 4 Jan 2024 07:05:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AB236B02E7; Thu, 4 Jan 2024 07:05:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 38F796B02E3 for ; Thu, 4 Jan 2024 07:05:11 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 01B401C077A for ; Thu, 4 Jan 2024 12:05:10 +0000 (UTC) X-FDA: 81641498022.24.71671B8 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf30.hostedemail.com (Postfix) with ESMTP id 3D18A80017 for ; Thu, 4 Jan 2024 12:05:08 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=l8Li4VvR; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf30.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.218.41 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704369909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=z071ZOVrV7cQhPIZSpfbxn2i/ugENcMb4cwQcQkzR+I=; b=MW5gNO11OcGl53+ZS8AcYft/5q3uLroBrfWP2lK+PNU7N6XioBnTACwHBiNeUp9M33xd+k 0DNjdcU6NE+40vxf+dZK7oC4npk1z7VtkkWSQcg25iYxH8lLLLR1BVPeNSnpbgXKWKTHdx 9gzZZMgYo1Ox4Yuv/PalFkKEvua37fU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=l8Li4VvR; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf30.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.218.41 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704369909; a=rsa-sha256; cv=none; b=JsFlIQlymQ/z3KkbDiQSYqv8uOnrKIdi8nkRAc5wCNADPhBfCpNQAImBKbCCRSZTwxgGT+ nyB8/GDvhiNRbf5GJcpN8qnoTA+3DganUXKOnr80DnbRyiK/W2ZlOWVo8oRO6fgn5pFVNS HgHv3lzSVjDACaav25rvE5x0q7QvA+4= Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a277339dcf4so47603866b.2 for ; Thu, 04 Jan 2024 04:05:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704369908; x=1704974708; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=z071ZOVrV7cQhPIZSpfbxn2i/ugENcMb4cwQcQkzR+I=; b=l8Li4VvR1EvAapDuEG2ZmJk7EgK+OZuydsYAdV9v5523uCsizItubCxQV7/cm7rn8w JA/VKo3Uy/KA7KmdHhwxMPkHT9its5pvwv80ttygG177oa/rKRQ71JJ+moM85G/hCIks kBwLnjt4I4s55V5IEjFO/kLx1qsaVvxYf8WEnlsoRwBobO8EW1PRUDvmBgWhmBlqEqPj w3H7W7QFHBvgKvO1cYkRs7usuEIRSuYVk0uuL+jB9frwnSmEEHpWU1gOr5o7tvKonT8S QCH7gJass1y0B72C1Sr0krUyH0MyVduykyjfRcysqwRTGaBJMuqQ+okFbskSd6M2434t cJAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704369908; x=1704974708; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z071ZOVrV7cQhPIZSpfbxn2i/ugENcMb4cwQcQkzR+I=; b=FjiwHoUS53ucZVC8NFIk0d/xRAHUoxq+zjkzsHThnIxJvmmGVxwYlfQKOgEteAG5CY 0vQDzcRH8DCYGu6pO/zQngLo+nZWn5UT0XFoWCFi0QISgnptj5VeqAAuYShhAAiF/eFd qkP4W6X8RHOGf0xFcGGT7FJ7vgGXShxgHXIjsW/mhBZJCqAOiy9jiIY80M2NxMUk16aI Qjy2Hvbfjjf3vnFcyF20sN9Pk6R1DSkZf0ALeOxY1GFVcxmfK7OZj+rQ+NYWCw1P6I8M apP9gWJAkIklpiTMhC3keVT52ZtZ/2utu0yDQ7jzPOGbwF24wvxgibP3TJmLBlfSBlN2 IUpA== X-Gm-Message-State: AOJu0YxtKx8fBz0dzc8VXjDTMDl2t9ZzIfi6ViJs4EYKgMXudy7rRtXH r/VeKgmh1l+SY9YKzH8tLjAuQg2xiVAn/iLfm2hBOQhmZKY= X-Google-Smtp-Source: AGHT+IFR64NY/NROAmz9WSpobH9bCqoNuzeYJ5wmYxSEhL49XMX06krXPHW0OI/sdYjgJj00Se8mlw== X-Received: by 2002:a17:906:5a51:b0:a28:e2d7:b41d with SMTP id my17-20020a1709065a5100b00a28e2d7b41dmr260021ejc.0.1704369907666; Thu, 04 Jan 2024 04:05:07 -0800 (PST) Received: from localhost ([102.140.209.237]) by smtp.gmail.com with ESMTPSA id ew18-20020a170907951200b00a1dd58874b8sm13592133ejc.119.2024.01.04.04.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 04:05:07 -0800 (PST) Date: Thu, 4 Jan 2024 15:05:03 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Alex Hung Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Alex Deucher , Harry Wentland Subject: [linux-next:master 4679/10295] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9280 amdgpu_dm_atomic_commit_tail() error: we previously assumed 'acrtc' could be null (see line 9277) Message-ID: <7e5c7ab1-4ee9-4221-b585-6a9aa2c6dcc3@moroto.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3D18A80017 X-Stat-Signature: yfoyhre7ffjb8hxityn3bjbzn4kcs7ka X-HE-Tag: 1704369908-178783 X-HE-Meta: U2FsdGVkX18RAUPQeeJV1jCpDiV/RGO9apvtVRLxqe8CEvDVfmcgoE1lO/XZIukBST3TnYxsxezCD9O4S71gWXYyBk167O9PxANDPHPwYjCGm0yIih4UMxchM6jtcoqqNIrv22vf32RbD2TrgkSojwkAcYm0sBogaJFWBwS5HwjrvGAj2JIWhN+ib6EvqQ8qYn9lRnj3n/zgFcs8RYyOvNvupCvts4TXBYHAyGSaFWXSHPAPzgIwm65XTwmrkmNedxnphkRW3Yt5Sc95fTHkrF6uiF0h8k4ITnw/ZRDiofBHW0HGHYHgCDQFDTEy8SC5GJGmjKt0npSjM5YjPLNBChMSHMW7uLSozdlaYu/vUG4yEQFnReogm3T3qPjQZQSJohTVGEWc/AyFznSJY63WR96qSJN0ioFr4sVSiHuEn3RHBccM8k3QtvuUc89ZeaENuXtvMncQjzOPjHAiXjh55Fbc43uWKjlXDxMQbs7odUwZI6BxARqXXmtVRruLrJkdk+aewLleo3PPFU3Nnt+g4FeHAFamS8si6bP06/Px8+76INGdB46v6hC9zlaYF9LQaeucGOaTprYs7G2JNaWm9QifsYIL5Kc+Jj5xopSGX9uL8ec8JDlnI/BNQIB665ja8gZ0ozuqMQG5pV/hA8pdmkfCwkYymtGInFXag5k/lfvvp+AculQE89v6rPdE2PSN769JpLYjxC/5WnvJrbGovpYQltkfCciQS6GX8dOh9N1yHakyjdSFrjsAauyyGtOmG/wzScYAq4a8/U0ku032sFBCtVHYho3UfgXIyP5oZRCamMB2yc21uNU6Uj3kxQRqaZlfG5kjyBBuCkIPv0Ty19cjx1EIbk3dRc2RczxPSFU67tp9lT6mSWlBZBQd4bh0atyGyJoFcYWn7gNoBxzDTz+8Be+i1/t46WMehXcV2HLo5UjoENo98GzpwqfKYwcDWrif7yUnPDnfV8z6lC0 bbofByG0 zk4X3DRNhE5oPUY9774MfsBth1dUsSfT15QFWVzjcEOV0p2vg0JAXrS+Wo2S8RgLhptRRJ9cohR7owOWiYbscvXdSP4EKo9hSL7i4KxbiNDdLPnh4eENjmauOdx7qVdY0Y8TAV1zS2K7X/zz1WgZqbVj8LdJMBUyV8DMKoCwLTX3dS825wvFRhr+Co91j8WYKKp1WaJSdA9hma8nGf281eQDfEe6eCElqj51ZGPJYmMZrimwIAXCOE4dBhPbSvdjERXx0XP1r4hHDZJUjNMY8/V33j9QF6l83IqMO9ZgDGcwvTrqC65On5BbGRIXhiChfdufwItGh3lxONELv7SQjqAy3dBj1ZXujoC4nkomJjf1ZmlBBR+RM8S5NibXslRMlsJl96skkuPk5axzIkYk+mrYlgKOCCO9FsfRY4KSdRflUYgilXCcq4mkxB6lG4Czgrve/zXs4QMUxYvNM03j92yWFdbxEWz45f05Vz0uKg1faz6DRYQsiShTu0b0a/9PyaHvWz/H/HOddUYTGXZwKAZoFj/EpYAQ4QiewVd7zUJBdD7+haJ6CYXMHev1xK+6HOIx1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 39676dfe52331dba909c617f213fdb21015c8d10 commit: f872e2f5f0beabd34c03799a5c597f6ba47b51cc [4679/10295] drm/amd/display: Add writeback enable field (wb_enabled) config: x86_64-randconfig-161-20231228 (https://download.01.org/0day-ci/archive/20240101/202401010520.1VZfOvg0-lkp@intel.com/config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202401010520.1VZfOvg0-lkp@intel.com/ New smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9280 amdgpu_dm_atomic_commit_tail() error: we previously assumed 'acrtc' could be null (see line 9277) vim +/acrtc +9280 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c e7b07ceef2a650 Harry Wentland 2017-08-10 9263 c81e13b929df2f Alex Hung 2023-12-01 9264 /* Enable writeback */ c81e13b929df2f Alex Hung 2023-12-01 9265 for_each_new_connector_in_state(state, connector, new_con_state, i) { c81e13b929df2f Alex Hung 2023-12-01 9266 struct dm_connector_state *dm_new_con_state = to_dm_connector_state(new_con_state); c81e13b929df2f Alex Hung 2023-12-01 9267 struct amdgpu_crtc *acrtc = to_amdgpu_crtc(dm_new_con_state->base.crtc); c81e13b929df2f Alex Hung 2023-12-01 9268 c81e13b929df2f Alex Hung 2023-12-01 9269 if (connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK) c81e13b929df2f Alex Hung 2023-12-01 9270 continue; c81e13b929df2f Alex Hung 2023-12-01 9271 c81e13b929df2f Alex Hung 2023-12-01 9272 if (!new_con_state->writeback_job) c81e13b929df2f Alex Hung 2023-12-01 9273 continue; c81e13b929df2f Alex Hung 2023-12-01 9274 c81e13b929df2f Alex Hung 2023-12-01 9275 new_crtc_state = NULL; c81e13b929df2f Alex Hung 2023-12-01 9276 c81e13b929df2f Alex Hung 2023-12-01 @9277 if (acrtc) ^^^^^ Check for NULL c81e13b929df2f Alex Hung 2023-12-01 9278 new_crtc_state = drm_atomic_get_new_crtc_state(state, &acrtc->base); c81e13b929df2f Alex Hung 2023-12-01 9279 f872e2f5f0beab Alex Hung 2023-12-01 @9280 if (acrtc->wb_enabled) ^^^^^^^^^^^^^^^^^ Unchecked dereference f872e2f5f0beab Alex Hung 2023-12-01 9281 continue; f872e2f5f0beab Alex Hung 2023-12-01 9282 c81e13b929df2f Alex Hung 2023-12-01 9283 dm_new_crtc_state = to_dm_crtc_state(new_crtc_state); c81e13b929df2f Alex Hung 2023-12-01 9284 c81e13b929df2f Alex Hung 2023-12-01 9285 dm_set_writeback(dm, dm_new_crtc_state, connector, new_con_state); f872e2f5f0beab Alex Hung 2023-12-01 9286 acrtc->wb_enabled = true; c81e13b929df2f Alex Hung 2023-12-01 9287 } c81e13b929df2f Alex Hung 2023-12-01 9288 6ce8f316673f61 Nicholas Kazlauskas 2019-07-11 9289 /* Update audio instances for each connector. */ 6ce8f316673f61 Nicholas Kazlauskas 2019-07-11 9290 amdgpu_dm_commit_audio(dev, state); 6ce8f316673f61 Nicholas Kazlauskas 2019-07-11 9291 7230362c78d441 Alex Deucher 2020-12-10 9292 /* restore the backlight level */ -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki