From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6D60C369B1 for ; Wed, 16 Apr 2025 04:02:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 465DD6B0213; Wed, 16 Apr 2025 00:02:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EA696B0246; Wed, 16 Apr 2025 00:02:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B3A36B0248; Wed, 16 Apr 2025 00:02:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0B0276B0213 for ; Wed, 16 Apr 2025 00:02:15 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 201F5141CEA for ; Wed, 16 Apr 2025 04:02:16 +0000 (UTC) X-FDA: 83338559472.26.A4DE32E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 4009A18000C for ; Wed, 16 Apr 2025 04:02:14 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fAvaujJG; spf=pass (imf16.hostedemail.com: domain of "SRS0=KX8R=XC=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=KX8R=XC=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org"; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744776134; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tldOPXFRLylQljGiNlWOpNcTifdsTDZeMXPDmBxqLCg=; b=KqeaAwR/lmHuMLDNCxmmMPrIvYWgzcREU/lEIjbE+znWQWT2dWBzuGW0i3+SQtLFmeKFLf dORCM5AjQVeNjWHXqL5LglR6wKULYHOXi0voxucjtaMoUgrpkdtDyZ991W8UD2F+vHIHIT CfOhnGG7KnX6GYsO/uUvJGZ6RwdlX6U= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fAvaujJG; spf=pass (imf16.hostedemail.com: domain of "SRS0=KX8R=XC=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=KX8R=XC=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org"; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744776134; a=rsa-sha256; cv=none; b=VJy/pZLpfsINlNAiGmQUseH3OPI/kFlB/TyeUjodARAWX9sB14zQO9twjcIHLf4ZGbma+b Q2oRoeVcxCrKV+coVa4F2+1wGHlr6XfBC4z69fcK65rmWkOVmp/+Sh6/V1V0pUuL/5YH/Y zo71Qwm1CEF1UDOYoVadrtz10RXBrXY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3345B5C1FAB; Wed, 16 Apr 2025 03:59:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE22EC4CEE2; Wed, 16 Apr 2025 04:02:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744776132; bh=yKu3+0W5p/giE32i5CggvyTCCB+2AuwXMDnAiewOH40=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=fAvaujJGwORcwP7R6qBeHYKxI0ASWsvESDJuXp04DKyftuObqkCRUd51LEJBRL/rm kPS7zO6IQe7M5Yj6AzY4fz9ShSN7jfkoFs3JGVT0/9iO3BL0Q7PHq3wPdJZ510CuKd NhWXuo4YpPzvKT2gAqn2ogS9KKmjmQVO0Rmm+XHkQ1t3bIOBaUlHYBxyhnUyW51FMq xZjq9toDxXpkes6r/ITlEPZeZrA1pPs3hlGHpnbBT70A3lS9Nvv2KXcH9ulkv9rRjq crqS8wgHZ78toHrWG7HVuC8kaS6yuMLNIywQEf/SldSpxdXR0BwfN84VAvycDqJ7Vo iUYV9qqTfdK2A== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 7A5B3CE06FE; Tue, 15 Apr 2025 21:02:12 -0700 (PDT) Date: Tue, 15 Apr 2025 21:02:12 -0700 From: "Paul E. McKenney" To: Sweet Tea Dorminy Cc: Ye Liu , Andrew Morton , linux-kernel@vger.kernel.org, linux-toolchains@vger.kernel.org, linux-mm@kvack.org, Ye Liu , Omar Sandoval Subject: Re: [PATCH] tools/drgn: Add script to display page state for a given PID and VADDR Message-ID: <7e45afc8-dde0-481a-b0bf-0237f551ebe0@paulmck-laptop> Reply-To: paulmck@kernel.org References: <20250415075024.248232-1-ye.liu@linux.dev> <20250415191414.a64de2d228ab5f43a5390acf@linux-foundation.org> <42f50a48-10da-4739-9e51-f865fbf04bdd@linux.dev> <098e977c-55cd-498b-bd36-725333c06210@dorminy.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <098e977c-55cd-498b-bd36-725333c06210@dorminy.me> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4009A18000C X-Stat-Signature: yb3epoqa14fks3b49865izqhhwj7uk1b X-HE-Tag: 1744776134-936253 X-HE-Meta: U2FsdGVkX19sm6hcTUKrXaW85q8egAvSBeIsIEeiecrP8eHU24IF01NSl8gq9EIgCyaHp6UtqwBT0vBTePdv4veI3+43OOZdznSwsZYX/AymOXQEiwOrpb5GFjFlLN+YHoqjwJar4aIqwnWGG/bqE1jziTATHVkX5Xom0gqGo9b1i22C6bkQOSLxhaXtlGzjIKkEz8jCiQgYo4yiaVRD84gePbpBJGB3GePr2xgIf8CSheA7EHfJz9ezecgilGInzbUSlyqOtAriOeeCa+1+YH3PT7dVwMpTDjHPE/7QGllKbYeS+ySi4ysSlSx036ruMQGofyrUq0Xu0g+SLxccvxO8HuRq4KiZl6vIMKslMwvJFS3qVTvdttAUbJwJKVOb4IVb2FiDGVBZFYFOVmSo5zwBG1/KhBX+fdDRTKzneJ39Y2apG/C0BfswJGWaNKKDKLYO/VaOD2h5QAekwnXSd1M5PW0DCkvsZ/tFlnq1VeKDk6vDE/XoXP6xNBwORPhLOk57eyg917qYThHPMVo6Cna6aafs1DsTdBEotKdnFNXz25f9QeO13Kiwut0YkyMgt3Zq0DTfNCo5UjTGfYuZZpjK2hjsKkCnLU0/eacQ2wzgTNqNTsg6stbdY6gO8FD+ATzsAgBB33Y9BDQ1v9CExDXXYmRiTEZWwJlaCN4Xt/3/3M1q2Dc1iGrvvHx9FaPO+9n/zmD8udEgNK2S0sJqwdGcHFn/lS0OEb83cjEhMCSHkd9InRM646f+0IQXJ9FHLvqeAMMBCMYIHmn8BiLNGRSPHXDhrjiy0rriQCP9023T6Vmels3KoXuh683Uw2t/4eGKhnKDrPYlIbsO6r0NAVgbkZEV7eFOBnJWQKiP7LnpJ/UEiACIUcGXiOx5bnVxd+UvEYainldboSsUdpjuUxY5MWQkX4OTA8J77ZJeYrSCefWbeBIqe88DClaKeBm657g64SfyQYvUiiKUcoe o9dgRRFr W6JruyUIVxm2DhHzDSRfZZPLULycPc83xBvF42rjoXMbIQBWrVAUSuKjmrIBLEIEQbvlhkkXN+osJNb4uAw/UdcM//8jiX/I946e9kMWV72LNQGYx2uT/Nu4+v8t+NVydIX9VM8NxkDxSizFhd77x1y931lp534+kJYLbVeA0pSfeae3Tqw7FV0TVmD5F3Rc1DpQWoHEtHF4uKaSP+AxPJGbDQChIto5HQhLIZ3aav+lcbdmg7yynVmhkGrQ4kqvCfpJ04PivIP9zc9QhqTCRTO4WfJHNIoZ/AE2Hn5f+qSPlQx33HMnLi7XmUXkwH19mKYoxyk977rROkPCzvYY0ZRnstpxCZKw0MdV/OajA2CmnEUn+wNznZ52eWihmNLeqXicBklB107GtCmwnrI72jKSzIZUlsC4fgkXNHYUEzTSjWiVuMA0GDs3tER75hRPzDI49Gt8VZp+6jzpSBpEwUfc3xvSypL/cuQGnHXlHYzSDm3QGvvzJms3A/31AqR1ZpdTkQZpModw2t0esAGnno1qr6nyyJr4QIqbmg9E+Y4zMI/grhuFKwRaww3rMRWxbS5fJz9+dHkkWW1nQdPtkuhb1/cvU4Y796oT1wRx+ei54Tu7gYxwpXVmiJdSLU1AiT+bvK/OWz3n9ukTyIRIOoqk5k4N57IFB19vznwEgxY13AC5rphWw7TjqfxFyXGOPmSgB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 15, 2025 at 11:28:41PM -0400, Sweet Tea Dorminy wrote: > > > On 4/15/25 10:46 PM, Ye Liu wrote: > > > > 在 2025/4/16 10:14, Andrew Morton 写道: > > > On Tue, 15 Apr 2025 15:50:24 +0800 Ye Liu wrote: > > > > > > > From: Ye Liu > > > > > > > > Introduces a new drgn script, `show_page_info.py`, which allows users > > > > to analyze the state of a page given a process ID (PID) and a virtual > > > > address (VADDR). This can help kernel developers or debuggers easily > > > > inspect page-related information in a live kernel or vmcore. > > > > > > > > The script extracts information such as the page flags, mapping, and > > > > other metadata relevant to diagnosing memory issues. > > > > > > > > Currently, there is no specific maintainer entry for `tools/drgn/` in the > > > > MAINTAINERS file. Therefore, this patch is sent to the general kernel and > > > > tools mailing lists for review. > > > Help. My copy of linux has no tools/drgn/ > > I noticed that the current upstream Linux tree doesn't contain a > > `tools/drgn/` directory. > > > > I'm interested in contributing a drgn script tool as well. > > Given that this directory does not yet exist in mainline, where would > > be the appropriate place to add new drgn scripts? Would it make sense > > to create a new `tools/drgn/` directory, or is there a preferred > > location for such debugging scripts? > > > > Thanks, > > Ye > > I believe the traditional thing to do with new drgn scripts is to add them > to the contrib directory in drgn via pull request: > https://github.com/osandov/drgn/blob/main/contrib/README.rst I have an RCU-related drgn script in tools/rcu, so maybe this one should go in tools/mm. Thanx, Paul