From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA908C433FE for ; Mon, 3 Jan 2022 20:17:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED9A56B0071; Mon, 3 Jan 2022 15:17:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E88166B0073; Mon, 3 Jan 2022 15:17:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4FFC6B0074; Mon, 3 Jan 2022 15:17:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0145.hostedemail.com [216.40.44.145]) by kanga.kvack.org (Postfix) with ESMTP id C28656B0071 for ; Mon, 3 Jan 2022 15:17:33 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 789C7181A3462 for ; Mon, 3 Jan 2022 20:17:33 +0000 (UTC) X-FDA: 78990085986.21.A3E6EA9 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by imf13.hostedemail.com (Postfix) with ESMTP id 8E74920013 for ; Mon, 3 Jan 2022 20:17:15 +0000 (UTC) Received: by mail-qt1-f182.google.com with SMTP id l17so31640232qtk.7 for ; Mon, 03 Jan 2022 12:17:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=Z+4dvYAVW+j0wGcJEqsm3l7X49nKlhTo4PX3QCjARbI=; b=Qw9Jx9WY063FuYx+JVQOsWkzBedAxK2DCaL6XmLunRK1zNv4pF5HOCMt1bkHjtFyrl ANnu3cChhHaR7nRHSJ7M7/poL1lFHRJ/08RW8pajfCnHxNhT8AstTD0fxDgWx2VsiwJ6 9fvGaH1QNYylKsRp+kZoKWV0lZLaSY2QRFG4aOBditRJ0fJ3hbhlUP9Ixx/GjxAlr5Xu zMv0AJSJJ58a0suCzw9URtww3P/PKVmpcLkLhSuXHsE8vd49OJoYtqJ3KdnSDIdTXboH gY/t6WPd2qeXqO+1/6mQ4PHeyAWSQMTrLZsifWn8ozjlvXw3+DnStRUBQHRMJT58qGxD Kozg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=Z+4dvYAVW+j0wGcJEqsm3l7X49nKlhTo4PX3QCjARbI=; b=lmGb4NCLHwbQ0NM4mRdBjzacFE3LL7JyouISbFJ+8QgCyd0wFsShnUPJ1i+zGNLNAM vdv6nz1ndcsFX+/k6RVIlQuZjKw28sYxFg/CWuvGAy7fogb+d0mXhOWcWzG2ij/wGBRr R4aVaGC1ByppQHa6wt7HwOvKZCmcesGoBnEeSe/C6eI6TrY+04LPLFAurtlVBiqyLs/j xA97Nlc6jraIw7ALFvObFrAaRiHbB4NE7kbOkY+Bky9P6gHglFfeYlGc4k+RJ4oOdU96 6cnciLSHdd2wNlCZNzDPkfWR8dozJm2gohxmynxYhONYcv7UZaC84C/NWdAlBWn8jcrW yr7w== X-Gm-Message-State: AOAM530GHyKwJjCPYdrQRGv+fE91wH93rSL3L8ZOTvJzhegD0QceiuL6 9xUrU3kXcFM810bZ5JOE5+gI2w== X-Google-Smtp-Source: ABdhPJyKl4m1Y1Oq58YEXMHG463q9HzkROZdjykUOsOVYl7lEApjy7SN7bG5Xk0WnWFA+a53grJZMA== X-Received: by 2002:ac8:424f:: with SMTP id r15mr41340371qtm.265.1641241051183; Mon, 03 Jan 2022 12:17:31 -0800 (PST) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id j13sm29376286qtr.21.2022.01.03.12.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jan 2022 12:17:30 -0800 (PST) Date: Mon, 3 Jan 2022 12:17:28 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@ripple.anvils To: Christoph Hellwig cc: Hugh Dickins , Matthew Wilcox , Andrew Morton , Jan Kara , William Kucharski , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH next 1/3] truncate,shmem: Fix data loss when hole punched in folio In-Reply-To: Message-ID: <7e41698-915-93c2-2cc1-6cfc18ede6f@google.com> References: <43bf0e3-6ad8-9f67-7296-786c7b3b852f@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 8E74920013 X-Stat-Signature: kro5gktwpba5xa7i9p5y9tirx5h6f6mp Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Qw9Jx9WY; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of hughd@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=hughd@google.com X-Rspamd-Server: rspam11 X-HE-Tag: 1641241035-915125 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 2 Jan 2022, Christoph Hellwig wrote: > On Sun, Jan 02, 2022 at 05:32:28PM -0800, Hugh Dickins wrote: > > > > + same_folio = (lstart >> PAGE_SHIFT) == (lend >> PAGE_SHIFT); > > Should this move to the else branch? We could add an else branch and move it there, yes. I liked Matthew's else-less style with partial_end, and followed that. Whatever: since he posted that diff yesterday, I imagine he'll just merge this into the fixed patch, in whatever style he prefers. > > Same for the other copy of this code. Otherwise this looks sane. Thanks, Hugh