From: Hugh Dickins <hughd@google.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Hugh Dickins <hughd@google.com>,
Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>,
William Kucharski <william.kucharski@oracle.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH next 1/3] truncate,shmem: Fix data loss when hole punched in folio
Date: Mon, 3 Jan 2022 12:17:28 -0800 (PST) [thread overview]
Message-ID: <7e41698-915-93c2-2cc1-6cfc18ede6f@google.com> (raw)
In-Reply-To: <YdKq9bOcZ0M30LZ8@infradead.org>
On Sun, 2 Jan 2022, Christoph Hellwig wrote:
> On Sun, Jan 02, 2022 at 05:32:28PM -0800, Hugh Dickins wrote:
> >
> > + same_folio = (lstart >> PAGE_SHIFT) == (lend >> PAGE_SHIFT);
>
> Should this move to the else branch?
We could add an else branch and move it there, yes. I liked
Matthew's else-less style with partial_end, and followed that.
Whatever: since he posted that diff yesterday, I imagine he'll
just merge this into the fixed patch, in whatever style he prefers.
>
> Same for the other copy of this code. Otherwise this looks sane.
Thanks,
Hugh
prev parent reply other threads:[~2022-01-03 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 1:32 Hugh Dickins
2022-01-03 7:51 ` Christoph Hellwig
2022-01-03 20:17 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e41698-915-93c2-2cc1-6cfc18ede6f@google.com \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox