From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4C71E67485 for ; Thu, 31 Oct 2024 21:18:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EC446B0082; Thu, 31 Oct 2024 17:18:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49BE26B008C; Thu, 31 Oct 2024 17:18:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31F6E6B0092; Thu, 31 Oct 2024 17:18:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 155AC6B0082 for ; Thu, 31 Oct 2024 17:18:45 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8BFF11618D2 for ; Thu, 31 Oct 2024 21:18:44 +0000 (UTC) X-FDA: 82735159920.20.452E228 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf07.hostedemail.com (Postfix) with ESMTP id 7D6B040006 for ; Thu, 31 Oct 2024 21:18:04 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of robin.murphy@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=robin.murphy@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730409441; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZXfqYT0Vxq3NrMHo0NjmMIQHCe7uXs274OngLgkp9GY=; b=d94lqzYXaDbSWq7O6kMbbTL7BxpTtCJ2P/jPFOf3VZzW/W3lswD4IS9Ihzq7nvbCKhNVTY v806jkQtl/pj5oSMhL2/dG2wKmojzOrBKVa2YBMOeLTtL3rGdpvhwq4Gi+qUbZHJXgZiIk qH/4XSflIgnuj2rrIZ++BIBgOmlHWu0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730409441; a=rsa-sha256; cv=none; b=x2zZWl3jVI3UlGqPbsbqpVHJNO46ZkPaa21V320g/cXV8yETs1yYMJfunNGYad5+l/S2Os 2hgZ6aNfa94L5qaTxkiHgdltjBYOBBXPSd/LuxXzQMji347wemHFf1vN6zXXC1AR9l0xs0 aHixeHTCpyusEPRjHM8EWXn8JAAi3l8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of robin.murphy@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=robin.murphy@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C6EFD153B; Thu, 31 Oct 2024 14:19:11 -0700 (PDT) Received: from [10.1.196.40] (e121345-lin.cambridge.arm.com [10.1.196.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 334AF3F73B; Thu, 31 Oct 2024 14:18:30 -0700 (PDT) Message-ID: <7e362d8b-c02a-4327-9c5d-af1c4725ddc7@arm.com> Date: Thu, 31 Oct 2024 21:18:11 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 08/17] dma-mapping: add a dma_need_unmap helper To: Leon Romanovsky , Jens Axboe , Jason Gunthorpe , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg Cc: Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org References: <00385b3557fa074865d37b0ac613d2cb28bcb741.1730298502.git.leon@kernel.org> From: Robin Murphy Content-Language: en-GB In-Reply-To: <00385b3557fa074865d37b0ac613d2cb28bcb741.1730298502.git.leon@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Stat-Signature: 76hwx4k5jd1jjr913bx9st8fzy96u9ap X-Rspamd-Queue-Id: 7D6B040006 X-Rspam-User: X-HE-Tag: 1730409484-110048 X-HE-Meta: U2FsdGVkX19VAstvrtMF3KFtkDZ5D20EiDlgLlDBeHR5xfn7AgAB15srQk3XIvDbUb4aVJBUAnLJ9hTqo0lqiy7ttyOYyCarMPOjQqseqeIf2tHFN6GYVng0jzN39gTedT91SgKuY+h22T8TTnwY5YqDBTbRlcbYB0rfInMrEG4LvNfG/o8dWXIRW8QAhBdY599nRkw0RqeDvc+pWC0kCGoaGDHO1islkXZXNcpaLObdN1JtT5N8e+4RhDE09xTrQ4O1kx7yVeoQvqbF0EOOZVfjcYkob4B+qUgYbVuWm79HZ3hqg6MumVS/PM9CIF0on4d+nNbZVe+i7JFYbPcSUroK6E8EFF0VdCVTJF6oj8eEN/90eAwH/Hl+GJRnyILSW2hSZniecrBJXiO3qd/NWM4d2BNV/XStgR5ub2aaM8mq7AnUcc/C+udqzylWGXtB1cTAkLfZ/rOn5jUmNLc+gGJrNeTjWxSYjxfV5YUnVRtxkLgZ/P4NosCPCv92bb1C6L7NWSSE2JiQYTlDBwCf19Na5vI04VwXTrya7AamQTyPE+qnnMvKQu+gO6Auik3BqJCp0mkkxK7S5CWrExQKVY2lwynoNzwt6opKxPseuN2IvX4e4JkNjyu+F0YgKACMYJxHa4DSSo2sQhkphAZ1XT2902LAscN3XONcRVk9TlpdNTCa/m5FuI466cYNa6tyK2z1NTv5YIrd7jW6QGAlPg9zRVrTrXAgy13ctVXwuWkuiNYTLcpCHIgyW9qsdF48coyqdcdA+If30c7rzpzdU6xp3QKn6TRrmDXYZ/bmMkwjqegASH+PXrpr/9axt6kmOvH3kYhHfuH4qA9PNSUub4zmpgHAXd+ewUp4JWXS9bmsJzfZVcjMvsfstwjsOQ8/3IpDyNxp/FzYFqK5voQw9PSvUPON1N6gQ6IvqHfSmD4ScYksXjh210euVTij/bwMI8kzEgCE/fTLMlzjhLC IjsfxNha DPyV3KB2ENaG9VkRw0DgcAur17QlgPL735TLDUg6NqEmMxQ45Dik28mLndLnuPJ2TFGRjfpZMaYLDzUP4Ip+UfleXIqMjynA1V6tF/jMQym2tT5ZBplRGJAQsuHpHh8sC7/sdQuXVUsde09v2TzsnbMPtH6Tinkla19KYQXX5QonM5nxacf0DmqSsP4KifE/XnnxbjKILi4LXMXFzuvgZSTYoBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30/10/2024 3:12 pm, Leon Romanovsky wrote: > From: Christoph Hellwig > > Add helper that allows a driver to skip calling dma_unmap_* > if the DMA layer can guarantee that they are no-nops. > > Signed-off-by: Christoph Hellwig > Signed-off-by: Leon Romanovsky > --- > include/linux/dma-mapping.h | 5 +++++ > kernel/dma/mapping.c | 20 ++++++++++++++++++++ > 2 files changed, 25 insertions(+) > > diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h > index 8074a3b5c807..6906edde505d 100644 > --- a/include/linux/dma-mapping.h > +++ b/include/linux/dma-mapping.h > @@ -410,6 +410,7 @@ static inline bool dma_need_sync(struct device *dev, dma_addr_t dma_addr) > { > return dma_dev_need_sync(dev) ? __dma_need_sync(dev, dma_addr) : false; > } > +bool dma_need_unmap(struct device *dev); > #else /* !CONFIG_HAS_DMA || !CONFIG_DMA_NEED_SYNC */ > static inline bool dma_dev_need_sync(const struct device *dev) > { > @@ -435,6 +436,10 @@ static inline bool dma_need_sync(struct device *dev, dma_addr_t dma_addr) > { > return false; > } > +static inline bool dma_need_unmap(struct device *dev) > +{ > + return false; > +} > #endif /* !CONFIG_HAS_DMA || !CONFIG_DMA_NEED_SYNC */ > > struct page *dma_alloc_pages(struct device *dev, size_t size, > diff --git a/kernel/dma/mapping.c b/kernel/dma/mapping.c > index 864a1121bf08..daa97a650778 100644 > --- a/kernel/dma/mapping.c > +++ b/kernel/dma/mapping.c > @@ -442,6 +442,26 @@ bool __dma_need_sync(struct device *dev, dma_addr_t dma_addr) > } > EXPORT_SYMBOL_GPL(__dma_need_sync); > > +/** > + * dma_need_unmap - does this device need dma_unmap_* operations > + * @dev: device to check > + * > + * If this function returns %false, drivers can skip calling dma_unmap_* after > + * finishing an I/O. This function must be called after all mappings that might > + * need to be unmapped have been performed. In terms of the unmap call itself, why don't we just use dma_skip_sync to short-cut dma_direct_unmap_*() and make sure it's as cheap as possible? In terms of not having to unmap implying not having to store addresses at all, it doesn't seem super-useful when you still have to store them for long enough to find out that you don't :/ Thanks, Robin. > + */ > +bool dma_need_unmap(struct device *dev) > +{ > + if (!dma_map_direct(dev, get_dma_ops(dev))) > + return true; > +#ifdef CONFIG_DMA_NEED_SYNC > + if (!dev->dma_skip_sync) > + return true; > +#endif > + return IS_ENABLED(CONFIG_DMA_API_DEBUG); > +} > +EXPORT_SYMBOL_GPL(dma_need_unmap); > + > static void dma_setup_need_sync(struct device *dev) > { > const struct dma_map_ops *ops = get_dma_ops(dev);