From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45072C48BF8 for ; Mon, 19 Feb 2024 23:50:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6825A6B007D; Mon, 19 Feb 2024 18:50:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 632AA6B0080; Mon, 19 Feb 2024 18:50:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D2E26B0081; Mon, 19 Feb 2024 18:50:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3ED7B6B007D for ; Mon, 19 Feb 2024 18:50:35 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D142740219 for ; Mon, 19 Feb 2024 23:50:34 +0000 (UTC) X-FDA: 81810200388.17.08D9FEC Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id B7FCFC0009 for ; Mon, 19 Feb 2024 23:50:32 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="mCm8Sa/w"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PyozkvVG; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="mCm8Sa/w"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PyozkvVG; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708386633; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xdc5X6/5GGwU4BxQQI32gcL1J486hJF1mILZ+mYNYfE=; b=YcNHG1GmUy2qylvghPuhweQac8fUh4VT4kMIpt+vmAwmKT9wMQQkjY4se+nydDSnag/7LD JwEdjzlaPJ0JoBW/4FPUsq4LgHaO8e7pRvzQ+XObd7/QKq576Y7DBsLCMfgD5ITC8bZQN7 Wdz20TlglUQjGIU5XLUeLkDrEEhQD60= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="mCm8Sa/w"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PyozkvVG; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="mCm8Sa/w"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PyozkvVG; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708386633; a=rsa-sha256; cv=none; b=Lt2GbJYXtYGkMKQ0/zY2la6vHNvuv7psY4pD5L6hsWvmSnn/a4459DegDABPmIlpG3PjBL gtogCVszREqM3pzHnElOAOR4caiWeZsweEP/m1SBKvSvVKXTtYEkOmOvk1x1LhnB41scPZ MIDb6yXKtVlLxeKRduAKckIft3ri590= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5918821FD2; Mon, 19 Feb 2024 23:50:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708386630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xdc5X6/5GGwU4BxQQI32gcL1J486hJF1mILZ+mYNYfE=; b=mCm8Sa/wftvlFDrbkfvdTadwSWrLxMuhTXMhGHgC8byTdtF8w1tiAiH+FDr6Jf5nxwH+oW tuMqbNz2it8eY8Q4WNk+qADo5j2tiayESsWsE2LiIHhBXfaTXle2eu4DeAmOaCQ9RY9tKT 4pTnpMc9w/a64SKyNbyMmUsqKrXqjiU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708386630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xdc5X6/5GGwU4BxQQI32gcL1J486hJF1mILZ+mYNYfE=; b=PyozkvVGeWy4FpEDUzEh3vvu1E+DHVjiY/cZL5IekdrEtAIjmD5/epjKaxgBzv4bw/xbFC zHIcndKfdmAz5vBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708386630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xdc5X6/5GGwU4BxQQI32gcL1J486hJF1mILZ+mYNYfE=; b=mCm8Sa/wftvlFDrbkfvdTadwSWrLxMuhTXMhGHgC8byTdtF8w1tiAiH+FDr6Jf5nxwH+oW tuMqbNz2it8eY8Q4WNk+qADo5j2tiayESsWsE2LiIHhBXfaTXle2eu4DeAmOaCQ9RY9tKT 4pTnpMc9w/a64SKyNbyMmUsqKrXqjiU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708386630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xdc5X6/5GGwU4BxQQI32gcL1J486hJF1mILZ+mYNYfE=; b=PyozkvVGeWy4FpEDUzEh3vvu1E+DHVjiY/cZL5IekdrEtAIjmD5/epjKaxgBzv4bw/xbFC zHIcndKfdmAz5vBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3634813647; Mon, 19 Feb 2024 23:50:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id srCIDEbp02X6YgAAD6G6ig (envelope-from ); Mon, 19 Feb 2024 23:50:30 +0000 Message-ID: <7e31accb-db01-486f-afb8-18a3f5402d00@suse.cz> Date: Tue, 20 Feb 2024 00:50:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: regression/bisected commit 773688a6cb24b0b3c2ba40354d883348a2befa38 make my system completely unusable under high load To: Andrew Morton Cc: Marco Elver , Mikhail Gavrilov , Andrey Konovalov , glider@google.com, dvyukov@google.com, eugenis@google.com, Oscar Salvador , Linux List Kernel Mailing , Linux Memory Management List References: <91c50335-e7b6-4ae1-9dad-a0c990b52021@suse.cz> <20240219152836.11d36709c594e66fe3037f2d@linux-foundation.org> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <20240219152836.11d36709c594e66fe3037f2d@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B7FCFC0009 X-Stat-Signature: 89fxkdb6dw8kwghwogzdmccz3wpgqykp X-Rspam-User: X-HE-Tag: 1708386632-189191 X-HE-Meta: U2FsdGVkX1+GS/HoIafbC/bOwEvHTRv/g5J1wITxPUBMQcI+vGxfTZuh8lmXgjdFKZhhBWttkrXWcMZXwacUrUWGmLR7xDQMBi/6Itw7UW3/Tet+why+3Q7YIV+3/GCLbbvjB7+AcUF2ZixQnhmMucA7/LSMPgHVJrhcMAmsYB04vFjdmgyDwqn9vrEDypevjnrHUCnFcwmwuJQkZ8naTRodgxT467R8pTe2nc40Xa9LgHP3hkIuOXhucMNo4/OL95t3M7UKjBEexuevnrf33B+5zs5tFl/3uQycYsbIrN8PUFIP2biK7ffskuJNgiBgJdizn4BLNxxsGUHfg0ekwhmRhrFszzTQsEk+qWrdReaVUjkf8jZ9XVcx7VL2i4swTXkUnY5ucwYXuYD0ZQH8svL22dwDci1BrSogkXux3X0pQ10rViZdcwIiE/VPUIFQxQgdZANIFQSfsL5aR4a98GYz49gPmi16ck91qfPg4MDQ7epwgdtyUiLvQqUaohj91CYndw4Yxa1+SrZKKRQSw+svT8fksFHSS52z2qnoJC5s3a7/91eUOJpknclsUcaa8H7XAdkYoVUcd1Xb5YD70a4yj/fnCbeQ+ixQdH0XPPY/t4hlAh8Crpc7u7KYlaf/Q/AngTi6LMI48ft7IAaVdIpDPxObYFzUo1vF3KiG/GNK8XQY1VlfBPWlVYTd2w1Q60lmwzSZNkRXMpkLXGfAVvpAqC1qupsH9GOCIZ3G+QtJCFNfxtQh6v6Iee3JnTNnGrgdxurjttAMVIfvd0NzoANkjys75s5nanPf44tcdp+qqfA6QbYs0kWhtqbG6deNu0DaEQ6voANyrC2JC+2tTSWqBVSehYig1Tg3AEuhvJnHWPmpMvqPU0YTPzcvFEdny+1nJ3D7WH3LRM/4muliTjhaiwLC0AxAX/iELnzNaipO7Og1MJdrP0cHBViogcKBPuzRU1uTKfvO2FrcOLB qAWBXpyW 4b+wkdz77GDqczFwEMv9kO4EQXXgq/uoHaMQi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/20/24 00:28, Andrew Morton wrote: > On Mon, 19 Feb 2024 11:09:23 +0100 Vlastimil Babka wrote: > >> On 2/19/24 10:52, Marco Elver wrote: >>> On Mon, 19 Feb 2024 at 10:48, Mikhail Gavrilov >>> wrote: >>>> >>>> On Sat, Feb 3, 2024 at 1:14 AM Mikhail Gavrilov >>>> wrote: >>>>> >>>>> You are right. >>>>> Thanks for digging into it! >>>>> >>>> >>>> This [2] revert is still not merged at least I checked on 4f5e5092fdbf. >>>> Is there any plan to merge it or find another approach? >>>> >>>> [2] https://lore.kernel.org/all/20240118110216.2539519-2-elver@google.com/ >>> >>> I think it's already in -mm and -next. It just takes time, which is a >>> good thing, after all we want to let -next testing confirm nothing is >>> wrong with it. >>> >>> Andrew, is this planned for the next merge window or as a "hot fix" >>> for the current rc? Given it has the right "Fixes" tags it will make >>> it to stable kernels eventually, but I also think that the previous >>> "slow" version is almost unusable on big systems, so it may be >>> worthwhile considering the current rc. >> >> Yeah it would be best to fix in 6.8 to prevent regressions. >> > > I'm all confused. > > 4434a56ec209 ("stackdepot: make fast paths lock-less again") was > mainlined for v6.8-rc3. Uh sorry, I just trusted the info that it's not merged and didn't verify it myself. Yeah, I can see it is there. > That patch Fixed: 108be8def46e ("lib/stackdepot: allow users to evict > stack traces") which was mainlined for v6.8-rc1, so 4434a56ec209 did > not need a cc:stable? That's right.