From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C73BC83005 for ; Mon, 12 Jun 2023 09:22:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 265A56B0074; Mon, 12 Jun 2023 05:22:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 215DE6B0075; Mon, 12 Jun 2023 05:22:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DD636B0078; Mon, 12 Jun 2023 05:22:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0016A6B0074 for ; Mon, 12 Jun 2023 05:22:09 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BCE12C017B for ; Mon, 12 Jun 2023 09:22:09 +0000 (UTC) X-FDA: 80893554378.27.EADAD84 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 921751C0002 for ; Mon, 12 Jun 2023 09:22:07 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NhYCwi4R; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686561727; a=rsa-sha256; cv=none; b=lTGieEFbn929DP4gvOG/BRgJpXkd8gfnxOp8uu1mkyb8F7OzrnLMHwlFewT/VBqB7Kltn9 7Ym8v2DNHWVMYJ5aYmBIVPt+rABRWmL21PVbOURQbJAGm73/l9KyDfAnO4F3joG0YGkgDN h1leqgEGQz+C9tCOB2BScaI2hNqwCfQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NhYCwi4R; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686561727; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jmiYL5ekUeYsbYDrWaIYmx1UrfmarTSRZzI2A2Eq1R4=; b=1zwpa4YOQPSYTIXDNhQy+B3FVnnLzn3lCPrKfx2B/6j2PI2gK204mfhJVDAidtLMizWxUj FfmL5/mM1AdVmZgoDUShassb7ncz7x7gv1hvqg7XiMfzYBPVUKXQUWDkwKgKEymECmXwZz 8iNyfOh/f0FxTQYSv9JowLniEVAf5+Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686561726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jmiYL5ekUeYsbYDrWaIYmx1UrfmarTSRZzI2A2Eq1R4=; b=NhYCwi4RfUsaiafiv1x0xbihx+/cDtArSzwm5PZhRZlEMljFB52PU2+K2bwB7jHesIahiT tFhV+vQyUqk7OmiIPmsiiHeVYnPrjSTqA5wcrb2Kg6gwbHPX5QlKPgB7yT7pT8Y9rNbUxw qPSJxPVEo0xuNUM7MOAvjKsn3hOzXzw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-378-rn2wXZb2M5-s4EfMEsoAMA-1; Mon, 12 Jun 2023 05:22:05 -0400 X-MC-Unique: rn2wXZb2M5-s4EfMEsoAMA-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-30fa3ea38bcso889334f8f.1 for ; Mon, 12 Jun 2023 02:22:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686561724; x=1689153724; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jmiYL5ekUeYsbYDrWaIYmx1UrfmarTSRZzI2A2Eq1R4=; b=TqVm6XKat50VYIcIA73SeNnoLXoE8t+MiUyVRar7d5QEpn0isDsz9YuLPzUn9RYRc2 Q7XDvwauc11IOrh9yNFXXMltzCrFKSL3DOqO2uT1jwVlAsH/+Zf361majxGlvVq7Xp3t T0KeBg/C3/qiycGH4InrKDiL8dM/Xk3cXtaP4+kJS8QZTyDofPdNJYZXugpYc7ZR8GeU Z3NtZrZ4o0HOZomHTlKTziGCj6fjLvx4reOnc1jfIB9s29r1YdQykx8d5afL8qRdpbR0 jUWtVnoXxLJmbsE1hIdWuKwov9Qac7rnCAtDeAQtaVrUFlTxmNWJr7OEvFRq44hkZL+u Km0w== X-Gm-Message-State: AC+VfDxYXKYj7zqrcpR889W1qG1EByCMAxwdNCwI/vgrVHFxk+Z+7Yal P3sC8zrHLX/sHMsaM72LAy7xhdJQoIwLLnh2DwiSUSQvFfUoRfMGbIGD8tseF7JvZ5/Ja2SOx8Y bQRYujYTpj/I= X-Received: by 2002:adf:f84e:0:b0:30a:e66d:25b7 with SMTP id d14-20020adff84e000000b0030ae66d25b7mr3699348wrq.13.1686561724450; Mon, 12 Jun 2023 02:22:04 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4aSaKMrUoLClL2yCKclHi5IHBVSe5TPx0z3eq3RsU4ebM4GMlPhs7avKHXJFSTqWa8aRrulg== X-Received: by 2002:adf:f84e:0:b0:30a:e66d:25b7 with SMTP id d14-20020adff84e000000b0030ae66d25b7mr3699326wrq.13.1686561724064; Mon, 12 Jun 2023 02:22:04 -0700 (PDT) Received: from ?IPV6:2003:cb:c74e:1600:4f67:25b2:3e8c:2a4e? (p200300cbc74e16004f6725b23e8c2a4e.dip0.t-ipconnect.de. [2003:cb:c74e:1600:4f67:25b2:3e8c:2a4e]) by smtp.gmail.com with ESMTPSA id c1-20020a5d5281000000b0030aded83385sm11909047wrv.27.2023.06.12.02.22.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jun 2023 02:22:03 -0700 (PDT) Message-ID: <7e2144b1-23f3-68ec-b4b1-f4ed9025b476@redhat.com> Date: Mon, 12 Jun 2023 11:22:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2] mm/vmalloc: Replace the ternary conditional operator with min() To: Lu Hongfei , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , "open list:VMALLOC" , open list Cc: opensource.kernel@vivo.com References: <20230609092602.26412-1-luhongfei@vivo.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230609092602.26412-1-luhongfei@vivo.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 921751C0002 X-Stat-Signature: zqfrqm153u1zr694c36ukqq1aciy3mpw X-Rspam-User: X-HE-Tag: 1686561727-118812 X-HE-Meta: U2FsdGVkX1+g7Hk9d2PB01nWF09GoPGluUl2Xrm1S01YWDPatprgpjYA96xdfsahg+fhVFDSTxih+IEo7NKotfQWXavaWdde7epYLx9u24K45nw7Wn2r4NmC2ZosBUYYBvCwXJkwZbudRszX6JqmDQsp5lYxLrVskeG3Du2vLlNMDpHnJeTPDlcwYtwXgoDVt2hkzLuYbWX+4R6g8XIOtQYV82KIPVpSOXCPab6B9QCORtTEbHXqVrZT5FV31zRjN3dUDq+PvOuNa/raxnHXGiX4w0FteUpd6s/aOaLM9I8CiAsqJIMhyf1Lsxatr3QyTUakluq1RjpgAnaxoR+71p0ADEfRLyRUMQ5/tmNqkuPXoPzQJCM3TCURrGDu8gbjxOMg9DWDnYIvl0a2tvAd+u+uYMSt2MRWQxBtXiG9deC3P4ER/a4nx/rvJYlM/+fw8NczNXbFbY4sDxI4nnf2QoiqoHqPQszS7pMKRMXPgQ2AHDTtx+iIzxvTbfGFSDDlVGgd1bdSNCqgDhS/9MNyFsnxZ71BSbOT+SwY6FPlBtmvQXzI3DWee3s3pLmoyYpa2/jBNCuNQHnX0SUmnVWhZOYrnEplktX1b7jsZ8QfJp/ugqhYjYltfFGjntpha86XkGKVsGU1KZdFbjm33PDMSYcjjCDMGK4WNYFYi9VECZ+wnsJQWEJzzyJJCDEzUyzU+Yo6lpdBK3oHKQromiYRRUhw/dSd+IXNPxAwJW+zzebQwmib7EZ2Ldrs4bkDZ6Cy5vHioYEvB5Z/0/XCfbEMXsT8VWhC/J1NrS22DGEQkI2IDQQvWBEG9uCsBBDT46ONJJ8ubhsHmt8CLldz94QgUwDqCsJjf+gXzeY2E+8iYJKVwnkQpZZs8DNEnZmwk6Kd1uQ/qoQ6B/aAh6j27w8KtirOF/nngzHejUZjCVzpoIFiZrfdISAhbbtbElbZ+2LnGQbP88P9kyU+lC37WyP QNawI7jj Ldzjp+x+Dg8oqpcvTm5CV+JRz5kUHn2nQ3nwe8IXVC9SGALaDuEWs0q6m5DGp6lVNvrjUTqwHdcOkjVxM4BeFyJU/oBiFJ5ZKFLDoaur2TPCrCyAklwWMS759HiYq+SXLS/zkqVwpx9ZDfqs+jbyXmJXMlIgXJz1OGPnR5Wk8x8mSY6+aW3TJ3+PnCAl8uR7fBROglmeUVEmYkcWgqSNpslSQjGaIIpzjjIFZnSiTPHp1SsWBfNEbm/6XDU/qmdR/e+t2QySARhEzlqtsCslYmxkegodCVFGJktXFWSYa9/LZZnYwzQ+kUpiTikllqcBq2DyMJu7nmV3Dkez8VlgSWqrwF9Kqs0vvwr1GVbV+RvfognakJAfX26XnRb9o+DA1Onq7ygkGwmRalQo+L73dMiFbvRaoQDPqwKwVLLX+F/QAkxGWx22GlXuDhlBytDJJ8yUL56lco5fNbaEDaGCLUD5Oh3+dWpXmbrAspOytCYfXOhs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.06.23 11:26, Lu Hongfei wrote: > It would be better to replace the traditional ternary conditional > operator with min() in zero_iter > > Signed-off-by: Lu Hongfei > Reviewed-by: Lorenzo Stoakes > --- > mm/vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 29077d61ff81..6125ed506895 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3571,7 +3571,7 @@ static size_t zero_iter(struct iov_iter *iter, size_t count) > while (remains > 0) { > size_t num, copied; > > - num = remains < PAGE_SIZE ? remains : PAGE_SIZE; > + num = min_t(size_t, remains, PAGE_SIZE); > copied = copy_page_to_iter_nofault(ZERO_PAGE(0), 0, num, iter); > remains -= copied; > Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb