From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35A9DC282DE for ; Wed, 5 Mar 2025 19:49:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E8FD280007; Wed, 5 Mar 2025 14:49:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 29BB5280003; Wed, 5 Mar 2025 14:49:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13E16280007; Wed, 5 Mar 2025 14:49:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E64BF280003 for ; Wed, 5 Mar 2025 14:49:27 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 27E171A0A55 for ; Wed, 5 Mar 2025 19:49:28 +0000 (UTC) X-FDA: 83188536816.29.58D031E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id A5BAF1C000F for ; Wed, 5 Mar 2025 19:49:25 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W2qHqkd7; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741204165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=03yN7yH51hsHUzMn2+esz4Pv4dir90wQl0oFMfmdQtc=; b=BLEWjQE2f7ETtSSzvFRUdjOuEhhSeNbNhZtNi4O3tDQaKuX3pZQnXwA1bubLfh0ovO+bZK Nb2GnCxopkQ9hK+ig45t3wcVeg2APX9woDatXybYGVWBBdlujQwRPjGTisyZNQ/AdliB4r mlGo3o+4SfM4NePGnJM2+kx7RZqbIbo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W2qHqkd7; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741204165; a=rsa-sha256; cv=none; b=bon+H523UD2R0fQkPwdGXdcgbGMG09AIkiUcLiOP5G1j4YJgqQ6yDbGMwGJtxXBPW634ni t3uEGTJec4711cxAwdSFmO3WG36j8zZMk7FqJNu44mPw5DDOMzTnM55j+pV6pGnwMvp8vR p9nqmvt9KUMnBwZRMPG0dgN37Xltn2w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741204165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=03yN7yH51hsHUzMn2+esz4Pv4dir90wQl0oFMfmdQtc=; b=W2qHqkd75uswsFX+UTAxHgbRy0L5e9xMdZvz38NgMhY4efv640sAu3UkY+5v4fpZ2d1zhw MGjjcnIJORFFiX20nQRYn6Yf4SU6MrmZGfiF+cccY7k7soaUIeNYEXBggoDY0/B1jjYrBD pHtnEfGwNkcItQ1GI3W34oey4UQoNqs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-294-FPTFDCFWNmi1pPIDVOqIJw-1; Wed, 05 Mar 2025 14:49:22 -0500 X-MC-Unique: FPTFDCFWNmi1pPIDVOqIJw-1 X-Mimecast-MFC-AGG-ID: FPTFDCFWNmi1pPIDVOqIJw_1741204156 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-438e180821aso37159635e9.1 for ; Wed, 05 Mar 2025 11:49:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741204156; x=1741808956; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=03yN7yH51hsHUzMn2+esz4Pv4dir90wQl0oFMfmdQtc=; b=ugGbMcMtHkq2nkbMSigp8Z+te665oCB0tpa7WFhyVBvNdxFEB9bvv9LQV6N3LYrdbG XWzNFc1vXmweFEpwm0x/Jlk36tngIoFaywK0fSL46io+l+JzWFscWzKTliYYuOhvNX6k ojZ1oss5UV3EfnEd/XrYQRnL58cCh+1bVvxWcdzuvShgqR1Ytv5gFABSA/qQvxkVgS7V BsDkd9nGr8ZDgFfJwhNTkdfjLTmAvMlw7tmLV7MbL1BASu6lfXhGLCHHV0Rigc0Hqa24 oXa1HRbA5Mr6TuzDI+G76mGkIJAmM5OOWzA04HytzjbuqJTOxk5gZpK94QtmC0HlLABs Vtfg== X-Forwarded-Encrypted: i=1; AJvYcCX5xnYwOuuboIQyIDbmKWjazTk8NhR2TKgb/uCrdiHsAVy7AJ5m8SKjg5nrKp/uUaAG05wMHAGloQ==@kvack.org X-Gm-Message-State: AOJu0YzCPSCDTikII4Q1ItPvH6XdLbS8MweEBM47Gge5zmmi9abyo8wQ HHmQww+EF8XVEpk6vOqCH19rIKbDdkPBowIqN4TmsKKMswyjX91WKd68Ds0SJkIunKXiGuKxozk A+8YpFDqyvtaaGh6J3NDKca6yttC8OP1f/kWmd1NGmVOQzqPH X-Gm-Gg: ASbGncsBrxlTarlBuQgt5yha4cHr/UQhHApJOI0AQiNDWag1W+Cn069IGYaoh32b2Tp ob7pgbjXwrr0uzVy71JUs8Qv69usyF2c5LyAQO7lWPbTeNO4RDWPT0WSWFa1+OVryR2UcnI/Q4U uVoK8D8YL3psUAR3aFKHT1G6reqsej/JQ29N/fG+oAGml9tgZ3OReyx/xEUaKz+gxPWNwO/l5ma domdcwdu/XKpNgNjrl67VHQ3ZlhBC0ED735NcZ1cATnRiNz1rRFigXe4ww6AzhGpwok7rUGV38/ fC/2UuU4P42iZSa9UbpvFZXIqT6thgstCfAiET8zYsyMVkMfNIn4l6bg3q1q2P+Ee7kAJvC5wHs BX1hv7BDbsTg+os6Iua7hKRHRCTxa7vB+meITgAwyWKg= X-Received: by 2002:a05:600c:35d4:b0:439:9f42:c137 with SMTP id 5b1f17b1804b1-43bd298f9fbmr41869675e9.11.1741204155841; Wed, 05 Mar 2025 11:49:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IHaclzLgfCSRWemIkkhnUP4/0u1OqlT3G4gkm4XEO0QvHJdU5h97AT9npPILhWPM591bWsdJQ== X-Received: by 2002:a05:600c:35d4:b0:439:9f42:c137 with SMTP id 5b1f17b1804b1-43bd298f9fbmr41869485e9.11.1741204155413; Wed, 05 Mar 2025 11:49:15 -0800 (PST) Received: from ?IPV6:2003:cb:c739:5b00:84f2:50f3:bdc8:d500? (p200300cbc7395b0084f250f3bdc8d500.dip0.t-ipconnect.de. [2003:cb:c739:5b00:84f2:50f3:bdc8:d500]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bd91338cesm14038955e9.7.2025.03.05.11.49.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Mar 2025 11:49:15 -0800 (PST) Message-ID: <7e151e6b-3f81-4e37-b314-c6e9f19c1b82@redhat.com> Date: Wed, 5 Mar 2025 20:49:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 00/16] mm/madvise: batch tlb flushes for MADV_DONTNEED and MADV_FREE To: Shakeel Butt Cc: Matthew Wilcox , SeongJae Park , "Liam R. Howlett" , Andrew Morton , Lorenzo Stoakes , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20250305181611.54484-1-sj@kernel.org> <46960f37-0d12-4cfd-a214-1ddae2495665@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7fXo8e08_p2-5i3tjWbCaBqI0ekXqgBnuuGAB2obguo_1741204156 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A5BAF1C000F X-Rspam-User: X-Stat-Signature: dzgepspo4kgjkzn1gxrf6uqwrahypi1n X-HE-Tag: 1741204165-535550 X-HE-Meta: U2FsdGVkX1+mIXTlgvQ0DpFWIcqLZ39p/ddHy0IR0DW8Ex/GoJimwx0yDizhwYp5tCHTNSOOBcS9b66z12mibp5JnY+oy3tBqaYtubPMStNBWV1V51cq7L8YOszoJ4Yq7a0C5EpMkzVZDQeS5VQbwKa2Z7+YOdI3TwpF0Gn3WpGvN2YeM/FB0XMmDUf5zmpjlrBCAWtSshn5Mp8OLEwpGYp2JhiYo56ZrNZG5SRQW15z2GOHqS6+vvK0EDhVqLwVtiz57gK0HQ2Xtf7/etqcHB4r0mCApvWQxQ52XfveUFLFLY5x/YeIUa7O8bxkZdHrr9dXTINYQK+A2OTcfzQyaWMNex4ZILzE5P7mobszB3UR4BLrBISdLZ3WTIdQYDoOUl72+W4wSm7vtP+2XP5prjqJNIybn5OxTSwuYbV7zvVbDzoTpeQFemEUugGeljqTuk4sQAeLchdAcl7CgeuwTspuygR7zbRxRV2zOnbRwld42aiEOzDKm1OOsR73INWwhAmjCMSr9/IBt5CG4Is6WvsEQiybF9RhONL+I7DuuBMxrcZoF6IvzvUNtKTiNjHG9PRcxp1K5UesJFG/AVDsOa2C8HvcUdHxNmq+P3kBBuHoIsGtSjiG07mTVVyAB0Y7vKkI9Z/UUR9PhzrLWCLToRTB0tcQpFfTYJOt4uAEm0ZymxziveE93UvwZlG86M+DfGUfy85wetvBEofPbIzw+fWoBwkxy8GFZpcOgN3TJ00XWnHuyQ6GyRaaqFgJc+MBV1bS1b/8rAHsA8nS12ibjsYNG2JvO+RCCOtG/9Lq48GpFjiUpHBVyt/8fJQ0EI+I34EhSm8kAf+RjLeh5gSKcwh1sEuTFO6wErJC2pYYCAMn09tLQOncfXn1jHG85q2JRL5rs7DGICtrhsakmBC/UEUvvbyApEbhDtmO7MOFLTC2EUyxuVfhNz8nuG+aYs8IeaEKyDxf2YncU/WN94i 74cH5lBu iELJTW+baw8K+ttRHlGttN5aPUhQwmE2s8TqYn2yJyibPhE/erV2V11GlGiPY241mtTGU+oxIra6DBmVkA1mGzSQTrRwBc2i9FvRFCudEgjMCPeDFSs6ynX5wb8Ad5bgZrnOVbI5menaach5UkwRZEPCiO7ZuQyv6jngdqZe3VTvsAman9znmNBKKC7HqhocCLDbXwV5k1zYLXIQodD3kFEYsncHFKlfr+RW5B8hEMG5fnS/tvDKIQMK1Kx6SXH+IZNkLF5c1LgAobSJ528ggRVmzHP3mis2ahN+a+gQAEz+kCYyskJtYamBFTDiyO0firqu9ZIvNosy6SGpFyXoOAh1Dk8/ZXjqzxE77dXiGjAOKRWhj6LoIBZy4miscN+C+kUfJWFd01BlNxrKLAw+jyjSPHV5Ulm7TspfZdrQV3GNUUhEzEQWpgJ7iu9hDs3f58PBt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.03.25 20:46, Shakeel Butt wrote: > On Wed, Mar 05, 2025 at 08:19:41PM +0100, David Hildenbrand wrote: >> On 05.03.25 19:56, Matthew Wilcox wrote: >>> On Wed, Mar 05, 2025 at 10:15:55AM -0800, SeongJae Park wrote: >>>> For MADV_DONTNEED[_LOCKED] or MADV_FREE madvise requests, tlb flushes >>>> can happen for each vma of the given address ranges. Because such tlb >>>> flushes are for address ranges of same process, doing those in a batch >>>> is more efficient while still being safe. Modify madvise() and >>>> process_madvise() entry level code path to do such batched tlb flushes, >>>> while the internal unmap logics do only gathering of the tlb entries to >>>> flush. >>> >>> Do real applications actually do madvise requests that span multiple >>> VMAs? It just seems weird to me. Like, each vma comes from a separate >>> call to mmap [1], so why would it make sense for an application to >>> call madvise() across a VMA boundary? >> >> I had the same question. If this happens in an app, I would assume that a >> single MADV_DONTNEED call would usually not span multiples VMAs, and if it >> does, not that many (and that often) that we would really care about it. > > IMHO madvise() is just an add-on and the real motivation behind this > series is your next point. > >> >> OTOH, optimizing tlb flushing when using a vectored MADV_DONTNEED version >> would make more sense to me. I don't recall if process_madvise() allows for >> that already, and if it does, is this series primarily tackling optimizing >> that? > > Yes process_madvise() allows that and that is what SJ has benchmarked > and reported in the cover letter. In addition, we are adding > process_madvise() support in jemalloc which will land soon. Makes a lot of sense to me! -- Cheers, David / dhildenb