From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8F42C02198 for ; Wed, 12 Feb 2025 09:52:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1919E280004; Wed, 12 Feb 2025 04:52:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1431C280002; Wed, 12 Feb 2025 04:52:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0862280004; Wed, 12 Feb 2025 04:52:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CE47A280002 for ; Wed, 12 Feb 2025 04:52:27 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A3462C1930 for ; Wed, 12 Feb 2025 09:52:17 +0000 (UTC) X-FDA: 83110827114.04.B9468BC Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf04.hostedemail.com (Postfix) with ESMTP id 7AF3040006 for ; Wed, 12 Feb 2025 09:52:13 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of chenridong@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=chenridong@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739353935; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mbpApkpv1HNaltQjasqY2Uq0tt49kc7wDPCURQOnDx4=; b=A1Obd519vD+k9cgC1TG3Dj5TOwXkdQHfPKay35HRKSLt8lEHNja4mEpjNpWo1cQBsxIkjV Pp/sME4qZkWIVq9hRcm6PGeaQfGNpvQSNgpScskJo0TVToY10E4HcC2SKcDvRBZ9w+aocE 0r4mZhSdfA/Mqc84Ua/lG8TKm5sgwrg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of chenridong@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=chenridong@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739353935; a=rsa-sha256; cv=none; b=DCkQuNuhIq/zIJ392JoKqB/n26kx4+a/kZzyBjtNnbtkK1gvb3HLGvUuxryOyJnu+uAfT+ F9FfT0q+jNes1zYxxSNmUcV4zYTXOjPXRUPla22oMiqKt2bucjyWS+ByiR+uUgWFzevvxL z1Lrjfy59Errwxron56CIJKURT5+/2w= Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4YtD9W1KFRz4f3kvq for ; Wed, 12 Feb 2025 17:51:43 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id DEC741A12BC for ; Wed, 12 Feb 2025 17:52:05 +0800 (CST) Received: from [10.67.109.79] (unknown [10.67.109.79]) by APP1 (Coremail) with SMTP id cCh0CgBnGHlCb6xnEwBSDg--.38612S2; Wed, 12 Feb 2025 17:52:03 +0800 (CST) Message-ID: <7dd7109d-7554-4b69-8a46-02620abb8583@huaweicloud.com> Date: Wed, 12 Feb 2025 17:52:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/oom_kill: revert watchdog reset in global OOM process To: Vlastimil Babka , Michal Hocko Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, yosryahmed@google.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, davidf@vimeo.com, mkoutny@suse.com, paulmck@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com References: <20250212025707.67009-1-chenridong@huaweicloud.com> Content-Language: en-US From: Chen Ridong In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CM-TRANSID:cCh0CgBnGHlCb6xnEwBSDg--.38612S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Zw45Jw1rJF4rKr4xCF4rXwb_yoW8WF4kpF W7u3WDKan8G3Wjvr4av34Iqry2kr1xXF4rZF1DJw15Zrn09rnrArW8Cw4Yga4DXwn3ua1j vFn0ga4fJ3y5J37anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvjb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lFIxGxcIEc7CjxVA2Y2ka0xkIwI1lc7CjxVAaw2AF wI0_Jw0_GFyl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4 xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r4a6rW5 MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I 0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWU JVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUF1 v3UUUUU X-CM-SenderInfo: hfkh02xlgr0w46kxt4xhlfz01xgou0bp/ X-Rspamd-Queue-Id: 7AF3040006 X-Stat-Signature: yyu4zfqzcuxmwstybg4rpdfxprai8xxw X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1739353933-610133 X-HE-Meta: U2FsdGVkX18B4zCxFLFxXQVEq3Cu2EU1x0zEo6Vt9HI/R2aAOuBPebltgo8axWlUNoS+buRhSH39f6NIRIJD/Ih+gMhKbjquzVtj1vMq9U9MRbsLIkyA1ESlrwcQSu4i32KgdDgUbP8NdNBs7OpBfKSftWhSSL+GA7pQf8gBA2DpHMvcc9v45iyOSV1zl8PvBeiUghC1M4jcpKCOx9OpQ2z5QfMgzkuOVQh2Fddq1O3i9H60mbadtBS7aMf7MAh5WwIB9z4EZmUAzz2Wnc6rCeMjiOvy53KsT7Lmb2e+lqED5RNUoEpkuyKLVToJRkZqUH5KxgFl6vaLln+xB6pe9m/KB3F+EvoDVYSnLPwyz2zUPeDIupCxfbrbaDerXOVoOzgvQHcSPzHMXoLqraq8MkINdiTYoHOU7bCdCSrNKT5NwB/enfFQz0mc4vji16skz98koVt0gnZblk2yJhd4Yanz2Z+gQpmHq6FrreiBZRcSWEnIDyOfer4UoQApWCXm5z6Xvhz09ke2nxs0K9IGes73NcIF20OhW6SVLMnv5V63Up/h+D+U97wBBXdwCT0+8VIS7UOF0kODtyInKEHUfBVqVDC8Hl1ViGPy45LJRH/Lx6BamDXX7g7bTcvQggzqqnkrFG0+Fz6CJE8ZIVmDVMvTVxcIU5FXGXQC4GM459EkLON+u4SRa7eg1P/0Q9OQb+xpQ7TVS2DhFc9I0cx82khJyuwi6BCpeXvhBaKskO7QIZ4KEHKC8sSX85u6sg1A5aEt9r7vN6D41ZXGhOQyhYpeEEqdvWDE+oJzv4zvYsaPjfHbdIEgrt0ggi6FH1QSd/Fdm4wYg68NEYYRXzfyjDDAjg4ED1n+zK4tRpDs5Gc/LN9HMieBynZZJ5jGvw1XyPpaEnT/cray2JvdWXmKt4ozWQi9WhAGXUNQF5RGzvjWlH3h0TsCvMOFE0OXLqQqZXma8cdKzusGvzXNqip HpQbNBgL qH2clGHofR+6D2CpTuUH5XTCGM1F30Qu/vI4VRXjKgT89OThWo+irALumg7/hLElPtZ1WBmBspl6oT1KHxdzmgti+OpjsBfU8S9d7bHhvS4ydLbO0UQxxIizvVAiLQJui1TQnuxIRYZ8vXm5xGDLZM/Y76UeAig6KUZVprrOtNTPYFNjiC1z24j+/gDvh94LLH7Wg4kPwA9K5zAAg6sdrA2oI/NxhwsT7sKbrXVNnZnZrTDd42uGVYl/P3K7MfBr9Gu7bnKiPAk588MT5B/9wwJQ16A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/2/12 17:34, Vlastimil Babka wrote: > On 2/12/25 10:19, Chen Ridong wrote: >> >> >> On 2025/2/12 16:57, Michal Hocko wrote: >>> On Wed 12-02-25 02:57:07, Chen Ridong wrote: >>>> From: Chen Ridong >>>> >>>> Unlike memcg OOM, which is relatively common, global OOM events are rare >>>> and typically indicate that the entire system is under severe memory >>>> pressure. The commit ade81479c7dd ("memcg: fix soft lockup in the OOM >>>> process") added the touch_softlockup_watchdog in the global OOM handler to >>>> suppess the soft lockup issues. However, while this change can suppress >>>> soft lockup warnings, it does not address RCU stalls, which can still be >>>> detected and may cause unnecessary disturbances. Simply remove the >>>> modification from the global OOM handler. >>>> >>>> Fixes: ade81479c7dd ("memcg: fix soft lockup in the OOM process") >>> >>> But this is not really fixing anything, is it? While this doesn't >>> address a potential RCU stall it doesn't address any actual problem. >>> So why do we want to do this? >>> >> >> >> [1] >> https://lore.kernel.org/cgroups/0d9ea655-5c1a-4ba9-9eeb-b45d74cc68d0@huaweicloud.com/ >> >> As previously discussed, the work I have done on the global OOM is 'half >> of the job'. Based on our discussions, I thought that it would be best >> to abandon this approach for global OOM. Therefore, I am sending this >> patch to revert the changes. >> >> Or just leave it? > > I suggested that part doesn't need to be in the patch, but if it was merged > with it, we can just leave it there. Thanks. See. Thank you very much. Best regards, Ridong