From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C9C0C4320E for ; Tue, 31 Aug 2021 14:08:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1D4156103A for ; Tue, 31 Aug 2021 14:08:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1D4156103A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 702158D0006; Tue, 31 Aug 2021 10:08:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 689E38D0001; Tue, 31 Aug 2021 10:08:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DC8C8D0006; Tue, 31 Aug 2021 10:08:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0086.hostedemail.com [216.40.44.86]) by kanga.kvack.org (Postfix) with ESMTP id 369FE8D0001 for ; Tue, 31 Aug 2021 10:08:43 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5E313824999B for ; Tue, 31 Aug 2021 14:08:41 +0000 (UTC) X-FDA: 78535556442.10.122DFB5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf13.hostedemail.com (Postfix) with ESMTP id E429F1023056 for ; Tue, 31 Aug 2021 14:08:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630418920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mk5ulB/sJnXWATjcBk59gJWvrwHsxe0fgZRViunJDv8=; b=K44RQmvKqDH5yIxWcOKD/vl9KOVWvaxnafKPTvytGIAfC0zDmgTEWzRHVNTCePcIh5mcvM J14kS3T7iUasqecrRXgqw+y2A+ZOrMkYA7D5iDHY8D31MEx5XWaqSzUdcQVlo+jzZ+pG08 opp14u+TxYu6hC0ELm4+5kjbZTuMlkI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-447-_JXgWXxCPzyrzVx1906_zw-1; Tue, 31 Aug 2021 10:08:36 -0400 X-MC-Unique: _JXgWXxCPzyrzVx1906_zw-1 Received: by mail-wm1-f69.google.com with SMTP id c4-20020a1c9a04000000b002e864b7edd1so6019678wme.6 for ; Tue, 31 Aug 2021 07:08:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Mk5ulB/sJnXWATjcBk59gJWvrwHsxe0fgZRViunJDv8=; b=sUMOQjvPK4ZSAbgPFVVwIfiQSJPVjv1d1ceNxFe0IaBMcGg4bq8FQHQTYmtDa1r4Ra DSSSOiOsENJOUJIN4pjr/o3m2am8hdOKjAE0ruHHNfZVJvQ/Wok/RpptEKCRbvOwbHeE t8xCRipMYHoaEC5nF5vDqTggJP6p/d+OmFraxWYUOLgc0jzFrv5IFnt0NhXKx0lz9KyH 9tbP8VtEhOtHBMZGBz6USfkAg1CcRe1Se48qZpm5gAcsLKxP6wXM/73xcDQJlAo0xoSp HKbs9hzcA5ubnw/d/HoUd/uK7OyfWDvyhZ+sMqvME0d3DUaubcNrIAs7aY+aVgf9hNCm cS8w== X-Gm-Message-State: AOAM533NBIf3hpBVrrkf3notS5pM3QCHYrNv6kQOPtnSiA/HpT2IiGEo LQ79QRCbbIDx5n2Y9w74+1702aizpUpYTdn9YNKFWxKJh1KZf5NWyRAkuHEot58M4m5JwOA4ZA7 ATsrgeraPUJE= X-Received: by 2002:adf:b789:: with SMTP id s9mr21263464wre.315.1630418915635; Tue, 31 Aug 2021 07:08:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwWWutNM16gAtmpsGvqXoBgY4Kyes/Y8/gUxBFVp48/XHeLuFfK/v9T34UmkA7/LJtH8CB5hw== X-Received: by 2002:adf:b789:: with SMTP id s9mr21263440wre.315.1630418915491; Tue, 31 Aug 2021 07:08:35 -0700 (PDT) Received: from [192.168.3.132] (p4ff23bf5.dip0.t-ipconnect.de. [79.242.59.245]) by smtp.gmail.com with ESMTPSA id z19sm2875100wma.0.2021.08.31.07.08.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Aug 2021 07:08:35 -0700 (PDT) Subject: Re: [PATCH 4/6] mm/page_alloc.c: use helper function zone_spans_pfn() To: Miaohe Lin , akpm@linux-foundation.org Cc: vbabka@suse.cz, sfr@canb.auug.org.au, peterz@infradead.org, mgorman@techsingularity.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210830141051.64090-1-linmiaohe@huawei.com> <20210830141051.64090-5-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat Message-ID: <7dd3aae5-bc31-c163-b661-2cf1df830615@redhat.com> Date: Tue, 31 Aug 2021 16:08:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210830141051.64090-5-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E429F1023056 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K44RQmvK; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf13.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam01 X-Stat-Signature: ks81mzzn3mha1375nszoz64i7sp8ykao X-HE-Tag: 1630418920-228092 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 30.08.21 16:10, Miaohe Lin wrote: > Use helper function zone_spans_pfn() to check whether pfn is within a > zone to simplify the code slightly. > > Signed-off-by: Miaohe Lin > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index b5edcfe112aa..7bb79e959ab4 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1576,7 +1576,7 @@ static void __meminit init_reserved_page(unsigned long pfn) > for (zid = 0; zid < MAX_NR_ZONES; zid++) { > struct zone *zone = &pgdat->node_zones[zid]; > > - if (pfn >= zone->zone_start_pfn && pfn < zone_end_pfn(zone)) > + if (zone_spans_pfn(zone, pfn)) > break; > } > __init_single_page(pfn_to_page(pfn), pfn, zid, nid); > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb