From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35ECACF58D4 for ; Fri, 20 Sep 2024 06:43:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85AE36B0085; Fri, 20 Sep 2024 02:43:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80A366B0088; Fri, 20 Sep 2024 02:43:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D2096B0089; Fri, 20 Sep 2024 02:43:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 503376B0085 for ; Fri, 20 Sep 2024 02:43:50 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C3DCE4122F for ; Fri, 20 Sep 2024 06:43:49 +0000 (UTC) X-FDA: 82584176178.12.96AB277 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id E6ADC80014 for ; Fri, 20 Sep 2024 06:43:47 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PDGTePdJ; spf=pass (imf02.hostedemail.com: domain of longman@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726814569; a=rsa-sha256; cv=none; b=EEfWq2gRo67y8vXx6izjRfubmI8Afd699K863dRYCQr389Hc0BLpgyMXsiXZjsZ9KIUQX8 rxxBlj86kmc5B3Qr6iJ2EZX4R/kvs+k37WkOliHE/BY0V00U6PnTnmgLAPxKSvGOsNyvmQ t7z5DPDsLlagQW8Sz5uw1NNCRv86M+g= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PDGTePdJ; spf=pass (imf02.hostedemail.com: domain of longman@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726814569; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6lIQhi9dLmsll2G2cHgSkPLAoZ5Wd5248GHYInTXW7U=; b=as7JEuiMPTuJn39QK3wrjQOPUvB4xf4PylNQAH4LrmGh8NBtk6nc2nG5VaTG87p6XN7pOD gC7uH027OOJPL6EK02gSurYDjOeWYCeooD7KXmRHwRb9XB64ZdPhqEZMsJe8iVbW2JvdZd 3FW52bolDqtVSgjNnMLAn7wbcQvHP18= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726814627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6lIQhi9dLmsll2G2cHgSkPLAoZ5Wd5248GHYInTXW7U=; b=PDGTePdJNgBk842BzWVfBbCgOxv6WMdQnKARVl2jIK74gisOZJ/ZO5U0lTZtHRomQ0q3mz cx8F1pxYrc5igTJmRKbmTvFSvq6BCfzps3yGQPX1pTqNd1ZNQEehCKHK7+vjm8qU6Bny8+ a875NwiDbtjbj6o8de3nFVZ7mfzT0jc= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-2-NXtqnH66MXietrhV2vWcwQ-1; Fri, 20 Sep 2024 02:43:45 -0400 X-MC-Unique: NXtqnH66MXietrhV2vWcwQ-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5EE271944CE7; Fri, 20 Sep 2024 06:43:44 +0000 (UTC) Received: from [10.45.224.224] (unknown [10.45.224.224]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 791A219560AA; Fri, 20 Sep 2024 06:43:42 +0000 (UTC) Message-ID: <7db244ee-91ba-4d45-8c54-dc98a75d8501@redhat.com> Date: Fri, 20 Sep 2024 02:43:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] memory tier: Remove unused default_dram_perf_ref_source To: "Huang, Ying" Cc: Andrew Morton , Alistair Popple , Dave Jiang , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240919191357.49976-1-longman@redhat.com> <87y13mvo0n.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Language: en-US From: Waiman Long In-Reply-To: <87y13mvo0n.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Stat-Signature: tjh4ry64317nekrmithwzqpcbp7njbbj X-Rspamd-Queue-Id: E6ADC80014 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1726814627-429463 X-HE-Meta: U2FsdGVkX1/I+jioKYgNUR0kJjUkVjlpK6QjivdjszhIhE5sWnhHE6jADZpbSDIEYBUIUAhdCiJvBHqhUZ9iGtfh1NBgjQMqf/DUhPzmKgMdlW3E1AYCzR152NJcZqsokxXTwb2Cs4+SyBqpIIskDjlZmVtibzw583nxn8tLyFJGO2LnkmqfGwRMRBalCGmzXHqaQgwsuTEDrk83Oc2zBxoio6q8gEikUKokBjtQ2ZE4q5TKjKfD1h4UbyZazqKudUX9uioilDUnIGKobNDxhKoZatnUzYvJFJHb69quKo43+y4cKFu8isbUmngEAyys93V1DR4oamE3yLYrd+/3KLiznrJVtIwtqI3S9RLG1ID3TuGU5RGNNJiTcC7zG7gmQ23mp9enpQThebqqsSftLjDdjyfjAm16zMn/2tP1cVUxgetaU1Xqz/04njGMjbd0CTgwqdYwy7akLIgBXn5bx/Wen5P9R8XYAAAaC00FqBiVBSkNEooEZPdX+1199jnqoyZJXIJGJyEXnUVhkknNfC284sL/MjXq+XiMS812gwC4ysNHXc1ftASfAxsRgDPH7pfxN1CAH7JNybJpLLANMVIi1AHaucoY9R45xusXPT8ZojqejqvOxkaaPvp0cqNapU6fX+JBrroInSIJWP1dPtbhVqEX/3R8pugIybZAmJ4oxlsJWrnBYFYHGd4aGZ0sDRnms1fgaafu/I1rdqj+XPtikiujLoAg4awxybuWvJKWkG26qy7xDNu4fg/Dy4M9F2bGVaBjK8IVKkzLeFcF9pT81ewiOh/XxZYTHnb4ATlUBi5Tag5ES+kCYJibOG0oaLwstVKNMfnDlsGDaSLlU4HvgUSbf4nUY/CWM5XR0UJe9L99Ic4O3tlf4hEfOe6iNU4rT/N8+B/1F1xwPHVpMM56hXxQd6wThAxHEVoTGTYXTr2PnRHbJzy4rywbMY+dyrvx61274F7fIfItjXK WWJ8P8AC KWMXLEG8shzsi36NylAcTNFMWz/kcf/BKR46f3QcKCqtmd1FrJNGB5vBAazjVv65etGHUtJ1y6ypLLr+3tMZsKcGH45jT7cYGys2TEgavnc06ikjWnxzx63zw1jRJcKp0hJ2ogzCCn9a94sDqiuxqUI/duzkwxTZapjzElyL6ynaDFYoUeNTuSvsYJst6SlFQiiaeVWRFNOO+GBp4TobmMCqOydvyE0E11ECAKPZsEblqCQjcENp1ZHtjvJ2GPHgaMJ4d4Hy63bRP9C5rYt+XWErUfSzx1qTexrRtRrKXLE0gN9QrKobK1YZI5yW2GuOdPOPDPQajiMLrnUqt2oqzYtBrl698jesvj876uhXuqoru844TALdEvnW5/8bjjGGkJG9EdqncjMyqITvUEb+6WD5UNwzMcLaiuSulqyOzM5II8z+HsTXFz2RKZA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/20/24 02:26, Huang, Ying wrote: > Hi, Waiman, > > Waiman Long writes: > >> Commit 3718c02dbd4c ("acpi, hmat: calculate abstract distance with HMAT") >> added a default_dram_perf_ref_source variable that was initialized but >> never used. This causes kmemleak to report the following memory leak: >> >> unreferenced object 0xff11000225a47b60 (size 16): >>   comm "swapper/0", pid 1, jiffies 4294761654 >>   hex dump (first 16 bytes): >>     41 43 50 49 20 48 4d 41 54 00 c1 4b 7d b7 75 7c  ACPI HMAT..K}.u| >>   backtrace (crc e6d0e7b2): >>     [] __kmalloc_node_track_caller_noprof+0x36b/0x440 >>     [] kstrdup+0x36/0x60 >>     [] mt_set_default_dram_perf+0x23a/0x2c0 >>     [] hmat_init+0x2b3/0x660 >>     [] do_one_initcall+0x11c/0x5c0 >>     [] do_initcalls+0x1b4/0x1f0 >>     [] kernel_init_freeable+0x4ae/0x520 >>     [] kernel_init+0x1c/0x150 >>     [] ret_from_fork+0x31/0x70 >>     [] ret_from_fork_asm+0x1a/0x30 > Good catch! > >> Fix this memory leak by removing default_dram_perf_ref_source. > We should have used that information. So, I suggest the fix as below. > Is it OK for you? > > ---------------------------8<--------------------------------------- > From 32e6d70f531718cf99064a43fdffc8639aedcc5c Mon Sep 17 00:00:00 2001 > From: Huang Ying > Date: Fri, 20 Sep 2024 09:47:40 +0800 > Subject: [PATCH] memory tiers: use default_dram_perf_ref_source in log message > > Commit 3718c02dbd4c ("acpi, hmat: calculate abstract distance with HMAT") > added a default_dram_perf_ref_source variable that was initialized but > never used. This causes kmemleak to report the following memory leak: > > unreferenced object 0xff11000225a47b60 (size 16): > comm "swapper/0", pid 1, jiffies 4294761654 > hex dump (first 16 bytes): > 41 43 50 49 20 48 4d 41 54 00 c1 4b 7d b7 75 7c ACPI HMAT..K}.u| > backtrace (crc e6d0e7b2): > [] __kmalloc_node_track_caller_noprof+0x36b/0x440 > [] kstrdup+0x36/0x60 > [] mt_set_default_dram_perf+0x23a/0x2c0 > [] hmat_init+0x2b3/0x660 > [] do_one_initcall+0x11c/0x5c0 > [] do_initcalls+0x1b4/0x1f0 > [] kernel_init_freeable+0x4ae/0x520 > [] kernel_init+0x1c/0x150 > [] ret_from_fork+0x31/0x70 > [] ret_from_fork_asm+0x1a/0x30 > > This reminds us that we forget to use the performance data source > information. So, use the variable in the error log message to help > identify the root cause of inconsistent performance number. > > Fixes: 3718c02dbd4c ("acpi, hmat: calculate abstract distance with HMAT") > Signed-off-by: "Huang, Ying" > Reported-by: Waiman Long > --- > mm/memory-tiers.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index 4775b3a3dabe..0f5ba5c6e0c6 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -749,10 +749,10 @@ int mt_set_default_dram_perf(int nid, struct access_coordinate *perf, > pr_info( > "memory-tiers: the performance of DRAM node %d mismatches that of the reference\n" > "DRAM node %d.\n", nid, default_dram_perf_ref_nid); > - pr_info(" performance of reference DRAM node %d:\n", > - default_dram_perf_ref_nid); > + pr_info(" performance of reference DRAM node %d from %s:\n", > + default_dram_perf_ref_nid, default_dram_perf_ref_source); > dump_hmem_attrs(&default_dram_perf, " "); > - pr_info(" performance of DRAM node %d:\n", nid); > + pr_info(" performance of DRAM node %d from %s:\n", nid, source); > dump_hmem_attrs(perf, " "); > pr_info( > " disable default DRAM node performance based abstract distance algorithm.\n"); That looks good for me. As I am not sure how this variable should be used, I just removed it in my patch. Acked-by: Waiman Long