From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDF58C4707C for ; Fri, 12 Jan 2024 04:17:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A1586B008A; Thu, 11 Jan 2024 23:17:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 351326B0093; Thu, 11 Jan 2024 23:17:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 218E26B0095; Thu, 11 Jan 2024 23:17:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 123776B008A for ; Thu, 11 Jan 2024 23:17:39 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 87027120354 for ; Fri, 12 Jan 2024 04:17:38 +0000 (UTC) X-FDA: 81669350196.03.00ACA44 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf19.hostedemail.com (Postfix) with ESMTP id E979D1A0006 for ; Fri, 12 Jan 2024 04:17:34 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705033056; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AOZ9M/aVW0UUHjJhxPJQpCBMeLmvzbywzG3h1dY09kY=; b=0nOZYJmBc0Hg40iRuuKoPFXEyGI8Nq1gmAH8RV+ylIX2bzSefTfT7C7EzzMkZO62ZgnE3T 5BUWnUKtkAbVem/c26+lYlVTrcMCTseB3yB94P5U3R7wmhY4f+kml2ubaPWpKmHKyj+m+J swGTAzGwX6Bchozb4PpW53kBnRE6pEY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705033056; a=rsa-sha256; cv=none; b=39DaTL/X5aMGPaIc/3s9xJHxE0bsJSPtz5yCrd92s8W6n4+1PeJyEkD9wvSsGWI42yeLyv f6ou1MIytKXK+Cgnc5zEvaXVezN2kmv5uGykuLVYP+0VXt9RWyp8JvDSDI3hsEmzGEVGGD RrEdjRIL5uROrYT/CZ5KQZURzby0/Og= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.163]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4TB7WH5Qbhz29k9x; Fri, 12 Jan 2024 12:15:55 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 412421800D3; Fri, 12 Jan 2024 12:17:29 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Jan 2024 12:17:28 +0800 Message-ID: <7da39683-9b33-4f4e-baa5-69e63962943b@huawei.com> Date: Fri, 12 Jan 2024 12:17:28 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/8] mm: swap: introduce pfn_swap_entry_to_folio() Content-Language: en-US To: Matthew Wilcox CC: Andrew Morton , , , , References: <20240111111239.2453282-1-wangkefeng.wang@huawei.com> <20240111111239.2453282-2-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm100001.china.huawei.com (7.185.36.93) X-Stat-Signature: gdx9zqkdtd38wkonprudqu65hcg8ysig X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E979D1A0006 X-Rspam-User: X-HE-Tag: 1705033054-114959 X-HE-Meta: U2FsdGVkX1+tvVmuNzxPf2DUwoBjcphQMWGHz1t8G3802zmf/2XPr/XtY71XIpwPp5EGv3NHkBMrW3b9UlStU7QxCBuz+1nX/7tyVG+VmD5Fl6dCLafsD0E8wF34NP/oTKa//+3FfPaSu7UAHbDIzMeUQEU5EUC7pTxXCtot5YArCzb/6t5O6TZ81rxbSeq41SXzbKgZBYbagMXl0xfN7SIdi8wQH6TAwpUQN1xAS3LNUFx7nwBq5LRIEhibLiX6CNNJclraxdrVZ9M6pXJMIh2rgopJOG3sWijWrtFhxTe4JaNpmBjqDoeJgu7wp4pBRJ5zw0kzSek6zs+JREUJhm+bAGI+QxO9s0rIw4Ys8IigKZI/dpvXyAZ5e/m6plVwTqtzj3KYAo1EUT9AnBLnMkAFdrTHyopPhjjVGyAxZZZdr5552CNn8FUiUM0MUMfuqJaP6ktN7czhUoxl8MNlBdt8wdOT4FQ6MNutyo+JXp6T7o62ugNexzjr36q1jpbwhi+xt5zkBS78OtqWhhg2tsLEMSkg+LlHQnMFbTXIRqyEEqQzUDCzUowJua/pbvwjIBfCKR6WKzcoyORm3ti7fwh+Nc9v9HE3KkqbUSUHdiPCU1jxo3fnfpF7EQw2DxucRR0+je5rNzU/Ea01LiHBSg3DE/V5KWU+WMfBDVrEqPBU9PWX2jTPaIwRjVeXbiLTTmBkDxJY2kFlHcPGJ/LN23K2yK4RTg2uzZvoonooVFft11hpGxGX7Rxkwjh6Mj0sEqlw/7amLm6UrhZo/NNzV9x11pIucsFhhHFCvO9IvYlMHIm77zpGcByv8eJq8e4xb5Db96WPTK7DMVdClyhPgBZkiupX6ghBB0BuGNsLwTY/J5eFqx204a8vdZcqALTLBrBMHXvmLhdWKHvF6o9o+Gdaw1f8Z+mZ6PKxs01qU0HbKxncvNfPxlUDibhdONuY4kR1v2uRlpNcvLqq8PG cCiAZvTg Zk9TlxUOdbxivs63carDbWrWWVCU7bcwvcZZevbvVWDyKe4nwlVO5IN/BzMuARO3MNLh/7UVSun11Zmi2Ba+8P7d7hAIQhEvm5/2hVlhyRuz6HPZu4KBk3CmHoi0QhwpkHhUv1VSoVLQ0LiXVF9GupMaX18BllT1lSnHtBp7LfVKXLEkFYLxGA+mqy4Vs4FbQs+ZzOUa4VHRafKltqjMtmi6ucTO32XDUPWtdhAad0hqZfDsS+xYSWLybB1ulLz0ko/gDqcPddAEzIALWJpUZ5FNTkTgVUm6VMJ2U15oR6zc8SQ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/11 22:39, Matthew Wilcox wrote: > On Thu, Jan 11, 2024 at 02:37:41PM +0000, Matthew Wilcox wrote: >> On Thu, Jan 11, 2024 at 07:12:32PM +0800, Kefeng Wang wrote: >>> Introduce a new pfn_swap_entry_to_folio(), it is similar to >>> pfn_swap_entry_to_page(), but return a folio, which allow us >>> to completely replace the struct page variables with struct >>> folio variables. >> >> I have the exact same patch in my tree except I called it >> pfn_swap_entry_folio(). I also noted: >> >> Thanks to the compound_head() hidden inside PageLocked(), this saves a >> call to compound_head() over calling page_folio(pfn_swap_entry_to_page()) >> >>> Signed-off-by: Kefeng Wang >> >> Reviewed-by: Matthew Wilcox (Oracle) > > Oh, and I converted a couple of callers ... > migration_entry_wait_on_locked and change_huge_pmd. Those should > probably be added to this patch. > Thanks for your update, and all above conversion in your v3, and I check more callers, eg, hugetlb_change_protection,break_ksm_pmd_entry could be converted too, but we could send separate patch.